coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot
by Dinesh Gehlot (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal. Hello Kapil Porwal, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75755?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Code-Review+1 by Kapil Porwal, Verified+1 by build bot (Jenkins) Change subject: soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot ...................................................................... soc/intel/cmd/blk/cse: Store fw versions in CMOS memory for cold boot During a cold reboot, the CBMEM memory resets and loses the stored firmware versions. This causes the firmware versions to be fetched again from the CSE, which increases the boot time by about 200 ms. This patch stores a backup of the firmware version in CMOS and updates the CBMEM memory during a cold reboot. BUG=b:280722061 Test=Verified the changes on nissa board. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Ibc5a027aa2bb7217e5032f56fece0846783557a5 --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 54 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/75755/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/75755?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc5a027aa2bb7217e5032f56fece0846783557a5 Gerrit-Change-Number: 75755 Gerrit-PatchSet: 10 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS
by Dinesh Gehlot (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Sridhar Siricilla. Hello Kapil Porwal, Sridhar Siricilla, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74995?usp=email to look at the new patch set (#39). The following approvals got outdated and were removed: Code-Review+1 by Kapil Porwal, Verified+1 by build bot (Jenkins) Change subject: soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS ...................................................................... soc/intel/cmd/blk/cse: Implement APIs to access FW versions in CMOS This patch implements APIs to access the FW versions in CMOS. The get API allows users to retrieve the current version from CMOS memory. The set API allows users to set the version in CMOS memory. BUG=b:280722061 TEST=APIs verified on nivviks and marasov board. Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786 --- M src/soc/intel/common/block/cse/Kconfig M src/soc/intel/common/block/cse/Makefile.inc A src/soc/intel/common/block/cse/cse_lite_cmos.c A src/soc/intel/common/block/include/intelblocks/cse_lite_cmos.h 4 files changed, 213 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/74995/39 -- To view, visit https://review.coreboot.org/c/coreboot/+/74995?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786 Gerrit-Change-Number: 74995 Gerrit-PatchSet: 39 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash
by Krystian Hebel (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Martin L Roth, Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68987?usp=email ) Change subject: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash ...................................................................... Patch Set 11: Code-Review+2 (1 comment) File src/soc/intel/alderlake/hsphy.c: https://review.coreboot.org/c/coreboot/+/68987/comment/08de8758_af4943bf : PS10, Line 251: size_t > This isn't necessary, `sizeof` returns a value of type `size_t` anyway. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/68987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f Gerrit-Change-Number: 68987 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/Makefile: Fix build dir setting
by Nicholas Chin (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth, Nico Huber. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email ) Change subject: doc/Makefile: Fix build dir setting ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75893/comment/b95021ff_daba6e5c : PS4, Line 16: and make it writable. > I assume this makes no difference, at least commit 4d8da8ed alone […] I did some experimentation and it does seem to work even with `BUILDDIR = _build` instead of `BUILDDIR ?= _build`, which is what I assume Felix means by making it writable. The part that does seem to matter is that everything uses the same BUILDDIR name. -- To view, visit https://review.coreboot.org/c/coreboot/+/75893?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3 Gerrit-Change-Number: 75893 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:36:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/Makefile: Fix build dir setting
by Nico Huber (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email ) Change subject: doc/Makefile: Fix build dir setting ...................................................................... Patch Set 4: -Code-Review (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75893/comment/08c8b6de_bcace405 : PS4, Line 16: and make it writable. > I assume this makes no difference, at least commit 4d8da8ed alone […] Forgot that I can just read how it's called: In `makeSphinx.sh` we have ``` make sphinx BUILDDIR=/tmp/build ``` This `BUILDDIR=/tmp/build` got through even to the `Makefile.sphinx`. What broke it is the different variable name. Because rn. we have an explicit `BUILDDIR=` in the `Makefile` overriding the one from the `makeSphinx.sh`. Patchset: PS4: With the variable names the same, I don't understand the overall change (before commit 4d8da8ed to after this one). The only effective difference seems to be the added `mkdir -p`. Is this necessary? -- To view, visit https://review.coreboot.org/c/coreboot/+/75893?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3 Gerrit-Change-Number: 75893 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:35:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: doc/Makefile: Fix build dir setting
by Nico Huber (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email ) Change subject: doc/Makefile: Fix build dir setting ...................................................................... Patch Set 4: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75893/comment/e35de218_34d87273 : PS4, Line 9: The commit 4d8da8ed ("Docs: Update sphinx targets with the build directory") Line is too long. https://review.coreboot.org/c/coreboot/+/75893/comment/6fc96413_0d9e3ec7 : PS4, Line 10: an user *a user*, because phonetically it starts with a consonant. https://review.coreboot.org/c/coreboot/+/75893/comment/0fbf4ea3_c93f0d0a : PS4, Line 10: intending AFAICT, beings intend, a variable would be *intended* https://review.coreboot.org/c/coreboot/+/75893/comment/11534295_5ebfb6b4 : PS4, Line 12: outside Technically it's possible on the make command line. What doesn't work is setting it in the environment. That before commit 4d8da8ed the `$(BUILDDIR)` in `Makefile.sphinx` was already overwritable shows this. https://review.coreboot.org/c/coreboot/+/75893/comment/0099d8fd_8ae5dcd8 : PS4, Line 16: and make it writable. I assume this makes no difference, at least commit 4d8da8ed alone wouldn't explain it. -- To view, visit https://review.coreboot.org/c/coreboot/+/75893?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc44134cf1996592597252aeb9dcf7ffb3378ee3 Gerrit-Change-Number: 75893 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 16 Jun 2023 13:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable option
by Felix Singer (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Arthur Heymans, Elyes Haouas, Eric Lai, Jan Samek, Mario Scheithauer, Michael Niewöhner, Michał Żygowski, Nico Huber, Piotr Król, Subrata Banik. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75871?usp=email ) Change subject: [RFC] soc/intel/skylake: Use boolean type for s0ix_enable option ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > If we do this at a bigger scale, I would prefer an enum. Then it could > look as nice as > ``` > register s0ix = enabled > ``` I would just go with the true/false macros which we already have. That would be enough for me. -- To view, visit https://review.coreboot.org/c/coreboot/+/75871?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I372dfb65e6bbfc79c3f036ce34bc399875d5ff16 Gerrit-Change-Number: 75871 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 12:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash
by Michał Żygowski (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Krystian Hebel, Martin L Roth, Paul Menzel, Subrata Banik, Tarun Tuli. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68987?usp=email ) Change subject: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Use `%z` in `printf` instead of `%lx` for those arguments. Thanks, done -- To view, visit https://review.coreboot.org/c/coreboot/+/68987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f Gerrit-Change-Number: 68987 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Fri, 16 Jun 2023 11:58:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash
by Michał Żygowski (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Martin L Roth, Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli. Hello Krystian Hebel, Martin L Roth, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68987?usp=email to look at the new patch set (#11). Change subject: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash ...................................................................... soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash The patch adds a possibility to cache the PCIe 5.0 HSPHY firmware in the SPI flash. New flashmap region is created for that purpose. The goal of caching is to reduce the dependency on CSME and the HECI IP LOAD command which may fail when the CSME is disabled, e.g. soft disabled by HECI command or HAP disabled. This change allows to keep PCIe 5.0 root ports functioning even if CSME/HECI is not functional. TEST=Boot Ubuntu 22.04 on MSI PRO Z690-A and notice PCIe 5.0 port is functional after loading the HSPHY from cache. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f --- M Makefile.inc M src/soc/intel/alderlake/Kconfig M src/soc/intel/alderlake/Makefile.inc M src/soc/intel/alderlake/hsphy.c M util/cbfstool/default-x86.fmd 5 files changed, 309 insertions(+), 38 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/68987/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/68987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f Gerrit-Change-Number: 68987 Gerrit-PatchSet: 11 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash
by Krystian Hebel (Code Review) 16 Jun '23

16 Jun '23

Attention is currently required from: Martin L Roth, Michał Żygowski, Paul Menzel, Subrata Banik, Tarun Tuli. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68987?usp=email ) Change subject: soc/intel/alderlake/hsphy: Add possibility to cache HSPHY in flash ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > Tried with clang and got the error. […] Use `%z` in `printf` instead of `%lx` for those arguments. -- To view, visit https://review.coreboot.org/c/coreboot/+/68987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5a37f5b06706ff30d92f60f1bf5dc900edbde96f Gerrit-Change-Number: 68987 Gerrit-PatchSet: 10 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 16 Jun 2023 11:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023