coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_f0 struct
by Fred Reitberger (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Felix Held, Matt DeVillier, Raul Rangel. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76072?usp=email ) Change subject: soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_f0 struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6750b58dacb9b9192ed21128eb6e3a4495b96d0 Gerrit-Change-Number: 76072 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:42:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/acpi/ivrs: conditionally generate eMMC entry
by Fred Reitberger (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Arthur Heymans, Felix Held, Jason Glenesk, Matt DeVillier, Raul Rangel. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75933?usp=email ) Change subject: soc/amd/common/block/acpi/ivrs: conditionally generate eMMC entry ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00865cb7caf82547e89eb5e77817e3d8ca5d35dd Gerrit-Change-Number: 75933 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:41:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_hpet struct
by Fred Reitberger (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Felix Held, Matt DeVillier, Raul Rangel. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76074?usp=email ) Change subject: soc/amd/common/block/acpi/ivrs: zero-initialize ivhd_hpet struct ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If4d3563c485eed4a7cb0526a62f7b6c80f763bfd Gerrit-Change-Number: 76074 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:40:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Arthur Heymans, Lance Zhao, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76070?usp=email ) Change subject: acpi/acpi.c: Don't set MADT lapic addr on !ENV_X86 ...................................................................... Patch Set 1: (1 comment) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76070/comment/84a8ca2d_e36eee0c : PS1, Line 161: if (ENV_X86) I'm fine with this, but one might consider moving this and the COMMON_MADT conditionals below over to acpi_apic.c. Current expectation is to not see LAPIC or IOAPIC entries for ARM at least? -- To view, visit https://review.coreboot.org/c/coreboot/+/76070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e5032fd02af7e8e9ffd2e20aa214a8392ab6335 Gerrit-Change-Number: 76070 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:29:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: acpi/acpi.c: Split of ACPI table generation into separate files
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Arthur Heymans, Felix Singer, Lance Zhao, Tim Wawrzynczak. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76008?usp=email ) Change subject: acpi/acpi.c: Split of ACPI table generation into separate files ...................................................................... Patch Set 1: (2 comments) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76008/comment/d93799ce_7063eefa : PS1, Line 229: static u16 acpi_sci_int(void) You might want to move this with followup. To clear the remaining #ifdef for <arch/ioapic.h> include. https://review.coreboot.org/c/coreboot/+/76008/comment/b8b41ad9_e1c0f312 : PS1, Line 606: int acpi_create_srat_lapic(acpi_srat_lapic_t *lapic, u8 node, u8 apic) Is there something that makes MADT LAPIC entries x86-specific, but SRAT LAPICs not? ACPI does not strictly say ARMs could not expose APIC interrupt model, but assuming GIC model and splitting this seems reasonable. -- To view, visit https://review.coreboot.org/c/coreboot/+/76008?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5083b26c0d4cc6764b4e3cb0ff586797cae7e3af Gerrit-Change-Number: 76008 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:20:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/jasperlake: Add per-SKU power limits
by Sumeet R Pawnikar (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: ChiaLing, Paul Menzel, Reka Norman, Ryan Lin, Subrata Banik, Zhuohao Lee. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75679?usp=email ) Change subject: soc/intel/jasperlake: Add per-SKU power limits ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic086e32a2692f4f5f9b661585b216fa207fc56fd Gerrit-Change-Number: 75679 Gerrit-PatchSet: 14 Gerrit-Owner: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ryan Lin <ryan.lin(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chia-Ling Hou <chia-ling.hou(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ryan Lin <ryan.lin(a)intel.com> Gerrit-Attention: ChiaLing <chia-ling.hou(a)intel.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 11:11:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [WIP] SMBIOS: Move identification strings
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Angel Pons, Boris Mittelberg, Caveh Jalali, Christian Walter, Erik van den Bogaert, Frans Hendriks, Jason Nien, Lean Sheng Tan, Martin Roth, Michał Kopeć, Michał Żygowski, Patrick Rudolph, Piotr Król, Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74452?usp=email to look at the new patch set (#9). Change subject: [WIP] SMBIOS: Move identification strings ...................................................................... [WIP] SMBIOS: Move identification strings Platform code could provide the strings that are used to fill in SMBIOS type1, type2 and type3 tables. Change the code such that this board "identity" is initialized before creation of actual SMBIOS tables. Default behaviour is to inherit type1 (system) from type2 (aka board) fields, and type3 (chassis) from type1 (system) fields. For type3, manufacturer and asset_tag can now be individually set and may be different from those in type1 and type2 tables. Some implementations of fetching SMBIOS string were not re-entrant. Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/drivers/generic/cbfs-serial/cbfs-serial.c M src/drivers/i2c/at24rf08c/lenovo_serials.c M src/drivers/ocp/dmi/smbios.c M src/drivers/secunet/dmi/smbios.c M src/drivers/vpd/vpd_serial.c M src/ec/google/chromeec/ec.h M src/ec/google/chromeec/ec_smbios.c M src/include/identity.h M src/include/smbios.h M src/lib/identity.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/mainboard/emulation/qemu-i440fx/fw_cfg.c M src/mainboard/facebook/monolith/ramstage.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/drallion/variants/drallion/sku.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/glados/variants/lars/variant.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kahlee/variants/baseboard/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/sarien/sku.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/jasperlake_rvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/msi/ms7d25/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/smbios.c M src/mainboard/prodrive/hermes/smbios.c M src/mainboard/protectli/vault_cml/mainboard.c M src/mainboard/starlabs/lite/smbios.c M src/mainboard/starlabs/starbook/smbios.c M src/vendorcode/google/smbios.c 36 files changed, 342 insertions(+), 412 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/74452/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/74452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6 Gerrit-Change-Number: 74452 Gerrit-PatchSet: 9 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/abuild: Add per-build statistics tarfile
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Arthur Heymans, Martin L Roth. Hello Arthur Heymans, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75803?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins) Change subject: util/abuild: Add per-build statistics tarfile ...................................................................... util/abuild: Add per-build statistics tarfile Change-Id: Icb9a5bdf94013fe493dc8ec634cf3094bcff2838 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M util/abuild/abuild 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/75803/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb9a5bdf94013fe493dc8ec634cf3094bcff2838 Gerrit-Change-Number: 75803 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: [WIP] SMBIOS: Move identification strings
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Kyösti Mälkki has restored this change. ( https://review.coreboot.org/c/coreboot/+/74452?usp=email ) Change subject: [WIP] SMBIOS: Move identification strings ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/74452?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28a8199b4a5482984dd7fdde67e90acca5af5ca6 Gerrit-Change-Number: 74452 Gerrit-PatchSet: 8 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[XS] Change in coreboot[master]: mb/msi/ms7d25/vboot-rwab.fmd: Add 32KiB HSPHY cache region
by Michał Żygowski (Code Review) 23 Jun '23

23 Jun '23

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68988?usp=email ) Change subject: mb/msi/ms7d25/vboot-rwab.fmd: Add 32KiB HSPHY cache region ...................................................................... mb/msi/ms7d25/vboot-rwab.fmd: Add 32KiB HSPHY cache region Add the HSPHY region required by INCLUDE_HSPHY_IN_FMAP option. It is needed in case CSME/HECI is disabled or not visible to keep the PCIe 5.0 root ports functional. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: Ic4793fc9457f58e914ef3e18cce1294f230462bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/68988 Reviewed-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/msi/ms7d25/vboot-rwab.fmd 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Paul Menzel: Looks good to me, but someone else must approve Krystian Hebel: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/msi/ms7d25/vboot-rwab.fmd b/src/mainboard/msi/ms7d25/vboot-rwab.fmd index b4dc044..665c894 100644 --- a/src/mainboard/msi/ms7d25/vboot-rwab.fmd +++ b/src/mainboard/msi/ms7d25/vboot-rwab.fmd @@ -22,14 +22,15 @@ CONSOLE 128K SMMSTORE(PRESERVE) 256K + HSPHY_FW(PRESERVE) 32K - RW_SECTION_A 5280K { + RW_SECTION_A 5264K { VBLOCK_A 64K FW_MAIN_A(CBFS) RW_FWID_A 0x100 } - RW_SECTION_B 5280K { + RW_SECTION_B 5264K { VBLOCK_B 64K FW_MAIN_B(CBFS) RW_FWID_B 0x100 -- To view, visit https://review.coreboot.org/c/coreboot/+/68988?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4793fc9457f58e914ef3e18cce1294f230462bd Gerrit-Change-Number: 68988 Gerrit-PatchSet: 13 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023