coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[XS] Change in coreboot[master]: mb/google/brya: Add support for variant_memcfg_init()
by Tarun Tuli (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Bob Moragues, David Wu, Eric Lai, Kane Chen, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75990?usp=email ) Change subject: mb/google/brya: Add support for variant_memcfg_init() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I think it is better to copy some data than to create a new API for something that can be accomplish […] I agree with Nick. I dont see the need for this CLs addition. My vote is lets do it via the variant_memory_params returning the appropriate struct. Seems much cleaner/easier for this somewhat special case. -- To view, visit https://review.coreboot.org/c/coreboot/+/75990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4926139e36602f87c8317ab4b476636e02f87771 Gerrit-Change-Number: 75990 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 20:02:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu <david_wu(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/acpi/ivrs: use memset on ivhd_[11,40]
by Felix Held (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Raul Rangel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76077?usp=email ) Change subject: soc/amd/common/block/acpi/ivrs: use memset on ivhd_[11,40] ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/block/acpi/ivrs.c: https://review.coreboot.org/c/coreboot/+/76077/comment/7054e653_a8499a58 : PS1, Line 206: memset(ivhd_40, 0, sizeof(acpi_ivrs_ivhd40_t)); > fixed in the next patch i split this into two patches, since those are two separate logical changes. doing both in one patch would also work, since the changes aren't that complicated though -- To view, visit https://review.coreboot.org/c/coreboot/+/76077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I70b12fee99d6c71318189ac35e615589a4c8c629 Gerrit-Change-Number: 76077 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 19:40:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: arch/x86/smbios: Add a config string for BIOS Vendor in SMBIOS Type 0
by Kyösti Mälkki (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Martin L Roth, Martin Roth, Nico Huber, Nill Ge, Paul Menzel, Subrata Banik, TangYiwei, Ziang Wang, niehaitao(a)bytedance.com. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email ) Change subject: arch/x86/smbios: Add a config string for BIOS Vendor in SMBIOS Type 0 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: Not sure if it matters, but logs will continue to show "coreboot-xxxx" as the version string. -- To view, visit https://review.coreboot.org/c/coreboot/+/75737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dfcca338ffc48b150c966b9aefcefe928704d24 Gerrit-Change-Number: 75737 Gerrit-PatchSet: 5 Gerrit-Owner: TangYiwei Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Ziang Wang <ziang.wang(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Jeff Li <lijinfeng01(a)inspur.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 19:20:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intelblocks/pep: Send All Monitor Off/On command only in FWCM case
by Utkarsh H Patel (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Balaji Manigandan, Felix Singer, Hannah Williams, Kapil Porwal, Paul Menzel, Subrata Banik, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Vikrant Jadeja. Utkarsh H Patel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email ) Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13 Gerrit-Change-Number: 75717 Gerrit-PatchSet: 9 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Vikrant Jadeja Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 19:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intelblocks/pep: Send All Monitor Off/On command only in FWCM case
by Hannah Williams (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Balaji Manigandan, Felix Singer, Kapil Porwal, Paul Menzel, Subrata Banik, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Utkarsh H Patel, Vikrant Jadeja. Hannah Williams has uploaded a new patch set (#9) to the change originally created by Usha P. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email ) Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case ...................................................................... intelblocks/pep: Send All Monitor Off/On command only in FWCM case ALL_MONITOR_OFF command is sent using DPOF. TBT controller needs to be notified about ALL_MONITOR_OFF(TBT Displays OFF) only when Firmware Connection Manager(FWCM) is in use during S0ix Entry/Exit. When configured for SWCM this command should not be sent. BUG=b:288536417 TEST= Build and boot Rex Proto-1. Verify S0ix working. Signed-off-by: Usha P <usha.p(a)intel.com> Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13 --- M src/soc/intel/common/block/acpi/pep.c 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/75717/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/75717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13 Gerrit-Change-Number: 75717 Gerrit-PatchSet: 9 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Reviewer: Vikrant Jadeja Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Vikrant Jadeja Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
by Jason Glenesk (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Paul Menzel, Tim Van Patten. Hello Jason Nien, Martin Roth, Matt DeVillier, Tim Van Patten, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76091?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ...................................................................... mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call Update system_configuration to 3 for 15W. Specification "FT6 Infrastructure Roadmap #57316" incorrectly lists system config index of 4 for 15W. Setting to 4 will cause an additional call to the SMU that is not needed and will add boot delay. Both SMU and FSP interpret configs > 3 as 3. BUG=b:267294958 TEST=Confirm extra message "Service Request 0x5F" not in log. Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.com> --- M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76091/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Gerrit-Change-Number: 76091 Gerrit-PatchSet: 5 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
by Jason Glenesk (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Paul Menzel, Tim Van Patten. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email ) Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/76091/comment/4cd96a04_d619b499 : PS2, Line 264: # DPTC: Refer the spec "FT6 Infrastructure Roadmap"#57316 : # Set system_configuration to 3 for 15W : register "system_configuration" = "3" > I think it would be good to add a comment here that the document is actually wrong, and why using `3 […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Gerrit-Change-Number: 76091 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 18:55:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
by Jason Glenesk (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Matt DeVillier, Paul Menzel, Tim Van Patten. Hello Jason Nien, Martin Roth, Matt DeVillier, Tim Van Patten, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76091?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ...................................................................... mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call Update system_configuration to 3 for 15W. Specification "FT6 Infrastructure Roadmap #57316" incorrectly lists system config index of 4 for 15W. Setting to 4 will cause an additional call to the SMU that is not needed and will add boot delay. Both SMU and FSP interpret configs > 3 as 3. BUG=b:267294958 TEST=Confirm extra message "Service Request 0x5F" not in log. Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Signed-off-by: Jason Glenesk <jason.glenesk(a)amd.com> --- M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/76091/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Gerrit-Change-Number: 76091 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
by Jason Glenesk (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Paul Menzel, Tim Van Patten. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email ) Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76091/comment/1a80476a_bca7aaf4 : PS2, Line 9: FT6 : Infrastructure Roadmap"#57316 > Is there an AMD bug to update the documentation for future SOCs? https://partnerissuetracker.corp.google.com/issues/288545213 https://review.coreboot.org/c/coreboot/+/76091/comment/1bbcf075_3a8d3f92 : PS2, Line 12: Both SMU and FSP interpret configs > 3 as 3. > There is a point early in the flow, where the FSP also does not know anything about the expected TDP […] Done https://review.coreboot.org/c/coreboot/+/76091/comment/c58da38f_69271c19 : PS2, Line 15: TEST=Confirm extra message is not sent in serial log. > In the source for pmfw, 3 was always used, the 4 was just replaced by 3 because it was >3. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Gerrit-Change-Number: 76091 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 18:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jason Glenesk <jason.glenesk(a)gmail.com> Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call
by Jason Glenesk (Code Review) 23 Jun '23

23 Jun '23

Attention is currently required from: Jason Glenesk, Jason Nien, Martin Roth, Paul Menzel, Tim Van Patten. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76091?usp=email ) Change subject: mb/google/skyrim/: Set system_configuration to 3 to avoid SMU call ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76091/comment/c431e2b7_288e9acc : PS2, Line 12: Both SMU and FSP interpret configs > 3 as 3. > Why does this require an extra call to the SMU to be performed, since it sounds like something they' […] There is a point early in the flow, where the FSP also does not know anything about the expected TDP and will use the default return of fused values from this call to make some decisions rather than the system configuration, if the system configuration does not fall within the values it has in the table. https://review.coreboot.org/c/coreboot/+/76091/comment/9b13caec_51df11bf : PS2, Line 15: TEST=Confirm extra message is not sent in serial log. > Is there any validation of the DPTC settings themselves that can be done, to verify the new value do […] In the source for pmfw, 3 was always used, the 4 was just replaced by 3 because it was >3. File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb: PS2: > This change also needs to be made in `src/mainboard/google/skyrim/variants/winterhold/overridetree. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/76091?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f3e305c48801b4e499de56d06c0dcd3eeacc626 Gerrit-Change-Number: 76091 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Fri, 23 Jun 2023 18:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023