coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/reef: Disable unused devices in devicetrees
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/74891 ) Change subject: mb/google/reef: Disable unused devices in devicetrees ...................................................................... mb/google/reef: Disable unused devices in devicetrees The image processing unit (Iunit) and SoC UARTS are not used on any reef boards. Change-Id: Iacdf93b4952cbc63fc465f07d440463106527b8d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/reef/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/coral/devicetree.cb M src/mainboard/google/reef/variants/pyro/devicetree.cb M src/mainboard/google/reef/variants/sand/devicetree.cb M src/mainboard/google/reef/variants/snappy/devicetree.cb 5 files changed, 20 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74891/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacdf93b4952cbc63fc465f07d440463106527b8d Gerrit-Change-Number: 74891 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/apl: Hide IPC ACPI device from Windows
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes. Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74892 ) Change subject: soc/intel/apl: Hide IPC ACPI device from Windows ...................................................................... soc/intel/apl: Hide IPC ACPI device from Windows The IPC device does not have or need any drivers under Windows, so set the ACPI status to enabled but hidden (0xb). Linux is unaffected as it does not use the ACPI status function. Change-Id: I02efb64a845edc6e4fc559e7e99a7825abf4c2aa Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/apollolake/acpi/pmc_ipc.asl 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/74892/1 diff --git a/src/soc/intel/apollolake/acpi/pmc_ipc.asl b/src/soc/intel/apollolake/acpi/pmc_ipc.asl index d90b42e..55585c4 100644 --- a/src/soc/intel/apollolake/acpi/pmc_ipc.asl +++ b/src/soc/intel/apollolake/acpi/pmc_ipc.asl @@ -42,5 +42,9 @@ Return (^RBUF) } + Method (_STA, 0x0, NotSerialized) + { + Return(0xb) + } } } -- To view, visit https://review.coreboot.org/c/coreboot/+/74892 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I02efb64a845edc6e4fc559e7e99a7825abf4c2aa Gerrit-Change-Number: 74892 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/reef: Disable unused devices in devtrees
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74891 ) Change subject: mb/google/reef: Disable unused devices in devtrees ...................................................................... mb/google/reef: Disable unused devices in devtrees Change-Id: Iacdf93b4952cbc63fc465f07d440463106527b8d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/reef/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/coral/devicetree.cb M src/mainboard/google/reef/variants/pyro/devicetree.cb M src/mainboard/google/reef/variants/sand/devicetree.cb M src/mainboard/google/reef/variants/snappy/devicetree.cb 5 files changed, 17 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74891/1 diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb index 34e4fbf..704a3cd 100644 --- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb @@ -124,7 +124,7 @@ device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 03.0 on end # - Iunit + device pci 03.0 off end # - Iunit device pci 0d.0 on end # - P2SB device pci 0d.1 on end # - PMC device pci 0d.2 on end # - SPI diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb index f1d6030..9e44d86 100644 --- a/src/mainboard/google/reef/variants/coral/devicetree.cb +++ b/src/mainboard/google/reef/variants/coral/devicetree.cb @@ -124,7 +124,7 @@ device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 03.0 on end # - Iunit + device pci 03.0 off end # - Iunit device pci 0d.0 on end # - P2SB device pci 0d.1 on end # - PMC device pci 0d.2 on end # - SPI @@ -238,8 +238,8 @@ device pci 17.2 off end # - I2C 6 device pci 17.3 off end # - I2C 7 device pci 18.0 on end # - UART 0 - device pci 18.1 on end # - UART 1 - device pci 18.2 on end # - UART 2 + device pci 18.1 off end # - UART 1 + device pci 18.2 off end # - UART 2 device pci 18.3 off end # - UART 3 device pci 19.0 on end # - SPI 0 device pci 19.1 off end # - SPI 1 diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb index 7f7706e..7e032b0 100644 --- a/src/mainboard/google/reef/variants/pyro/devicetree.cb +++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb @@ -133,7 +133,7 @@ device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 03.0 on end # - Iunit + device pci 03.0 off end # - Iunit device pci 0d.0 on end # - P2SB device pci 0d.1 on end # - PMC device pci 0d.2 on end # - SPI diff --git a/src/mainboard/google/reef/variants/sand/devicetree.cb b/src/mainboard/google/reef/variants/sand/devicetree.cb index 7fe9d4f..73c1d22 100644 --- a/src/mainboard/google/reef/variants/sand/devicetree.cb +++ b/src/mainboard/google/reef/variants/sand/devicetree.cb @@ -120,7 +120,7 @@ device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 03.0 on end # - Iunit + device pci 03.0 off end # - Iunit device pci 0d.0 on end # - P2SB device pci 0d.1 on end # - PMC device pci 0d.2 on end # - SPI diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb index f2b069f..62e9618 100644 --- a/src/mainboard/google/reef/variants/snappy/devicetree.cb +++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb @@ -129,7 +129,7 @@ device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 03.0 on end # - Iunit + device pci 03.0 off end # - Iunit device pci 0d.0 on end # - P2SB device pci 0d.1 on end # - PMC device pci 0d.2 on end # - SPI -- To view, visit https://review.coreboot.org/c/coreboot/+/74891 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iacdf93b4952cbc63fc465f07d440463106527b8d Gerrit-Change-Number: 74891 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/reef: Disable Intel Trace Hub PCI device
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74890 ) Change subject: mb/google/reef: Disable Intel Trace Hub PCI device ...................................................................... mb/google/reef: Disable Intel Trace Hub PCI device It's not particularly useful to end users, and shows up as an unknown PCI device under Windows Device Manager. TEST=build reef, boot Windows, verify unknown PCI device no longer present in Device Manager. Change-Id: Ie8ec46e2e07b6635bfe9766812ce08b866c71d66 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/reef/variants/baseboard/devicetree.cb M src/mainboard/google/reef/variants/coral/devicetree.cb M src/mainboard/google/reef/variants/pyro/devicetree.cb M src/mainboard/google/reef/variants/sand/devicetree.cb M src/mainboard/google/reef/variants/snappy/devicetree.cb 5 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/74890/1 diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb index d24e67b..34e4fbf 100644 --- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb @@ -120,7 +120,7 @@ device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF - device pci 00.2 on end # - NPK + device pci 00.2 off end # - NPK device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb index f162519..f1d6030 100644 --- a/src/mainboard/google/reef/variants/coral/devicetree.cb +++ b/src/mainboard/google/reef/variants/coral/devicetree.cb @@ -120,7 +120,7 @@ device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF - device pci 00.2 on end # - NPK + device pci 00.2 off end # - NPK device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb index 79da9fd..7f7706e 100644 --- a/src/mainboard/google/reef/variants/pyro/devicetree.cb +++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb @@ -129,7 +129,7 @@ device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF - device pci 00.2 on end # - NPK + device pci 00.2 off end # - NPK device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end diff --git a/src/mainboard/google/reef/variants/sand/devicetree.cb b/src/mainboard/google/reef/variants/sand/devicetree.cb index 45007f0..7fe9d4f 100644 --- a/src/mainboard/google/reef/variants/sand/devicetree.cb +++ b/src/mainboard/google/reef/variants/sand/devicetree.cb @@ -116,7 +116,7 @@ device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF - device pci 00.2 on end # - NPK + device pci 00.2 off end # - NPK device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb index ec9ea9c1..f2b069f 100644 --- a/src/mainboard/google/reef/variants/snappy/devicetree.cb +++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb @@ -125,7 +125,7 @@ device domain 0 on device pci 00.0 on end # - Host Bridge device pci 00.1 on end # - DPTF - device pci 00.2 on end # - NPK + device pci 00.2 off end # - NPK device pci 02.0 on # - Gen register "gfx" = "GMA_DEFAULT_PANEL(0)" end -- To view, visit https://review.coreboot.org/c/coreboot/+/74890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8ec46e2e07b6635bfe9766812ce08b866c71d66 Gerrit-Change-Number: 74890 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support
by Sean Rhodes (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74869 ) Change subject: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Gerrit-Change-Number: 74869 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Apr 2023 21:17:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74869 ) Change subject: payloads/edk2: Add Kconfig to enable UEFI SecureBoot support ...................................................................... Patch Set 2: (2 comments) File payloads/external/edk2/Kconfig: https://review.coreboot.org/c/coreboot/+/74869/comment/7066d5e8_1996d066 PS1, Line 246: feature > support? Done https://review.coreboot.org/c/coreboot/+/74869/comment/5c661a85_b1dbc96b PS1, Line 248: default y if EDK2_REPO_MRCHROMEBOX && SMMSTORE_V2 > No help text? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4be58c3315cabe08729d717c59203fdc6a3e2958 Gerrit-Change-Number: 74869 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 30 Apr 2023 21:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: device/allocator: Allow for multiple domain resources of a type
by Felix Held (Code Review) 01 May '23

01 May '23

Attention is currently required from: Jonathan Zhang, Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67018 ) Change subject: device/allocator: Allow for multiple domain resources of a type ...................................................................... Patch Set 6: (1 comment) File src/device/resource_allocator_v4.c: https://review.coreboot.org/c/coreboot/+/67018/comment/4c51bf9c_2dff0393 PS6, Line 317: if (res->flags & IORESOURCE_FIXED) : continue; haven't properly root-caused the behavior i've seen, but when having the IORESOURCE_FIXED flag set in all subtractive MMIO ranges on the domain level, that results in no usable domain MMIO resources being found. unsure if this is intended or not -- To view, visit https://review.coreboot.org/c/coreboot/+/67018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3d3a60c9a4438accdb06444e2b50cc9b0b2eb009 Gerrit-Change-Number: 67018 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 30 Apr 2023 21:15:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Update default branch for MrChromebox repo
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Martin L Roth, Matt DeVillier, Stefan Reinauer. Hello build bot (Jenkins), Sean Rhodes, Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74868 to look at the new patch set (#2). Change subject: payloads/edk2: Update default branch for MrChromebox repo ...................................................................... payloads/edk2: Update default branch for MrChromebox repo Update the default branch used for MrChromebox's edk2 fork from 2022-07 to 2023-04. This updated branch has been rebased on the latest upstream stable tag (edk2-stable202302), and adds support for UEFI SecureBoot and TPM 1.2/2.0 management (though it does not currently support Google CR50/Ti50 TPMs). TEST=build/boot various boards with edk2 payload selected. Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/edk2/Kconfig 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/74868/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I096eaa4e065db731a70ba238ba5a3bb49e5db867 Gerrit-Change-Number: 74868 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Remove ABOVE_4G_MEMORY option
by Matt DeVillier (Code Review) 01 May '23

01 May '23

Attention is currently required from: Sean Rhodes, Nico Huber, Martin L Roth, Benjamin Doron, Stefan Reinauer, Paul Menzel, Lean Sheng Tan. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 ) Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: note: this patch is dependent on CB:74868 being merged first -- To view, visit https://review.coreboot.org/c/coreboot/+/74336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a Gerrit-Change-Number: 74336 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sun, 30 Apr 2023 21:07:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: payloads/edk2: Remove ABOVE_4G_MEMORY option
by Sean Rhodes (Code Review) 30 Apr '23

30 Apr '23

Attention is currently required from: Nico Huber, Martin L Roth, Matt DeVillier, Benjamin Doron, Stefan Reinauer, Paul Menzel, Lean Sheng Tan. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 ) Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option ...................................................................... Patch Set 4: (1 comment) Patchset: PS3: > dc5f2905ebfdf68ae28ce1081d435af0f8641dd9 is not part of the current default branch uefipayload_20220 […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a Gerrit-Change-Number: 74336 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sun, 30 Apr 2023 20:37:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023