coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/brya/var/omnigul: Adjust I2Cs CLK to be around 400 kHz
by Derek Huang (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Jamie Chen, Tarun Tuli, Subrata Banik, Kyle Lin, Nick Vaccaro. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74393 ) Change subject: mb/google/brya/var/omnigul: Adjust I2Cs CLK to be around 400 kHz ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74393 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7c4fdf0e003318a69b870b487a60accefbc0ffed Gerrit-Change-Number: 74393 Gerrit-PatchSet: 2 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/msi/ms_7d25: Clear recovery request in mainboard_final
by Michał Żygowski (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Michał Kopeć. Hello Michał Kopeć, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74402 to look at the new patch set (#2). Change subject: mb/msi/ms_7d25: Clear recovery request in mainboard_final ...................................................................... mb/msi/ms_7d25: Clear recovery request in mainboard_final For ChromeOS platform the recovery reason is cleared in vb2api_kernel_phase2 which is probably not called by any non-ChromeOS system. It results in the platform being stuck in recovery mode, e.g. when RW firmware verification fails. Even if the RW partition is flashed with correctly signed image, the persistent non-zero recovery reason will prevent vboot from attempting the RW partition check. Clear the recovery reason in the mainboard_final function. The call is made very late in the boot process thus it will not interfere with vboot logic. If still relevant, verstage will set the recovery reason back. The recovery reason will still be available in vboot workbuf in cbmem for the payload and OS. The additional reboot happening in the verstage when in recovery mode is a small disadvantage of this solution. TEST=Boot with RW partition corrupted and then with RW partition valid. When it is corrupted, the platform stays in recovery mode, when becomes valid the platform boots from RW partition. Tested on MSI PRO Z690-A DDR4. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I6c5444c2976fe5f68a2c6964710761c268d2255b --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74402/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c5444c2976fe5f68a2c6964710761c268d2255b Gerrit-Change-Number: 74402 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: security/vboot: Add function to clear recovery request
by Michał Żygowski (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Julius Werner, Yu-Ping Wu. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74343 ) Change subject: security/vboot: Add function to clear recovery request ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Can you please split this into a patch that does just the vboot uprev itself (with the commit messag […] Changes split. -- To view, visit https://review.coreboot.org/c/coreboot/+/74343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617 Gerrit-Change-Number: 74343 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:16:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/nissa/var/craask: Add GTCH7503 and split TS by SSFC
by Tyler Wang (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: David Wu, Tarun Tuli, Kangheui Won, Ren Kuo, Reka Norman, Nick Vaccaro, Eric Lai. Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74298 ) Change subject: mb/google/nissa/var/craask: Add GTCH7503 and split TS by SSFC ...................................................................... Patch Set 8: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/74298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I636f21be39f26a617653e134129a11479e801ea2 Gerrit-Change-Number: 74298 Gerrit-PatchSet: 8 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quantatw.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quantatw.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:16:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/msi/ms_7d25: Clear recovery request in mainboard_final
by Michał Żygowski (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Michał Kopeć. Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74402 ) Change subject: mb/msi/ms_7d25: Clear recovery request in mainboard_final ...................................................................... mb/msi/ms_7d25: Clear recovery request in mainboard_final For ChromeOS platform the recovery reason is cleared in vb2api_kernel_phase2 which is probably not called by any non-ChromeOS system. It results in the platform being stuck in recovery mode, e.g. when RW firmware verification fails. Even if the RW partition is flashed with correctly signed image, the persistent non-zero recovery reason will prevent vboot from attempting the RW partition check. Clear the recoveyr reason in the mainboard_final function. The call is made very late in the boot process thus it will not interfere with vboot logic. If still relevant, verstage will set the recovery reason back. The recovery reason will still be available in vboot workbuf in cbmem for the payload and OS. The additional reboot happening in the verstage when in recovery mode is a small disadvantage of this solution. TEST=Boot with RW partition corrupted and then with RW partition valid. When it is corrupted, the platform stays in recovery mode, when becomes valid the platform boots from RW partition. Tested on MSI PRO Z690-A DDR4. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I6c5444c2976fe5f68a2c6964710761c268d2255b --- M src/mainboard/msi/ms7d25/mainboard.c 1 file changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/74402/1 diff --git a/src/mainboard/msi/ms7d25/mainboard.c b/src/mainboard/msi/ms7d25/mainboard.c index 539f897e..a5410e7 100644 --- a/src/mainboard/msi/ms7d25/mainboard.c +++ b/src/mainboard/msi/ms7d25/mainboard.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <device/device.h> +#include <security/vboot/vboot_common.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <smbios.h> @@ -495,7 +496,14 @@ #endif } +static void mainboard_final(void *chip_info) +{ + if (CONFIG(VBOOT)) + vboot_clear_recovery_request(); +} + struct chip_operations mainboard_ops = { .init = mainboard_init, .enable_dev = mainboard_enable, + .final = mainboard_final, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/74402 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c5444c2976fe5f68a2c6964710761c268d2255b Gerrit-Change-Number: 74402 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Update vboot submodule to upstream main
by Michał Żygowski (Code Review) 13 Apr '23

13 Apr '23

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74401 ) Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id 5b8596ce: 2sha256_arm: Fix data abort issue to commit id 35f50c31: Fix build error when compiling without -DNDEBUG This brings in 41 new commits. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I58f6740c34670ea5a501ff2ee8cfcf9d2a1c25e9 --- M 3rdparty/vboot 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/74401/1 diff --git a/3rdparty/vboot b/3rdparty/vboot index 5b8596c..35f50c3 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 5b8596cefd1a61252501943f2534323708338732 +Subproject commit 35f50c3154e58821cc027bf13be2b949bc4c90f3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74401 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58f6740c34670ea5a501ff2ee8cfcf9d2a1c25e9 Gerrit-Change-Number: 74401 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: security/vboot: Add function to clear recovery request
by Michał Żygowski (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Michał Żygowski, Yu-Ping Wu. Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74343 to look at the new patch set (#3). Change subject: security/vboot: Add function to clear recovery request ...................................................................... security/vboot: Add function to clear recovery request For ChromeOS platform the recovery reason is cleared in vb2api_kernel_phase2 which is probably not called by any non-ChromeOS system. It results in the platform being stuck in recovery mode, e.g. when RW firmware verification fails. Even if the RW partition is flashed with correctly signed image, the persistent non-zero recovery reason will prevent vboot from attempting the RW partition check. Use the newly exposed vb2api_clear_recovery to clear the recovery reason and save it immediately to the VBNV. The idea is to let non-ChromeOS coreboot platform to clear the recovery reason when needed. TEST=Clear the recovery reason in mainboard_final function right before payload jump when RW partition is corrupted and RW partition is valid. In case it is corrupted, the platform stays in recovery mode, when valid the platform boots from RW partition. Tested on MSI PRO Z690-A DDR4. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617 --- M src/security/vboot/bootmode.c M src/security/vboot/vboot_common.h 2 files changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/74343/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ffaf3e8f61a28a68c9802c184961b1b9bf9d617 Gerrit-Change-Number: 74343 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/rex: Create screebo variant
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: YH Lin, Tarun Tuli, Kapil Porwal, Eric Lai, Simon Zhou. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74391 ) Change subject: mb/google/rex: Create screebo variant ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Please wait this CL, https://review.coreboot.org/c/coreboot/+/74257 or cherry-pick for create_variant.sh +1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74391 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d05ca7c0fe596378ca15d0734d46ad1dc63a1f9 Gerrit-Change-Number: 74391 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:14:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: screebo: initial coreboot for rex variant
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: YH Lin, Tarun Tuli, Kapil Porwal, Simon Zhou. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74392 ) Change subject: screebo: initial coreboot for rex variant ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @Simon, do u have platform mapping document for Screebo? which we can refer to review the code? -- To view, visit https://review.coreboot.org/c/coreboot/+/74392 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a6fe30ebbabb4325b8c855ec0fb6eaf7bc2e8ee Gerrit-Change-Number: 74392 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Simon Zhou <zhouguohui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:13:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Replace assert with error message
by Subrata Banik (Code Review) 13 Apr '23

13 Apr '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74370 ) Change subject: soc/intel/meteorlake: Replace assert with error message ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74370 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I49a988b7eda009456d438ba7be0d2918826e1c36 Gerrit-Change-Number: 74370 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 13 Apr 2023 09:10:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023