Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74516 )
Change subject: soc/intel/common: Remove superfluous cmos_offset from ramtop
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74516
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc1e7d78d2e3ae04330d19e64c3437ff07060ea8
Gerrit-Change-Number: 74516
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:50:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74443 )
Change subject: ec/starlabs/merlin: Update the merlin variant
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8384fc9322058297e8219ac8e483ac37a70bd33
Gerrit-Change-Number: 74443
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:50:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74517 )
Change subject: soc/intel/cometlake: Enable early caching of RAMTOP region
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I579f85e84e0aba7f192ff81a6725d65b7f79ff75
Gerrit-Change-Number: 74517
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:50:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74518 )
Change subject: soc/intel/jasperlake: Enable early caching of RAMTOP region
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74518
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadbce3124a88cf5be0aebde4a76ec6fd4b670216
Gerrit-Change-Number: 74518
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:50:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Nico Huber, Arthur Heymans.
Hello Subrata Banik, build bot (Jenkins), Nico Huber, Arthur Heymans, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74432
to look at the new patch set (#5).
Change subject: mb/starlabs/starbook: Add ramtop to CMOS layout
......................................................................
mb/starlabs/starbook: Add ramtop to CMOS layout
Add `ramtop` to CMOS layout so SOC_INTEL_COMMON_BASECODE_RAMTOP
can be used.
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7
---
M src/mainboard/starlabs/starbook/cmos.layout
M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/74432/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88128d2c62bdc3246a3f30e768c353f0fe3faeb7
Gerrit-Change-Number: 74432
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes, Subrata Banik, Lean Sheng Tan.
Hello build bot (Jenkins), Nico Huber, Subrata Banik, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74511
to look at the new patch set (#4).
Change subject: soc/intel/common: Make ramtop offset configurable
......................................................................
soc/intel/common: Make ramtop offset configurable
Make the `ramtop_cmos_offset` configurable in Kconfig, with a default
value of 1000. This is outside the checksummed area for most boards.
Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/soc/intel/common/basecode/ramtop/Kconfig
M src/soc/intel/common/basecode/ramtop/ramtop.c
2 files changed, 37 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/74511/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Subrata Banik, Kangheui Won, Kapil Porwal, Ivy Jian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74530 )
Change subject: lib: Perform early initialization of FW config in ramstage
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I understand the problem but I'm not sure if this is the best solution. […]
Maybe add stage check like this CL? https://review.coreboot.org/c/coreboot/+/54752
--
To view, visit https://review.coreboot.org/c/coreboot/+/74530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36e7c7d2edc74a2b7fcc192690af73651e87183
Gerrit-Change-Number: 74530
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, cong yang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 )
Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
......................................................................
Patch Set 6:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74135/comment/0db2fab0_f1ca8218
PS6, Line 9: mipi
MIPI
https://review.coreboot.org/c/coreboot/+/74135/comment/241433f9_de4ce33b
PS6, Line 10: mipi panel
MIPI panels
Patchset:
PS5:
> Done, but this changed is not verified since I haven't got the starmie board yet..
Then let's keep this open until this patch is tested.
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/fca8e69b_75812e1c
PS6, Line 79: adc_voltages_table = adc_voltages_detachable;
Just `voltages = adc_voltages_detachable[channel]` here and no need for `adc_voltages_table`.
https://review.coreboot.org/c/coreboot/+/74135/comment/9935bf15_9ddfc131
PS6, Line 113: if (cached_sku_code == BOARD_ID_INIT) {
Since the logic becomes complicated, let's return here if `cached_sku_code != BOARD_ID_INIT`. Then one indentation level could be saved for the following code.
https://review.coreboot.org/c/coreboot/+/74135/comment/6c294cfc_c4290ac1
PS6, Line 116: #if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON))
Use `if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON))
https://review.coreboot.org/c/coreboot/+/74135/comment/19cd95f8_0dff78a3
PS6, Line 126: if (cached_sku_code == CROS_SKU_UNKNOWN) {
I think we can also add `cached_sku_code == CROS_SKU_UNPROVISIONED` here, so that the "if" statements could be merged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74135
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4
Gerrit-Change-Number: 74135
Gerrit-PatchSet: 6
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Kevin3 Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74536 )
Change subject: mb/google/dedede: Create boxy variant
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/74536
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief22eb000421c23abf6de3f99eb860bdae1e7919
Gerrit-Change-Number: 74536
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin3 Yang <kevin3.yang(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:22:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian, Eric Lai.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74530 )
Change subject: lib: Perform early initialization of FW config in ramstage
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I understand the problem but I'm not sure if this is the best solution.
src/include/bootstate.h states "BS_PRE_DEVICE - before any device tree actions take place" so if we interpret fw_config_init as a "device tree action" then it does not match the definition of BS_PRE_DEVICE, wdyt?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74530
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If36e7c7d2edc74a2b7fcc192690af73651e87183
Gerrit-Change-Number: 74530
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 19 Apr 2023 07:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment