coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/intel/meteorlake: Drop FSP CPU feature programming for ChromeOS
by Subrata Banik (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74168 ) Change subject: soc/intel/meteorlake: Drop FSP CPU feature programming for ChromeOS ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: ChromeOS FSP is now able to drop CpuFeaturePei.ffs based on the approval made by Intel FSP Team. Hence, we are good to select Kconfig to let coreboot do the CPU feature programming. -- To view, visit https://review.coreboot.org/c/coreboot/+/74168 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaed0a009813098610190b2a3a985b0748c0d51de Gerrit-Change-Number: 74168 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 09:51:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison
by Yu-Ping Wu (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74553 ) Change subject: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/soc/mediatek/mt8195/apusys_devapc.c: https://review.coreboot.org/c/coreboot/+/74553/comment/9c25179b_ad615671 PS2, Line 154: perm != 0 > This is wrong. `1` is a valid value. […] Changing to `perm < NO_PROTECTION` is fine, but I think we will still get the same warning? -- To view, visit https://review.coreboot.org/c/coreboot/+/74553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f Gerrit-Change-Number: 74553 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 09:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
by Ruihai Zhou (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu, Yidi Lin, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 ) Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ...................................................................... Patch Set 8: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/74135/comment/f58d9bde_ea37af87 PS6, Line 9: mipi > MIPI Done https://review.coreboot.org/c/coreboot/+/74135/comment/c140e9c6_959f16be PS6, Line 10: mipi panel > MIPI panels Done File src/mainboard/google/corsola/boardid.c: https://review.coreboot.org/c/coreboot/+/74135/comment/63042264_e0d0b43a PS6, Line 79: adc_voltages_table = adc_voltages_detachable; > Just `voltages = adc_voltages_detachable[channel]` here and no need for `adc_voltages_table`. Done, thank you. https://review.coreboot.org/c/coreboot/+/74135/comment/e107f441_54608c71 PS6, Line 113: if (cached_sku_code == BOARD_ID_INIT) { > Since the logic becomes complicated, let's return here if `cached_sku_code != BOARD_ID_INIT`. […] Done https://review.coreboot.org/c/coreboot/+/74135/comment/27b0dded_ddba7cdd PS6, Line 116: #if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON)) > Use `if (CONFIG(BOARD_GOOGLE_STARMIE_COMMON)) Done https://review.coreboot.org/c/coreboot/+/74135/comment/4b9e71d4_426ff961 PS6, Line 126: if (cached_sku_code == CROS_SKU_UNKNOWN) { > I think we can also add `cached_sku_code == CROS_SKU_UNPROVISIONED` here, so that the "if" statement […] I think the CROS_SKU_UNPROVISIONED sku id is expected for kingler/krabby board, we don't want to change it to adc mapping value -- To view, visit https://review.coreboot.org/c/coreboot/+/74135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4 Gerrit-Change-Number: 74135 Gerrit-PatchSet: 8 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 09:45:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
by Ruihai Zhou (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, cong yang. Hello Hung-Te Lin, build bot (Jenkins), Yidi Lin, Yu-Ping Wu, cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74135 to look at the new patch set (#8). Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ...................................................................... mb/google/corsola: Report SKU and panel ID for unprovisioned devices The MIPI panels will be used on the detachable variant starmie, and there will be different MIPI panels used on starmie. In order to make the different panels functional on unprovisioned devices, it needs to pass the SKU ID and panel ID to the payload to load the matched device tree for kernel. From the schematic, the starmie variant will read the LCM ID from ADC channel 5. BRANCH=corsola BUG=b:275470328 TEST=boot starmie and see FW screen display Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4 --- M src/mainboard/google/corsola/boardid.c M src/mainboard/google/corsola/display.h 2 files changed, 85 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74135/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/74135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4 Gerrit-Change-Number: 74135 Gerrit-PatchSet: 8 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison
by Arthur Heymans (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Hung-Te Lin, Arthur Heymans, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74553 to look at the new patch set (#3). Change subject: soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison ...................................................................... soc/mediatek/mt8195/apusys_devapc.c: Fix unsigned comparison Clang warns about unsigned comparison below 0. Use the enum value itself to fix this warning. Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/mediatek/mt8195/apusys_devapc.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/74553/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74553 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12fccff2fb7d43fd4582afd518a7eab632908a5f Gerrit-Change-Number: 74553 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: vendorcode/mediatek/mt8195: Fix set but unused variables
by Arthur Heymans (Code Review) 19 Apr '23

19 Apr '23

Arthur Heymans has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/74548 ) Change subject: vendorcode/mediatek/mt8195: Fix set but unused variables ...................................................................... vendorcode/mediatek/mt8195: Fix set but unused variables The clang compiler warns about this. Change-Id: I1584258aa24d6a0bf558b3c622bc53c156a37b09 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/vendorcode/mediatek/mt8195/dramc/Hal_io.c M src/vendorcode/mediatek/mt8195/dramc/dramc_actiming.c M src/vendorcode/mediatek/mt8195/dramc/dramc_dvfs.c M src/vendorcode/mediatek/mt8195/dramc/dramc_pi_calibration_api.c M src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c M src/vendorcode/mediatek/mt8195/dramc/emi.c M src/vendorcode/mediatek/mt8195/include/dramc_common.h M src/vendorcode/mediatek/mt8195/include/x_hal_io.h 8 files changed, 42 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/74548/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74548 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1584258aa24d6a0bf558b3c622bc53c156a37b09 Gerrit-Change-Number: 74548 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/google/corsola: Report SKU and panel ID for unprovisioned devices
by Ruihai Zhou (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, cong yang. Hello Hung-Te Lin, build bot (Jenkins), Yidi Lin, Yu-Ping Wu, cong yang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74135 to look at the new patch set (#7). Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ...................................................................... mb/google/corsola: Report SKU and panel ID for unprovisioned devices The MIPI panels will be used on the detachable variant starmie, and there will be different MIPI panels used on starmie. In order to make the different panels functional on unprovisioned devices, it needs to pass the SKU ID and panel ID to the payload to load the matched device tree for kernel. From the schematic, the starmie variant will read the LCM ID from ADC channel 5. BRANCH=corsola BUG=b:275470328 TEST=boot starmie and see FW screen display Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4 --- M src/mainboard/google/corsola/boardid.c M src/mainboard/google/corsola/display.h 2 files changed, 83 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/74135/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/74135 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6339dc3c177fb8982f77fb3bd32dc00da735fce4 Gerrit-Change-Number: 74135 Gerrit-PatchSet: 7 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/constitution: Generate SPD ID for supported parts
by Jakub Czapiga (Code Review) 19 Apr '23

19 Apr '23

Jakub Czapiga has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74497 ) Change subject: mb/google/brya/var/constitution: Generate SPD ID for supported parts ...................................................................... mb/google/brya/var/constitution: Generate SPD ID for supported parts Add supported memory part in mem_parts_used.txt, then generate. K4UBE3D4AB-MGCL BUG=b:267539938 TEST=run part_id_gen to generate SPD id Change-Id: Iee41bb4511f2d77e5ddc2798f9d4db6137ed818d Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74497 Reviewed-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/constitution/memory/Makefile.inc M src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt 3 files changed, 24 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified David Wu: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/constitution/memory/Makefile.inc b/src/mainboard/google/brya/variants/constitution/memory/Makefile.inc index 5af5272..eb56598 100644 --- a/src/mainboard/google/brya/variants/constitution/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/constitution/memory/Makefile.inc @@ -5,4 +5,4 @@ SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AB-MGCL -SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:B +SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:B, K4UBE3D4AB-MGCL diff --git a/src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt index 30dc4e0c..9b1871c 100644 --- a/src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/constitution/memory/dram_id.generated.txt @@ -6,3 +6,4 @@ DRAM Part Name ID to assign K4U6E3S4AB-MGCL 0 (0000) MT53E1G32D2NP-046 WT:B 1 (0001) +K4UBE3D4AB-MGCL 1 (0001) diff --git a/src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt index d80a500..29280ea 100644 --- a/src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/constitution/memory/mem_parts_used.txt @@ -1,2 +1,3 @@ K4U6E3S4AB-MGCL MT53E1G32D2NP-046 WT:B +K4UBE3D4AB-MGCL -- To view, visit https://review.coreboot.org/c/coreboot/+/74497 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee41bb4511f2d77e5ddc2798f9d4db6137ed818d Gerrit-Change-Number: 74497 Gerrit-PatchSet: 4 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Matthew Ziegelbaum <ziegs(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pablo Ceballos <pceballos(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: configure cpu power limits
by Sumeet R Pawnikar (Code Review) 19 Apr '23

19 Apr '23

Sumeet R Pawnikar has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74373 ) Change subject: soc/intel/meteorlake: configure cpu power limits ...................................................................... Abandoned This is not required any more. This improved patch https://review.coreboot.org/c/coreboot/+/74380 takes care of this change. -- To view, visit https://review.coreboot.org/c/coreboot/+/74373 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9faf28a522d3afea75c2c744d076d761e7080e50 Gerrit-Change-Number: 74373 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: lib: Perform early initialization of FW config in ramstage
by Kapil Porwal (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Tarun Tuli, Kangheui Won, Ivy Jian, Eric Lai. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74530 ) Change subject: lib: Perform early initialization of FW config in ramstage ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I do not see any failure(s) with this CL on google/rex -- To view, visit https://review.coreboot.org/c/coreboot/+/74530 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If36e7c7d2edc74a2b7fcc192690af73651e87183 Gerrit-Change-Number: 74530 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 09:16:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023