coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/brya/var/vell: Generate SPD ID for supported memory part
by Shon Wang (Code Review) 24 Apr '23

24 Apr '23

Shon Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74713 ) Change subject: mb/google/brya/var/vell: Generate SPD ID for supported memory part ...................................................................... mb/google/brya/var/vell: Generate SPD ID for supported memory part Add new memory parts Hynix H58G66AK6BX070 Micron MT62F2G32D8DR-031 WT:B BUG=b: BRANCH=firmware-brya-14505.B TEST=run part_id_gen to generate SPD id Change-Id: I2e6a916de08e7c05e95909d2b69bc839d13192d9 --- M src/mainboard/google/brya/variants/vell/memory/Makefile.inc M src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/74713/1 diff --git a/src/mainboard/google/brya/variants/vell/memory/Makefile.inc b/src/mainboard/google/brya/variants/vell/memory/Makefile.inc index 012e70e..4beede7 100644 --- a/src/mainboard/google/brya/variants/vell/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/vell/memory/Makefile.inc @@ -7,3 +7,5 @@ SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B SPD_SOURCES += spd/lp5/set-0/spd-2.hex # ID = 1(0b0001) Parts = MT62F1G32D4DR-031 WT:B, H9JCNNNCP3MLYR-N6E SPD_SOURCES += spd/lp5/set-0/spd-3.hex # ID = 2(0b0010) Parts = H58G56AK6BX069 +SPD_SOURCES += spd/lp5/set-0/spd-6.hex # ID = 3(0b0011) Parts = H58G66AK6BX070 +SPD_SOURCES += spd/lp5/set-0/spd-4.hex # ID = 4(0b0100) Parts = MT62F2G32D8DR-031 WT:B diff --git a/src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt index 057bb13..60cd377 100644 --- a/src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/vell/memory/dram_id.generated.txt @@ -8,3 +8,5 @@ MT62F1G32D4DR-031 WT:B 1 (0001) H9JCNNNCP3MLYR-N6E 1 (0001) H58G56AK6BX069 2 (0010) +H58G66AK6BX070 3 (0011) +MT62F2G32D8DR-031 WT:B 4 (0100) diff --git a/src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt index 62769f1e..09b9e17 100644 --- a/src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/vell/memory/mem_parts_used.txt @@ -13,3 +13,5 @@ MT62F1G32D4DR-031 WT:B H9JCNNNCP3MLYR-N6E H58G56AK6BX069 +H58G66AK6BX070 +MT62F2G32D8DR-031 WT:B -- To view, visit https://review.coreboot.org/c/coreboot/+/74713 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2e6a916de08e7c05e95909d2b69bc839d13192d9 Gerrit-Change-Number: 74713 Gerrit-PatchSet: 1 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Documentation/releases/coreboot-4.20: Add toolchain updates section
by Jason Glenesk (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Elyes Haouas. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72621 ) Change subject: Documentation/releases/coreboot-4.20: Add toolchain updates section ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fff8b97f6b85165a71aa2a86417f27986fd25fe Gerrit-Change-Number: 72621 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 24 Apr 2023 00:53:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/phoenix/include/xhci: add USB4 XHCI device pointers
by Eric Lai (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Robert Zieba, Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Felix Held. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74658 ) Change subject: soc/amd/phoenix/include/xhci: add USB4 XHCI device pointers ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14725d4b546ffcca42e21bbe7756babaaff8fea3 Gerrit-Change-Number: 74658 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 00:09:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation/mainboard/hp: Add more about internal flashing
by Nicholas Chin (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Felix Singer, Václav Straka. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74248 ) Change subject: Documentation/mainboard/hp: Add more about internal flashing ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53a697a2dd6c10fff8f287284f75d229c7c4b636 Gerrit-Change-Number: 74248 Gerrit-PatchSet: 10 Gerrit-Owner: Václav Straka Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Václav Straka Gerrit-Comment-Date: Sun, 23 Apr 2023 22:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/cpu/amd/mtrr: fix typo in get_top_of_mem_above_4gb
by Felix Held (Code Review) 23 Apr '23

23 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74710 ) Change subject: include/cpu/amd/mtrr: fix typo in get_top_of_mem_above_4gb ...................................................................... include/cpu/amd/mtrr: fix typo in get_top_of_mem_above_4gb Add the missing 'b' to the 4gb so that get_top_of_mem_above_4gb is in line with get_top_of_mem_below_4gb. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic9170372d8b0c27d7de3bd04d822c95e2015cb10 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74710 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> --- M src/include/cpu/amd/mtrr.h M src/northbridge/amd/pi/00730F01/northbridge.c M src/soc/amd/common/block/acpi/tables.c M src/soc/amd/stoneyridge/northbridge.c 4 files changed, 21 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved diff --git a/src/include/cpu/amd/mtrr.h b/src/include/cpu/amd/mtrr.h index e96dc90..04d775c 100644 --- a/src/include/cpu/amd/mtrr.h +++ b/src/include/cpu/amd/mtrr.h @@ -70,7 +70,7 @@ return rdmsr(TOP_MEM).lo; } -static inline uint64_t get_top_of_mem_above_4g(void) +static inline uint64_t get_top_of_mem_above_4gb(void) { msr_t msr = rdmsr(TOP_MEM2); return (uint64_t)msr.hi << 32 | msr.lo; diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index cba57d8..b9ac022 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -550,7 +550,7 @@ * Shift value right by 20 bit to make it fit into 32bit, * giving us 1MB granularity and a limit of almost 4Exabyte of memory. */ - acpigen_write_name_dword("TOM2", get_top_of_mem_above_4g() >> 20); + acpigen_write_name_dword("TOM2", get_top_of_mem_above_4gb() >> 20); acpigen_pop_len(); } @@ -834,7 +834,7 @@ sizek = 0; } else { - uint64_t topmem2 = get_top_of_mem_above_4g(); + uint64_t topmem2 = get_top_of_mem_above_4gb(); basek = 4 * 1024 * 1024; sizek = topmem2 / 1024 - basek; } diff --git a/src/soc/amd/common/block/acpi/tables.c b/src/soc/amd/common/block/acpi/tables.c index 17db421..3ba9af6 100644 --- a/src/soc/amd/common/block/acpi/tables.c +++ b/src/soc/amd/common/block/acpi/tables.c @@ -58,6 +58,6 @@ * Shift value right by 20 bit to make it fit into 32bit, * giving us 1MB granularity and a limit of almost 4Exabyte of memory. */ - acpigen_write_name_dword("TOM2", get_top_of_mem_above_4g() >> 20); + acpigen_write_name_dword("TOM2", get_top_of_mem_above_4gb() >> 20); acpigen_pop_len(); } diff --git a/src/soc/amd/stoneyridge/northbridge.c b/src/soc/amd/stoneyridge/northbridge.c index bafeabb..75fdfa4 100644 --- a/src/soc/amd/stoneyridge/northbridge.c +++ b/src/soc/amd/stoneyridge/northbridge.c @@ -328,7 +328,7 @@ uint32_t uma_size = get_uma_size(); uint32_t mem_useable = (uintptr_t)cbmem_top(); uint32_t tom = get_top_of_mem_below_4gb(); - uint64_t high_tom = get_top_of_mem_above_4g(); + uint64_t high_tom = get_top_of_mem_above_4gb(); uint64_t high_mem_useable; int idx = 0x10; -- To view, visit https://review.coreboot.org/c/coreboot/+/74710 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9170372d8b0c27d7de3bd04d822c95e2015cb10 Gerrit-Change-Number: 74710 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: util/crossgcc: Update GCC from 11.3 to 12.2
by Felix Singer (Code Review) 23 Apr '23

23 Apr '23

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66922 ) Change subject: util/crossgcc: Update GCC from 11.3 to 12.2 ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > Yeah I don't want to submit this before the release too. Just removed the hashtag. […] Also, GCC 13 might not have the current Ada issues. I still need to test it, but in this case we could just skip GCC 12 I think. -- To view, visit https://review.coreboot.org/c/coreboot/+/66922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09 Gerrit-Change-Number: 66922 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Apr 2023 18:20:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/crossgcc: Update GCC from 11.3 to 12.2
by Felix Singer (Code Review) 23 Apr '23

23 Apr '23

Attention is currently required from: Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66922 ) Change subject: util/crossgcc: Update GCC from 11.3 to 12.2 ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: > We should not merge this before the release. After the release is fine. Yeah I don't want to submit this before the release too. Just removed the hashtag. Forgot to do that. -- To view, visit https://review.coreboot.org/c/coreboot/+/66922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09 Gerrit-Change-Number: 66922 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sun, 23 Apr 2023 18:09:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: Remove unused CHIPs
by Martin L Roth (Code Review) 23 Apr '23

23 Apr '23

Attention is currently required from: Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72600 ) Change subject: treewide: Remove unused CHIPs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I think this needs a manual rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/72600 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia65a0a56a6668a13761bad35f6a44ed8f6a35a78 Gerrit-Change-Number: 72600 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 23 Apr 2023 18:03:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/releases/coreboot-4.20: Add toolchain updates section
by Martin L Roth (Code Review) 23 Apr '23

23 Apr '23

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72621 ) Change subject: Documentation/releases/coreboot-4.20: Add toolchain updates section ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72621 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fff8b97f6b85165a71aa2a86417f27986fd25fe Gerrit-Change-Number: 72621 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 23 Apr 2023 18:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: util/crossgcc: Update GCC from 11.3 to 12.2
by Martin L Roth (Code Review) 23 Apr '23

23 Apr '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66922 ) Change subject: util/crossgcc: Update GCC from 11.3 to 12.2 ...................................................................... Patch Set 15: Code-Review-1 (1 comment) Patchset: PS15: We should not merge this before the release. After the release is fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/66922 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia15e48847c6aea4f3188588b5092250568f16a09 Gerrit-Change-Number: 66922 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Sun, 23 Apr 2023 18:01:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023