coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: acpi: Add a runtime method to override exposed _Sx sleep states
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak. Hello Lance Zhao, build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74762 to look at the new patch set (#4). Change subject: acpi: Add a runtime method to override exposed _Sx sleep states ...................................................................... acpi: Add a runtime method to override exposed _Sx sleep states This allows mainboards to override available sleep states at runtime. This is done by adding a IntObj in SSDT that DSDT consumes to override the available _Sx states. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 --- M src/acpi/Kconfig M src/acpi/acpi.c M src/include/acpi/acpi.h M src/southbridge/intel/common/acpi/sleepstates.asl 4 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/74762/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel: Don't report _S1 state when unsupported
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jeff Daly, Nico Huber, Tarun Tuli, Subrata Banik, Jonathan Zhang, Johnny Lin, Christian Walter, Kapil Porwal, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu. Hello build bot (Jenkins), Jeff Daly, Jonathan Zhang, Sean Rhodes, Tarun Tuli, Subrata Banik, Johnny Lin, Kapil Porwal, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74760 to look at the new patch set (#4). Change subject: soc/intel: Don't report _S1 state when unsupported ...................................................................... soc/intel: Don't report _S1 state when unsupported Since skylake Intel hardware does not support this sleep state. Trying to do enter it results in a system hang on at least Alderlake (prodrive/atlas). Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da --- M src/Kconfig M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig M src/soc/intel/xeon_sp/Kconfig M src/southbridge/intel/common/acpi/sleepstates.asl 12 files changed, 32 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/74760/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da Gerrit-Change-Number: 74760 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel: Don't report _S1 state when unsupported
by Arthur Heymans (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jeff Daly, Nico Huber, Tarun Tuli, Subrata Banik, Jonathan Zhang, Johnny Lin, Christian Walter, Kapil Porwal, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74760 ) Change subject: soc/intel: Don't report _S1 state when unsupported ...................................................................... Patch Set 3: (1 comment) File src/southbridge/intel/common/acpi/sleepstates.asl: https://review.coreboot.org/c/coreboot/+/74760/comment/823121f2_3dc9000b PS3, Line 6: #else > This else wouldn't be the same as `#if CONFIG(HAVE_ACPI_RESUME)` anymore. Done, thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/74760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da Gerrit-Change-Number: 74760 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 16:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intel/mtl: Add get_cse_ver_from_cbfs function
by Sridhar Siricilla (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Ashish Kumar Mishra. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74755 ) Change subject: intel/mtl: Add get_cse_ver_from_cbfs function ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 Gerrit-Change-Number: 74755 Gerrit-PatchSet: 5 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:56:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel: Don't report _S1 state when unsupported
by Nico Huber (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jeff Daly, Tarun Tuli, Subrata Banik, Jonathan Zhang, Johnny Lin, Christian Walter, Kapil Porwal, Vanessa Eusebio, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Tim Chu. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74760 ) Change subject: soc/intel: Don't report _S1 state when unsupported ...................................................................... Patch Set 3: (1 comment) File src/southbridge/intel/common/acpi/sleepstates.asl: https://review.coreboot.org/c/coreboot/+/74760/comment/bd033bb7_d43a038d PS3, Line 6: #else This else wouldn't be the same as `#if CONFIG(HAVE_ACPI_RESUME)` anymore. -- To view, visit https://review.coreboot.org/c/coreboot/+/74760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da Gerrit-Change-Number: 74760 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:56:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intel/mtl: Add get_cse_ver_from_cbfs function
by Ashish Kumar Mishra (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Ashish Kumar Mishra, Sridhar Siricilla. Hello Sridhar Siricilla, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74755 to look at the new patch set (#5). Change subject: intel/mtl: Add get_cse_ver_from_cbfs function ...................................................................... intel/mtl: Add get_cse_ver_from_cbfs function This patch implements helper function get_cse_ver_from_cbfs() to retrieve the CSE Lite version from CBFE RW's metadata and calls the helper function from cse_check_update_status() TEST=Verified CSE Lite version in coreboot boot log Signed-off-by: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 46 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74755/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 Gerrit-Change-Number: 74755 Gerrit-PatchSet: 5 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap()
by Tim Van Patten (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74716 ) Change subject: soc/amd/common/block: Add missing cbfs_unmap() ...................................................................... Patch Set 2: (7 comments) File src/soc/amd/common/block/cpu/update_microcode.c: https://review.coreboot.org/c/coreboot/+/74716/comment/36c881b6_74964255 PS2, Line 98: ucode = find_microcode(ucode, equivalent_processor_rev_id); This is a bug, since we can no long `cbfs_unmap(ucode)`, since we've lost the address. Please restore `ucode_cache`, so we can call `cbfs_unmap(ucode)` before returning if there is an error. https://review.coreboot.org/c/coreboot/+/74716/comment/e61532db_5d21c1d8 PS2, Line 100: cbfs_unmap((void *)ucode); As noted in the previous comment, this is essentially calling `cbfs_unmap(NULL)` (as enforced by the conditional to get here). https://review.coreboot.org/c/coreboot/+/74716/comment/a5b71908_b3c3e905 PS2, Line 111: (void *) Are these casts necessary? File src/soc/amd/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/74716/comment/ff1eb536_467c4fc0 PS1, Line 168: if (ram == NULL) { : printk(BIOS_ERR, "%s: Unable to load ROM for %s\n", : __func__, dev_path(dev)); : } > Actually, I did not add 'return' here on purpose. […] Ack https://review.coreboot.org/c/coreboot/+/74716/comment/a605a277_dc4a2686 PS1, Line 173: cbfs_unmap(rom); > I talked with Jakub and Konrad and we decided to add `pci_rom_free` function which for now directly […] `cbfs_unmap()` ignores addresses it doesn't recognize, so it's (currently) safe to always call it, even if it's not entirely correct. File src/soc/amd/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/74716/comment/0ac5898f_f4590eff PS2, Line 157: timestamp_add_now(TS_OPROM_COPY_END); : return; ref1 https://review.coreboot.org/c/coreboot/+/74716/comment/b24f8365_fabea334 PS2, Line 164: return; Based on the comment below, this appears to be missing a call to `timestamp_add_now()`. The error case above (ref1) also includes it, so it appears to have been missed. -- To view, visit https://review.coreboot.org/c/coreboot/+/74716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1 Gerrit-Change-Number: 74716 Gerrit-PatchSet: 2 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:46:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intel/mtl: Add get_cse_ver_from_cbfs function
by Himanshu Sahdev (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Ashish Kumar Mishra, Sridhar Siricilla. Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74755 ) Change subject: intel/mtl: Add get_cse_ver_from_cbfs function ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/74755/comment/f854fe66_0d84ea98 PS4, Line 642: version_ptr version_str? -- To view, visit https://review.coreboot.org/c/coreboot/+/74755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 Gerrit-Change-Number: 74755 Gerrit-PatchSet: 4 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:41:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: intel/mtl: Add get_cse_ver_from_cbfs function
by Ashish Kumar Mishra (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Sridhar Siricilla. Hello Sridhar Siricilla, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74755 to look at the new patch set (#4). Change subject: intel/mtl: Add get_cse_ver_from_cbfs function ...................................................................... intel/mtl: Add get_cse_ver_from_cbfs function This patch implements helper function get_cse_ver_from_cbfs() to retrieve the CSE Lite version from CBFE RW's metadata and calls the helper function from cse_check_update_status() TEST=Verified CSE Lite version in coreboot boot log Signed-off-by: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 46 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/74755/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1bf186adfc3f87826a7ce9b0167a6bbe6767299 Gerrit-Change-Number: 74755 Gerrit-PatchSet: 4 Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi: Add missing cbfs_unmap()
by Tim Van Patten (Code Review) 25 Apr '23

25 Apr '23

Attention is currently required from: Lance Zhao, Konrad Adamczyk, Jakub Czapiga, Tim Wawrzynczak, Grzegorz Bernacki, Karthik Ramasubramanian. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74715 ) Change subject: acpi: Add missing cbfs_unmap() ...................................................................... Patch Set 2: (1 comment) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/74715/comment/db262c16_bdcb2ce9 PS2, Line 1934: cbfs_unmap(dsdt_file); This call doesn't actually free the memory. Instead, these `cbfs_unmap()` calls need to be reversed, since the memory must be freed in reverse order of how it was allocated. Looking at the implementation of `cbfs_unmap()`, it just calls `mem_pool_free()`: `src/third_party/coreboot/src/lib/cbfs.c` ``` void cbfs_unmap(void *mapping) { ... mem_pool_free(&cbfs_cache, mapping); } ``` However, `mem_pool_free()` will only free the last allocation, which in this case was `slic_file`. `src/third_party/coreboot/src/commonlib/mem_pool.c` ``` void mem_pool_free(struct mem_pool *mp, void *p) { /* Determine if p was the most recent allocation. */ if (p == NULL || mp->last_alloc != p) <<---- last_alloc == slic_file return; mp->free_offset = mp->last_alloc - mp->buf; mp->last_alloc = mp->second_to_last_alloc; /* No way to track allocation before this one. */ mp->second_to_last_alloc = NULL; } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/74715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf7ba6842f42404ad8bb415f8e7fda10403cbe2e Gerrit-Change-Number: 74715 Gerrit-PatchSet: 2 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 25 Apr 2023 15:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023