coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[L] Change in coreboot[main]: mb/google/dedede: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78127?usp=email ) Change subject: mb/google/dedede: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/dedede: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I5527d5968be35f52b912d9d6e1d9f46f24569bbc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78127 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name 2 files changed, 183 insertions(+), 125 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/dedede/Kconfig b/src/mainboard/google/dedede/Kconfig index 02087ac..be8c04a 100644 --- a/src/mainboard/google/dedede/Kconfig +++ b/src/mainboard/google/dedede/Kconfig @@ -45,6 +45,189 @@ select MEMORY_MAPPED_TPM select BOARD_GOOGLE_BASEBOARD_DEDEDE +config BOARD_GOOGLE_BOTEN + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_DIBBI + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select RT8168_GEN_ACPI_POWER_RESOURCE + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + +config BOARD_GOOGLE_DEDEDE + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 + +config BOARD_GOOGLE_DRAWCIA + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select DRIVERS_INTEL_MIPI_CAMERA + select INTEL_GMA_HAVE_VBT + select SOC_INTEL_COMMON_BLOCK_IPU + +config BOARD_GOOGLE_HABOKI + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU + +config BOARD_GOOGLE_MADOO + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_WADDLEDOO + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU + +config BOARD_GOOGLE_WADDLEDEE + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select BOARD_ROMSIZE_KB_32768 + +config BOARD_GOOGLE_LALALA + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_INTEL_MIPI_CAMERA + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select SOC_INTEL_COMMON_BLOCK_IPU + +config BOARD_GOOGLE_MAGOLOR + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_I2C_DA7219 + select DRIVERS_INTEL_MIPI_CAMERA + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + select INTEL_GMA_HAVE_VBT + select SOC_INTEL_COMMON_BLOCK_IPU + +config BOARD_GOOGLE_METAKNIGHT + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + +config BOARD_GOOGLE_LANTIS + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + +config BOARD_GOOGLE_GALTIC + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_SASUKE + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_STORO + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + select DRIVERS_INTEL_MIPI_CAMERA + select SOC_INTEL_COMMON_BLOCK_IPU + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_SASUKETTE + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_KRACKO + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_BLIPPER + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_CRET + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_PIRIKA + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_CAPPY2 + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + +config BOARD_GOOGLE_BUGZZY + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_DA7219 + select DRIVERS_I2C_SX9360 + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_CORORI + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + +config BOARD_GOOGLE_DRIBLEE + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + +config BOARD_GOOGLE_GOOEY + select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_BEADRIX + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select BASEBOARD_DEDEDE_LAPTOP + select DRIVERS_GENERIC_MAX98357A + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + +config BOARD_GOOGLE_SHOTZO + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + +config BOARD_GOOGLE_TARANZA + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select RT8168_GEN_ACPI_POWER_RESOURCE + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR + +config BOARD_GOOGLE_BOXY + select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 + select RT8168_GEN_ACPI_POWER_RESOURCE + select RT8168_GET_MAC_FROM_VPD + select RT8168_SET_LED_MODE + if BOARD_GOOGLE_BASEBOARD_DEDEDE config BASEBOARD_DEDEDE_LAPTOP diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name index f668fb1..f11770e 100644 --- a/src/mainboard/google/dedede/Kconfig.name +++ b/src/mainboard/google/dedede/Kconfig.name @@ -2,34 +2,15 @@ config BOARD_GOOGLE_BOTEN bool "-> Boten (Lenovo 500e Chromebook Gen 3)" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_I2C_SX9324 - select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_DIBBI bool "-> Dibbi" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select RT8168_GEN_ACPI_POWER_RESOURCE - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE config BOARD_GOOGLE_DEDEDE bool "-> Dedede" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select BOARD_ROMSIZE_KB_32768 config BOARD_GOOGLE_DRAWCIA bool "-> Drawcia" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select DRIVERS_INTEL_MIPI_CAMERA - select INTEL_GMA_HAVE_VBT - select SOC_INTEL_COMMON_BLOCK_IPU help The Drawcia board supports the following devices: - HP Chromebook x360 11 G4 EE (Drawcia) @@ -38,181 +19,75 @@ config BOARD_GOOGLE_HABOKI bool "-> HABOKI" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select DRIVERS_INTEL_MIPI_CAMERA - select SOC_INTEL_COMMON_BLOCK_IPU config BOARD_GOOGLE_MADOO bool "-> Madoo" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_WADDLEDOO bool "-> Waddledoo" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select BOARD_ROMSIZE_KB_32768 - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 - select DRIVERS_INTEL_MIPI_CAMERA - select SOC_INTEL_COMMON_BLOCK_IPU config BOARD_GOOGLE_WADDLEDEE bool "-> Waddledee" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select BOARD_ROMSIZE_KB_32768 config BOARD_GOOGLE_LALALA bool "-> Lalala" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_INTEL_MIPI_CAMERA - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select SOC_INTEL_COMMON_BLOCK_IPU config BOARD_GOOGLE_MAGOLOR bool "-> Magolor" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_I2C_DA7219 - select DRIVERS_INTEL_MIPI_CAMERA - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR - select INTEL_GMA_HAVE_VBT - select SOC_INTEL_COMMON_BLOCK_IPU config BOARD_GOOGLE_METAKNIGHT bool "-> Metaknight" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP config BOARD_GOOGLE_LANTIS bool "-> Lantis" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A config BOARD_GOOGLE_GALTIC bool "-> Galtic" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_SASUKE bool "-> Sasuke (Samsung Galaxy Chromebook Go)" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_STORO bool "-> Storo (Asus Chromebook CR1100)" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_I2C_SX9324 - select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER - select DRIVERS_INTEL_MIPI_CAMERA - select SOC_INTEL_COMMON_BLOCK_IPU - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_SASUKETTE bool "-> Sasukette" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_KRACKO bool "-> Kracko" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_SX9324 - select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_BLIPPER bool "-> Blipper" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_CRET bool "-> Cret" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_PIRIKA bool "-> Pirika" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_CAPPY2 bool "-> Cappy2" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP config BOARD_GOOGLE_BUGZZY bool "-> Bugzzy" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_DA7219 - select DRIVERS_I2C_SX9360 - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_CORORI bool "-> Corori" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A config BOARD_GOOGLE_DRIBLEE bool "-> Driblee" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A config BOARD_GOOGLE_GOOEY bool "-> Gooey" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_TPM2 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_I2C_SX9324 - select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_BEADRIX bool "-> Beadrix" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select BASEBOARD_DEDEDE_LAPTOP - select DRIVERS_GENERIC_MAX98357A - select DRIVERS_I2C_SX9324 - select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER config BOARD_GOOGLE_SHOTZO bool "-> Shotzo" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 config BOARD_GOOGLE_TARANZA bool "-> Taranza" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select RT8168_GEN_ACPI_POWER_RESOURCE - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE - select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR config BOARD_GOOGLE_BOXY bool "-> Boxy" - select BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50 - select RT8168_GEN_ACPI_POWER_RESOURCE - select RT8168_GET_MAC_FROM_VPD - select RT8168_SET_LED_MODE -- To view, visit https://review.coreboot.org/c/coreboot/+/78127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5527d5968be35f52b912d9d6e1d9f46f24569bbc Gerrit-Change-Number: 78127 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[L] Change in coreboot[main]: mb/google/dedede: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78127?usp=email ) Change subject: mb/google/dedede: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5527d5968be35f52b912d9d6e1d9f46f24569bbc Gerrit-Change-Number: 78127 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 03 Oct 2023 15:09:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Felix Singer, Nick Vaccaro, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78126?usp=email ) Change subject: mb/google/brya: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Needs a manual rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/78126?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1439f785cb9ceeefab9d24caa88e35bd43f68315 Gerrit-Change-Number: 78126 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Oct 2023 15:08:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/brya: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Felix Singer, Nick Vaccaro, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78126?usp=email ) Change subject: mb/google/brya: Move selects from Kconfig.name to Kconfig ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78126?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1439f785cb9ceeefab9d24caa88e35bd43f68315 Gerrit-Change-Number: 78126 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Oct 2023 15:08:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/siemens: Move selects from Kconfig.name to Kconfig
by Martin L Roth (Code Review) 03 Oct '23

03 Oct '23

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75078?usp=email ) Change subject: mb/siemens: Move selects from Kconfig.name to Kconfig ...................................................................... mb/siemens: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Ic199a60013ceedfd15b191a5fe707be6654ad3a2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75078 Reviewed-by: Werner Zeh <werner.zeh(a)siemens.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/mainboard/siemens/fa_ehl/Kconfig M src/mainboard/siemens/fa_ehl/Kconfig.name M src/mainboard/siemens/mc_apl1/Kconfig M src/mainboard/siemens/mc_apl1/Kconfig.name M src/mainboard/siemens/mc_ehl/Kconfig M src/mainboard/siemens/mc_ehl/Kconfig.name 6 files changed, 39 insertions(+), 13 deletions(-) Approvals: Werner Zeh: Looks good to me, approved Mario Scheithauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/siemens/fa_ehl/Kconfig b/src/mainboard/siemens/fa_ehl/Kconfig index c673f9b..a2f8c89 100644 --- a/src/mainboard/siemens/fa_ehl/Kconfig +++ b/src/mainboard/siemens/fa_ehl/Kconfig @@ -7,6 +7,9 @@ select USE_SIEMENS_HWILIB select SOC_INTEL_DISABLE_POWER_LIMITS +config BOARD_SIEMENS_FA_EHL + select BOARD_SIEMENS_BASEBOARD_FA_EHL + source "src/mainboard/siemens/fa_ehl/variants/*/Kconfig" if BOARD_SIEMENS_BASEBOARD_FA_EHL diff --git a/src/mainboard/siemens/fa_ehl/Kconfig.name b/src/mainboard/siemens/fa_ehl/Kconfig.name index 0f9d062..b3bbe8a 100644 --- a/src/mainboard/siemens/fa_ehl/Kconfig.name +++ b/src/mainboard/siemens/fa_ehl/Kconfig.name @@ -2,4 +2,3 @@ config BOARD_SIEMENS_FA_EHL bool "-> FA EHL" - select BOARD_SIEMENS_BASEBOARD_FA_EHL diff --git a/src/mainboard/siemens/mc_apl1/Kconfig b/src/mainboard/siemens/mc_apl1/Kconfig index 4701739..73efead 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig +++ b/src/mainboard/siemens/mc_apl1/Kconfig @@ -7,6 +7,27 @@ select USE_SIEMENS_HWILIB select INTEL_LPSS_UART_FOR_CONSOLE +config BOARD_SIEMENS_MC_APL1 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL2 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL3 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL4 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL5 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL6 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + +config BOARD_SIEMENS_MC_APL7 + select BOARD_SIEMENS_BASEBOARD_MC_APL1 + source "src/mainboard/siemens/mc_apl1/variants/*/Kconfig" if BOARD_SIEMENS_BASEBOARD_MC_APL1 diff --git a/src/mainboard/siemens/mc_apl1/Kconfig.name b/src/mainboard/siemens/mc_apl1/Kconfig.name index 9c9ff27..4fd32e50 100644 --- a/src/mainboard/siemens/mc_apl1/Kconfig.name +++ b/src/mainboard/siemens/mc_apl1/Kconfig.name @@ -2,28 +2,21 @@ config BOARD_SIEMENS_MC_APL1 bool "-> MC APL1" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL2 bool "-> MC APL2" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL3 bool "-> MC APL3" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL4 bool "-> MC APL4" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL5 bool "-> MC APL5" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL6 bool "-> MC APL6" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 config BOARD_SIEMENS_MC_APL7 bool "-> MC APL7" - select BOARD_SIEMENS_BASEBOARD_MC_APL1 diff --git a/src/mainboard/siemens/mc_ehl/Kconfig b/src/mainboard/siemens/mc_ehl/Kconfig index 89d53c7..93b084d 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig +++ b/src/mainboard/siemens/mc_ehl/Kconfig @@ -9,6 +9,21 @@ select USE_SIEMENS_HWILIB select SOC_INTEL_DISABLE_POWER_LIMITS +config BOARD_SIEMENS_MC_EHL1 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL2 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL3 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL4 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + +config BOARD_SIEMENS_MC_EHL5 + select BOARD_SIEMENS_BASEBOARD_MC_EHL + source "src/mainboard/siemens/mc_ehl/variants/*/Kconfig" if BOARD_SIEMENS_BASEBOARD_MC_EHL diff --git a/src/mainboard/siemens/mc_ehl/Kconfig.name b/src/mainboard/siemens/mc_ehl/Kconfig.name index 8ad4744..7f22703 100644 --- a/src/mainboard/siemens/mc_ehl/Kconfig.name +++ b/src/mainboard/siemens/mc_ehl/Kconfig.name @@ -2,20 +2,15 @@ config BOARD_SIEMENS_MC_EHL1 bool "-> MC EHL1" - select BOARD_SIEMENS_BASEBOARD_MC_EHL config BOARD_SIEMENS_MC_EHL2 bool "-> MC EHL2" - select BOARD_SIEMENS_BASEBOARD_MC_EHL config BOARD_SIEMENS_MC_EHL3 bool "-> MC EHL3" - select BOARD_SIEMENS_BASEBOARD_MC_EHL config BOARD_SIEMENS_MC_EHL4 bool "-> MC EHL4" - select BOARD_SIEMENS_BASEBOARD_MC_EHL config BOARD_SIEMENS_MC_EHL5 bool "-> MC EHL5" - select BOARD_SIEMENS_BASEBOARD_MC_EHL -- To view, visit https://review.coreboot.org/c/coreboot/+/75078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic199a60013ceedfd15b191a5fe707be6654ad3a2 Gerrit-Change-Number: 75078 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: soc/intel/cmn/gfx: Add API to report presence of external display
by Subrata Banik (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78080?usp=email ) Change subject: soc/intel/cmn/gfx: Add API to report presence of external display ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/78080/comment/3e546c7e_2f6d55bb : PS1, Line 59: #if CONFIG(REPORT_EXTERNAL_DISPLAY_AT_PREBOOT) > Sorry, you acknowledged this but you are still testing the Kconfig inside the function now... what's the final reasoning here? My point was that I think you should be able to remove the Kconfig entirely, if this code either works as intended or just returns a 0 for all platforms running it (because returning a 0 is what we want for those that don't support it anyway). Now i have removed the kconfig entirely as now I'm satisfied with testing older platforms. i have guarded the Kconfig, until that time. -- To view, visit https://review.coreboot.org/c/coreboot/+/78080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77436940978c7fa9368d79394b46a5e794c32e42 Gerrit-Change-Number: 78080 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 15:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel: Move USB wake methods to a common ASL file
by Martin L Roth (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Nick Vaccaro, Reka Norman, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78085?usp=email ) Change subject: soc/intel: Move USB wake methods to a common ASL file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabdfe2bece7fafc284ddf04382f1bbcacc370cce Gerrit-Change-Number: 78085 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-CC: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 03 Oct 2023 15:06:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: {commonlib, libpayload}: Add "is external display" in coreboot table
by Subrata Banik (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Andrey Petrov, Arthur Heymans, Julius Werner, Karthik Ramasubramanian, Nick Vaccaro, Yu-Ping Wu. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77796?usp=email ) Change subject: {commonlib, libpayload}: Add "is_external display" in coreboot table ...................................................................... Patch Set 4: (2 comments) File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/77796/comment/5b51a915_72128749 : PS4, Line 447: config REPORT_EXTERNAL_DISPLAY_AT_PREBOOT > Is this used anywhere? SOC should have use that bt lets drop it as suggested by Julius. File src/drivers/intel/fsp2_0/include/fsp/graphics.h: https://review.coreboot.org/c/coreboot/+/77796/comment/b1730811_6387368f : PS4, Line 25: int soc_report_external_display(void); > If it's declared here (only for intel fsp), then the function name should have the `fsp_` prefix. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/77796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b Gerrit-Change-Number: 77796 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 14:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH
by Subrata Banik (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78077?usp=email ) Change subject: ec/google: Assume LID open for platforms without VBOOT_LID_SWITCH ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: I felt there is no relation between VBOOT_LID_SWITCH config related refactoring and what the rest of the CLs does to detect the external display presence or not. Hence, I will rebase CB:78078 at ToT and keep the VBOOT_LID_SWITCH refactoring Cls as is to allow more time before deciding a path. -- To view, visit https://review.coreboot.org/c/coreboot/+/78077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34bfc21329660a4bfd1ffed939b6dfb7e7109204 Gerrit-Change-Number: 78077 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 14:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/puff: Hide LSPCON device from Windows
by Matt DeVillier (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: CoolStar, Subrata Banik. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78040?usp=email ) Change subject: mb/google/puff: Hide LSPCON device from Windows ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > > was that causing any issue while booting to chromeos ? […] tested with ChromeOS Flex and ChromeOS via Brunch, no display-related issues in either -- To view, visit https://review.coreboot.org/c/coreboot/+/78040?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib646e01a337b8d7baf20a886c49a8cb64d6408f3 Gerrit-Change-Number: 78040 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 14:22:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023