coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: mb/prodrive: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75029?usp=email ) Change subject: mb/prodrive: Move selects from Kconfig.name to Kconfig ...................................................................... mb/prodrive: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Iface0fd1d44649c6d9773940818e028e3d3a4292 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75029 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/Kconfig.name M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Kconfig.name 4 files changed, 6 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig index 5761fad..e4be946 100644 --- a/src/mainboard/prodrive/atlas/Kconfig +++ b/src/mainboard/prodrive/atlas/Kconfig @@ -12,6 +12,9 @@ select PCIEXP_SUPPORT_RESIZABLE_BARS select SOC_INTEL_ALDERLAKE_PCH_P +config BOARD_PRODRIVE_ATLAS + select BOARD_PRODRIVE_ATLAS_BASEBOARD + if BOARD_PRODRIVE_ATLAS_BASEBOARD config ATLAS_ENABLE_SAGV diff --git a/src/mainboard/prodrive/atlas/Kconfig.name b/src/mainboard/prodrive/atlas/Kconfig.name index f4304a0..722f0e5 100644 --- a/src/mainboard/prodrive/atlas/Kconfig.name +++ b/src/mainboard/prodrive/atlas/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_PRODRIVE_ATLAS bool "Atlas" - select BOARD_PRODRIVE_ATLAS_BASEBOARD diff --git a/src/mainboard/prodrive/hermes/Kconfig b/src/mainboard/prodrive/hermes/Kconfig index e4ccd2d..0a0db36 100644 --- a/src/mainboard/prodrive/hermes/Kconfig +++ b/src/mainboard/prodrive/hermes/Kconfig @@ -18,6 +18,9 @@ select HAVE_ACPI_RESUME if !HERMES_USES_SPS_FIRMWARE select DISABLE_ACPI_HIBERNATE if HERMES_USES_SPS_FIRMWARE +config BOARD_PRODRIVE_HERMES + select BOARD_PRODRIVE_HERMES_BASEBOARD + if BOARD_PRODRIVE_HERMES_BASEBOARD config HERMES_USES_SPS_FIRMWARE diff --git a/src/mainboard/prodrive/hermes/Kconfig.name b/src/mainboard/prodrive/hermes/Kconfig.name index 10dd9ba..4aff62f 100644 --- a/src/mainboard/prodrive/hermes/Kconfig.name +++ b/src/mainboard/prodrive/hermes/Kconfig.name @@ -1,3 +1,2 @@ config BOARD_PRODRIVE_HERMES bool "Hermes" - select BOARD_PRODRIVE_HERMES_BASEBOARD -- To view, visit https://review.coreboot.org/c/coreboot/+/75029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iface0fd1d44649c6d9773940818e028e3d3a4292 Gerrit-Change-Number: 75029 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/amd/mayan: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75083?usp=email ) Change subject: mb/amd/mayan: Move selects from Kconfig.name to Kconfig ...................................................................... mb/amd/mayan: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I5a321680b1b84ca0b2598d2446ff10257947a733 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75083 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/amd/mayan/Kconfig M src/mainboard/amd/mayan/Kconfig.name 2 files changed, 1 insertion(+), 1 deletion(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/amd/mayan/Kconfig b/src/mainboard/amd/mayan/Kconfig index 35b39a6..1c6b15a 100644 --- a/src/mainboard/amd/mayan/Kconfig +++ b/src/mainboard/amd/mayan/Kconfig @@ -14,6 +14,7 @@ select PCIEXP_COMMON_CLOCK select PCIEXP_L1_SUB_STATE select SOC_AMD_COMMON_BLOCK_ESPI_RETAIN_PORT80_EN + select SOC_AMD_PHOENIX config FMDFILE default "src/mainboard/amd/mayan/chromeos.fmd" if CHROMEOS diff --git a/src/mainboard/amd/mayan/Kconfig.name b/src/mainboard/amd/mayan/Kconfig.name index 9c99748..8179596 100644 --- a/src/mainboard/amd/mayan/Kconfig.name +++ b/src/mainboard/amd/mayan/Kconfig.name @@ -2,4 +2,3 @@ config BOARD_AMD_MAYAN_PHOENIX bool "-> Mayan for Phoenix SoC" - select SOC_AMD_PHOENIX -- To view, visit https://review.coreboot.org/c/coreboot/+/75083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5a321680b1b84ca0b2598d2446ff10257947a733 Gerrit-Change-Number: 75083 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: dell/snb_ivb_workstations: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75072?usp=email ) Change subject: dell/snb_ivb_workstations: Move selects from Kconfig.name to Kconfig ...................................................................... dell/snb_ivb_workstations: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I80bd87aa2f97da74a1bbcf05b16f0d5980e142f2 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/75072 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/dell/snb_ivb_workstations/Kconfig M src/mainboard/dell/snb_ivb_workstations/Kconfig.name 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig b/src/mainboard/dell/snb_ivb_workstations/Kconfig index 8dcafd1..bf211bb 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig @@ -18,6 +18,14 @@ select PCIEXP_L1_SUB_STATE select DRIVERS_UART_8250IO +config BOARD_DELL_OPTIPLEX_9010 + select BOARD_DELL_SNB_IVB_WORKSTATIONS + select SOUTHBRIDGE_INTEL_C216 + +config BOARD_DELL_PRECISION_T1650 + select BOARD_DELL_SNB_IVB_WORKSTATIONS + select SOUTHBRIDGE_INTEL_C216 + if BOARD_DELL_SNB_IVB_WORKSTATIONS config MAINBOARD_DIR diff --git a/src/mainboard/dell/snb_ivb_workstations/Kconfig.name b/src/mainboard/dell/snb_ivb_workstations/Kconfig.name index 6f6d833..d258054 100644 --- a/src/mainboard/dell/snb_ivb_workstations/Kconfig.name +++ b/src/mainboard/dell/snb_ivb_workstations/Kconfig.name @@ -1,9 +1,5 @@ config BOARD_DELL_OPTIPLEX_9010 bool "OptiPlex 9010 SFF" - select BOARD_DELL_SNB_IVB_WORKSTATIONS - select SOUTHBRIDGE_INTEL_C216 config BOARD_DELL_PRECISION_T1650 bool "Dell Precision T1650" - select BOARD_DELL_SNB_IVB_WORKSTATIONS - select SOUTHBRIDGE_INTEL_C216 -- To view, visit https://review.coreboot.org/c/coreboot/+/75072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80bd87aa2f97da74a1bbcf05b16f0d5980e142f2 Gerrit-Change-Number: 75072 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/lenovo/t520: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78131?usp=email ) Change subject: mb/lenovo/t520: Move selects from Kconfig.name to Kconfig ...................................................................... mb/lenovo/t520: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I6b71c7c5c9e32e21c757c0ed0e9c6bd9d58a4f75 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78131 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/lenovo/t520/Kconfig M src/mainboard/lenovo/t520/Kconfig.name 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/lenovo/t520/Kconfig b/src/mainboard/lenovo/t520/Kconfig index a5af0db..2223b72 100644 --- a/src/mainboard/lenovo/t520/Kconfig +++ b/src/mainboard/lenovo/t520/Kconfig @@ -25,6 +25,12 @@ # Workaround for EC/KBC IRQ1. select SERIRQ_CONTINUOUS_MODE +config BOARD_LENOVO_T520 + select BOARD_LENOVO_BASEBOARD_T520 + +config BOARD_LENOVO_W520 + select BOARD_LENOVO_BASEBOARD_T520 + if BOARD_LENOVO_BASEBOARD_T520 config VBOOT diff --git a/src/mainboard/lenovo/t520/Kconfig.name b/src/mainboard/lenovo/t520/Kconfig.name index cc622f0..d77afc8 100644 --- a/src/mainboard/lenovo/t520/Kconfig.name +++ b/src/mainboard/lenovo/t520/Kconfig.name @@ -1,7 +1,5 @@ config BOARD_LENOVO_T520 bool "ThinkPad T520" - select BOARD_LENOVO_BASEBOARD_T520 config BOARD_LENOVO_W520 bool "ThinkPad W520" - select BOARD_LENOVO_BASEBOARD_T520 -- To view, visit https://review.coreboot.org/c/coreboot/+/78131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6b71c7c5c9e32e21c757c0ed0e9c6bd9d58a4f75 Gerrit-Change-Number: 78131 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/asus/h61-series: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78130?usp=email ) Change subject: mb/asus/h61-series: Move selects from Kconfig.name to Kconfig ...................................................................... mb/asus/h61-series: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I6a78efa4be2ee34e7dac06a8b8014da12b21fbdc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78130 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/asus/h61-series/Kconfig M src/mainboard/asus/h61-series/Kconfig.name 2 files changed, 48 insertions(+), 38 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/asus/h61-series/Kconfig b/src/mainboard/asus/h61-series/Kconfig index eeec4e7..2f34719 100644 --- a/src/mainboard/asus/h61-series/Kconfig +++ b/src/mainboard/asus/h61-series/Kconfig @@ -12,6 +12,54 @@ select SOUTHBRIDGE_INTEL_BD82X6X select USE_NATIVE_RAMINIT +config BOARD_ASUS_H61M_CS + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_8192 + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select NO_UART_ON_SUPERIO + select SUPERIO_NUVOTON_NCT6779D + +config BOARD_ASUS_P8H61_M_LX + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_4096 + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select SUPERIO_NUVOTON_COMMON_COM_A + select SUPERIO_NUVOTON_NCT6776 + +config BOARD_ASUS_P8H61_M_LX3_R2_0 + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_8192 + select NO_UART_ON_SUPERIO + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select SUPERIO_NUVOTON_NCT6779D + +config BOARD_ASUS_P8H61_M_PRO + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_4096 + select DRIVERS_ASMEDIA_ASPM_BLACKLIST + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select MEMORY_MAPPED_TPM + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select SUPERIO_NUVOTON_NCT6776 + +config BOARD_ASUS_P8H61_M_PRO_CM6630 + select BOARD_ASUS_H61_SERIES + select BOARD_ROMSIZE_KB_4096 + select DRIVERS_ASMEDIA_ASPM_BLACKLIST + select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE + select MEMORY_MAPPED_TPM + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select SUPERIO_NUVOTON_NCT6776 + if BOARD_ASUS_H61_SERIES config MAINBOARD_DIR diff --git a/src/mainboard/asus/h61-series/Kconfig.name b/src/mainboard/asus/h61-series/Kconfig.name index d2175a8..471d268 100644 --- a/src/mainboard/asus/h61-series/Kconfig.name +++ b/src/mainboard/asus/h61-series/Kconfig.name @@ -1,52 +1,14 @@ config BOARD_ASUS_H61M_CS bool "H61M-CS" - select BOARD_ASUS_H61_SERIES - select BOARD_ROMSIZE_KB_8192 - select HAVE_CMOS_DEFAULT - select HAVE_OPTION_TABLE - select NO_UART_ON_SUPERIO - select SUPERIO_NUVOTON_NCT6779D config BOARD_ASUS_P8H61_M_LX bool "P8H61-M LX" - select BOARD_ASUS_H61_SERIES - select BOARD_ROMSIZE_KB_4096 - select HAVE_CMOS_DEFAULT - select HAVE_OPTION_TABLE - select REALTEK_8168_RESET - select RT8168_SET_LED_MODE - select SUPERIO_NUVOTON_COMMON_COM_A - select SUPERIO_NUVOTON_NCT6776 config BOARD_ASUS_P8H61_M_LX3_R2_0 bool "P8H61-M LX3 R2.0" - select BOARD_ASUS_H61_SERIES - select BOARD_ROMSIZE_KB_8192 - select NO_UART_ON_SUPERIO - select REALTEK_8168_RESET - select RT8168_SET_LED_MODE - select SUPERIO_NUVOTON_NCT6779D config BOARD_ASUS_P8H61_M_PRO bool "P8H61-M PRO" - select BOARD_ASUS_H61_SERIES - select BOARD_ROMSIZE_KB_4096 - select DRIVERS_ASMEDIA_ASPM_BLACKLIST - select HAVE_CMOS_DEFAULT - select HAVE_OPTION_TABLE - select MEMORY_MAPPED_TPM - select REALTEK_8168_RESET - select RT8168_SET_LED_MODE - select SUPERIO_NUVOTON_NCT6776 config BOARD_ASUS_P8H61_M_PRO_CM6630 bool "P8H61-M PRO CM6630" - select BOARD_ASUS_H61_SERIES - select BOARD_ROMSIZE_KB_4096 - select DRIVERS_ASMEDIA_ASPM_BLACKLIST - select HAVE_CMOS_DEFAULT - select HAVE_OPTION_TABLE - select MEMORY_MAPPED_TPM - select REALTEK_8168_RESET - select RT8168_SET_LED_MODE - select SUPERIO_NUVOTON_NCT6776 -- To view, visit https://review.coreboot.org/c/coreboot/+/78130?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a78efa4be2ee34e7dac06a8b8014da12b21fbdc Gerrit-Change-Number: 78130 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78129?usp=email ) Change subject: mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig ...................................................................... mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I817faab0438a35d2e8859342e7c2b2dbaa0afeeb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78129 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/intel/glkrvp/Kconfig M src/mainboard/intel/glkrvp/Kconfig.name 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index c2584f3..5a1ae43 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -13,6 +13,10 @@ select DRIVERS_I2C_DA7219 select SOC_ESPI +config BOARD_INTEL_GLKRVP + select BOARD_INTEL_BASEBOARD_GLKRVP + select BASEBOARD_GLKRVP_LAPTOP + if BOARD_INTEL_BASEBOARD_GLKRVP config BASEBOARD_GLKRVP_LAPTOP diff --git a/src/mainboard/intel/glkrvp/Kconfig.name b/src/mainboard/intel/glkrvp/Kconfig.name index b0cfdc5..0502c4c 100644 --- a/src/mainboard/intel/glkrvp/Kconfig.name +++ b/src/mainboard/intel/glkrvp/Kconfig.name @@ -1,4 +1,2 @@ config BOARD_INTEL_GLKRVP bool "Glkrvp" - select BOARD_INTEL_BASEBOARD_GLKRVP - select BASEBOARD_GLKRVP_LAPTOP -- To view, visit https://review.coreboot.org/c/coreboot/+/78129?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I817faab0438a35d2e8859342e7c2b2dbaa0afeeb Gerrit-Change-Number: 78129 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/gigabyte/ga-h61m-series: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78128?usp=email ) Change subject: mb/gigabyte/ga-h61m-series: Move selects from Kconfig.name to Kconfig ...................................................................... mb/gigabyte/ga-h61m-series: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: Iec0829ba80d3d4b4bc79e14a97d085930c4c5202 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78128 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/gigabyte/ga-h61m-series/Kconfig M src/mainboard/gigabyte/ga-h61m-series/Kconfig.name 2 files changed, 14 insertions(+), 6 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/src/mainboard/gigabyte/ga-h61m-series/Kconfig b/src/mainboard/gigabyte/ga-h61m-series/Kconfig index 8f4366b..77bd800 100644 --- a/src/mainboard/gigabyte/ga-h61m-series/Kconfig +++ b/src/mainboard/gigabyte/ga-h61m-series/Kconfig @@ -16,6 +16,20 @@ select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT +config BOARD_GIGABYTE_GA_H61M_S2PV + select BOARD_GIGABYTE_GA_H61M_SERIES + +config BOARD_GIGABYTE_GA_H61M_DS2 + select BOARD_GIGABYTE_GA_H61M_SERIES + +config BOARD_GIGABYTE_GA_H61M_DS2V + select BOARD_GIGABYTE_GA_H61M_SERIES + select NO_UART_ON_SUPERIO + +config BOARD_GIGABYTE_GA_H61MA_D3V + select BOARD_GIGABYTE_GA_H61M_SERIES + select NO_UART_ON_SUPERIO + if BOARD_GIGABYTE_GA_H61M_SERIES config MAINBOARD_DIR diff --git a/src/mainboard/gigabyte/ga-h61m-series/Kconfig.name b/src/mainboard/gigabyte/ga-h61m-series/Kconfig.name index f584a28..f70b824 100644 --- a/src/mainboard/gigabyte/ga-h61m-series/Kconfig.name +++ b/src/mainboard/gigabyte/ga-h61m-series/Kconfig.name @@ -1,17 +1,11 @@ config BOARD_GIGABYTE_GA_H61M_S2PV bool "GA-H61M-S2PV" - select BOARD_GIGABYTE_GA_H61M_SERIES config BOARD_GIGABYTE_GA_H61M_DS2 bool "GA-H61M-DS2" - select BOARD_GIGABYTE_GA_H61M_SERIES config BOARD_GIGABYTE_GA_H61M_DS2V bool "GA-H61M-DS2V" - select BOARD_GIGABYTE_GA_H61M_SERIES - select NO_UART_ON_SUPERIO config BOARD_GIGABYTE_GA_H61MA_D3V bool "GA-H61MA-D3V" - select BOARD_GIGABYTE_GA_H61M_SERIES - select NO_UART_ON_SUPERIO -- To view, visit https://review.coreboot.org/c/coreboot/+/78128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec0829ba80d3d4b4bc79e14a97d085930c4c5202 Gerrit-Change-Number: 78128 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 03 Oct '23

03 Oct '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78132?usp=email ) Change subject: mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig ...................................................................... mb/intel/mtlrvp: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: If6b666478e15a8e843b50b60be490593349240bd Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78132 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin L Roth <gaumless(a)gmail.com> --- M src/mainboard/intel/mtlrvp/Kconfig M src/mainboard/intel/mtlrvp/Kconfig.name 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Martin L Roth: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 8a59085..f225aa5 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -26,10 +26,12 @@ config BOARD_INTEL_MTLRVP_P_EXT_EC select BOARD_EXT_EC_SPECIFIC_OPTIONS + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_INTEL_MTLRVP_P_MCHP select BOARD_EXT_EC_SPECIFIC_OPTIONS select EC_GOOGLE_CHROMEEC_MEC + select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_EXT_EC_SPECIFIC_OPTIONS def_bool n diff --git a/src/mainboard/intel/mtlrvp/Kconfig.name b/src/mainboard/intel/mtlrvp/Kconfig.name index afba1ef..9f61aff 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig.name +++ b/src/mainboard/intel/mtlrvp/Kconfig.name @@ -3,8 +3,6 @@ config BOARD_INTEL_MTLRVP_P_EXT_EC bool "Meteorlake-P RVP with Chrome EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON config BOARD_INTEL_MTLRVP_P_MCHP bool "Meteorlake-P RVP with Microchip EC" - select SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON -- To view, visit https://review.coreboot.org/c/coreboot/+/78132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6b666478e15a8e843b50b60be490593349240bd Gerrit-Change-Number: 78132 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/rex: Configure ISH UART TX/RX as NC
by Subrata Banik (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Bernardo Perez Priego, Cliff Huang, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Li1 Feng, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78049?usp=email ) Change subject: mb/google/rex: Configure ISH UART TX/RX as NC ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78049?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8aba45420744a3990e1f9637c3b31ea2e0f78f87 Gerrit-Change-Number: 78049 Gerrit-PatchSet: 4 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 16:56:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex: Configure ISH UART TX/RX as NC
by Tanu Malhotra (Code Review) 03 Oct '23

03 Oct '23

Attention is currently required from: Bernardo Perez Priego, Cliff Huang, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Li1 Feng, Subrata Banik, Tarun. Tanu Malhotra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78049?usp=email ) Change subject: mb/google/rex: Configure ISH UART TX/RX as NC ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78049?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8aba45420744a3990e1f9637c3b31ea2e0f78f87 Gerrit-Change-Number: 78049 Gerrit-PatchSet: 4 Gerrit-Owner: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 03 Oct 2023 16:53:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023