coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5227 discussions

Change in coreboot[master]: soc/intel/elkhartlake: Hook up FSP hyper-threading setting to option API
by Nico Huber (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Felix Singer, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60546 ) Change subject: soc/intel/elkhartlake: Hook up FSP hyper-threading setting to option API ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: Tested? Does it even support HT? -- To view, visit https://review.coreboot.org/c/coreboot/+/60546 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5aa783b7a17676e12f3bb49f7cf2ac2cb0bb07c Gerrit-Change-Number: 60546 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sat, 30 Apr 2022 13:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cannonlake: Hook up FSP hyper-threading setting to option API
by Nico Huber (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Felix Singer, Sean Rhodes, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60544 ) Change subject: soc/intel/cannonlake: Hook up FSP hyper-threading setting to option API ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60544 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I173b87da5ce76549672c50ba30204cd77be8b82f Gerrit-Change-Number: 60544 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sat, 30 Apr 2022 13:01:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Move FSP_HYPERTHREADING to common Intel Kconfig
by Nico Huber (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Felix Singer, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60543 ) Change subject: soc/intel/skylake: Move FSP_HYPERTHREADING to common Intel Kconfig ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/soc/intel/common/block/cpu/Kconfig: https://review.coreboot.org/c/coreboot/+/60543/comment/6e7061d6_e9a54893 PS2, Line 141: bool "Enable Hyper-Threading" The prompt, or the whole config, should be opt in unless you plan to make it useful for all platforms that include this file (I don't think all platforms support HT, so this would probably be futile). -- To view, visit https://review.coreboot.org/c/coreboot/+/60543 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I892d48b488cbf828057f0e9be9edc4352c58bbe7 Gerrit-Change-Number: 60543 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sat, 30 Apr 2022 12:59:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/skylake: Hook up FSP hyper-threading setting to option API
by Nico Huber (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Felix Singer, Michael Niewöhner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60542 ) Change subject: soc/intel/skylake: Hook up FSP hyper-threading setting to option API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/60542/comment/eefd098b_e8ce5487 PS2, Line 15: obsolete now. This board takes config FSP_HYPERTHREADING into account now. That's ok, but the change in behavior should be mentioned. -- To view, visit https://review.coreboot.org/c/coreboot/+/60542 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1023d1b94acb63f30455c56b394b68059deaaa16 Gerrit-Change-Number: 60542 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Sat, 30 Apr 2022 12:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: lenovo/x230: introduce FHD variant
by Nico Huber (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Felix Singer, Xue Yao, Paul Menzel, Kilian Neuner, Angel Pons, Charles Moyes, Alexander Couzens. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 ) Change subject: lenovo/x230: introduce FHD variant ...................................................................... Patch Set 22: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/28950/comment/60345aca_7e50b5dc PS22, Line 14: uses the same method of enabling the custom eDP panel. If there was a single way a mod could do it or if this change would document what mod in what configuration was tested, it would have been merged years ago, AFAICT. https://review.coreboot.org/c/coreboot/+/28950/comment/e1ea45b2_f107ec21 PS22, Line 18: brightness controls to work out of the box. This seems misleading. Yes, it "allows" things to work OOB. But it doesn't always work OOB. The nitrocaster mod in its default confi- guration, for instance, is designed to work without firmware modi- fications and doesn't work well if the firmware is adapted, AIUI. https://review.coreboot.org/c/coreboot/+/28950/comment/2bbe726e_4a0ebd7c PS22, Line 24: - Set the DP-3 as internally connected. This part is missing in the libgfxinit configuration. File src/mainboard/lenovo/x230/Kconfig: https://review.coreboot.org/c/coreboot/+/28950/comment/adca0244_3401b880 PS19, Line 26: select GFX_GMA_PANEL_1_ON_EDP if BOARD_LENOVO_X230_EDP > Done `_EDP` here means the dedicated eDP port. I assume this needs a `DP3` default for `config GFX_GMA_PANEL_1_PORT`. File src/mainboard/lenovo/x230/Kconfig.name: https://review.coreboot.org/c/coreboot/+/28950/comment/fe1c3f04_a84348d5 PS22, Line 11: bool "ThinkPad X230 eDP Mod (2K/FHD)" Please add a help text about tested mods and their configuration. -- To view, visit https://review.coreboot.org/c/coreboot/+/28950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0 Gerrit-Change-Number: 28950 Gerrit-PatchSet: 22 Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kilian Neuner <cb(a)9-r.net> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com> Gerrit-Reviewer: Richard Slindee Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aleksei Kharlamov <derlafff(a)ya.ru> Gerrit-CC: Charles Moyes <thechuckster(a)gmail.com> Gerrit-CC: Christian Herzog Gerrit-CC: Holger Levsen <holger(a)layer-acht.org> Gerrit-CC: MartiniMoe Gerrit-CC: Matthias Wiedhalm Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Pavel Kovalenko <su(a)nitrocaster.me> Gerrit-CC: Sergey Alirzaev <zl29ah(a)gmail.com> Gerrit-CC: Stanislaw Kaminski <stanislaw.kaminski(a)gmail.com> Gerrit-CC: Tom Hiller <thrilleratplay(a)gmail.com> Gerrit-CC: Tomasz Jan Góralczyk Gerrit-CC: Xue Yao <xueyao(a)xyte.ch> Gerrit-CC: clayton craft Gerrit-CC: nullmark <nullmark(a)googlemail.com> Gerrit-CC: slact Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Xue Yao <xueyao(a)xyte.ch> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kilian Neuner <cb(a)9-r.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Charles Moyes <thechuckster(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 30 Apr 2022 12:43:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: treewide/azalia: Fix 16-bit read and use common functions
by Paul Menzel (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph, Elyes Haouas. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61845 ) Change subject: treewide/azalia: Fix 16-bit read and use common functions ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/61845/comment/6c32b091_d3aab011 PS9, Line 9: Correct the codec mask and read only 16 bits. : Use common codec_detect() and azalia_audio_init(). Please either format as a list, or do not wrap the line, just because the sentence ends. https://review.coreboot.org/c/coreboot/+/61845/comment/08296994_787e81a8 PS9, Line 11: Tested how? -- To view, visit https://review.coreboot.org/c/coreboot/+/61845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I530aa21d5a26ade0bc071351ac609c84bd8eb2cb Gerrit-Change-Number: 61845 Gerrit-PatchSet: 9 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 30 Apr 2022 11:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION
by Paul Menzel (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Hung-Te Lin, Julius Werner, Yu-Ping Wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63925 ) Change subject: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf5900df605899af699b25266e87b5d557c4e830 Gerrit-Change-Number: 63925 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 30 Apr 2022 11:07:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION
by Yu-Ping Wu (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63925 ) Change subject: cbfstool: MediaTek: Hash bootblock.bin for CBFS_VERIFICATION ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63925/comment/2a391c6a_335eda0c PS3, Line 7: cbfstool: Add MediaTek fixup > Maybe more specific: […] Done https://review.coreboot.org/c/coreboot/+/63925/comment/7a3dfd5e_2850aeac PS3, Line 9: bootROM > Is that the official spelling? According to https://en.wikipedia.org/wiki/Boot_ROM both "boot ROM" or "bootROM" are valid. File util/cbfstool/platform_fixups.c: https://review.coreboot.org/c/coreboot/+/63925/comment/8947979a_8b79204f PS3, Line 151: ERROR("fixups: MediaTek data size too small: %zu\n", data_size); > Add a colon after MediaTek, so it doesn’t read as a sentence? Done https://review.coreboot.org/c/coreboot/+/63925/comment/a91b33fa_8ed65fde PS3, Line 173: int > bool? Oops. -- To view, visit https://review.coreboot.org/c/coreboot/+/63925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf5900df605899af699b25266e87b5d557c4e830 Gerrit-Change-Number: 63925 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 30 Apr 2022 09:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Enlarge CBFS_MCACHE to 16K
by Yu-Ping Wu (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63924 ) Change subject: soc/mediatek/mt8186: Enlarge CBFS_MCACHE to 16K ...................................................................... Patch Set 3: (3 comments) File src/soc/mediatek/mt8186/include/soc/memlayout.ld: https://review.coreboot.org/c/coreboot/+/63924/comment/40a868ae_a9e29482 PS2, Line 25: TTB(0x00100000, 28K) : DMA_COHERENT(0x00107000, 4K) : TPM_TCPA_LOG(0x00108000, 2K) : FMAP_CACHE(0x00108800, 2K) : WATCHDOG_TOMBSTONE(0x00109000, 4) : CBFS_MCACHE(0x00109004, 16K - 4) : /* EMPTY(0x0010d000, 4K) */ : STACK(0x0010E000, 7K) : TIMESTAMP(0x0010FC00, 1K) : /* MT8186 has 64KB SRAM. */ Done, with slight adjustment. > STACK 7k-4 From my experiments, the STACK size needs to be a multiple of 16. Neither `7K-4` nor `7K-8` work: the last log was `Jump to BL`, which means that the device got stuck somewhere in bootblock before `console_init()`. The device can boot with `7K-16` though. ARM64's memlayout.h only requires the address to be 16-byte aligned. I'm not sure if we should also add an extra assertion for the size. https://review.coreboot.org/c/coreboot/+/63924/comment/da136ef5_33562588 PS2, Line 44: /* 4K reserved for BOOTROM until BOOTBLOCK is started */ > Correction. […] Done https://review.coreboot.org/c/coreboot/+/63924/comment/7e5dbe11_6a2d2084 PS2, Line 50: 184K > aarch64-cros-linux-gnu-objdump -x dram.elf | grep memsz […] Yes, I've mentioned that in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/63924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e07eb9fae1644a0fbfbdc599ca0a0e11bbe54b5 Gerrit-Change-Number: 63924 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 30 Apr 2022 09:39:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Enlarge CBFS_MCACHE to 16K
by Yu-Ping Wu (Code Review) 30 Apr '22

30 Apr '22

Attention is currently required from: Julius Werner, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63924 to look at the new patch set (#3). Change subject: soc/mediatek/mt8186: Enlarge CBFS_MCACHE to 16K ...................................................................... soc/mediatek/mt8186: Enlarge CBFS_MCACHE to 16K The per-file hash for CBFS_VERIFICATION, stored as a CBFS file attribute, would increase the total RO metadata size by 75% (3796->6656 for corsola). Therefore, in order to make RO metadata cache fit into CBFS_MCACHE, enlarge it from 8K to 16K. Adjust the memlayout by decreasing the DRAM_INIT_CODE from 196K to 184K (only 160K needed for now), and moving VBOOT2_WORK region to L2C. Also shuffle the regions in SRAM with better comments. BUG=b:229670703 TEST=emerge-corsola coreboot TEST=Enabled CBFS_VERIFICATION and booted kingler into kernel BRANCH=none Change-Id: I8e07eb9fae1644a0fbfbdc599ca0a0e11bbe54b5 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8186/include/soc/memlayout.ld 1 file changed, 22 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/63924/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63924 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e07eb9fae1644a0fbfbdc599ca0a0e11bbe54b5 Gerrit-Change-Number: 63924 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

← Newer
1
2
3
4
5
6
7
...
523
Older →

Jump to page:

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022