coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: soc/intel/xeon_sp: Remove the allocator workaround
by Christian Walter (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Patrick Rudolph, Tim Chu. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62353 ) Change subject: soc/intel/xeon_sp: Remove the allocator workaround ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/xeon_sp/skx/chip.c: https://review.coreboot.org/c/coreboot/+/62353/comment/6eefad97_83c8d579 PS8, Line 34: #if CONFIG(HAVE_ACPI_TABLES) : .write_acpi_tables = &northbridge_write_acpi_tables, : #if CONFIG(HAVE_ACPI_TABLES) : .acpi_name = soc_acpi_name : #endif : #endif > lol... Better be safe than sorry? -- To view, visit https://review.coreboot.org/c/coreboot/+/62353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedca35cca8350eb53b5be04c42474d2b4c9d347f Gerrit-Change-Number: 62353 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 14:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/xeon_sp: Remove the allocator workaround
by Arthur Heymans (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Christian Walter, Patrick Rudolph, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62353 ) Change subject: soc/intel/xeon_sp: Remove the allocator workaround ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/xeon_sp/skx/chip.c: https://review.coreboot.org/c/coreboot/+/62353/comment/5cf7b2cf_d0abd87a PS8, Line 34: #if CONFIG(HAVE_ACPI_TABLES) : .write_acpi_tables = &northbridge_write_acpi_tables, : #if CONFIG(HAVE_ACPI_TABLES) : .acpi_name = soc_acpi_name : #endif : #endif lol... -- To view, visit https://review.coreboot.org/c/coreboot/+/62353 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedca35cca8350eb53b5be04c42474d2b4c9d347f Gerrit-Change-Number: 62353 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 14:20:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: update overridetree
by Felix Held (Code Review) 21 Apr '22

21 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63080 ) Change subject: mb/google/brask/variants/moli: update overridetree ...................................................................... mb/google/brask/variants/moli: update overridetree Add FW_CONFIG STORAGE and probe for UNKNOWN, NVME and eMMC. BUG=b:220039297 TEST=emerge-brask coreboot. Signed-off-by: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Change-Id: If83031edcd90ea746704590765102b9b0dee03c1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63080 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-by: Zhuohao Lee <zhuohao(a)google.com> --- M src/mainboard/google/brya/variants/moli/overridetree.cb 1 file changed, 23 insertions(+), 11 deletions(-) Approvals: build bot (Jenkins): Verified Zhuohao Lee: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/moli/overridetree.cb b/src/mainboard/google/brya/variants/moli/overridetree.cb index eb13b06..2048b61 100644 --- a/src/mainboard/google/brya/variants/moli/overridetree.cb +++ b/src/mainboard/google/brya/variants/moli/overridetree.cb @@ -4,6 +4,11 @@ option OPT_HDMI 1 option OPT_DP 2 end + field STORAGE 4 5 + option STORAGE_UNKNOWN 0 + option STORAGE_NVME 1 + option STORAGE_EMMC 2 + end end chip soc/intel/alderlake # Enable HDMI2 in PortA, HDMI1 in PortB, HDMI/DP in Port2 @@ -12,10 +17,10 @@ [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" - register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2_Type-A Port A2 - register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC2)" # USB2_Type-A Port A3 - register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Disable USB2_Type-A Port A9 - register "tcss_ports[2]" = "TCSS_PORT_EMPTY" # Disable TCP3 + register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2 Port2 + register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC2)" # USB2 Port3 + register "usb2_ports[8]" = "USB2_PORT_EMPTY" # Disable USB2 Port9 + register "tcss_ports[2]" = "TCSS_PORT_EMPTY" # Disable TCP3 register "cnvi_bt_audio_offload" = "true" device domain 0 on device ref tcss_dma0 on @@ -32,7 +37,9 @@ .clk_src = 0, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" - end # SSD gen4 + probe STORAGE STORAGE_NVME + probe STORAGE STORAGE_UNKNOWN + end # SSD device ref cnvi_wifi on chip drivers/wifi/generic register "wake" = "GPE0_PME_B0" @@ -91,10 +98,10 @@ register "srcclk_pin" = "3" device generic 0 on end end - end # PCIE8 SD card - device ref pcie_rp9 off end #pcie_rp 9 Empty - device ref pcie_rp10 off end #pcie_rp 10 Empty - device ref pcie_rp11 off end #pcie_rp 11 Empty + end # SD card + device ref pcie_rp9 off end #pcie_rp 9 Empty + device ref pcie_rp10 off end #pcie_rp 10 Empty + device ref pcie_rp11 off end #pcie_rp 11 Empty device ref pcie_rp12 on chip soc/intel/common/block/pcie/rtd3 register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E20)" @@ -102,14 +109,19 @@ register "srcclk_pin" = "1" register "reset_delay_ms" = "50" register "enable_delay_ms" = "20" - device generic 0 alias emmc_rtd3 on end + device generic 0 alias emmc_rtd3 on + probe STORAGE STORAGE_EMMC + probe STORAGE STORAGE_UNKNOWN + end end # Enable PCIe-to-eMMC bridge PCIE 12 using clk 1 register "pch_pcie_rp[PCH_RP(12)]" = "{ .clk_src = 1, .clk_req = 1, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" - end # PCIE12 BH799BB + probe STORAGE STORAGE_EMMC + probe STORAGE STORAGE_UNKNOWN + end # BH799BB device ref pch_espi on chip ec/google/chromeec use conn0 as mux_conn[0] -- To view, visit https://review.coreboot.org/c/coreboot/+/63080 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If83031edcd90ea746704590765102b9b0dee03c1 Gerrit-Change-Number: 63080 Gerrit-PatchSet: 23 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Lean Sheng Tan (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Angel Pons, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 ) Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... Patch Set 3: (1 comment) File src/soc/intel/elkhartlake/finalize.c: https://review.coreboot.org/c/coreboot/+/63762/comment/4eb12788_ab0a7faa PS2, Line 57: heci_finalize(); > missing a tab Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 3 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 13:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Lean Sheng Tan (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh. Hello Subrata Banik, Mario Scheithauer, Angel Pons, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63762 to look at the new patch set (#3). Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... soc/intel/elkhartlake: Skip FSP Notify APIs Follow this CL(60406) of ADL to skip FSP Notify APIs. Elkhart Lake SoC deselects Kconfigs as below: - USE_FSP_NOTIFY_PHASE_READY_TO_BOOT - USE_FSP_NOTIFY_PHASE_END_OF_FIRMWARE to skip FSP notify APIs (Ready to boot and End of Firmware) and make use of native coreboot driver to perform SoC recommended operations prior booting to payload/OS. Additionally, created a helper function `heci_finalize()` to keep HECI related operations separated for easy guarding again config. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 --- M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/elkhartlake/finalize.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/63762/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 3 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Angel Pons (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 ) Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/elkhartlake/finalize.c: https://review.coreboot.org/c/coreboot/+/63762/comment/47b7b10f_e947a095 PS2, Line 57: heci_finalize(); missing a tab -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 13:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Subrata Banik (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Angel Pons, Lean Sheng Tan, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 ) Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Yes already asked Werner to help to test out, pending is result. Very Nice -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 13:48:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Lean Sheng Tan (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Subrata Banik, Mario Scheithauer, Angel Pons, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 ) Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Wondering if you have tested after dropping those FSP APIs ? Yes already asked Werner to help to test out, pending is result. -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 13:47:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Lean Sheng Tan (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Angel Pons, Lean Sheng Tan, Werner Zeh. Hello Subrata Banik, Mario Scheithauer, Angel Pons, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63762 to look at the new patch set (#2). Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... soc/intel/elkhartlake: Skip FSP Notify APIs Follow this CL(60406) of ADL to skip FSP Notify APIs. Elkhart Lake SoC deselects Kconfigs as below: - USE_FSP_NOTIFY_PHASE_READY_TO_BOOT - USE_FSP_NOTIFY_PHASE_END_OF_FIRMWARE to skip FSP notify APIs (Ready to boot and End of Firmware) and make use of native coreboot driver to perform SoC recommended operations prior booting to payload/OS. Additionally, created a helper function `heci_finalize()` to keep HECI related operations separated for easy guarding again config. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 --- M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/elkhartlake/finalize.c 2 files changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/63762/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/elkhartlake: Skip FSP Notify APIs
by Subrata Banik (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Mario Scheithauer, Angel Pons, Lean Sheng Tan, Werner Zeh. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63762 ) Change subject: soc/intel/elkhartlake: Skip FSP Notify APIs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Wondering if you have tested after dropping those FSP APIs ? -- To view, visit https://review.coreboot.org/c/coreboot/+/63762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I477c204233f83bc96fd5cd39346bff15ed942dc6 Gerrit-Change-Number: 63762 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 13:43:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022