coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: Documentation: Rename infrastructure section
by Thomas Heijligen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62441 ) Change subject: Documentation: Rename infrastructure section ...................................................................... Patch Set 12: Code-Review+1 (1 comment) File Documentation/infrastructure/index.md: https://review.coreboot.org/c/coreboot/+/62441/comment/c8d7955a_86aa5b17 PS12, Line 3: This section contains documentation about our infrastructure What's about services here? -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 09 Mar 2022 16:02:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Add support for PCI MMIO CONFIG access.
by build bot (Jenkins) (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Ravi kumar, Furquan Shaikh, Arthur Heymans, Prasad Malisetty. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 ) Change subject: libpayload: Add support for PCI MMIO CONFIG access. ...................................................................... Patch Set 33: Verified-1 (2 comments) File payloads/libpayload/drivers/qc_pci_mmio_ops.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143619): https://review.coreboot.org/c/coreboot/+/57615/comment/c1e3f15b_0a9d9784 PS33, Line 107: cfg_address = (void*) pci_mmio_info->config_base; "(foo*)" should be "(foo *)" File payloads/libpayload/include/qc_pci.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143619): https://review.coreboot.org/c/coreboot/+/57615/comment/9d42e225_8950ee67 PS33, Line 70: #endif trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/57615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c Gerrit-Change-Number: 57615 Gerrit-PatchSet: 33 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 15:59:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Thomas Heijligen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62424 ) Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 09 Mar 2022 15:58:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Use file paths to flashing firmware tutorial
by Thomas Heijligen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62452 ) Change subject: Documentation: Use file paths to flashing firmware tutorial ...................................................................... Patch Set 9: Code-Review+1 (1 comment) File Documentation/mainboard/msi/ms7707/ms7707.md: https://review.coreboot.org/c/coreboot/+/62452/comment/ac4a8382_2669f91e PS5, Line 77: Read more about [flashing methods] > There are other cases in the documentation, which are similar. […] IMO this is ok, since the link is highlighted in the html. -- To view, visit https://review.coreboot.org/c/coreboot/+/62452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Gerrit-Change-Number: 62452 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 15:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: docs/releases: Fix warning "document isn't included in any toctree"
by Felix Singer (Code Review) 09 Mar '22

09 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62584 ) Change subject: docs/releases: Fix warning "document isn't included in any toctree" ...................................................................... docs/releases: Fix warning "document isn't included in any toctree" While running Sphinx, it shows the warning "document isn't included in any toctree" for the documents checklist.md and templates.md. These are not meant to be listed in ToC trees. Thus, mark them as orphaned to exclude them from ToC trees. Change-Id: I1ff8f7c24ac9b3c3a120914c0c72ab73e85c4873 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62584 Reviewed-by: Thomas Heijligen <src(a)posteo.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/releases/checklist.md M Documentation/releases/templates.md 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md index 50d99f6..80f59b7 100644 --- a/Documentation/releases/checklist.md +++ b/Documentation/releases/checklist.md @@ -1,3 +1,7 @@ +```eval_rst +:orphan: +``` + # coreboot Release Process This document describes our release process and all prerequisites to implement diff --git a/Documentation/releases/templates.md b/Documentation/releases/templates.md index 86973eb..adc9d66 100644 --- a/Documentation/releases/templates.md +++ b/Documentation/releases/templates.md @@ -1,3 +1,7 @@ +```eval_rst +:orphan: +``` + # Communication templates related to release management ## Deprecation notices -- To view, visit https://review.coreboot.org/c/coreboot/+/62584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ff8f7c24ac9b3c3a120914c0c72ab73e85c4873 Gerrit-Change-Number: 62584 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: vc/google/chromeos/Kconfig: Fix typo
by Felix Held (Code Review) 09 Mar '22

09 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62661 ) Change subject: vc/google/chromeos/Kconfig: Fix typo ...................................................................... vc/google/chromeos/Kconfig: Fix typo heirarchy ---> hierarchy Change-Id: I5cbd77a156852e6f8ad6eafc316ee33f153635b4 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62661 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/vendorcode/google/chromeos/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Matt DeVillier: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig index 605b09e..780344c 100644 --- a/src/vendorcode/google/chromeos/Kconfig +++ b/src/vendorcode/google/chromeos/Kconfig @@ -46,7 +46,7 @@ default y depends on TPM2 && RESUME_PATH_SAME_AS_BOOT help - Disable the platform heirarchy on resume path if the firmware + Disable the platform hierarchy on resume path if the firmware is involved in resume. The hierarchy is disabled prior to jumping to the OS. Note that this option is sepcific to TPM2 boards. This option is auto selected if CHROMEOS because it matches with -- To view, visit https://review.coreboot.org/c/coreboot/+/62661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cbd77a156852e6f8ad6eafc316ee33f153635b4 Gerrit-Change-Number: 62661 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: HACK trogdor: optimize coreboot.rom for T32 flash script HACK
by Ravi kumar (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, Yu-Ping Wu. Ravi kumar has uploaded a new patch set (#249) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/36278 ) Change subject: HACK trogdor: optimize coreboot.rom for T32 flash script HACK ...................................................................... HACK trogdor: optimize coreboot.rom for T32 flash script HACK Change-Id: I5293ac9365bf4ac74bc475e70a02062f5371f9b8 Signed-off-by: T Michael Turney <mturney(a)codeaurora.org> --- M src/security/vboot/Makefile.inc A util/qualcomm/optimize_coreboot 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/36278/249 -- To view, visit https://review.coreboot.org/c/coreboot/+/36278 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5293ac9365bf4ac74bc475e70a02062f5371f9b8 Gerrit-Change-Number: 36278 Gerrit-PatchSet: 249 Gerrit-Owner: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: qualcomm/sc7280: Add mdp clock support to turbo in coreboot
by Ravi kumar (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Ravi kumar, Taniya Das. Hello build bot (Jenkins), Taniya Das, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62371 to look at the new patch set (#5). Change subject: qualcomm/sc7280: Add mdp clock support to turbo in coreboot ...................................................................... qualcomm/sc7280: Add mdp clock support to turbo in coreboot This change supports the configuration and enablement of mdp clock to vote for turbo and supports different display panel resolutions and framerates. BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board. Signed-off-by: Taniya Das <quic_tdas(a)quicinc.com> Change-Id: Ibf4f11d02b0edf83461dbb7af99fda5f33cd5b71 --- M src/soc/qualcomm/sc7280/clock.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/62371/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62371 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf4f11d02b0edf83461dbb7af99fda5f33cd5b71 Gerrit-Change-Number: 62371 Gerrit-PatchSet: 5 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: qualcomm/sc7280: Add display external clock support in coreboot
by Ravi kumar (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Ravi kumar, Sudheer Amrabadi. Hello Shelley Chen, build bot (Jenkins), Taniya Das, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59611 to look at the new patch set (#23). Change subject: qualcomm/sc7280: Add display external clock support in coreboot ...................................................................... qualcomm/sc7280: Add display external clock support in coreboot Add support for EDP (Embedded DisplayPort) clocks in coreboot. This change supports the configuration and enablement of EDP PIXEL, LINK, LINK_INTF and AUX clocks. BUG=b:182963902,b:216687885 TEST=Validated on qualcomm sc7280 development board. Signed-off-by: Taniya Das <quic_tdas(a)quicinc.com> Change-Id: Ia6872ede515401e95ea2dadc9766e3e70fb66144 --- M src/soc/qualcomm/sc7280/clock.c M src/soc/qualcomm/sc7280/include/soc/clock.h 2 files changed, 53 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/59611/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/59611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6872ede515401e95ea2dadc9766e3e70fb66144 Gerrit-Change-Number: 59611 Gerrit-PatchSet: 23 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Taniya Das <quic_tdas(a)quicinc.com> Gerrit-CC: Taniya Das <tdas(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: docs/releases: Fix warning "document isn't included in any toctree"
by Thomas Heijligen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Felix Singer. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62584 ) Change subject: docs/releases: Fix warning "document isn't included in any toctree" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ff8f7c24ac9b3c3a120914c0c72ab73e85c4873 Gerrit-Change-Number: 62584 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Wed, 09 Mar 2022 15:33:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022