coreboot-gerrit December 2022

coreboot-gerrit@coreboot.org

1 participants
6828 discussions

[M] Change in coreboot[master]: drivers/pc80/vga: Add API to write multi-line video message
by Subrata Banik (Code Review) 31 Dec '22

31 Dec '22

Attention is currently required from: Tarun Tuli, Jeremy Compostella, Kapil Porwal, Angel Pons. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71265 ) Change subject: drivers/pc80/vga: Add API to write multi-line video message ...................................................................... Patch Set 6: (5 comments) File src/drivers/pc80/vga/vga.c: https://review.coreboot.org/c/coreboot/+/71265/comment/470de0be_ff561be7 PS3, Line 303: memcpy(str, string, strlen(string)); > I dont think we should attempt to handle line wrapping and leave it to the creation of the string having the tokens instead. @Kapil, marking this resolve now, we shall revive it later if required. Hope you are good with this. (feel free to open this comment if you think otherwise) File src/drivers/pc80/vga/vga.c: https://review.coreboot.org/c/coreboot/+/71265/comment/9ef60493_3f3e557e PS6, Line 268: VGA_COLUMNS > `VGA_COLUMNS - offset`? Ack File src/include/pc80/vga.h: https://review.coreboot.org/c/coreboot/+/71265/comment/0615fab3_7b0b4f01 PS6, Line 11: #define VGA_TEXT_HORIZONTAL_TOP 0 > are these used anywhere? kind of helper macro where caller of vga_write_text() can pass this macro as argument 1 (for specifying the line as VGA_LINES / 2) to specify the starting offset. https://review.coreboot.org/c/coreboot/+/71265/comment/949b825f_004fbb86 PS6, Line 12: #define VGA_TEXT_HORIZONTAL_MIDDLE (VGA_LINES / 2) > are these used anywhere? same as above. Are you suggesting to drop this and leave it up to the caller of vga_write_text()? https://review.coreboot.org/c/coreboot/+/71265/comment/c76ec754_ce435a61 PS6, Line 33: * vga_write_text() function can print the video message as per give alignment > nit- suggest something like: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71265 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib837e4deeba9b84038a91c93a68f03cee3474f9b Gerrit-Change-Number: 71265 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 31 Dec 2022 08:11:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tarun Tuli <taruntuli(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common: Move SGX supported API to cpulib
by Subrata Banik (Code Review) 31 Dec '22

31 Dec '22

Attention is currently required from: Pratikkumar V Prajapati. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71116 ) Change subject: soc/intel/common: Move SGX supported API to cpulib ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71116 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib630ac451152ae2471c862fced992dde3b49d05d Gerrit-Change-Number: 71116 Gerrit-PatchSet: 6 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 31 Dec 2022 07:54:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common: Untie PRMRR from SGX
by Subrata Banik (Code Review) 31 Dec '22

31 Dec '22

Attention is currently required from: Tarun Tuli, Sridhar Siricilla, Pratikkumar V Prajapati. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70819 ) Change subject: soc/intel/common: Untie PRMRR from SGX ...................................................................... Patch Set 17: Code-Review+1 (1 comment) File src/soc/intel/common/block/cpu/cpulib.c: https://review.coreboot.org/c/coreboot/+/70819/comment/09cf3fd6_65d6eca5 PS17, Line 408: if (CONFIG_SOC_INTEL_COMMON_BLOCK_PRMRR_SIZE == 0) ``` if (!CONFIG_SOC_INTEL_COMMON_BLOCK_PRMRR_SIZE) return 0; ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/70819 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd49a87be0293530705802fd9b830201a5863c2 Gerrit-Change-Number: 70819 Gerrit-PatchSet: 17 Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Will Kim <norwayforest92(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Sat, 31 Dec 2022 07:54:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: intel/ironlake: Specify supported memory type
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71584 ) Change subject: intel/ironlake: Specify supported memory type ...................................................................... intel/ironlake: Specify supported memory type Change-Id: Ib1bf132f248d1f3c42d32f884f09687964a0c6f2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/ironlake/Kconfig 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/71584/1 diff --git a/src/northbridge/intel/ironlake/Kconfig b/src/northbridge/intel/ironlake/Kconfig index a614058..044adfc 100644 --- a/src/northbridge/intel/ironlake/Kconfig +++ b/src/northbridge/intel/ironlake/Kconfig @@ -2,14 +2,22 @@ config NORTHBRIDGE_INTEL_IRONLAKE bool + +if NORTHBRIDGE_INTEL_IRONLAKE + +config NORTHBRIDGE_SPECIFIC_OPTIONS + def_bool y select CPU_INTEL_MODEL_2065X select VGA select INTEL_EDID select INTEL_GMA_ACPI select CACHE_MRC_SETTINGS select HAVE_DEBUG_RAM_SETUP - -if NORTHBRIDGE_INTEL_IRONLAKE + select NO_DDR5 + select NO_LPDDR4 + select NO_DDR4 + select NO_DDR2 + select USE_DDR3 config VBOOT select VBOOT_MUST_REQUEST_DISPLAY -- To view, visit https://review.coreboot.org/c/coreboot/+/71584 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib1bf132f248d1f3c42d32f884f09687964a0c6f2 Gerrit-Change-Number: 71584 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: apollolake/include/soc/meminit.h: Add missing stdbool
by Eric Lai (Code Review) 31 Dec '22

31 Dec '22

Attention is currently required from: Sean Rhodes, Elyes Haouas. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71245 ) Change subject: apollolake/include/soc/meminit.h: Add missing stdbool ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71245 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I317faf322a7e73b706724802d99815ab50e655e2 Gerrit-Change-Number: 71245 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sat, 31 Dec 2022 07:14:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/haswell: Specify supported memory type
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Attention is currently required from: Angel Pons. Hello Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71583 to look at the new patch set (#2). Change subject: nb/intel/haswell: Specify supported memory type ...................................................................... nb/intel/haswell: Specify supported memory type Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/haswell/Kconfig 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/71583/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Gerrit-Change-Number: 71583 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: nb/intel/haswell: Specify supported memory type
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/71583 ) Change subject: nb/intel/haswell: Specify supported memory type ...................................................................... nb/intel/haswell: Specify supported memory type Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/northbridge/intel/haswell/Kconfig 1 file changed, 18 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/71583/1 diff --git a/src/northbridge/intel/haswell/Kconfig b/src/northbridge/intel/haswell/Kconfig index b659bf6..cafd115 100644 --- a/src/northbridge/intel/haswell/Kconfig +++ b/src/northbridge/intel/haswell/Kconfig @@ -2,12 +2,18 @@ config NORTHBRIDGE_INTEL_HASWELL bool + +if NORTHBRIDGE_INTEL_HASWELL + +config NORTHBRIDGE_SPECIFIC_OPTIONS + def_bool y select CPU_INTEL_HASWELL select CACHE_MRC_SETTINGS select INTEL_DDI select INTEL_GMA_ACPI - -if NORTHBRIDGE_INTEL_HASWELL + select NO_DDR5 + select NO_LPDDR4 + select NO_DDR2 config USE_NATIVE_RAMINIT bool "[NOT WORKING] Use native raminit" -- To view, visit https://review.coreboot.org/c/coreboot/+/71583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I885cc00c8bfcfaaabb2ce2b0269172d8d7a88db5 Gerrit-Change-Number: 71583 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: Makefile.inc: Add 'Wduplicated-branches' command option
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/70250 ) Change subject: Makefile.inc: Add 'Wduplicated-branches' command option ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/70250 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifa16c79f60a5f1506c489d89c94d775c50cc4c80 Gerrit-Change-Number: 70250 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: Makefile.inc: Add 3rdparty/vboot path when vboot is enabled
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/71555 ) Change subject: Makefile.inc: Add 3rdparty/vboot path when vboot is enabled ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/71555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67a81293579bdc103372e080fa34bef366bf00d7 Gerrit-Change-Number: 71555 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[master]: southbridge/amd: Unify smbus.{c,h} and make them common
by Elyes Haouas (Code Review) 31 Dec '22

31 Dec '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61890 ) Change subject: southbridge/amd: Unify smbus.{c,h} and make them common ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/61890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ef8e4168b470435b244844e41ddb7f564bddf65 Gerrit-Change-Number: 61890 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martin.roth(a)tinkermill.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2022