Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/70155 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: soc/intel/common/block/uart: Show ACPI UART in OS
......................................................................
soc/intel/common/block/uart: Show ACPI UART in OS
Do not hide UARTs in ACPI mode from the OS, as this prevents using them
on at least Windows. Currently, the driver is only used on the Prodrive
Hermes mainboard.
Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/70155
Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com>
Reviewed-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/intel/common/block/uart/uart.c
1 file changed, 23 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Arthur Heymans: Looks good to me, but someone else must approve
Patrick Rudolph: Looks good to me, but someone else must approve
Lean Sheng Tan: Looks good to me, approved
diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c
index b881c58..0ca3361 100644
--- a/src/soc/intel/common/block/uart/uart.c
+++ b/src/soc/intel/common/block/uart/uart.c
@@ -253,7 +253,9 @@
acpi_device_write_uid(dev);
acpigen_write_name_string("_DDN", "LPSS ACPI UART");
- acpigen_write_STA(acpi_device_status(dev));
+
+ /* Do not hide the UART device from the OS */
+ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
/* Resources */
acpigen_write_name("_CRS");
--
To view, visit https://review.coreboot.org/c/coreboot/+/70155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01bdccff1b11e1862970c924fd5fc7718a2d6ce9
Gerrit-Change-Number: 70155
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70370 )
Change subject: mb/google/hatch/kohaku: set VBT boot resolution to 1080p
......................................................................
mb/google/hatch/kohaku: set VBT boot resolution to 1080p
Boot menus are too small at native 4K res on some panels, so
set fixed display resolution to 1920x1090p
TEST=build/boot KOHAKU with 4K display, verify boot menu text legible.
Change-Id: I82563c83de7ab302151f60d86b8a6824330d03ea
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/hatch/variants/kohaku/data.vbt
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/70370/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/data.vbt b/src/mainboard/google/hatch/variants/kohaku/data.vbt
index 31fcd1e..fbda413 100644
--- a/src/mainboard/google/hatch/variants/kohaku/data.vbt
+++ b/src/mainboard/google/hatch/variants/kohaku/data.vbt
Binary files differ
--
To view, visit https://review.coreboot.org/c/coreboot/+/70370
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82563c83de7ab302151f60d86b8a6824330d03ea
Gerrit-Change-Number: 70370
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/70369 )
Change subject: device/Kconfig: increase framebuffer max height/width to support 4K
......................................................................
device/Kconfig: increase framebuffer max height/width to support 4K
Increase the default max height/width for linear framebuffer so that
native display resolution works properly on 2160p and 1440p ultrawide
displays.
TEST=build/boot google/fizz, verify libgfxinit display init works
properly on 3440x1440p and 3840x2160p displays.
Change-Id: I95a1f1275a4faea195b73997c648023119807958
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/device/Kconfig
1 file changed, 19 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/70369/1
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 34600ad..d39339c 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -479,7 +479,7 @@
config LINEAR_FRAMEBUFFER_MAX_WIDTH
int "Maximum width in pixels"
depends on LINEAR_FRAMEBUFFER && MAINBOARD_USE_LIBGFXINIT
- default 2560
+ default 3840
help
Set the maximum width of the framebuffer. This may help with
default fonts too tiny for high-resolution displays.
@@ -487,7 +487,7 @@
config LINEAR_FRAMEBUFFER_MAX_HEIGHT
int "Maximum height in pixels"
depends on LINEAR_FRAMEBUFFER && MAINBOARD_USE_LIBGFXINIT
- default 1600
+ default 2160
help
Set the maximum height of the framebuffer. This may help with
default fonts too tiny for high-resolution displays.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a1f1275a4faea195b73997c648023119807958
Gerrit-Change-Number: 70369
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jamie Chen, Henry Sun, Derek Huang, Marco Chen, Karthik Ramasubramanian.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70353 )
Change subject: mb/google/octopus/variants/phaser: Implement variant_memory_sku()
......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/octopus/variants/phaser/memory.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165260):
https://review.coreboot.org/c/coreboot/+/70353/comment/581b9f4f_e558af82
PS1, Line 19: if ((int)board_id() < 7) {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165260):
https://review.coreboot.org/c/coreboot/+/70353/comment/0d60b3f1_3ee7838b
PS1, Line 22: else {
else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165260):
https://review.coreboot.org/c/coreboot/+/70353/comment/51080b83_79c6322a
PS1, Line 25: }
adding a line without newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/70353
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2330b7e16a09f8cc76ed96e81a6165afa80a03a4
Gerrit-Change-Number: 70353
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-CC: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 15:54:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61301
to look at the new patch set (#7).
Change subject: mb/system76: Add custom backlight levels for Intel GMA
......................................................................
mb/system76: Add custom backlight levels for Intel GMA
Add custom backlight levels for all models except:
- addw1
- bonw14: Does not use the iGPU
Change-Id: Ibea37f19acca0d718211fc41706019a92a240c70
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
A src/mainboard/system76/cml-u/acpi/backlight.asl
M src/mainboard/system76/cml-u/acpi/mainboard.asl
M src/mainboard/system76/cml-u/dsdt.asl
A src/mainboard/system76/gaze15/acpi/backlight.asl
M src/mainboard/system76/gaze15/acpi/mainboard.asl
M src/mainboard/system76/gaze15/dsdt.asl
A src/mainboard/system76/kbl-u/acpi/backlight.asl
M src/mainboard/system76/kbl-u/acpi/mainboard.asl
A src/mainboard/system76/oryp5/acpi/backlight.asl
M src/mainboard/system76/oryp5/acpi/mainboard.asl
M src/mainboard/system76/oryp5/dsdt.asl
A src/mainboard/system76/oryp6/acpi/backlight.asl
M src/mainboard/system76/oryp6/acpi/mainboard.asl
M src/mainboard/system76/oryp6/dsdt.asl
A src/mainboard/system76/tgl-h/acpi/backlight.asl
M src/mainboard/system76/tgl-h/acpi/mainboard.asl
M src/mainboard/system76/tgl-h/dsdt.asl
A src/mainboard/system76/tgl-u/acpi/backlight.asl
M src/mainboard/system76/tgl-u/acpi/mainboard.asl
M src/mainboard/system76/tgl-u/dsdt.asl
A src/mainboard/system76/whl-u/acpi/backlight.asl
M src/mainboard/system76/whl-u/acpi/mainboard.asl
M src/mainboard/system76/whl-u/dsdt.asl
23 files changed, 288 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/61301/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/61301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibea37f19acca0d718211fc41706019a92a240c70
Gerrit-Change-Number: 61301
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Crawford, Jeremy Soller, Angel Pons.
Hello build bot (Jenkins), Jeremy Soller, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/65384
to look at the new patch set (#22).
Change subject: mb/system76/adl-p: Add Lemur Pro 11 as a variant
......................................................................
mb/system76/adl-p: Add Lemur Pro 11 as a variant
The Lemur Pro 11 (lemp11) is an Alder Lake-U board.
Tested with a custom TianoCore UefiPayloadPkg.
Working:
- PS/2 keyboard, touchpad
- DIMM slot (with NMSO480E82-3200EA00)
- M.2 NVMe SSD (with MZVL2500HCJQ)
- M.2 SATA SSD (with WDS100T2B0B)
- All USB ports
- SD card reader
- Webcam
- WiFi/Bluetooth
- Integrated graphics using Intel GOP driver
- HDMI output
- DisplayPort output over USB-C
- Internal microphone
- Internal speakers
- Combined headset + mic 3.5mm audio
- Booting Pop!_OS Linux 22.04 with kernel 5.18.5
- Internal flashing with flashrom v1.2-703-g76118a7c10ed
Not working:
- On-board RAM: Requires CB:65567
- Detection of devices in TBT slot on boot
- S0ix suspend/resume
Change-Id: Ic930df1ebacc8c7ef14dbb6c67a97eddb918b365
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/lemp11.md
M src/mainboard/system76/adl-p/Kconfig
M src/mainboard/system76/adl-p/Kconfig.name
M src/mainboard/system76/adl-p/Makefile.inc
A src/mainboard/system76/adl-p/spd/samsung-P4AAF165WA-BCWDE.spd.hex
A src/mainboard/system76/adl-p/variants/lemp11/board_info.txt
A src/mainboard/system76/adl-p/variants/lemp11/data.vbt
A src/mainboard/system76/adl-p/variants/lemp11/gpio.c
A src/mainboard/system76/adl-p/variants/lemp11/gpio_early.c
A src/mainboard/system76/adl-p/variants/lemp11/hda_verb.c
A src/mainboard/system76/adl-p/variants/lemp11/overridetree.cb
A src/mainboard/system76/adl-p/variants/lemp11/romstage.c
13 files changed, 592 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/65384/22
--
To view, visit https://review.coreboot.org/c/coreboot/+/65384
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic930df1ebacc8c7ef14dbb6c67a97eddb918b365
Gerrit-Change-Number: 65384
Gerrit-PatchSet: 22
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset