coreboot-gerrit November 2022

coreboot-gerrit@coreboot.org

1 participants
7286 discussions

[S] Change in coreboot[master]: security/intel/stm/StmPlatformResource.c: Fix typo on "threads"
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61123 ) Change subject: security/intel/stm/StmPlatformResource.c: Fix typo on "threads" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/61123 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id57a9c689d5fa35cf1b4df9c37b12dd95cb9ef23 Gerrit-Change-Number: 61123 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: drivers/aspeed/common/ast_mode.c: Drop comparison to 'false'
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61472 ) Change subject: drivers/aspeed/common/ast_mode.c: Drop comparison to 'false' ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/61472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4276089a0673cce5e94d279056b531682e3a8584 Gerrit-Change-Number: 61472 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: cpu/intel/haswell/haswell.h: Include <cpu/intel/smm_reloc.h>
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/61122 ) Change subject: cpu/intel/haswell/haswell.h: Include <cpu/intel/smm_reloc.h> ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/61122 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1fcb779cd876ef6e2bec66b808c57dc4aadd2420 Gerrit-Change-Number: 61122 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[L] Change in coreboot[master]: util/lint: Update const_structs.checkpatch
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60949 ) Change subject: util/lint: Update const_structs.checkpatch ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/60949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61fc1b1f4d36f2fdf86d5cf518d32bb74b7763de Gerrit-Change-Number: 60949 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: soc/intel/common/block/cse/cse_lite.c: Remove repeated "to"
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/60906 ) Change subject: soc/intel/common/block/cse/cse_lite.c: Remove repeated "to" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/60906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I629ce2b8e3d4617d790a6bb95778148798651e9b Gerrit-Change-Number: 60906 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: [test for gcc-12 build] update libgfxinit and libhwbase
by build bot (Jenkins) (Code Review) 09 Nov '22

09 Nov '22

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68128 ) Change subject: [test for gcc-12 build] update libgfxinit and libhwbase ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/68128 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I962b9acd310c596c0b8c312583aefe5dd1f76e49 Gerrit-Change-Number: 68128 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 12:30:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: lib/gnat: Remove unrecognized pragma "Compiler_Unit_Warning"
by build bot (Jenkins) (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Elyes Haouas. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67828 ) Change subject: lib/gnat: Remove unrecognized pragma "Compiler_Unit_Warning" ...................................................................... Patch Set 4: Verified+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/67828 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia55304da1e3b2db1532300c4f1a2dd958f1975c4 Gerrit-Change-Number: 67828 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 09 Nov 2022 12:29:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Update fsp submodule to upstream master
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68653 ) Change subject: Update fsp submodule to upstream master ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68653 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d8984ed79e6b1ce4978a83e180b569493f47a18 Gerrit-Change-Number: 68653 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: Update opensbi submodule to upstream master
by Elyes Haouas (Code Review) 09 Nov '22

09 Nov '22

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/68655 ) Change subject: Update opensbi submodule to upstream master ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/68655 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e90f9f89effa4d1e641723859885d5874f4c7c0 Gerrit-Change-Number: 68655 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: drivers/phy/m88e1512: Provide functionality to customize LED status
by Werner Zeh (Code Review) 09 Nov '22

09 Nov '22

Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69386 ) Change subject: drivers/phy/m88e1512: Provide functionality to customize LED status ...................................................................... Patch Set 3: (4 comments) File src/drivers/phy/m88e1512/chip.h: https://review.coreboot.org/c/coreboot/+/69386/comment/961b08ad_4a9db253 PS2, Line 7: led_ctrl > something like that? Yes, looks better IMHO. File src/drivers/phy/m88e1512/m88e1512.h: https://review.coreboot.org/c/coreboot/+/69386/comment/ab3794bf_a7df6539 PS3, Line 7: PHY_MDIO_PAGE_ANY_ADR_RE This name is a bit misleading. In the linked datasheet this register is called 'Page Address'. The 'Page Any' note just tries to make clear, that this register is available on 'any' page. In addition, all the registers accessed here are on the MDIO interface. So adding this to the register defines does not provide additional information but only make the name longer. What about: #define PHY_PAGE_REG 0x16 I am still undecided if we really need the page defines. It is just a 1:1 mapped number... What dou you think? Accordingly, the LED contrl register would then be PHY_LED_FUNC_CTRL_REG We could even get rid of the PHY prefix, but this is up to you to decide. File src/drivers/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/69386/comment/308ef253_831e36d2 PS2, Line 22: dev->bus->dev->device > A guess the PCI path would be more helpfull here than the device ID, or? Ack File src/drivers/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/69386/comment/5500e4dc_7dd9ff8d PS3, Line 22: ... Just one '.' should be suitable here. -- To view, visit https://review.coreboot.org/c/coreboot/+/69386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia71c43f4286f9201f03cb759252ebb405ab81904 Gerrit-Change-Number: 69386 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Wed, 09 Nov 2022 11:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com> Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2022