Attention is currently required from: Tarun Tuli, Kyle Lin, Frank Chu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69367 )
Change subject: mb/google/brya/var/marasov: use RPL FSP headers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7874420c0fb51b9cc616cd979ffc9349c381602e
Gerrit-Change-Number: 69367
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:25:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Kyle Lin, Frank Chu, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69311 )
Change subject: mb/google/brya/var/marasov: Generate SPD ID for supported memory parts
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69311
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa0637b47d0017cdb9e26ed32328f4405c0df3f7
Gerrit-Change-Number: 69311
Gerrit-PatchSet: 5
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kyle Lin <kylelinck(a)google.com>
Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:25:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69423 )
Change subject: mb/google/brya: Update devicetree setting for gladios
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69423/comment/cfc4dbfd_b87b550b
PS1, Line 7: mb/google/brya: Update devicetree setting for gladios
mb/google/brya/var/gladios: Update devicetree setting
https://review.coreboot.org/c/coreboot/+/69423/comment/586707fb_c1892334
PS1, Line 9: schematic
add . after last word.
https://review.coreboot.org/c/coreboot/+/69423/comment/1cac4243_b2a9a952
PS1, Line 9: u
Update. Need upper case for first word.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69423
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8746d44daa43c06723bdfcac6803eb90a3c124b3
Gerrit-Change-Number: 69423
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:08:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69424 )
Change subject: mb/google/brya: use i2c1 for TPM for gladios
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69424/comment/e3e0467a_c879752c
PS1, Line 7: mb/google/brya: use i2c1 for TPM for gladios
mb/google/brya/var/gladios: Config I2C1 for TPM
Patchset:
PS1:
Please take care the title format.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6f2bf2a79df883bcb70171051cec4c577ca3bc4
Gerrit-Change-Number: 69424
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:06:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69425 )
Change subject: mb/google/brya: Include GL9763E driver for gladios eMMC boot disk support
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
Gerrit-Change-Number: 69425
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:05:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kevin Chiu, Tarun Tuli.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69425 )
Change subject: mb/google/brya: Include GL9763E driver for gladios eMMC boot disk support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69425/comment/673b4fc3_ecf16eca
PS1, Line 7: mb/google/brya: Include GL9763E driver for gladios eMMC boot disk support
mb/google/brya/var/gladios: Include GL9763E driver for eMMC support
--
To view, visit https://review.coreboot.org/c/coreboot/+/69425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
Gerrit-Change-Number: 69425
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 10 Nov 2022 05:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69425 )
Change subject: mb/google/brya: Include GL9763E driver for gladios eMMC boot disk support
......................................................................
mb/google/brya: Include GL9763E driver for gladios eMMC boot disk support
Support GL9763E as a eMMC boot disk
BUG=b:239513596
TEST=emerge-brask coreboot
Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
---
M src/mainboard/google/brya/Kconfig.name
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/69425/1
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name
index 2102961..447c72c 100644
--- a/src/mainboard/google/brya/Kconfig.name
+++ b/src/mainboard/google/brya/Kconfig.name
@@ -299,6 +299,7 @@
bool "-> Gladios"
select BOARD_GOOGLE_BASEBOARD_BRASK
select SOC_INTEL_RAPTORLAKE
+ select DRIVERS_GENESYSLOGIC_GL9763E
config BOARD_GOOGLE_MARASOV
bool "-> Marasov"
--
To view, visit https://review.coreboot.org/c/coreboot/+/69425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b29309615df381f1e24f29fc048c6f9bf216b7f
Gerrit-Change-Number: 69425
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-MessageType: newchange
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/69424 )
Change subject: mb/google/brya: use i2c1 for TPM for gladios
......................................................................
mb/google/brya: use i2c1 for TPM for gladios
This change sets DRIVER_TPM_I2C_BUS to the i2c 1 bus for TPM for the
gladios variant.
BUG=b:239513596
TEST=emerge-brask coreboot
Signed-off-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Change-Id: Id6f2bf2a79df883bcb70171051cec4c577ca3bc4
---
M src/mainboard/google/brya/Kconfig
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/69424/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index a114860..88202da 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -149,6 +149,7 @@
default 0x0 if BOARD_GOOGLE_YAVIKS
default 0x1 if BOARD_GOOGLE_ZYDRON
default 0x1 if BOARD_GOOGLE_LISBON
+ default 0x1 if BOARD_GOOGLE_GLADIOS
config DRIVER_TPM_I2C_ADDR
hex
--
To view, visit https://review.coreboot.org/c/coreboot/+/69424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6f2bf2a79df883bcb70171051cec4c577ca3bc4
Gerrit-Change-Number: 69424
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-MessageType: newchange