coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[S] Change in coreboot[master]: drivers/i2c/generic: Print error when using _CRS and PowerResource
by Martin Roth (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Tim Crawford, Raul Rangel, Karthik Ramasubramanian. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60174 ) Change subject: drivers/i2c/generic: Print error when using _CRS and PowerResource ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: This patch now needs a manual rebase before it can be merged. I think enough time has passed to allow the tests to be fixed, though I doubt anything has been done. My opinion is that we should merge this, then submit a patch to change it to warning, info, or something else if it breaks things too badly. -- To view, visit https://review.coreboot.org/c/coreboot/+/60174 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcc42ed81fff295fb168a0b343e96b3a650b1c84 Gerrit-Change-Number: 60174 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 30 Oct 2022 17:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: stoneyridge: Set the SPI read speed as 66MHz
by Martin Roth (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Bao Zheng, Jason Nien, Zheng Bao. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68884 ) Change subject: stoneyridge: Set the SPI read speed as 66MHz ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68884/comment/c284323e_e6b20811 PS1, Line 7: stoneyridge: Set the SPI Isn't this changing the read MODE, not the speed? I think we still want to use dual SPI, not single SPI. I'm not convinced that this is right. -- To view, visit https://review.coreboot.org/c/coreboot/+/68884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6083cfa515abeb2e981ff0ef825970c9311466b Gerrit-Change-Number: 68884 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Sun, 30 Oct 2022 17:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim: Implement touchscreen power sequencing
by Martin L Roth (Code Review) 30 Oct '22

30 Oct '22

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67778 ) Change subject: mb/google/skyrim: Implement touchscreen power sequencing ...................................................................... mb/google/skyrim: Implement touchscreen power sequencing Assuming variants have a touchscreen by default, set the enable GPIO high and hold in reset during romstage, then release reset in ramstage. This will allow the touchscreen to make use of the runtime I2C detect feature (enabled in a subsequent commit) so that an ACPI device entry is created only for the touchscreen actually present. Variants/SKUs which do not have a touchscreen (if any) can use the romstage/ramstage GPIO override tables to set the associated enable/ reset GPIOs to NC. BUG=b:121309055 TEST=build/boot skyrim with rest of patch series Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449 Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67778 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 35 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Martin Roth: Looks good to me, approved diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index 6062d93..2e265d1 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -113,10 +113,11 @@ PAD_NF(GPIO_116, CLK_REQ2_L, PULL_NONE), /* SOC_FPMCU_BOOT0 */ PAD_GPO(GPIO_130, LOW), + /* Enable touchscreen, release from reset */ /* EN_PP3300_TCHSCR */ - PAD_GPO(GPIO_131, LOW), + PAD_GPO(GPIO_131, HIGH), /* TCHSCR_RESET_L */ - PAD_GPO(GPIO_136, LOW), + PAD_GPO(GPIO_136, HIGH), /* SOC_BIOS_WP_L */ PAD_GPI(GPIO_138, PULL_NONE), /* EN_SPKR */ @@ -200,6 +201,11 @@ PAD_NFO(GPIO_27, PCIE_RST1_L, HIGH), /* SSD_AUX_RESET_L */ PAD_GPO(GPIO_6, HIGH), + /* Enable touchscreen, hold in reset */ + /* EN_PP3300_TCHSCR */ + PAD_GPO(GPIO_131, HIGH), + /* TCHSCR_RESET_L */ + PAD_GPO(GPIO_136, LOW), }; void baseboard_romstage_gpio_table(const struct soc_amd_gpio **gpio, size_t *size) -- To view, visit https://review.coreboot.org/c/coreboot/+/67778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4d7ac8f951bb94da2216a24dc85a96275c9d449 Gerrit-Change-Number: 67778 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/clevo/l140mu: make use of the new clevo/it5570e ec driver
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59850 ) Change subject: mb/clevo/l140mu: make use of the new clevo/it5570e ec driver ...................................................................... Patch Set 10: (1 comment) Patchset: PS8: > > Same comments as CML-U closed by mistake -- To view, visit https://review.coreboot.org/c/coreboot/+/59850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c4637936761cd62571b5d19fe2afd65560f49a0 Gerrit-Change-Number: 59850 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Oct 2022 16:08:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/clevo/l140mu: PECI idle workaround
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68794 ) Change subject: mb/clevo/l140mu: PECI idle workaround ...................................................................... Patch Set 6: (1 comment) File src/mainboard/clevo/tgl-u/variants/l140mu/gpio.c: https://review.coreboot.org/c/coreboot/+/68794/comment/76faae9a_ec41fd0e PS4, Line 238: pcr_rmw32(0x6b, 0x744, ~PAD_CFG1_PULL_MASK, PAD_CFG1_PULL_DN_20K); > Can this not be done inside the GPIO table itself instead of using direct PCR accesses? no, at least not yet. This requires making the special pads available in TGL. I started looking at this, but could get that working, yet. However, since it's a workaround anways, maybe it's not that bad to be a bit more explicit here -- To view, visit https://review.coreboot.org/c/coreboot/+/68794 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85193000af67cd2c0465bdbb58cdd51b68fd5b4f Gerrit-Change-Number: 68794 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Sun, 30 Oct 2022 16:07:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpigen: export acpigen_write_field_name
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Lance Zhao, Michał Żygowski, Michał Kopeć, Tim Wawrzynczak, Angel Pons, Arthur Heymans. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68787 ) Change subject: acpigen: export acpigen_write_field_name ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68787/comment/fd5035e2_e28f7d0c PS2, Line 7: add prototypes for some functions > How about: […] Done File src/include/acpi/acpigen.h: https://review.coreboot.org/c/coreboot/+/68787/comment/07e194e9_c6c9aaa5 PS2, Line 393: void acpigen_emit_simple_namestring(const char *name); > Can't you use acpigen_emit_namestring()? It would do the same under some conditions it seems. yes, done -- To view, visit https://review.coreboot.org/c/coreboot/+/68787 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If89f9569c33949995d3b45a5f871ff2cb84a6610 Gerrit-Change-Number: 68787 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Lance Zhao Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 30 Oct 2022 16:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
by build bot (Jenkins) (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 ) Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ...................................................................... Patch Set 6: (9 comments) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/5056ba15_805b6d77 PS6, Line 56: Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/ca0a754d_6f6e2453 PS6, Line 57: Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Non-standard signature: Co-authored-by: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/a42f89fe_a2967ec4 PS6, Line 58: Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Non-standard signature: Co-authored-by: File src/ec/clevo/it5570e/commands.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/86552337_51508e2e PS6, Line 44: while (recv_ec_data() != '$'); trailing statements should be on next line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/22ed6ce1_b2dc92c7 PS6, Line 119: else if (start > 100 || stop > 100) { else should follow close brace '}' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/e51a0e9c_7525a9be PS6, Line 122: else if (start >= stop) { else should follow close brace '}' File src/ec/clevo/it5570e/ec.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/759bdb8a_ee39d936 PS6, Line 123: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { braces {} are not necessary for any arm of this statement Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/467ac5af_76d7e178 PS6, Line 126: else { else should follow close brace '}' File src/ec/clevo/it5570e/ssdt.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161716): https://review.coreboot.org/c/coreboot/+/68791/comment/b1ab3089_9c29ecb6 PS6, Line 139: for (int i = 0; i < fan_cnt; i++) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/c/coreboot/+/68791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0 Gerrit-Change-Number: 68791 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sun, 30 Oct 2022 16:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/clevo/l140mu: make use of the new clevo/it5570e ec driver
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Michał Kopeć, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/59850 to look at the new patch set (#10). Change subject: mb/clevo/l140mu: make use of the new clevo/it5570e ec driver ...................................................................... mb/clevo/l140mu: make use of the new clevo/it5570e ec driver Hook up the new EC driver. Tested: - Fn hotkeys work (brightness, display, volume, tp toggle, ...) - Display lid - Sleep/wake - Camera (including Fn toggle) - Bluetooth (both CNVi and PCIe card) - Wi-Fi (both CNVi and PCIe card) - CMOS options Known issues: - Touchpad toggle needs OS setup; see CB:68791 Change-Id: I6c4637936761cd62571b5d19fe2afd65560f49a0 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/clevo/tgl-u/Kconfig M src/mainboard/clevo/tgl-u/Makefile.inc M src/mainboard/clevo/tgl-u/bootblock.c M src/mainboard/clevo/tgl-u/cmos.default M src/mainboard/clevo/tgl-u/cmos.layout M src/mainboard/clevo/tgl-u/dsdt.asl A src/mainboard/clevo/tgl-u/fadt.c A src/mainboard/clevo/tgl-u/smihandler.c A src/mainboard/clevo/tgl-u/variants/l140mu/acpi/variant.asl M src/mainboard/clevo/tgl-u/variants/l140mu/devicetree.cb 10 files changed, 116 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/59850/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/59850 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6c4637936761cd62571b5d19fe2afd65560f49a0 Gerrit-Change-Number: 59850 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68795 ) Change subject: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68795/comment/0c858c07_cace1b36 PS4, Line 11: Tested: > Anything not tested and/or not working? everything works fine, except the touchpad toggle on Linux when udev entries are missing (see CB:68791). That's not a board-specific issue, so I haven't mentioned it here. I could add a reference, though. -> done UCSI also doesn't work but it's not implemented, yet, anyways https://review.coreboot.org/c/coreboot/+/68795/comment/cdfcae81_4f8472c5 PS4, Line 17: Wifi > Wi-Fi Done Patchset: PS4: > Do the CMOS options work? Not sure if the code properly handles byte boundaries... Yes, I've tested all of them bc the first version raised a bunch of aligment errors. Which options du you mean specifically? -- To view, visit https://review.coreboot.org/c/coreboot/+/68795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe Gerrit-Change-Number: 68795 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Oct 2022 16:00:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver
by Michael Niewöhner (Code Review) 30 Oct '22

30 Oct '22

Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć, Angel Pons. Hello Felix Singer, build bot (Jenkins), Michał Żygowski, Michał Kopeć, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/68795 to look at the new patch set (#6). Change subject: mb/clevo/l140cu: make use of the new clevo/it5570e ec driver ...................................................................... mb/clevo/l140cu: make use of the new clevo/it5570e ec driver Hook up the new EC driver. Tested: - Fn hotkeys work (brightness, display, volume, tp toggle, ...) - Display lid - Sleep/wake - Camera (including Fn toggle) - Bluetooth (both CNVi and PCIe card) - Wi-Fi (both CNVi and PCIe card) - CMOS options Known issues: - Touchpad toggle needs OS setup; see CB:68791 Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M src/mainboard/clevo/cml-u/Kconfig M src/mainboard/clevo/cml-u/Makefile.inc M src/mainboard/clevo/cml-u/bootblock.c M src/mainboard/clevo/cml-u/cmos.default M src/mainboard/clevo/cml-u/cmos.layout M src/mainboard/clevo/cml-u/dsdt.asl A src/mainboard/clevo/cml-u/fadt.c A src/mainboard/clevo/cml-u/smihandler.c A src/mainboard/clevo/cml-u/variants/l140cu/acpi/variant.asl M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb 10 files changed, 115 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/68795/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/68795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I28ac401ada2945bb58fe862895458b10fed505fe Gerrit-Change-Number: 68795 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022