Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 )
Change subject: soc/intel/alderlake: Fix hang when MultiPhaseSiInit API is skipped
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56382/comment/3b06fe1b_c1b868b5
PS2, Line 7: Fix booting issue with MultiPhaseSiInit API skip
> Nit: I’d use: Fix hang when …
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:39:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai.
Hello V Sowmya, build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Ronak Kanabar, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56382
to look at the new patch set (#4).
Change subject: soc/intel/alderlake: Fix hang when MultiPhaseSiInit API is skipped
......................................................................
soc/intel/alderlake: Fix hang when MultiPhaseSiInit API is skipped
This patch honors soc_fsp_multi_phase_init_is_enable() function while
assigning EnableMultiPhaseSiliconInit UPD.
FSP would results into a hang while calling FSP-Notify Phase if
EnableMultiPhaseSiliconInit UPD remains enable but bootloader don't
make call into MultiPhaseSiInit as
soc_fsp_multi_phase_init_is_enable() returns 0.
Ensures EnableMultiPhaseSiliconInit UPD is getting updated based on
return value from soc_fsp_multi_phase_init_is_enable().
Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/soc/intel/alderlake/fsp_params.c
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/56382/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 )
Change subject: soc/intel/alderlake: Fix hang issue when MultiPhaseSiInit API is skipped
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56382/comment/fca9b6b0_77e17358
PS2, Line 7: Fix booting issue with MultiPhaseSiInit API skip
> Ack
Nit: I’d use: Fix hang when …
https://review.coreboot.org/c/coreboot/+/56382/comment/3b6e0b4c_294f9f81
PS2, Line 12: FSP would results into a hang while calling FSP-Notify Phase if
: EnableMultiPhaseSiliconInit UPD remains enable but bootloader don't
: make call into MultiPhaseSiInit as
: soc_fsp_multi_phase_init_is_enable() returns 0.
> Any FSP version that compliant with FSP2. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56373 )
Change subject: util/kconfig: Stop trying to make sense of Linux configs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56373
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbce93232ba2b54561abab5b2747c418d6efa92b
Gerrit-Change-Number: 56373
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:37:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56382 )
Change subject: soc/intel/alderlake: Fix hang issue when MultiPhaseSiInit API is skipped
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56382/comment/7a2e77d0_b33a088d
PS2, Line 7: Fix booting issue with MultiPhaseSiInit API skip
> Nit: *Fix* implies issues (at least for me). Shorter: […]
Ack
https://review.coreboot.org/c/coreboot/+/56382/comment/513979d5_fba438de
PS2, Line 12: FSP would results into a hang while calling FSP-Notify Phase if
: EnableMultiPhaseSiliconInit UPD remains enable but bootloader don't
: make call into MultiPhaseSiInit as
: soc_fsp_multi_phase_init_is_enable() returns 0.
> Which FSP version? I would put the problem description at the beginning.
Any FSP version that compliant with FSP2.2 spec would results into this issue hence i didn't mentioned any particular revision.
I hope that's okay ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:36:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai.
Hello V Sowmya, build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Angel Pons, Ronak Kanabar, Patrick Rudolph, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56382
to look at the new patch set (#3).
Change subject: soc/intel/alderlake: Fix hang issue when MultiPhaseSiInit API is skipped
......................................................................
soc/intel/alderlake: Fix hang issue when MultiPhaseSiInit API is skipped
This patch honors soc_fsp_multi_phase_init_is_enable() function while
assigning EnableMultiPhaseSiliconInit UPD.
FSP would results into a hang while calling FSP-Notify Phase if
EnableMultiPhaseSiliconInit UPD remains enable but bootloader don't
make call into MultiPhaseSiInit as
soc_fsp_multi_phase_init_is_enable() returns 0.
Ensures EnableMultiPhaseSiliconInit UPD is getting updated based on
return value from soc_fsp_multi_phase_init_is_enable().
Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Signed-off-by: Subrata Banik <subrata.banik(a)intel.com>
---
M src/soc/intel/alderlake/fsp_params.c
1 file changed, 12 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/56382/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56382
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I019fa8364605f5061d56e2d80b20e1a91857c423
Gerrit-Change-Number: 56382
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alex1 Kao, Shou-Chieh Hsu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56383 )
Change subject: mb/google/dedede/var/pirika: Configure I2C times for touchpad
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56383/comment/6aa3dc35_c55f63ae
PS2, Line 7: Configure I2C times
… to 380–400 kHz for touchpad
https://review.coreboot.org/c/coreboot/+/56383/comment/6b2ecb48_5dd506e8
PS2, Line 14: TEST=Build and check after tuning I2C clock is between 380 kHz and 400 kHz
Please list the exact measured values.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56383
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia57c90ead44ceb0990878dc0566e595bae5a9099
Gerrit-Change-Number: 56383
Gerrit-PatchSet: 2
Gerrit-Owner: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kirk Wang <kirk_wang(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Alex1 Kao <alex1_kao(a)pegatron.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 15:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment