coreboot-gerrit December 2021

coreboot-gerrit@coreboot.org

1 participants
5525 discussions

Change in coreboot[master]: mb/google/octopus: Move selects from Kconfig.name to Kconfig
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60344 ) Change subject: mb/google/octopus: Move selects from Kconfig.name to Kconfig ...................................................................... mb/google/octopus: Move selects from Kconfig.name to Kconfig Move selects from Kconfig.name to Kconfig so that the configuration is at one place and not distributed over two files. Change-Id: I5949fc474c4923beb1f41a40876f03e5c70fc5b1 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60344 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> --- M src/mainboard/google/octopus/Kconfig M src/mainboard/google/octopus/Kconfig.name 2 files changed, 80 insertions(+), 54 deletions(-) Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig index 1aac8b6..08ddd80 100644 --- a/src/mainboard/google/octopus/Kconfig +++ b/src/mainboard/google/octopus/Kconfig @@ -28,6 +28,86 @@ select SOC_ESPI select SOC_INTEL_GEMINILAKE +config BOARD_GOOGLE_AMPTON + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_BLOOG + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_BOBBA + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_CASTA + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_DOOD + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_FLEEX + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_FOOB + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_GARG + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_LICK + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_MEEP + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_OCTOPUS + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP + +config BOARD_GOOGLE_PHASER + select BASEBOARD_OCTOPUS_LAPTOP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + select NHLT_RT5682 if INCLUDE_NHLT_BLOBS + +config BOARD_GOOGLE_YORP + select BOARD_GOOGLE_BASEBOARD_OCTOPUS + select BASEBOARD_OCTOPUS_LAPTOP + select INTEL_GMA_HAVE_VBT + select NHLT_DA7219 if INCLUDE_NHLT_BLOBS + if BOARD_GOOGLE_BASEBOARD_OCTOPUS config CHROMEOS_WIFI_SAR diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name index 4168411..3657e9c 100644 --- a/src/mainboard/google/octopus/Kconfig.name +++ b/src/mainboard/google/octopus/Kconfig.name @@ -2,93 +2,39 @@ config BOARD_GOOGLE_AMPTON bool "-> Ampton (ASUS Chromebook Flip C214)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_BLOOG bool "-> Bloog (HP Chromebook x360 12b, 14a, x360 14b)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_BOBBA bool "-> Bobba (Acer Chromebook 311 / Spin 511)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_CASTA bool "-> Bluebird/Casta (Samsung Chromebook 4, 4+)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_DOOD bool "-> Dood" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_FLEEX bool "-> Fleex (Dell Chromebook 3100)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_FOOB bool "-> Foob" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_GARG bool "-> Garg" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_LICK bool "-> Lick (Ideapad 3 Chromebook)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_MEEP bool "-> Meep (HP Chromebook x360 11 G2 EE)" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_OCTOPUS bool "-> Octopus" - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select BASEBOARD_OCTOPUS_LAPTOP config BOARD_GOOGLE_PHASER bool "-> Phaser (Lenovo 100e/300e/500e Chromebook 2nd Gen (Intel))" - select BASEBOARD_OCTOPUS_LAPTOP - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS - select NHLT_RT5682 if INCLUDE_NHLT_BLOBS config BOARD_GOOGLE_YORP bool "-> Yorp" - select BOARD_GOOGLE_BASEBOARD_OCTOPUS - select BASEBOARD_OCTOPUS_LAPTOP - select INTEL_GMA_HAVE_VBT - select NHLT_DA7219 if INCLUDE_NHLT_BLOBS 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/60344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5949fc474c4923beb1f41a40876f03e5c70fc5b1 Gerrit-Change-Number: 60344 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/intel/alderlake: Add option to make MRC log silent
by Subrata Banik (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60472 ) Change subject: soc/intel/alderlake: Add option to make MRC log silent ...................................................................... soc/intel/alderlake: Add option to make MRC log silent Typically, FSP-M aka MRC debug log level is default set to `3` meaning prints all `Load, Error, Warnings & Info` Messages. Sometimes it's too much information to parse even when users aren't required to have such detailed information hence, implemented `fsp_map_console_log_level()` that maps coreboot console log level to FSP-M debug log level and suppress verbose MRC debug messages unless `HAVE_DEBUG_RAM_SETUP` config is enabled. TEST=FSP-M debug log suggested default `SerialDebugMrcLevel` UPD value is `2`. While the user selects `HAVE_DEBUG_RAM_SETUP` config `SerialDebugMrcLevel` UPD value is overridden to '5' aka verbose. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I21ea7324153e93ed32a7ce0f861c36c19a0d463c --- M src/soc/intel/alderlake/romstage/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/60472/1 diff --git a/src/soc/intel/alderlake/romstage/fsp_params.c b/src/soc/intel/alderlake/romstage/fsp_params.c index 8959bf7..0eeaabd 100644 --- a/src/soc/intel/alderlake/romstage/fsp_params.c +++ b/src/soc/intel/alderlake/romstage/fsp_params.c @@ -312,6 +312,9 @@ static void fill_fspm_trace_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_alderlake_config *config) { + /* Set MRC debug level */ + m_cfg->SerialDebugMrcLevel = fsp_map_console_log_level(); + /* Set debug probe type */ m_cfg->PlatformDebugConsent = CONFIG_SOC_INTEL_ALDERLAKE_DEBUG_CONSENT; -- To view, visit https://review.coreboot.org/c/coreboot/+/60472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21ea7324153e93ed32a7ce0f861c36c19a0d463c Gerrit-Change-Number: 60472 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/intel/fsp: Creates map between FSP and coreboot console level
by Subrata Banik (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60471 ) Change subject: drivers/intel/fsp: Creates map between FSP and coreboot console level ...................................................................... drivers/intel/fsp: Creates map between FSP and coreboot console level This patch performs a map between coreboot console level and FSP debug level. This would be useful to suppress MRC (FSP-M) debug logs. Users to select HAVE_DEBUG_RAM_SETUP config to get verbose MRC debug log, Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I398d576fad68a0d0fc931c175bbc04fcbc2e54ec --- M src/drivers/intel/fsp2_0/debug.c M src/drivers/intel/fsp2_0/include/fsp/debug.h 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/60471/1 diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c index 323c799..8d11e5f 100644 --- a/src/drivers/intel/fsp2_0/debug.c +++ b/src/drivers/intel/fsp2_0/debug.c @@ -1,10 +1,20 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include <commonlib/helpers.h> #include <console/console.h> #include <console/streams.h> #include <cpu/x86/mtrr.h> #include <fsp/util.h> +enum { + FSP_LOG_LEVEL_DISABLE = 0, + FSP_LOG_LEVEL_ERR, + FSP_LOG_LEVEL_ERR_WARN, + FSP_LOG_LEVEL_ERR_WARN_INFO, + FSP_LOG_LEVEL_ERR_WARN_INFO_EVENT, + FSP_LOG_LEVEL_VERBOSE +}; + asmlinkage size_t fsp_write_line(uint8_t *buffer, size_t number_of_bytes) { console_write_line(buffer, number_of_bytes); @@ -32,6 +42,41 @@ } } +int fsp_map_console_log_level(void) +{ + int fsp_debug_level; + + switch (get_max_console_log_level(CONSOLE_LOG_ALL)) { + case BIOS_EMERG: + case BIOS_ALERT: + case BIOS_CRIT: + case BIOS_ERR: + fsp_debug_level = FSP_LOG_LEVEL_ERR; + break; + case BIOS_WARNING: + fsp_debug_level = FSP_LOG_LEVEL_ERR_WARN; + break; + case BIOS_NOTICE: + fsp_debug_level = FSP_LOG_LEVEL_ERR_WARN_INFO; + break; + case BIOS_INFO: + fsp_debug_level = FSP_LOG_LEVEL_ERR_WARN_INFO_EVENT; + break; + case BIOS_DEBUG: + case BIOS_SPEW: + fsp_debug_level = FSP_LOG_LEVEL_VERBOSE; + break; + default: + fsp_debug_level = FSP_LOG_LEVEL_DISABLE; + break; + } + + if (!CONFIG(DEBUG_RAM_SETUP)) + fsp_debug_level = MIN(fsp_debug_level, FSP_LOG_LEVEL_ERR_WARN); + + return fsp_debug_level; +} + /*----------- * MemoryInit *----------- diff --git a/src/drivers/intel/fsp2_0/include/fsp/debug.h b/src/drivers/intel/fsp2_0/include/fsp/debug.h index be7dd3a..3b531bc 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/debug.h +++ b/src/drivers/intel/fsp2_0/include/fsp/debug.h @@ -6,6 +6,7 @@ #include <fsp/util.h> /* FSP debug API */ +int fsp_map_console_log_level(void); void fsp_debug_before_memory_init(fsp_memory_init_fn memory_init, const FSPM_UPD *fspm_old_upd, const FSPM_UPD *fspm_new_upd); -- To view, visit https://review.coreboot.org/c/coreboot/+/60471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I398d576fad68a0d0fc931c175bbc04fcbc2e54ec Gerrit-Change-Number: 60471 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: console: Create helper function to get max console log level
by Subrata Banik (Code Review) 29 Dec '21

29 Dec '21

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60470 ) Change subject: console: Create helper function to get max console log level ...................................................................... console: Create helper function to get max console log level This patch takes console level as argument and returns log level as per `loglevel.h` file to be used while printing serial messages. Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397 --- M src/console/init.c M src/include/console/console.h 2 files changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/60470/1 diff --git a/src/console/init.c b/src/console/init.c index 4427d68..9b1f03c 100644 --- a/src/console/init.c +++ b/src/console/init.c @@ -45,6 +45,21 @@ return 0; } +int get_max_console_log_level(int console_level) +{ + if (console_level == CONSOLE_LOG_NONE) + return BIOS_NEVER; + + if (console_level == CONSOLE_LOG_FAST) + if (CONFIG(CONSOLE_CBMEM)) + return BIOS_DEBUG; + + if (console_level == CONSOLE_LOG_ALL) + return get_log_level(); + + return 0; +} + void console_init(void) { init_log_level(); diff --git a/src/include/console/console.h b/src/include/console/console.h index 8849df3..be993b0 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -49,6 +49,7 @@ #if __CONSOLE_ENABLE__ void console_init(void); int console_log_level(int msg_level); +int get_max_console_log_level(int console_level); int printk(int msg_level, const char *fmt, ...) __attribute__((format(printf, 2, 3))); int vprintk(int msg_level, const char *fmt, va_list args); -- To view, visit https://review.coreboot.org/c/coreboot/+/60470 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56349f22c71c9db757b2be8eeb2dbfe959f80397 Gerrit-Change-Number: 60470 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
by Julius Werner (Code Review) 29 Dec '21

29 Dec '21

Attention is currently required from: Angel Pons, Alex James. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 ) Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h ...................................................................... Patch Set 7: Code-Review+2 (2 comments) File util/cbfstool/cbfs_image.c: https://review.coreboot.org/c/coreboot/+/60233/comment/bd99fcbf_715ac377 PS6, Line 528: uint32_t type = htobe32(cur->type); : : /* Current entry is empty. Kepp track of it. */ : if ((type == htobe32(CBFS_TYPE_NULL)) || : (type == htobe32(CBFS_TYPE_DELETED))) { > Yeah... Feel free to fix it if you want to... a lot of this code is very old and never really gets any attention. https://review.coreboot.org/c/coreboot/+/60233/comment/e6defdb5_03a9f5c5 PS6, Line 1031: be32toh(stage->loadaddr) > Seems like a mistake? be64toh(stage->loadaddr) is used everywhere else in this file. My mistake (from CB:46484), thanks for catching! Please fix it while we're here. -- To view, visit https://review.coreboot.org/c/coreboot/+/60233 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e Gerrit-Change-Number: 60233 Gerrit-PatchSet: 7 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alex James <theracermaster(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Dec 2021 18:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Alex James <theracermaster(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_cnl/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60428 ) Change subject: mb/purism/librem_cnl/acpi: Use Printf() for debug prints ...................................................................... mb/purism/librem_cnl/acpi: Use Printf() for debug prints Change-Id: I587dcd8fc208562ecf0e0ba6ea9f741538511192 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60428 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/gpe.asl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/gpe.asl b/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/gpe.asl index 611643b..8045aaf 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/gpe.asl +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/include/variant/acpi/gpe.asl @@ -2,7 +2,7 @@ // GPP_E15 SWI Method (_L49, 0, Serialized) { - Debug = Concatenate("GPE _L49: ", ToHexString(\_SB.PCI0.LPCB.EC0.WFNO)) + Printf ("GPE _L49: %o", ToHexString(\_SB.PCI0.LPCB.EC0.WFNO)) If (\_SB.PCI0.LPCB.EC0.ECOK) { If (\_SB.PCI0.LPCB.EC0.WFNO == One) { Notify(\_SB.LID0, 0x80) -- To view, visit https://review.coreboot.org/c/coreboot/+/60428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I587dcd8fc208562ecf0e0ba6ea9f741538511192 Gerrit-Change-Number: 60428 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/jecht/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60427 ) Change subject: mb/google/jecht/acpi: Use Printf() for debug prints ...................................................................... mb/google/jecht/acpi: Use Printf() for debug prints Change-Id: Ie54637c451252fd38aab9207ab0b846cc50f4b12 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60427 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl M src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl 4 files changed, 8 insertions(+), 16 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl index 2a16352..d5c943a 100644 --- a/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/guado/include/variant/acpi/thermal.asl @@ -95,8 +95,7 @@ Store (CTOK (\TMAX), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll Sleep (1000) @@ -104,8 +103,7 @@ // Re-read temperature from SuperIO Store (TCHK (), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) diff --git a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl index 2a16352..d5c943a 100644 --- a/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/jecht/include/variant/acpi/thermal.asl @@ -95,8 +95,7 @@ Store (CTOK (\TMAX), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll Sleep (1000) @@ -104,8 +103,7 @@ // Re-read temperature from SuperIO Store (TCHK (), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) diff --git a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl index 2a16352..d5c943a 100644 --- a/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/rikku/include/variant/acpi/thermal.asl @@ -95,8 +95,7 @@ Store (CTOK (\TMAX), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll Sleep (1000) @@ -104,8 +103,7 @@ // Re-read temperature from SuperIO Store (TCHK (), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) diff --git a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl index e2f2675..2b79320 100644 --- a/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl +++ b/src/mainboard/google/jecht/variants/tidus/include/variant/acpi/thermal.asl @@ -203,8 +203,7 @@ Store (CTOK (\TMAX), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for SuperIO to re-poll Sleep (1000) @@ -212,8 +211,7 @@ // Re-read temperature from SuperIO Store (TCHK (), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie54637c451252fd38aab9207ab0b846cc50f4b12 Gerrit-Change-Number: 60427 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/kahlee/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60426 ) Change subject: mb/google/kahlee/acpi: Use Printf() for debug prints ...................................................................... mb/google/kahlee/acpi: Use Printf() for debug prints Change-Id: Ib5ccba321f3cb737eb6287472314b06ebe6e2437 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60426 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl index 32a6549..732ff87 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -56,8 +56,7 @@ Store (CTOK (\TCRT), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) /* Wait 1 second for EC to re-poll */ Sleep (1000) @@ -65,8 +64,7 @@ /* Re-read temperature from EC */ Store (\_SB.PCI0.LPCB.EC0.TSRD (TMPS), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib5ccba321f3cb737eb6287472314b06ebe6e2437 Gerrit-Change-Number: 60426 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/slippy/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60425 ) Change subject: mb/google/slippy/acpi: Use Printf() for debug prints ...................................................................... mb/google/slippy/acpi: Use Printf() for debug prints Change-Id: I8c0d1aaccb729eab91c88c77c5efc53d3e951692 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60425 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/slippy/acpi/thermal.asl 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/slippy/acpi/thermal.asl b/src/mainboard/google/slippy/acpi/thermal.asl index 74e73a2..1e122a3 100644 --- a/src/mainboard/google/slippy/acpi/thermal.asl +++ b/src/mainboard/google/slippy/acpi/thermal.asl @@ -103,8 +103,7 @@ Store (CTOK (\TCRT), Local1) If (LGreaterEqual (Local0, Local1)) { - Store ("CRITICAL TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("CRITICAL TEMPERATURE: %o", Local0) // Wait 1 second for EC to re-poll Sleep (1000) @@ -112,8 +111,7 @@ // Re-read temperature from EC Store (TCHK (), Local0) - Store ("RE-READ TEMPERATURE", Debug) - Store (Local0, Debug) + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c0d1aaccb729eab91c88c77c5efc53d3e951692 Gerrit-Change-Number: 60425 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/google/zork/acpi: Use Printf() for debug prints
by Felix Singer (Code Review) 29 Dec '21

29 Dec '21

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60424 ) Change subject: mb/google/zork/acpi: Use Printf() for debug prints ...................................................................... mb/google/zork/acpi: Use Printf() for debug prints Change-Id: I433b7138da84b57e45e816ab116f8ca874fdc0e0 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/60424 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: HAOUAS Elyes <ehaouas(a)noos.fr> --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl index dec33ec..5667248 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/thermal.asl @@ -56,8 +56,7 @@ Local1 = CTOK (\TCRT) If (Local0 >= Local1) { - Debug = "CRITICAL TEMPERATURE" - Debug = Local0 + Printf ("CRITICAL TEMPERATURE: %o", Local0) /* Wait 1 second for EC to re-poll */ Sleep (1000) @@ -65,8 +64,7 @@ /* Re-read temperature from EC */ Local0 = \_SB.PCI0.LPCB.EC0.TSRD (TMPS) - Debug = "RE-READ TEMPERATURE" - Debug = Local0 + Printf ("RE-READ TEMPERATURE: %o", Local0) } Return (Local0) -- To view, visit https://review.coreboot.org/c/coreboot/+/60424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I433b7138da84b57e45e816ab116f8ca874fdc0e0 Gerrit-Change-Number: 60424 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2021