coreboot-gerrit November 2021

coreboot-gerrit@coreboot.org

1 participants
6394 discussions

Change in coreboot[master]: util/lint: Exclude coreboot-configurator directory from checkpatch
by Sean Rhodes (Code Review) 10 Nov '21

10 Nov '21

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59096 ) Change subject: util/lint: Exclude coreboot-configurator directory from checkpatch ...................................................................... util/lint: Exclude coreboot-configurator directory from checkpatch The linter doesn't work well with CPP so exclude. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I1b07b7b05340409e5c1695cc7bbdea68f8190097 --- M 3rdparty/blobs M util/lint/lint-007-checkpatch M util/lint/lint-extended-007-checkpatch 3 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/59096/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index f388b67..f836ff3 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit f388b6794e6f1f93b847de353f5eab8ba3e3b328 +Subproject commit f836ff362b0411ab6c9e580b1e32760aa6ea7e31 diff --git a/util/lint/lint-007-checkpatch b/util/lint/lint-007-checkpatch index 7a76878..d7443b3 100755 --- a/util/lint/lint-007-checkpatch +++ b/util/lint/lint-007-checkpatch @@ -11,6 +11,7 @@ EXCLUDED_DIRS="^payloads/libpayload/util/kconfig\|\ ^payloads/libpayload/curses/PDCurses\|\ +^util/coreboot-configurator\|\ ^util/crossgcc/patches\|\ ^util/inteltool\|\ ^util/kconfig\|\ diff --git a/util/lint/lint-extended-007-checkpatch b/util/lint/lint-extended-007-checkpatch index 8ec1188..f7a49c5 100755 --- a/util/lint/lint-extended-007-checkpatch +++ b/util/lint/lint-extended-007-checkpatch @@ -12,6 +12,7 @@ src/include/boot src/include/superio src/include/sys \ src/mainboard/adlink src/mainboard/purism src/mainboard/ti \ src/superio/acpi src/superio/common \ +util/coreboot-configurator " for directory in $DIRS; do -- To view, visit https://review.coreboot.org/c/coreboot/+/59096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1b07b7b05340409e5c1695cc7bbdea68f8190097 Gerrit-Change-Number: 59096 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mainboard/starlabs: Add StarBook Mk V
by Angel Pons (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Sean Rhodes, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 ) Change subject: mainboard/starlabs: Add StarBook Mk V ...................................................................... Patch Set 109: Code-Review+1 (22 comments) File Documentation/distributions.md: https://review.coreboot.org/c/coreboot/+/56088/comment/e1e94fad_90f4a3f1 PS109, Line 29: offer singular: offer*s* File Documentation/mainboard/starlabs/BiosLock.jpg: PS109: Converting this image to WebP reduces its size by 37.5% File Documentation/mainboard/starlabs/starbook_tgl.md: https://review.coreboot.org/c/coreboot/+/56088/comment/aa8df81b_58eef390 PS109, Line 16: GOP driver is recommended Is there any other option? https://review.coreboot.org/c/coreboot/+/56088/comment/b28d0620_fa13b253 PS109, Line 50: The below are optional I'm not sure if this is gramatically correct. How about: The files listed below are optional: File src/mainboard/starlabs/labtop/Kconfig: https://review.coreboot.org/c/coreboot/+/56088/comment/b268c1b1_96ff4107 PS109, Line 45: string Declaring the type shouldn't be needed https://review.coreboot.org/c/coreboot/+/56088/comment/1e0c8856_eca1a49f PS109, Line 52: int Declaring the type shouldn't be needed https://review.coreboot.org/c/coreboot/+/56088/comment/60769edb_3eca4617 PS109, Line 56: int Declaring the type shouldn't be needed https://review.coreboot.org/c/coreboot/+/56088/comment/1dd14ad3_d3e566e8 PS109, Line 66: string Declaring the type shouldn't be needed File src/mainboard/starlabs/labtop/acpi/mainboard.asl: https://review.coreboot.org/c/coreboot/+/56088/comment/d4e837d6_07d55ee1 PS109, Line 8: Comet Huh, isn't this a TGL board? https://review.coreboot.org/c/coreboot/+/56088/comment/d10252cd_36d3c6fc PS109, Line 25: "PRP00001" This device ID is invalid, one 0 too many. Could you please test if removing it (only keep "PNP0A05") still works? Related LKML discussion: https://www.spinics.net/lists/linux-acpi/msg103981.html File src/mainboard/starlabs/labtop/acpi/sleep.asl: https://review.coreboot.org/c/coreboot/+/56088/comment/f76bc43f_dcce4a34 PS109, Line 3: // _PTS: Prepare To Sleep nit: Drop these comments? File src/mainboard/starlabs/labtop/dsdt.asl: https://review.coreboot.org/c/coreboot/+/56088/comment/ca82aeb4_4ca07fcd PS109, Line 12: // OEM revision nit: remove? File src/mainboard/starlabs/labtop/hda_verb.c: https://review.coreboot.org/c/coreboot/+/56088/comment/10346c5c_24432879 PS109, Line 15: u32 viddid Unused parameter https://review.coreboot.org/c/coreboot/+/56088/comment/f213d64c_ba615cbf PS109, Line 23: %d Why not use `%08x` instead? File src/mainboard/starlabs/labtop/mainboard.c: https://review.coreboot.org/c/coreboot/+/56088/comment/fdac0b7e_aee8328f PS109, Line 31: return "B5"; How about `return CONFIG_MAINBOARD_FAMILY;` instead? File src/mainboard/starlabs/labtop/variants/tgl/board.fmd: https://review.coreboot.org/c/coreboot/+/56088/comment/e32806fa_4ba6ad01 PS109, Line 6: SI_ALL@0x0 0x500000 { : SI_DESC@0x0 0x1000 : SI_ME@0x1000 : } Why is this part indented with spaces? File src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/56088/comment/e56f8e07_8f2a8559 PS109, Line 3: register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{ : .tdp_pl1_override = 15, : .tdp_pl2_override = 15, : }" : : register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{ : .tdp_pl1_override = 15, : .tdp_pl2_override = 15, : }" I see `devtree_update()` overrides these values. I'd remove this assignment to avoid confusion (the initial values will default to 0). https://review.coreboot.org/c/coreboot/+/56088/comment/33dafb53_efd2fb32 PS109, Line 74: register "PcieRpEnable[0]" = "1" : register "PcieRpEnable[2]" = "1" The PCI devices for these RPs are disabled, why? https://review.coreboot.org/c/coreboot/+/56088/comment/6cf345b6_da9a796c PS109, Line 82: register "PcieClkSrcUsage[0]" = "0x40" TGL-U doesn't have PEG (PCI Express Graphics, i.e. CPU PCIe ports). https://review.coreboot.org/c/coreboot/+/56088/comment/c453b44d_3fa6f787 PS109, Line 236: device pci 1f.4 off end # SMBus Shouldn't SMBus be enabled? It's used to read the DIMM SPDs File src/mainboard/starlabs/labtop/variants/tgl/hda_verb.c: https://review.coreboot.org/c/coreboot/+/56088/comment/c5eb76a5_1287258c PS109, Line 8: 0x10ec1200 Why is this value different from the one in the `AZALIA_SUBVENDOR` macro? https://review.coreboot.org/c/coreboot/+/56088/comment/aa01cba3_21054afe PS109, Line 7: 0x10ec0256, // Codec Vendor / Device ID: Realtek ALC256 : 0x10ec1200, // Subsystem ID : 38, // Number of jacks (NID entries) Please use consistent comment style -- To view, visit https://review.coreboot.org/c/coreboot/+/56088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645 Gerrit-Change-Number: 56088 Gerrit-PatchSet: 109 Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Nov 2021 11:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Fill PSP directory to ROMSIG based on the SOC ID
by Bao Zheng (Code Review) 10 Nov '21

10 Nov '21

Bao Zheng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55454 ) Change subject: amdfwtool: Fill PSP directory to ROMSIG based on the SOC ID ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/55454 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I82efc3498bc831a45662a8628cc24fcdd502ec93 Gerrit-Change-Number: 55454 Gerrit-PatchSet: 15 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: amdfwtool: Put soc name setting to fw.cfg from command line
by Bao Zheng (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58552 ) Change subject: amdfwtool: Put soc name setting to fw.cfg from command line ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/58552/comment/c8986c40_c4bead0b PS11, Line 11: > This is for future combo feature. Each entry in combo has its own fw.cfg. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58552 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib0eead1f2156542ea03d58145f5ad67683bf9b52 Gerrit-Change-Number: 58552 Gerrit-PatchSet: 12 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Nov 2021 10:43:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Call the set_efs_table for Stoneyridge
by Bao Zheng (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge, Felix Held. Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58871 ) Change subject: amdfwtool: Call the set_efs_table for Stoneyridge ...................................................................... Patch Set 6: (2 comments) File src/soc/amd/stoneyridge/Makefile.inc: https://review.coreboot.org/c/coreboot/+/58871/comment/384ea076_73c8ddba PS3, Line 136: OPT_EFS_SPI_MICRON_FLAG=$(call add_opt_prefix, $(CONFIG_EFS_SPI_MICRON_FLAG), --spi-micron-flag) > i don't see the micron flag in the documentation for the pre-zen socs, so it's probably not needed t […] Done https://review.coreboot.org/c/coreboot/+/58871/comment/49710bee_3a7c3a18 PS3, Line 155: $(OPT_EFS_SPI_MICRON_FLAG) \ > same comment as above Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24499ff6daf7878b12b6044496f53379116c598f Gerrit-Change-Number: 58871 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 10 Nov 2021 10:42:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Call the set_efs_table for Stoneyridge
by Bao Zheng (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge. Hello build bot (Jenkins), Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58871 to look at the new patch set (#6). Change subject: amdfwtool: Call the set_efs_table for Stoneyridge ...................................................................... amdfwtool: Call the set_efs_table for Stoneyridge Related to https://review.coreboot.org/c/coreboot/+/58555 Need to test if it works on Stoneyridge platform Change-Id: I24499ff6daf7878b12b6044496f53379116c598f Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/soc/amd/stoneyridge/Makefile.inc M util/amdfwtool/amdfwtool.c 2 files changed, 10 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/58871/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/58871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24499ff6daf7878b12b6044496f53379116c598f Gerrit-Change-Number: 58871 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Set soc name for Stoneyridge
by Bao Zheng (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge, Felix Held. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Marshall Dawson, Richard Spiegel, Zheng Bao, Matt Papageorge, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58555 to look at the new patch set (#10). Change subject: amdfwtool: Set soc name for Stoneyridge ...................................................................... amdfwtool: Set soc name for Stoneyridge For the stoneyridge, soc_name is not set in Makefile, so set_efs_table is not called. Keep it unchanged. Change-Id: I0e82188ce64733420a578446e22a077ef789be92 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M src/soc/amd/stoneyridge/Makefile.inc M util/amdfwtool/amdfwtool.c 2 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/58555/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/58555 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e82188ce64733420a578446e22a077ef789be92 Gerrit-Change-Number: 58555 Gerrit-PatchSet: 10 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Matt Papageorge <matthewpapa07(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: driver/intel/mipi_camera: Add support for _DSC field
by Varshit B Pandya (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Patrick Rudolph. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58767 ) Change subject: driver/intel/mipi_camera: Add support for _DSC field ...................................................................... Patch Set 7: (3 comments) File src/drivers/intel/mipi_camera/camera.c: https://review.coreboot.org/c/coreboot/+/58767/comment/283b2aa3_9d112a4e PS6, Line 852: 0x4 > I think you meant defining this in chip. […] Done File src/drivers/intel/mipi_camera/camera.c: https://review.coreboot.org/c/coreboot/+/58767/comment/2e00ac3f_47200d88 PS7, Line 851: acpi_dsc > > how about dstate_during_kernel_probe ? […] Done File src/drivers/intel/mipi_camera/chip.h: https://review.coreboot.org/c/coreboot/+/58767/comment/3361988d_006847b6 PS5, Line 260: acpi_dsc; > I think subrata meant to remove the if condition in the camera. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/58767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5471f144918413a2982f86beaf3dbf7e4e66cc9b Gerrit-Change-Number: 58767 Gerrit-PatchSet: 7 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 10 Nov 2021 10:40:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: driver/intel/mipi_camera: Add support for _DSC field
by Varshit B Pandya (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/58767 to look at the new patch set (#8). Change subject: driver/intel/mipi_camera: Add support for _DSC field ...................................................................... driver/intel/mipi_camera: Add support for _DSC field The _DSC (Device State for Configuration) object evaluates to an integer may be used to tell Linux the highest allowed D state for a device during probe. The support for _DSC requires support from the kernel bus type if the bus driver normally sets the device in D0 state for probe. The D states and thus also the allowed values for _DSC are listed below. Number State Description 0 D0 Device fully powered on 1 D1 2 D2 3 D3hot 4 D3cold Off More details can be found here https://lkml.org/lkml/2021/10/25/397 BUG=none BRANCH=none TEST=Add corresponding field in brya, boot and dump SSDT to check if _DSC field is as per expectation. Name (_ADR, Zero) // _ADR: Address Name (_HID, "OVTI8856") // _HID: Hardware ID Name (_UID, Zero) // _UID: Unique ID Name (_DDN, "Ov 8856 Camera") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) } Method (_DSC, 0, NotSerialized) { Return (0x04) } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I5471f144918413a2982f86beaf3dbf7e4e66cc9b --- M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/mipi_camera/chip.h 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/58767/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/58767 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5471f144918413a2982f86beaf3dbf7e4e66cc9b Gerrit-Change-Number: 58767 Gerrit-PatchSet: 8 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: amdfwtool: Add APCB combo
by build bot (Jenkins) (Code Review) 10 Nov '21

10 Nov '21

Attention is currently required from: Bao Zheng, Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58620 ) Change subject: amdfwtool: Add APCB combo ...................................................................... Patch Set 11: (1 comment) File util/amdfwtool/amdfwtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132834): https://review.coreboot.org/c/coreboot/+/58620/comment/74aa86cb_62370b45 PS11, Line 1615: combo_apcb_bk[combo_index].ins & 0xF, combo_apcb_bk[combo_index].filename); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/58620 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21c2bf7d98ded43848ae8a8bb61d1ded1a277f88 Gerrit-Change-Number: 58620 Gerrit-PatchSet: 11 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Wed, 10 Nov 2021 10:19:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2021