Attention is currently required from: Raul Rangel, Paul Menzel, Jason Glenesk, Felix Held.
Hello build bot (Jenkins), Raul Rangel, ritul guru, Jason Glenesk, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57517
to look at the new patch set (#4).
Change subject: src/vendorcode/amd: Update FSP-M header
......................................................................
src/vendorcode/amd: Update FSP-M header
Add below UPDs:
1. iommu_enable: Allows enable/disable of iommu device.
2. xgbe_port0_mac: Pass xbge port0 mac address.
3. xgbe_port1_mac: Pass xbge port1 mac address.
4. xgbe_port_table: Pass xbge configuration table for port0/1.
5. xgbe_port_config_en: Allows enable/disable of xgbe port0/1.
Change-Id: I5278295a346cb549ec4a983319885a948659a75c
Signed-off-by: Aamir Bohra <aamirbohra(a)gmail.com>
---
M src/vendorcode/amd/fsp/picasso/FspmUpd.h
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/57517/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/57517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5278295a346cb549ec4a983319885a948659a75c
Gerrit-Change-Number: 57517
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra <aamirbohra(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Subrata Banik, EricR Lai.
Matt Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> Hi Matt, […]
Hi Eric,
At the least, I saw it from Gimble, Redrix and Primus.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Matt Chen, Subrata Banik.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
After I select CHROMEOS_WIFI_SAR, I can see CONFIG_DSAR_SET_NUM=0x3 in coreboot.config. You may can ask Kane for help.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:34:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Matt Chen, Subrata Banik.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Hi Matt,
This flag have depends, which project do you tested? Or did you test on brya?
--
To view, visit https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sugnan Prabhu S, Tim Wawrzynczak, Paul Menzel, Subrata Banik, EricR Lai.
Matt Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58951 )
Change subject: drivers/wifi/generic: fix package_size to align with WLAN driver
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
> sar_limits->sar->dsar_set_count = CONFIG_DSAR_SET_NUM; […]
You can run the check in real case.
As I can tell in many ADL-P project with this codes, it is not 0x3, but 0x1 no matter how I tweak the revision byte.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58951
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I18e7d5f658bbf42b7eeed3da330508f14b86c0f8
Gerrit-Change-Number: 58951
Gerrit-PatchSet: 6
Gerrit-Owner: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:25:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment