Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57025 )
Change subject: HACK: Herobrine: Reinit TPM INT gpio after qclib executes
......................................................................
Patch Set 16: Verified-1
(2 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129897):
https://review.coreboot.org/c/coreboot/+/57025/comment/67380b2a_7089b1a3
PS16, Line 220: mainboard_blob_fix();
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129897):
https://review.coreboot.org/c/coreboot/+/57025/comment/fcc6482d_b722ef91
PS16, Line 220: mainboard_blob_fix();
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/57025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c43d120ebb49800c82aec263ff8c215b60c5201
Gerrit-Change-Number: 57025
Gerrit-PatchSet: 16
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 06 Oct 2021 16:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57022 )
Change subject: HACK: Herobrine: Reinit TPM INT GPIO
......................................................................
Patch Set 16:
(3 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129896):
https://review.coreboot.org/c/coreboot/+/57022/comment/fdf330a6_3c64563c
PS16, Line 34:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129896):
https://review.coreboot.org/c/coreboot/+/57022/comment/a523511a_9525dc53
PS16, Line 34:
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-129896):
https://review.coreboot.org/c/coreboot/+/57022/comment/116e4c1b_88ffcda0
PS16, Line 34:
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/57022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30426cc0392a640fb6d3b1d0fafca7e9a67a76c3
Gerrit-Change-Number: 57022
Gerrit-PatchSet: 16
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Comment-Date: Wed, 06 Oct 2021 16:45:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney.
Ravi kumar has uploaded a new patch set (#16) to the change originally created by Shelley Chen. ( https://review.coreboot.org/c/coreboot/+/57022 )
Change subject: HACK: Herobrine: Reinit TPM INT GPIO
......................................................................
HACK: Herobrine: Reinit TPM INT GPIO
We noticed at some point after running the blobs that we started
getting TPM communication errors and realized that some QC blob was
reconfiguring this GPIO during execution. We haven't debugged to
which blob actually does this, so basically reinitializing the TPM
interrupt GPIO excessively to get around this issue for now.
Signed-off-by: Shelley Chen <shchen(a)google.com>
Change-Id: I30426cc0392a640fb6d3b1d0fafca7e9a67a76c3
---
M src/mainboard/google/herobrine/boardid.c
M src/mainboard/google/herobrine/chromeos.c
M src/mainboard/google/herobrine/mainboard.c
3 files changed, 35 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/57022/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/57022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30426cc0392a640fb6d3b1d0fafca7e9a67a76c3
Gerrit-Change-Number: 57022
Gerrit-PatchSet: 16
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Furquan Shaikh, Kyösti Mälkki, Prasad Malisetty.
Hello Shelley Chen, build bot (Jenkins), mturney mturney, Furquan Shaikh, Arthur Heymans, Kyösti Mälkki, Prasad Malisetty,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57614
to look at the new patch set (#9).
Change subject: libpayload: Export PCIe MMCONF from coreboot to libpayload
......................................................................
libpayload: Export PCIe MMCONF from coreboot to libpayload
Add support for passing PCIe MMCONF base from coreboot to
Libpayload. Parsing and saving PCIe MMCONF base address in
lib_sysinfo to allow config access from libpayload arch
specific PCI driver.
Signed-off-by: Prasad Malisetty <pmaliset(a)codeaurora.org>
Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940
---
M payloads/libpayload/Kconfig
M payloads/libpayload/include/coreboot_tables.h
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/coreboot.c
M src/commonlib/include/commonlib/coreboot_tables.h
M src/device/Kconfig
M src/include/boot/coreboot_tables.h
M src/lib/coreboot_table.c
M src/soc/qualcomm/sc7280/Kconfig
9 files changed, 58 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/57614/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/57614
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940
Gerrit-Change-Number: 57614
Gerrit-PatchSet: 9
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57449
to look at the new patch set (#12).
Change subject: Herobrine: sc7280: Add support for audio
......................................................................
Herobrine: sc7280: Add support for audio
Add gpio configuration for target specific i2s ports
BUG=b:182963902
TEST=Validated on qualcomm sc7280 developement board
Signed-off-by: Srinivasa Rao Mandadapu <srivasam(a)codeaurora.org>
Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002
---
M src/mainboard/google/herobrine/board.h
M src/mainboard/google/herobrine/chromeos.c
M src/mainboard/google/herobrine/mainboard.c
3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/57449/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/57449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ce95332f892d5d4acb2755307df84d37feb8002
Gerrit-Change-Number: 57449
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Sandeep Maheswaram, Sudheer Amrabadi, mturney mturney.
Hello build bot (Jenkins), Sandeep Maheswaram,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55378
to look at the new patch set (#35).
Change subject: herobrine: Assert gpio for USB_HUB_LDO_EN
......................................................................
herobrine: Assert gpio for USB_HUB_LDO_EN
Some herobrine variants have USB hub powered by discrete LDO that is
controlled by USB_HUB_LDO_EN gpio. Assert the GPIO on boot.
BUG=b:182963902
TEST=Validated on qualcomm sc7280 development board.
Signed-off-by: Sandeep Maheswaram <sanm(a)codeaurora.org>
Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2
---
M src/mainboard/google/herobrine/mainboard.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/55378/35
--
To view, visit https://review.coreboot.org/c/coreboot/+/55378
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia94e046f9eb0d3ce593f3445e0203a7391c14de2
Gerrit-Change-Number: 55378
Gerrit-PatchSet: 35
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Ravi kumar, Shelley Chen, Sandeep Maheswaram, mturney mturney, Julius Werner.
Hello Shelley Chen, build bot (Jenkins), Sandeep Maheswaram, mturney mturney, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56093
to look at the new patch set (#25).
Change subject: herobrine: Add support for USB initialization
......................................................................
herobrine: Add support for USB initialization
Initializing USB controller driver.
BUG=b:182963902
TEST=Validated USB enumeration on qcom sc7280 development board
Signed-off-by: Sandeep Maheswaram <sanm(a)codeaurora.org>
Change-Id: Ic378352a97e4f3ed89089f1f7545f8ebb172b1f2
---
M src/mainboard/google/herobrine/mainboard.c
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/56093/25
--
To view, visit https://review.coreboot.org/c/coreboot/+/56093
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic378352a97e4f3ed89089f1f7545f8ebb172b1f2
Gerrit-Change-Number: 56093
Gerrit-PatchSet: 25
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Sandeep Maheswaram <sanm(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset