Attention is currently required from: Furquan Shaikh, Julius Werner, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56577 )
Change subject: lib/cbfs: Add HAVE_CBFS_CACHE Kconfig
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I think this makes sense. […]
When I add the CBFS_CACHE() entry to the memlayout, ramstage reports the correct value:
```
coreboot-4.14-2248-ga3f9b16e0549-dirty Thu Oct 14 16:53:49 UTC 2021 ramstage starting (log level: 8)...
RX: main: cbfs_cache->size: 8192
```
What is the behavior when linking with an external that doesn't exist?
__weak extern u8 _##name##_size[];
If I never add the CBFS_CACHE() region to the memlaytout, that symbol is undefined right? Shouldn't it cause a linker error? Or is it expecting the module loader to take care of updating the pointer?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56577
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74434ef9250ff059e7587147b1456aeabbee33aa
Gerrit-Change-Number: 56577
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 14 Oct 2021 20:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel.
Hello build bot (Jenkins), Nico Huber, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56088
to look at the new patch set (#71).
Change subject: mainboard/starlabs: Add StarBook Mk V
......................................................................
mainboard/starlabs: Add StarBook Mk V
https://starlabs.systems/pages/starbook-specification
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
---
M Documentation/distributions.md
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/labtop.md
M MAINTAINERS
A src/mainboard/starlabs/Kconfig
A src/mainboard/starlabs/Kconfig.name
A src/mainboard/starlabs/labtop/Kconfig
A src/mainboard/starlabs/labtop/Kconfig.name
A src/mainboard/starlabs/labtop/Makefile.inc
A src/mainboard/starlabs/labtop/acpi/mainboard.asl
A src/mainboard/starlabs/labtop/acpi/sleep.asl
A src/mainboard/starlabs/labtop/board_info.txt
A src/mainboard/starlabs/labtop/bootblock.c
A src/mainboard/starlabs/labtop/cmos.default
A src/mainboard/starlabs/labtop/cmos.layout
A src/mainboard/starlabs/labtop/dsdt.asl
A src/mainboard/starlabs/labtop/hda_verb.c
A src/mainboard/starlabs/labtop/mainboard.c
A src/mainboard/starlabs/labtop/ramstage.c
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/romstage.h
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/variants.h
A src/mainboard/starlabs/labtop/variants/tgl/Makefile.inc
A src/mainboard/starlabs/labtop/variants/tgl/board.fmd
A src/mainboard/starlabs/labtop/variants/tgl/data.vbt
A src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
A src/mainboard/starlabs/labtop/variants/tgl/devtree.c
A src/mainboard/starlabs/labtop/variants/tgl/gpio.c
A src/mainboard/starlabs/labtop/variants/tgl/hda_verb.c
A src/mainboard/starlabs/labtop/variants/tgl/include/variant/ec.h
A src/mainboard/starlabs/labtop/variants/tgl/include/variant/smi.h
A src/mainboard/starlabs/labtop/variants/tgl/romstage.c
31 files changed, 1,599 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/56088/71
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 71
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel.
Hello build bot (Jenkins), Nico Huber, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56088
to look at the new patch set (#69).
Change subject: mainboard/starlabs: Add Star Labs LabTop series
......................................................................
mainboard/starlabs: Add Star Labs LabTop series
Add support for:
* LabTop Mk III (kbl-r)
* LabTop Mk IV (cml)
* StarBook Mk V (tgl)
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
---
M Documentation/distributions.md
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/labtop.md
M MAINTAINERS
A src/mainboard/starlabs/Kconfig
A src/mainboard/starlabs/Kconfig.name
A src/mainboard/starlabs/labtop/Kconfig
A src/mainboard/starlabs/labtop/Kconfig.name
A src/mainboard/starlabs/labtop/Makefile.inc
A src/mainboard/starlabs/labtop/acpi/mainboard.asl
A src/mainboard/starlabs/labtop/acpi/sleep.asl
A src/mainboard/starlabs/labtop/board_info.txt
A src/mainboard/starlabs/labtop/bootblock.c
A src/mainboard/starlabs/labtop/cmos.default
A src/mainboard/starlabs/labtop/cmos.layout
A src/mainboard/starlabs/labtop/dsdt.asl
A src/mainboard/starlabs/labtop/hda_verb.c
A src/mainboard/starlabs/labtop/mainboard.c
A src/mainboard/starlabs/labtop/ramstage.c
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/romstage.h
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/variants.h
A src/mainboard/starlabs/labtop/variants/tgl/Makefile.inc
A src/mainboard/starlabs/labtop/variants/tgl/board.fmd
A src/mainboard/starlabs/labtop/variants/tgl/data.vbt
A src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
A src/mainboard/starlabs/labtop/variants/tgl/devtree.c
A src/mainboard/starlabs/labtop/variants/tgl/gpio.c
A src/mainboard/starlabs/labtop/variants/tgl/hda_verb.c
A src/mainboard/starlabs/labtop/variants/tgl/include/variant/ec.h
A src/mainboard/starlabs/labtop/variants/tgl/include/variant/smi.h
A src/mainboard/starlabs/labtop/variants/tgl/romstage.c
31 files changed, 1,599 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/56088/69
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 69
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58346 )
Change subject: Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I8023c26de23c874c84106fda96e64dcfa0c5ba32
......................................................................
Patch Set 1:
(12 comments)
File src/ec/starlabs/merlin/acpi/ec.asl:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/67e79cfd_6993507e
PS1, Line 101: Return (Local1) // Return incase Arg0 doesnt exist
'incase' may be misspelled - perhaps 'in case'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/54270910_68ebdb09
PS1, Line 101: Return (Local1) // Return incase Arg0 doesnt exist
'doesnt' may be misspelled - perhaps 'doesn't'?
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/ea865237_ea0c1a26
PS1, Line 70: switch (get_uint_option("kbl_timeout", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/7abcee6f_1485f339
PS1, Line 97: switch (get_uint_option("fn_ctrl_swap", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/bd29921e_1792e33e
PS1, Line 115: switch (get_uint_option("max_charge", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/5c1ed9e4_ae8bc150
PS1, Line 123: ec_write(ECRAM_MAX_CHARGE, CHARGE_100);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/5fd15e81_86808933
PS1, Line 123: ec_write(ECRAM_MAX_CHARGE, CHARGE_100);
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/1091b63e_ac5b11b5
PS1, Line 136: switch (get_uint_option("fan_mode", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/37820437_63362941
PS1, Line 157: switch (get_uint_option("fn_lock_state", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/27c28e9b_111fe16e
PS1, Line 175: switch (get_uint_option("trackpad_state", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/e5d831ca_441c232d
PS1, Line 193: switch (get_uint_option("kbl_brightness", 0)) {
switch and case should be at the same indent
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130456):
https://review.coreboot.org/c/coreboot/+/58346/comment/be153d40_31fc9183
PS1, Line 220: switch (get_uint_option("kbl_state", 0)) {
switch and case should be at the same indent
--
To view, visit https://review.coreboot.org/c/coreboot/+/58346
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9101d014561d8c983d5748756acb4f45d347cfce
Gerrit-Change-Number: 58346
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 20:22:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ethan Tsao, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Raj Astekar, Patrick Rudolph.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58317 )
Change subject: soc/intel/common/acpi: Correct IPC sub command for reading LPM requirement
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi, Cliff,
Can you check with this patch for ADL?
We need this fix as we got failure in other platform.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58509f14f1e67472adda78e65c3a2e3ee9210765
Gerrit-Change-Number: 58317
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Ethan Tsao <ethan.tsao(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 14 Oct 2021 20:09:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/57045 )
Change subject: ec/starlabs/it8987: Add model specific methods
......................................................................
Abandoned
Outdated
--
To view, visit https://review.coreboot.org/c/coreboot/+/57045
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a28ec647f1061d20478f18e6f0628f9aca972b9
Gerrit-Change-Number: 57045
Gerrit-PatchSet: 13
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/55263 )
Change subject: ec/starlabs/it5570: Add Star Labs ITE 5570E support
......................................................................
Abandoned
Outdated
--
To view, visit https://review.coreboot.org/c/coreboot/+/55263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52287cd3c7606aa210621bb491665410c6fcab96
Gerrit-Change-Number: 55263
Gerrit-PatchSet: 34
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: abandon