John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports
......................................................................
mb/google/volteer: Add support for USB Type-C ports
Two usb type-c ports under the actual Mux device. Each port has
its own ACPI device entry (node). These nodes are the ones that
the USB Type-C port/connnector devices will refer to in order
to configure the mux.
BUG=b:151646486
BRANCH=None
TEST=Verify USB Type-C alternate mode (DP or TBT) along wth PMC control.
Change-Id: I4b443a1ca1c5361652a69586b340b1c95e9c3f06
Signed-off-by: John Zhao <john.zhao(a)intel.com>
---
A src/mainboard/google/volteer/acpi/usbc.asl
M src/mainboard/google/volteer/dsdt.asl
2 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/40425/1
diff --git a/src/mainboard/google/volteer/acpi/usbc.asl b/src/mainboard/google/volteer/acpi/usbc.asl
new file mode 100644
index 0000000..b185b2f
--- /dev/null
+++ b/src/mainboard/google/volteer/acpi/usbc.asl
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */
+
+Scope (\_SB.PCI0.PMC.MUX) {
+ /*
+ * Mux driver looks for usb type-C devices underneath it through
+ * _DSD and _ADR, where _ADR specifies the device address on the
+ * parent bus. CON0 is representing the first type-C port and CON1
+ * is representing the second.
+ */
+ Device (CON0)
+ {
+ Name (_ADR, 0)
+ /*
+ * These properties should have the values that the driver needs
+ * to supply to the PMC via IPC when the muxes are being
+ * configured.
+ */
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package() {
+ Package () { "usb2-port", 6 },
+ Package () { "usb3-port", 3 },
+ Package () { "sbu-orientation", "normal" },
+ Package () { "hsl-orientation", "normal" },
+ },
+ })
+ }
+
+ Device (CON1)
+ {
+ Name (_ADR, 1)
+ Name (_DSD, Package () {
+ ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+ Package() {
+ Package () { "usb2-port", 5 },
+ Package () { "usb3-port", 2 },
+ Package () { "sbu-orientation", "normal" },
+ Package () { "hsl-orientation", "normal" },
+ },
+ })
+ }
+}
diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl
index 640f7cd..1888267 100644
--- a/src/mainboard/google/volteer/dsdt.asl
+++ b/src/mainboard/google/volteer/dsdt.asl
@@ -50,4 +50,7 @@
/* Camera */
#include <soc/intel/tigerlake/acpi/ipu.asl>
#include "acpi/mipi_camera.asl"
+
+ /* usbc */
+ #include "acpi/usbc.asl"
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/40425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b443a1ca1c5361652a69586b340b1c95e9c3f06
Gerrit-Change-Number: 40425
Gerrit-PatchSet: 1
Gerrit-Owner: John Zhao <john.zhao(a)intel.com>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45478 )
Change subject: [UNTESTED]cpu/x86/mp_init.c: Print out the SMM save state revision when relocating
......................................................................
[UNTESTED]cpu/x86/mp_init.c: Print out the SMM save state revision when relocating
This can be used to determine the save state revision of a CPU.
Change-Id: I751d226a9de60f5dd03fd2bcb8c473bdbd5923a0
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/cpu/x86/mp_init.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/45478/1
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index caed8f4..3a48f1a 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -721,6 +721,8 @@
return;
}
+ printk(BIOS_DEBUG, "SMM save state revision: 0x%x\n", smm_revision());
+
/*
* The permanent handler runs with all cpus concurrently. Precalculate
* the location of the new SMBASE. If using SMM modules then this
--
To view, visit https://review.coreboot.org/c/coreboot/+/45478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I751d226a9de60f5dd03fd2bcb8c473bdbd5923a0
Gerrit-Change-Number: 45478
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37297 )
Change subject: mb/lenovo/x220/devicetree: Use subsystemid inheritance
......................................................................
mb/lenovo/x220/devicetree: Use subsystemid inheritance
Change-Id: Ia9367d03b6f97f1eb8c35045fd7bb79e5f45b535
Signed-off-by: Peter Lemenkov <lemenkov(a)gmail.com>
---
M src/mainboard/lenovo/x220/devicetree.cb
1 file changed, 15 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/37297/1
diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb
index 26fa1a4..5ae1427 100644
--- a/src/mainboard/lenovo/x220/devicetree.cb
+++ b/src/mainboard/lenovo/x220/devicetree.cb
@@ -37,13 +37,11 @@
register "pci_mmio_size" = "1024"
device domain 0 on
- device pci 00.0 on
- subsystemid 0x17aa 0x21db
- end # host bridge
+ subsystemid 0x17aa 0x21db inherit
+
+ device pci 00.0 on end # host bridge
device pci 01.0 off end # PCIe Bridge for discrete graphics
- device pci 02.0 on
- subsystemid 0x17aa 0x21db
- end # vga controller
+ device pci 02.0 on end # vga controller
chip southbridge/intel/bd82x6x # Intel Series 6 Cougar Point PCH
# GPI routing
@@ -80,49 +78,29 @@
device pci 19.0 on
subsystemid 0x17aa 0x21ce
end # Intel Gigabit Ethernet
- device pci 1a.0 on
- subsystemid 0x17aa 0x21db
- end # USB2 EHCI #2
- device pci 1b.0 on
- subsystemid 0x17aa 0x21db
- end # High Definition Audio
- device pci 1c.0 on
- subsystemid 0x17aa 0x21db
- end # PCIe Port #1
- device pci 1c.1 on
- subsystemid 0x17aa 0x21db
- end # PCIe Port #2 (wlan)
- device pci 1c.2 on
- subsystemid 0x17aa 0x21db
- end # PCIe Port #3
+ device pci 1a.0 on end # USB2 EHCI #2
+ device pci 1b.0 on end # High Definition Audio
+ device pci 1c.0 on end # PCIe Port #1
+ device pci 1c.1 on end # PCIe Port #2 (wlan)
+ device pci 1c.2 on end # PCIe Port #3
device pci 1c.3 on
- subsystemid 0x17aa 0x21db
smbios_slot_desc "7" "3" "ExpressCard Slot" "8"
end # PCIe Port #4
device pci 1c.4 on
- subsystemid 0x17aa 0x21db
chip drivers/ricoh/rce822
register "sdwppol" = "1"
register "disable_mask" = "0x87"
- device pci 00.0 on
- subsystemid 0x17aa 0x21fa
- end
+ device pci 00.0 on end
end
end # PCIe Port #5 (SD)
device pci 1c.5 off end # PCIe Port #6
- device pci 1c.6 on
- subsystemid 0x17aa 0x21db
- end # PCIe Port #7
+ device pci 1c.6 on end # PCIe Port #7
device pci 1c.7 off end # PCIe Port #8
- device pci 1d.0 on
- subsystemid 0x17aa 0x21db
- end # USB2 EHCI #1
+ device pci 1d.0 on end # USB2 EHCI #1
device pci 1e.0 off end # PCI bridge
device pci 1f.0 on #LPC bridge
- subsystemid 0x17aa 0x21db
chip ec/lenovo/pmh7
- device pnp ff.1 on # dummy
- end
+ device pnp ff.1 on end # dummy
register "backlight_enable" = "0x01"
register "dock_event_enable" = "0x01"
end
@@ -172,11 +150,8 @@
register "wwan_gpio_lvl" = "0"
end
end # LPC bridge
- device pci 1f.2 on
- subsystemid 0x17aa 0x21db
- end # SATA Controller 1
+ device pci 1f.2 on end # SATA Controller 1
device pci 1f.3 on
- subsystemid 0x17aa 0x21db
# eeprom, 8 virtual devices, same chip
chip drivers/i2c/at24rf08c
device i2c 54 on end
@@ -190,9 +165,7 @@
end
end # SMBus
device pci 1f.5 off end # SATA Controller 2
- device pci 1f.6 on
- subsystemid 0x17aa 0x21db
- end # Thermal
+ device pci 1f.6 on end # Thermal
end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/37297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9367d03b6f97f1eb8c35045fd7bb79e5f45b535
Gerrit-Change-Number: 37297
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Peter Lemenkov <lemenkov(a)gmail.com>
Gerrit-MessageType: newchange
Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40815 )
Change subject: [TEST] Enable link time optimization
......................................................................
[TEST] Enable link time optimization
Enable LTO to shake out the bugs.
Current problems:
- GCC does not track symbol origins when using LTO, so it must be
disabled for AGESA so it can be excluded from the illegal_globals check.
- GCC segfaults when compiling ARMV7
- Most of the Google boards do not compile because of a missing
reference to _watchdog_tombstone
Change-Id: I37474d4adbf653729bb2e631a1ff812b4319c17a
Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca>
---
M src/Kconfig
M src/vendorcode/amd/agesa/Makefile.inc
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/40815/1
diff --git a/src/Kconfig b/src/Kconfig
index e4821e8..375bca2 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -116,7 +116,7 @@
config LTO
bool "Use link time optimization (LTO)"
- default n
+ default y
depends on COMPILER_GCC
help
Compile with link time optimization. This can often decrease the
diff --git a/src/vendorcode/amd/agesa/Makefile.inc b/src/vendorcode/amd/agesa/Makefile.inc
index b96af84..3e4a53c 100644
--- a/src/vendorcode/amd/agesa/Makefile.inc
+++ b/src/vendorcode/amd/agesa/Makefile.inc
@@ -14,6 +14,12 @@
AGESA_CFLAGS := -march=k8-sse3 -mtune=k8-sse3 -fno-strict-aliasing
+# GCC currently does not track symbol origins when using LTO, so
+# AGESA gets caught in the illegal_globals check. Disable for now.
+ifeq ($(CONFIG_LTO),y)
+AGESA_CFLAGS += -fno-lto
+endif
+
CFLAGS_x86_32 += $(AGESA_CFLAGS)
CFLAGS_x86_64 += $(AGESA_CFLAGS)
--
To view, visit https://review.coreboot.org/c/coreboot/+/40815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37474d4adbf653729bb2e631a1ff812b4319c17a
Gerrit-Change-Number: 40815
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange