Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42609 )
Change subject: Makefile.inc: Add CARRIER_DIR to component discovery
......................................................................
Makefile.inc: Add CARRIER_DIR to component discovery
The configuration of the COMe module contains an additional carriers
directory, which contains the source codes for configuration for the
different carrierboards into which this module is plugged. Let's take
this into account in the build system to use CARRIER_DIR to select the
type of board in the local Makefile.inc, as it has done for VARIANT_DIR.
Used to build an image for the Kontron COMe-mAL10 module together with
the Kontron Ref.Carrier-i T10 TNI.
Change-Id: Ic6b2f8994b1293ae6f5bda8c9cc95128ba0abf7a
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M Makefile.inc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/42609/1
diff --git a/Makefile.inc b/Makefile.inc
index 86335d9..0f9d635 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -34,6 +34,7 @@
# Basic component discovery
MAINBOARDDIR=$(call strip_quotes,$(CONFIG_MAINBOARD_DIR))
VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR))
+CARRIER_DIR:=$(call strip_quotes,$(CONFIG_CARRIER_DIR))
COREBOOT_EXPORTS += MAINBOARDDIR VARIANT_DIR
## Final build results, which CBFSTOOL uses to create the final
--
To view, visit https://review.coreboot.org/c/coreboot/+/42609
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b2f8994b1293ae6f5bda8c9cc95128ba0abf7a
Gerrit-Change-Number: 42609
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37280 )
Change subject: soc/intel/fsp-car: Halt on improperly configured coreboot
......................................................................
soc/intel/fsp-car: Halt on improperly configured coreboot
Test if Kconfig symbols actually match what FSP does. If it is not
the case it best to halt right away instead of continuing to boot with
possibly hard to debug problems.
Change-Id: I8520adc868f08938af27ee686a8777c281afd4f9
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/37280/1
diff --git a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
index 4174f36..bde3849 100644
--- a/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
+++ b/src/soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
@@ -86,6 +86,11 @@
cmp $0, %eax
jnz .halt_forever
+ /* Check sanity of coreboot Kconfig symbols that need to match what FSP
+ does */
+ cmpl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %edx
+ jne .halt_forever
+
/* Setup bootblock stack */
movl _ecar_stack, %esp
--
To view, visit https://review.coreboot.org/c/coreboot/+/37280
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8520adc868f08938af27ee686a8777c281afd4f9
Gerrit-Change-Number: 37280
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37281 )
Change subject: drivers/intel/fsp1.1/car: Halt on improperly configured coreboot
......................................................................
drivers/intel/fsp1.1/car: Halt on improperly configured coreboot
Test if Kconfig symbols actually match what FSP does. If it is not
the case it best to halt right away instead of continuing to boot with
possibly hard to debug problems.
Change-Id: Ieec8259149cc8fd71c40fd1511a6a2cfa67c5337
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/drivers/intel/fsp1_1/cache_as_ram.S
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/37281/1
diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.S b/src/drivers/intel/fsp1_1/cache_as_ram.S
index fb39884..748c267 100644
--- a/src/drivers/intel/fsp1_1/cache_as_ram.S
+++ b/src/drivers/intel/fsp1_1/cache_as_ram.S
@@ -143,6 +143,11 @@
cmp $0, %eax
jne halt2
+ /* Check sanity of coreboot Kconfig symbols that need to match what FSP
+ does */
+ cmpl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %edx
+ jne .halt_forever
+
/* Setup BSP stack */
movl _ecar_stack, %esp
--
To view, visit https://review.coreboot.org/c/coreboot/+/37281
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec8259149cc8fd71c40fd1511a6a2cfa67c5337
Gerrit-Change-Number: 37281
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange