coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: Documentation/Intel: s5 charging applet design document
by Subrata Banik (Code Review) 18 Mar '20

18 Mar '20

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 ) Change subject: Documentation/Intel: s5 charging applet design document ...................................................................... Patch Set 4: -Code-Review (1 comment) https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5… File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md: https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/… [View More]

1 0

Change in coreboot[master]: Documentation/Intel: s5 charging applet design document
by Paul Menzel (Code Review) 18 Mar '20

18 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 ) Change subject: Documentation/Intel: s5 charging applet design document ...................................................................... Patch Set 4: (3 comments) https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5… File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md: https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5… … [View More]

1 0

Change in coreboot[master]: Documentation/Intel: s5 charging applet design document
by Paul Menzel (Code Review) 18 Mar '20

18 Mar '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 ) Change subject: Documentation/Intel: s5 charging applet design document ...................................................................... Patch Set 4: Code-Review-1 (3 comments) Discussion should happen on the mailing list. Please announce it there. https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/37762/4//COMMIT_MSG@… [View More]

1 0

Change in coreboot[master]: AUTHORS: Add authors from util/
by Patrick Georgi (Code Review) 18 Mar '20

18 Mar '20

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39616 ) Change subject: AUTHORS: Add authors from util/ ...................................................................... AUTHORS: Add authors from util/ Remove the list of converted trees now that all are in here. Removal can be a separate step, but from now on the expectation is that new authors add themselves to AUTHORS. Change-Id: Ic0bd0f05a38547a139b90d17f3872f31392bd8a3 Signed-off-by: … [View More]Patrick Georgi <pgeorgi(a)google.com> --- M AUTHORS 1 file changed, 30 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/39616/1 diff --git a/AUTHORS b/AUTHORS index f3c0aaa..2534a46 100644 --- a/AUTHORS +++ b/AUTHORS @@ -15,14 +15,17 @@ Advanced Micro Devices, Inc. AdaCore AG Electronics Ltd. +Alex Thiessen Alex Züpke Alexander Couzens Alexandru Gagniuc Analog Devices Inc. Analogix Semiconductor Andre Heider +Andriy Gapon Andy Fleming Angel Pons +Anton Kochkov ARM Limited and Contributors Arthur Heymans Asami Doi @@ -32,12 +35,14 @@ BAP - Bruhnspace Advanced Projects Bill Xie Bitland Tech Inc. +Boris Barbulovski Carl-Daniel Hailfinger Cavium Inc. Christoph Grenz Code Aurora Forum coresystems GmbH Corey Osgood +Curt Brune Damien Zammit Dave Airlie David Brownell @@ -45,8 +50,10 @@ David Hendricks David Mosberger-Tang David Mueller +Denis 'GNUtoo' Carikli Denis Dowling DENX Software Engineering +Derek Waldner Digital Design Corporation DMP Electronics Inc. Drew Eckhardt @@ -90,8 +97,10 @@ Ivan Vatlin James Ye Jason Zhao +Joe Pillow Johanna Schander Jonas 'Sortie' Termansen +Jonathan A. Kollasch Jonathan Neuschäfer Jordan Crouse Joseph Smith @@ -102,6 +111,7 @@ Kontron Europe GmbH Kshitij Kyösti Mälkki +Leah Rowe Lei Wen Li-Ta Lo Libra Li @@ -110,6 +120,7 @@ Linus Torvalds Linux Networx, Inc. LiPPERT ADLINK Technology GmbH +Lubomir Rintel Luc Verhaegen Maciej Matuszczyk Marc Bertens @@ -118,12 +129,14 @@ Marius Gröger Martin Mares Martin Renters +Martin Roth Marvell International Ltd. Marvell Semiconductor Inc. Matt DeVillier Maxim Polyakov MediaTek Inc. Michael Schroeder +Michael Niewöhner Mika Westerberg Mondrian Nuessle MontaVista Software, Inc. @@ -134,8 +147,11 @@ Nico Huber Nico Rikken Nicola Corna +Nils Jacobs +Nir Tzachar Nokia Corporation NVIDIA Corporation +Olivier Langlois Ollie Lo Omar Pakker Online SAS @@ -149,6 +165,7 @@ Per Odlund Peter Stuge Philipp Degler +Philipp Deppenwiese Philipp Hug Protectli Purism SPC @@ -159,17 +176,24 @@ Renze Nicolai Richard Spiegel Richard Woodruff +Rob Landley Robert Reeves +Robinson P. Tryon Rockchip, Inc. +Romain Lievin +Roman Zippel Ronald G. Minnich Rudolf Marek Russell King +Ruud Schramp Sage Electronic Engineering, LLC +Sam Ravnborg Samsung Electronics Samuel Holland SciTech Software, Inc. Sebastian Grzywna secunet Security Networks AG +Sencore Inc Sergej Ivanov Siemens AG SiFive, Inc @@ -178,12 +202,14 @@ Stefan Reinauer Stefan Tauner Steve Magnani +Steve Shenton ST Microelectronics SUSE LINUX AG Sven Schnelle Syed Mohammed Khasim System76 Texas Instruments +The Android Open Source Project The ChromiumOS Authors The Linux Foundation The Regents of the University of California @@ -197,25 +223,17 @@ University of Heidelberg Uwe Hermann VIA Technologies, Inc +Vikram Narayanan Vipin Kumar Vladimir Serbinenko Vlado Cibic Wang Qing Pei Ward Vandewege +Wilbert Duijvenvoorde Win Enterprises Wiwynn Corp. Wolfgang Denk +YADRO Yann Collet Yinghai Lu - - - -# Directories transferred -src/acpi -src/arch -src/commonlib -src/console -src/cpu -src/device -src/drivers -src/superio +Zachary Yedidia -- To view, visit https://review.coreboot.org/c/coreboot/+/39616 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic0bd0f05a38547a139b90d17f3872f31392bd8a3 Gerrit-Change-Number: 39616 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: newchange [View Less]

5 5

Change in coreboot[master]: util/inteltool: powermgt: make Sunrise Point dumping work
by 9elements QA (Code Review) 18 Mar '20

18 Mar '20

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39508 ) Change subject: util/inteltool: powermgt: make Sunrise Point dumping work ...................................................................... Patch Set 8: Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1422 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.… [View More]

1 0

Change in coreboot[master]: util/inteltool: powermgt: add code for dumping config registers
by Felix Held (Code Review) 18 Mar '20

18 Mar '20

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39509 ) Change subject: util/inteltool: powermgt: add code for dumping config registers ...................................................................... Patch Set 8: (2 comments) https://review.coreboot.org/c/coreboot/+/39509/8/util/inteltool/powermgt.c File util/inteltool/powermgt.c: https://review.coreboot.org/c/coreboot/+/39509/8/util/inteltool/powermgt.c@… PS8, Line 678: struct pci_dev *… [View More]

1 0

Change in coreboot[master]: util/inteltool: powermgt: make Sunrise Point dumping work
by Felix Held (Code Review) 18 Mar '20

18 Mar '20

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39508 ) Change subject: util/inteltool: powermgt: make Sunrise Point dumping work ...................................................................... util/inteltool: powermgt: make Sunrise Point dumping work The existing Sunrise Point ids are assigned to the wrong implementation, which would never work for these chipsets. Assign them to the right dumping implementation, which works for both Sunrise Point PCH-… [View More]H and PCH-LP. This also adds some missing device ids from doc#332691-003EN and doc#334659-005. Change-Id: Id102ef3809d675dc9a915d2cb3062e093487fa27 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39508 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M util/inteltool/powermgt.c 1 file changed, 23 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/util/inteltool/powermgt.c b/util/inteltool/powermgt.c index 3f489b8..70f8c48 100644 --- a/util/inteltool/powermgt.c +++ b/util/inteltool/powermgt.c @@ -745,16 +745,6 @@ case PCI_DEVICE_ID_INTEL_C224: case PCI_DEVICE_ID_INTEL_C226: case PCI_DEVICE_ID_INTEL_H81: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_SKL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_SKL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_SKL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_KBL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_KBL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_KBL: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_BASE: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_PREM: - case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_IHDCP_PREM: pmbase = pci_read_word(sb, 0x40) & 0xff80; pm_registers = pch_pm_registers; pm_registers_size = ARRAY_SIZE(pch_pm_registers); @@ -828,15 +818,35 @@ pm_registers = i82371xx_pm_registers; pm_registers_size = ARRAY_SIZE(i82371xx_pm_registers); break; - case PCI_DEVICE_ID_INTEL_I63XX: pmbase = pci_read_word(sb, 0x40) & 0xfffc; pm_registers = i63xx_pm_registers; pm_registers_size = ARRAY_SIZE(i63xx_pm_registers); break; - - case PCI_DEVICE_ID_INTEL_CM236: + case PCI_DEVICE_ID_INTEL_H110: + case PCI_DEVICE_ID_INTEL_H170: + case PCI_DEVICE_ID_INTEL_Z170: + case PCI_DEVICE_ID_INTEL_Q170: + case PCI_DEVICE_ID_INTEL_Q150: + case PCI_DEVICE_ID_INTEL_B150: case PCI_DEVICE_ID_INTEL_C236: + case PCI_DEVICE_ID_INTEL_C232: + case PCI_DEVICE_ID_INTEL_QM170: + case PCI_DEVICE_ID_INTEL_HM170: + case PCI_DEVICE_ID_INTEL_CM236: + case PCI_DEVICE_ID_INTEL_HM175: + case PCI_DEVICE_ID_INTEL_QM175: + case PCI_DEVICE_ID_INTEL_CM238: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_PRE: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_SKL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_SKL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_SKL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_BASE_KBL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_PREM_KBL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_PREM_KBL: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_BASE: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_U_IHDCP_PREM: + case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_Y_IHDCP_PREM: case PCI_DEVICE_ID_INTEL_CANNONPOINT_LP_U_PREM: acpi = pci_get_dev(pacc, sb->domain, sb->bus, sb->dev, 2); if (!acpi) { -- To view, visit https://review.coreboot.org/c/coreboot/+/39508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id102ef3809d675dc9a915d2cb3062e093487fa27 Gerrit-Change-Number: 39508 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged [View Less]

1 0

Change in coreboot[master]: util/inteltool: powermgt: make Sunrise Point dumping work
by Felix Held (Code Review) 18 Mar '20

18 Mar '20

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39508 ) Change subject: util/inteltool: powermgt: make Sunrise Point dumping work ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id:… [View More]

1 0

Change in coreboot[master]: mb/google/deltaur: add deltaur mainboard initial support
by Bora Guvendik (Code Review) 18 Mar '20

18 Mar '20

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39502 ) Change subject: mb/google/deltaur: add deltaur mainboard initial support ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/39502/5/src/mainboard/google/delta… File src/mainboard/google/deltaur/chromeos.fmd: https://review.coreboot.org/c/coreboot/+/39502/5/src/mainboard/google/delta… PS5, Line 5: … [View More]

1 0

Change in coreboot[master]: mb/google/deltaur: add deltaur mainboard initial support
by Bora Guvendik (Code Review) 18 Mar '20

18 Mar '20

Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Selma Bensaid, Tim Wawrzynczak, Duncan Laurie, EricR Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39502 to look at the new patch set (#6). Change subject: mb/google/deltaur: add deltaur mainboard initial support ...................................................................... mb/google/deltaur: add deltaur mainboard initial support Created a new Google baseboard named … [View More]deltaur, taking volteer as a starting point. BUG=b:151102807 TEST=make build successful Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> Change-Id: Ib98f328df22f39e7d9d625a3292954881ee15b15 --- A src/mainboard/google/deltaur/Kconfig A src/mainboard/google/deltaur/Kconfig.name A src/mainboard/google/deltaur/Makefile.inc A src/mainboard/google/deltaur/board_info.txt A src/mainboard/google/deltaur/bootblock.c A src/mainboard/google/deltaur/chromeos.c A src/mainboard/google/deltaur/chromeos.fmd A src/mainboard/google/deltaur/dsdt.asl A src/mainboard/google/deltaur/ec.c A src/mainboard/google/deltaur/mainboard.c A src/mainboard/google/deltaur/smihandler.c A src/mainboard/google/deltaur/variants/baseboard/Makefile.inc A src/mainboard/google/deltaur/variants/baseboard/devicetree.cb A src/mainboard/google/deltaur/variants/baseboard/gpio.c A src/mainboard/google/deltaur/variants/baseboard/include/baseboard/ec.h A src/mainboard/google/deltaur/variants/baseboard/include/baseboard/gpio.h A src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h A src/mainboard/google/deltaur/variants/deltan/Makefile.inc A src/mainboard/google/deltaur/variants/deltan/gpio.c A src/mainboard/google/deltaur/variants/deltan/include/variant/ec.h A src/mainboard/google/deltaur/variants/deltan/include/variant/gpio.h A src/mainboard/google/deltaur/variants/deltan/overridetree.cb A src/mainboard/google/deltaur/variants/deltaur/Makefile.inc A src/mainboard/google/deltaur/variants/deltaur/gpio.c A src/mainboard/google/deltaur/variants/deltaur/include/variant/ec.h A src/mainboard/google/deltaur/variants/deltaur/include/variant/gpio.h A src/mainboard/google/deltaur/variants/deltaur/overridetree.cb 27 files changed, 841 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/39502/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/39502 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib98f328df22f39e7d9d625a3292954881ee15b15 Gerrit-Change-Number: 39502 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Bernardo Perez Priego <bernardo.perez.priego(a)intel.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.corp-partner.google.com> Gerrit-CC: Varun Joshi <varun.joshi(a)intel.com> Gerrit-MessageType: newpatchset [View Less]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020