coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: util/inteltool: add code for dumping GSPI registers
by Felix Held (Code Review) 21 Mar '20

21 Mar '20

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39520 ) Change subject: util/inteltool: add code for dumping GSPI registers ...................................................................... Patch Set 14: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39520 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf21f51bcf6e10ba8e4e8061466fecaca11f294f Gerrit-Change-Number: 39520 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:38:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add code for dumping SMBus registers
by Felix Held (Code Review) 21 Mar '20

21 Mar '20

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39519 ) Change subject: util/inteltool: add code for dumping SMBus registers ...................................................................... Patch Set 14: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/39519/14/util/inteltool/smbus.c File util/inteltool/smbus.c: https://review.coreboot.org/c/coreboot/+/39519/14/util/inteltool/smbus.c@125 PS14, Line 125: smbus SMBus? https://review.coreboot.org/c/coreboot/+/39519/14/util/inteltool/smbus.c@132 PS14, Line 132: is it intended that here are less spaces than in the same print statements below? -- To view, visit https://review.coreboot.org/c/coreboot/+/39519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I73f1e1544ceccfa538bb9b0a8c21e10fc42bedb6 Gerrit-Change-Number: 39519 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add code to dump I2C registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39518 ) Change subject: util/inteltool: add code to dump I2C registers ...................................................................... Patch Set 12: (1 comment) The code assumes PCI devices anyway, so why not make the `switch` on their DID instead of the PCH's? Or maybe `libpci` can even filter the devices, idk. https://review.coreboot.org/c/coreboot/+/39518/12/util/inteltool/i2c.c File util/inteltool/i2c.c: https://review.coreboot.org/c/coreboot/+/39518/12/util/inteltool/i2c.c@210 PS12, Line 210: if (i2c) The block above already presumes that `i2c` is set. Generally, the if/for depth goes way too far here. Adding some functions might help, e.g. one to print the MMIO regs, one that prints the PCI config (and calls the former). That would allow us to stay flexible enough in case somebody wants to add support for hidden (ACPI mode) controllers. -- To view, visit https://review.coreboot.org/c/coreboot/+/39518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f97d4fe1695750458920d3c14b35cd51c334225 Gerrit-Change-Number: 39518 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:28:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add code to dump I2C registers
by Felix Held (Code Review) 21 Mar '20

21 Mar '20

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39518 ) Change subject: util/inteltool: add code to dump I2C registers ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/39518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f97d4fe1695750458920d3c14b35cd51c334225 Gerrit-Change-Number: 39518 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:23:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39566 ) Change subject: util/inteltool: spi: add Sunrise Point config registers ...................................................................... Patch Set 6: Code-Review+1 (1 comment) https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c File util/inteltool/spi.c: https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c@66 PS6, Line 66: { 0x00, 4, "BIOS_SPI_DID_VID - Device ID and Vendor ID" }, : { 0x04, 4, "BIOS_SPI_STS_CMD - Status and Command" }, : { 0x08, 4, "BIOS_SPI_CC_RID - Revision ID" }, : { 0x0c, 4, "BIOS_SPI_BIST_HTYPE_LT_CLS - BIST, Header Type, Latency Timer, Cache Line Size" }, : { 0x10, 4, "BIOS_SPI_BAR0 - SPI BAR0 MMIO" }, Does this make sense? those are standard PCI registers, `lspci` has nicer output for them. -- To view, visit https://review.coreboot.org/c/coreboot/+/39566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Gerrit-Change-Number: 39566 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:16:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add code for dumping config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39565 ) Change subject: util/inteltool: spi: add code for dumping config registers ...................................................................... Patch Set 6: (1 comment) Maybe call it `pci` or `pci_cfg`? Took me a moment to realize what `cfg` is about. https://review.coreboot.org/c/coreboot/+/39565/6/util/inteltool/spi.c File util/inteltool/spi.c: https://review.coreboot.org/c/coreboot/+/39565/6/util/inteltool/spi.c@439 PS6, Line 439: pci_free_dev(spi); I suppose this was missing in the previous patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/39565 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcf6b41ea6eb3fc654872c60fb4298b65ea95932 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: make Sunrise Point dumping work
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39564 ) Change subject: util/inteltool: spi: make Sunrise Point dumping work ...................................................................... Patch Set 5: Code-Review+1 (2 comments) https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c File util/inteltool/spi.c: https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c@94 PS5, Line 94: { 0xd4, 4, "BIOS_SBRS - SPI Bus Requester Status" }, Do we have to prefix everything with BIOS_? I know the datasheets do... https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c@406 PS5, Line 406: ; one ; should be enough :) -- To view, visit https://review.coreboot.org/c/coreboot/+/39564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d4dae07d493414d6c7a0c4593ff28dd5b60faa Gerrit-Change-Number: 39564 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 13:02:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: gpio add code for dumping GPIO Community cfg registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39511 ) Change subject: util/inteltool: gpio add code for dumping GPIO Community cfg registers ...................................................................... Patch Set 10: (6 comments) https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_groups… File util/inteltool/gpio_groups.c: https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_groups… PS7, Line 82: if (community->community_cfg_registers) { `_size` should be 0 too, so we don't need this `if` Should we give these register prints a heading? https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/… File util/inteltool/gpio_names/gpio_groups.h: https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/… PS7, Line 14: community_ no need to mention `community` again and again https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/… PS7, Line 15: size `count` like below? https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h File util/inteltool/inteltool.h: https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h… PS7, Line 385: uint16_t Can we be sure, 16 bits are enough? https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h… PS7, Line 385: typedef struct { uint16_t addr; char *name; } gpiocom_register_t; It doesn't seem to become part of a global API, so why declare it here? In case you move it, please also get rid of the typedef ;) https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h… PS7, Line 385: char const char? -- To view, visit https://review.coreboot.org/c/coreboot/+/39511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I493584e74293d5eb15780f781cb69159bbf5383b Gerrit-Change-Number: 39511 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 12:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: gpio: add Sunrise Point GPIO Community config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39512 ) Change subject: util/inteltool: gpio: add Sunrise Point GPIO Community config registers ...................................................................... Patch Set 11: (3 comments) The numbers seem correct, but why does everything look red know? ^^ https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/… File util/inteltool/gpio_names/sunrise.h: https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/… PS8, Line 8: C please keep the lower-case hex style. https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/… PS8, Line 34: }; also applies to LP version https://review.coreboot.org/c/coreboot/+/39512/8/util/inteltool/gpio_names/… PS8, Line 581: .community_cfg_registers_size = ARRAY_SIZE(sunrise_community_ab_cfg_registers), Please maintain alignment of the = -- To view, visit https://review.coreboot.org/c/coreboot/+/39512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ea094878252925f01bea80cc8cf60daf4491061 Gerrit-Change-Number: 39512 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 12:30:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39566 ) Change subject: util/inteltool: spi: add Sunrise Point config registers ...................................................................... Uploaded patch set 6: Patch Set 5 was rebased. -- To view, visit https://review.coreboot.org/c/coreboot/+/39566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Gerrit-Change-Number: 39566 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 12:22:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020