coreboot-gerrit March 2020

coreboot-gerrit@coreboot.org

1 participants
3326 discussions

Change in coreboot[master]: util/inteltool: spi: make Sunrise Point dumping work
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39564 ) Change subject: util/inteltool: spi: make Sunrise Point dumping work ...................................................................... Uploaded patch set 6. -- To view, visit https://review.coreboot.org/c/coreboot/+/39564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d4dae07d493414d6c7a0c4593ff28dd5b60faa Gerrit-Change-Number: 39564 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 17:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: make Sunrise Point dumping work
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Patrick Rudolph, Paul Menzel, Stefan Reinauer, Angel Pons, Mimoja, Aaron Durbin, Nico Huber, Maxim Polyakov, Idwer Vollering, Christian Walter, Felix Held, HAOUAS Elyes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39564 to look at the new patch set (#6). Change subject: util/inteltool: spi: make Sunrise Point dumping work ...................................................................... util/inteltool: spi: make Sunrise Point dumping work The implementation for Sunrise Point-LP SPI interface could never work because the whole addressing scheme changed. The correct implementation has been added, which works for both Sunrise Point PCH-H and PCH-LP. This also adds some missing device ids from doc#332691-003EN and doc#334659-005. Change-Id: Ib7d4dae07d493414d6c7a0c4593ff28dd5b60faa Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/inteltool/inteltool.c M util/inteltool/inteltool.h M util/inteltool/spi.c 3 files changed, 79 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/39564/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/39564 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7d4dae07d493414d6c7a0c4593ff28dd5b60faa Gerrit-Change-Number: 39564 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

1 0

Change in coreboot[master]: util/inteltool: gpio: add Sunrise Point GPIO Community config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39512 ) Change subject: util/inteltool: gpio: add Sunrise Point GPIO Community config registers ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… File util/inteltool/gpio_names/sunrise.h: https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… PS12, Line 261: 0x013 > 0x013 eh, you know what I mean -- To view, visit https://review.coreboot.org/c/coreboot/+/39512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ea094878252925f01bea80cc8cf60daf4491061 Gerrit-Change-Number: 39512 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 15:29:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: gpio: add Sunrise Point GPIO Community config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39512 ) Change subject: util/inteltool: gpio: add Sunrise Point GPIO Community config registers ...................................................................... Patch Set 12: (4 comments) https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… File util/inteltool/gpio_names/sunrise.h: https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… PS12, Line 64: }; it's still exactly the same as the non-LP version, or did I miss something? https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… PS12, Line 84: 0x013 unlikely https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… PS12, Line 209: 0x013 0x010? https://review.coreboot.org/c/coreboot/+/39512/12/util/inteltool/gpio_names… PS12, Line 261: 0x013 0x013 -- To view, visit https://review.coreboot.org/c/coreboot/+/39512 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ea094878252925f01bea80cc8cf60daf4491061 Gerrit-Change-Number: 39512 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 15:28:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add code to dump I2C registers
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39518 ) Change subject: util/inteltool: add code to dump I2C registers ...................................................................... Patch Set 12: (1 comment) https://review.coreboot.org/c/coreboot/+/39518/12/util/inteltool/i2c.c File util/inteltool/i2c.c: https://review.coreboot.org/c/coreboot/+/39518/12/util/inteltool/i2c.c@210 PS12, Line 210: if (i2c) > The block above already presumes that `i2c` is set. Generally, the if/for […] Not right if i2c_cfg_registers_size = 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/39518 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f97d4fe1695750458920d3c14b35cd51c334225 Gerrit-Change-Number: 39518 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 15:07:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39566 ) Change subject: util/inteltool: spi: add Sunrise Point config registers ...................................................................... Uploaded patch set 7. (1 comment) https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c File util/inteltool/spi.c: https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c@66 PS6, Line 66: { 0x00, 4, "BIOS_SPI_DID_VID - Device ID and Vendor ID" }, : { 0x04, 4, "BIOS_SPI_STS_CMD - Status and Command" }, : { 0x08, 4, "BIOS_SPI_CC_RID - Revision ID" }, : { 0x0c, 4, "BIOS_SPI_BIST_HTYPE_LT_CLS - BIST, Header Type, Latency Timer, Cache Line Size" }, : { 0x10, 4, "BIOS_SPI_BAR0 - SPI BAR0 MMIO" }, > There are many more registers than these... we might as well print the […] ack -- To view, visit https://review.coreboot.org/c/coreboot/+/39566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Gerrit-Change-Number: 39566 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 15:03:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Michael Niewöhner (Code Review) 21 Mar '20

21 Mar '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Patrick Rudolph, Paul Menzel, Stefan Reinauer, Angel Pons, Mimoja, Aaron Durbin, Nico Huber, Maxim Polyakov, Idwer Vollering, Christian Walter, HAOUAS Elyes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/39566 to look at the new patch set (#7). Change subject: util/inteltool: spi: add Sunrise Point config registers ...................................................................... util/inteltool: spi: add Sunrise Point config registers This adds the Sunrise Point SPI config registers from doc#332691-003EN. Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M util/inteltool/spi.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/39566/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/39566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Gerrit-Change-Number: 39566 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: gpio add code for dumping GPIO Community cfg registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39511 ) Change subject: util/inteltool: gpio add code for dumping GPIO Community cfg registers ...................................................................... Patch Set 11: (2 comments) https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/… File util/inteltool/gpio_names/gpio_groups.h: https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/gpio_names/… PS7, Line 15: size > I kept the convention naming it _size like I did in all other subsystems IMO, we should stick to conventions of the closest code and (if possible) not break with it in one .c file. Also, `size` often refers to the size in bytes. https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h File util/inteltool/inteltool.h: https://review.coreboot.org/c/coreboot/+/39511/7/util/inteltool/inteltool.h… PS7, Line 385: uint16_t > not 100% sure but I'm not aware of platforms having 32bit cfg register addresses for gpio So why risk it? (nothing to lose btw., the struct will be padded anyway) -- To view, visit https://review.coreboot.org/c/coreboot/+/39511 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I493584e74293d5eb15780f781cb69159bbf5383b Gerrit-Change-Number: 39511 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 14:58:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: spi: add Sunrise Point config registers
by Nico Huber (Code Review) 21 Mar '20

21 Mar '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39566 ) Change subject: util/inteltool: spi: add Sunrise Point config registers ...................................................................... Patch Set 6: (1 comment) https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c File util/inteltool/spi.c: https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c@66 PS6, Line 66: { 0x00, 4, "BIOS_SPI_DID_VID - Device ID and Vendor ID" }, : { 0x04, 4, "BIOS_SPI_STS_CMD - Status and Command" }, : { 0x08, 4, "BIOS_SPI_CC_RID - Revision ID" }, : { 0x0c, 4, "BIOS_SPI_BIST_HTYPE_LT_CLS - BIST, Header Type, Latency Timer, Cache Line Size" }, : { 0x10, 4, "BIOS_SPI_BAR0 - SPI BAR0 MMIO" }, > IMHO we should dump everything to have everything when dumping to a log file for example There are many more registers than these... we might as well print the whole config space with your argument. We could, and just only print names for those regs we know. But I'd still prefer to leave it to `lspci`. -- To view, visit https://review.coreboot.org/c/coreboot/+/39566 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9 Gerrit-Change-Number: 39566 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Reviewer: Idwer Vollering <vidwer(a)gmail.com> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Mimoja <coreboot(a)mimoja.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 21 Mar 2020 14:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michael Niewöhner Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2020