coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: Documentation: Update release notes for Denverton NS deprecation
by Michael Niewöhner (Code Review) 12 Nov '20

12 Nov '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47539 ) Change subject: Documentation: Update release notes for Denverton NS deprecation ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/47539 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a6df3f3e640d1316e9cc2dbe244ea63c3a24dfa Gerrit-Change-Number: 47539 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 12 Nov 2020 22:22:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: FSP 2.0: Add fsp_relax_security
by Nico Huber (Code Review) 12 Nov '20

12 Nov '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 ) Change subject: FSP 2.0: Add fsp_relax_security ...................................................................... Patch Set 22: (1 comment) https://review.coreboot.org/c/coreboot/+/25437/22/src/drivers/intel/fsp2_0/… File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/25437/22/src/drivers/intel/fsp2_0/… PS22, Line 58: __weak bool should_fsp_relax_security(void) In case this goes in, please use a more specific name. Technically it's should_fsp_skip_readytoboot_and_endoffirmware() For Denverton, this might be about locks only, but for other platforms it seems to be much more. For instance, when I tried something like this with KabyLakeFSP, some controller stopped working (xHCI or AHCI, IIRC). -- To view, visit https://review.coreboot.org/c/coreboot/+/25437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174 Gerrit-Change-Number: 25437 Gerrit-PatchSet: 22 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Guckian <d.guckian20(a)gmail.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Thu, 12 Nov 2020 22:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/dnv_ns: enable common CPU code and hook up VMX configuration
by Michael Niewöhner (Code Review) 12 Nov '20

12 Nov '20

Michael Niewöhner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46474 ) Change subject: soc/intel/dnv_ns: enable common CPU code and hook up VMX configuration ...................................................................... Abandoned nobody can test this :( -- To view, visit https://review.coreboot.org/c/coreboot/+/46474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab556055fb229a7e3387ddbd4ff1cb461e36f7b2 Gerrit-Change-Number: 46474 Gerrit-PatchSet: 20 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stephen Douthit <stephend(a)silicom-usa.com> Gerrit-Reviewer: Steve Mooney Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: FSP 2.0: Add fsp_relax_security
by Julien Viard de Galbert (Code Review) 12 Nov '20

12 Nov '20

Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 ) Change subject: FSP 2.0: Add fsp_relax_security ...................................................................... Patch Set 21: (5 comments) I can understand that this change is very specific to a use case (BMC able to enable/disable the security flag) and a platform (denverton FSP does not provide and UPD to handle that). So maybe that change should just not go in and I should rewrite my other patches to not depend on it. What do you think ? https://review.coreboot.org/c/coreboot/+/25437/6/src/drivers/intel/fsp2_0/n… File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/25437/6/src/drivers/intel/fsp2_0/n… PS6, Line 79: if ((phase == READY_TO_BOOT) && fsp_relax_security()) { > Is it possible to move this after soc_display_mtrrs()? yes https://review.coreboot.org/c/coreboot/+/25437/9/src/drivers/intel/fsp2_0/n… File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/25437/9/src/drivers/intel/fsp2_0/n… PS9, Line 69: __attribute__((weak)) > There is __weak macro to use. Done https://review.coreboot.org/c/coreboot/+/25437/9/src/drivers/intel/fsp2_0/n… PS9, Line 78: fsp_relax_security() > How were you envisioning this working? Recompile with a stronger symbol that returns true? At that p […] The stronger symbol will only return true if the BMC told it to do so... without reflashing, while a Kconfig require rebuild and reflash... https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/… File src/drivers/intel/fsp2_0/notify.c: https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/… PS18, Line 70: fsp_relax_security > Right I missed the introduction of CHIPSET_LOCKDOWN_COREBOOT, I can certainly rewrite it using that. […] Except I can't... on other platform CHIPSET_LOCKDOWN_COREBOOT/FSP is used to fill the parameters to FSP but on denverton we don't have any parameters to configure lockdown. Reusing it here would break other platforms. So next option rename it. https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/… PS18, Line 70: __attribute__((weak)) bool fsp_relax_security(void) > Ah, I missed the bmcInfo patch and I don't know bmcInfo, yet \o/ Soo... just that I get that right.. […] Exaclty, the 'tagada' platform is using denverton microservers as 'blade' but without hotplug so when one has issue we prefer to be able to diagnose it remotely. Our BMC is not very powerful but can still set several settings in flash in the bmcInfo struct that coreboot will then pick. -- To view, visit https://review.coreboot.org/c/coreboot/+/25437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174 Gerrit-Change-Number: 25437 Gerrit-PatchSet: 21 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Guckian <d.guckian20(a)gmail.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 12 Nov 2020 22:13:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Comment-In-Reply-To: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Aaron Durbin <adurbin(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/denverton_ns: Lock SPIBAR
by Julien Viard de Galbert (Code Review) 12 Nov '20

12 Nov '20

Hello build bot (Jenkins), David Guckian, Patrick Georgi, Steve Mooney, Paul Menzel, Vanessa Eusebio, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/25441 to look at the new patch set (#22). Change subject: soc/intel/denverton_ns: Lock SPIBAR ...................................................................... soc/intel/denverton_ns: Lock SPIBAR - Allow flash access when "Security Override" is set. - Don't lock when relax_security is set. Change-Id: I6934918d0c70245f03a1642f9a05e0110a205bc9 Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/soc/intel/common/block/fast_spi/fast_spi_def.h M src/soc/intel/denverton_ns/lpc.c 2 files changed, 57 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/25441/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/25441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6934918d0c70245f03a1642f9a05e0110a205bc9 Gerrit-Change-Number: 25441 Gerrit-PatchSet: 22 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Steve Mooney Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/scaleway/tagada: Use bmcInfo to enable Relaxed Security Mode
by Julien Viard de Galbert (Code Review) 12 Nov '20

12 Nov '20

Hello build bot (Jenkins), Patrick Georgi, Paul Menzel, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/25438 to look at the new patch set (#22). Change subject: mb/scaleway/tagada: Use bmcInfo to enable Relaxed Security Mode ...................................................................... mb/scaleway/tagada: Use bmcInfo to enable Relaxed Security Mode Change-Id: Id3a51452d587556c3fd671a0e28a65e940d6e8cb Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/mainboard/scaleway/tagada/bmcinfo.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/25438/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/25438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3a51452d587556c3fd671a0e28a65e940d6e8cb Gerrit-Change-Number: 25438 Gerrit-PatchSet: 22 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: FSP 2.0: Add fsp_relax_security
by Julien Viard de Galbert (Code Review) 12 Nov '20

12 Nov '20

Hello build bot (Jenkins), Patrick Georgi, Paul Menzel, Vanessa Eusebio, Andrey Petrov, Patrick Rudolph, David Guckian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/25437 to look at the new patch set (#22). Change subject: FSP 2.0: Add fsp_relax_security ...................................................................... FSP 2.0: Add fsp_relax_security The rationale is that for some hardware testing tools to work properly some register must not be locked, adding this hook allows the platform to define its way of disabling the locks. The implementation is to not call the final FSP notify stage that does the locking. Change-Id: I972e7387c2612ee0053df21afb55b0b264961174 Signed-off-by: Julien Viard de Galbert <jviarddegalbert(a)online.net> --- M src/drivers/intel/fsp2_0/include/fsp/api.h M src/drivers/intel/fsp2_0/notify.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/25437/22 -- To view, visit https://review.coreboot.org/c/coreboot/+/25437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174 Gerrit-Change-Number: 25437 Gerrit-PatchSet: 22 Gerrit-Owner: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: David Guckian <d.guckian20(a)gmail.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Aaron Durbin <adurbin(a)chromium.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/intel/fsp/fsp2_0/alderlake: Update FSP header file version to 1454
by Tim Wawrzynczak (Code Review) 12 Nov '20

12 Nov '20

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47244 ) Change subject: vc/intel/fsp/fsp2_0/alderlake: Update FSP header file version to 1454 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/47244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I973f48b2af0336f04ee16cd1c4c91940a49af0e3 Gerrit-Change-Number: 47244 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Nov 2020 22:02:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/dnv_ns: enable common CPU code and hook up VMX configuration
by Nico Huber (Code Review) 12 Nov '20

12 Nov '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46474 ) Change subject: soc/intel/dnv_ns: enable common CPU code and hook up VMX configuration ...................................................................... Patch Set 20: (1 comment) https://review.coreboot.org/c/coreboot/+/46474/20//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/46474/20//COMMIT_MSG@13 PS20, Line 13: FSP does not : configure VMX at all Is that documented/tested/guessed? -- To view, visit https://review.coreboot.org/c/coreboot/+/46474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab556055fb229a7e3387ddbd4ff1cb461e36f7b2 Gerrit-Change-Number: 46474 Gerrit-PatchSet: 20 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Guckian <david.guckian(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julien Viard de Galbert <coreboot-review-ju(a)vdg.name> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stephen Douthit <stephend(a)silicom-usa.com> Gerrit-Reviewer: Steve Mooney Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Nov 2020 21:52:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAKE: MOAAAAAR $$$$$$$$
by Nico Huber (Code Review) 12 Nov '20

12 Nov '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29639 ) Change subject: MAKE: MOAAAAAR $$$$$$$$ ...................................................................... Patch Set 1: > Is this still needed? Not literally needed. But I keep it as a reminder that our cold-cache abuild could be much more efficient: The dollars would help to have the same entries in automatically generated .d dependency files even when the build/ dir changes. But there is more work in ccache to be done to make this useful. -- To view, visit https://review.coreboot.org/c/coreboot/+/29639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19d3016e67f8930345e0da9564abcc5e5f8ab365 Gerrit-Change-Number: 29639 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 12 Nov 2020 21:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020