coreboot-gerrit November 2020

coreboot-gerrit@coreboot.org

1 participants
3243 discussions

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: set FADT PM profile to ENTERPRISE_S...
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48088 to look at the new patch set (#9). Change subject: mb/supermicro/x11-lga1151-series: set FADT PM profile to ENTERPRISE_SERVER ...................................................................... mb/supermicro/x11-lga1151-series: set FADT PM profile to ENTERPRISE_SERVER Set the FADT PM profile to ENTERPRISE_SERVER, since the currently supported X11 boards are server boards. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I8fb5c7c262fbd3f3c085d7c2e2ef3d6ff6ce73eb --- M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc A src/mainboard/supermicro/x11-lga1151-series/fadt.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/48088/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/48088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8fb5c7c262fbd3f3c085d7c2e2ef3d6ff6ce73eb Gerrit-Change-Number: 48088 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: rework gpio setup to not use headers
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Patrick Georgi, Martin Roth, Paul Menzel, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48087 to look at the new patch set (#9). Change subject: mb/supermicro/x11-lga1151-series: rework gpio setup to not use headers ...................................................................... mb/supermicro/x11-lga1151-series: rework gpio setup to not use headers Rework gpio setup for the board series to not use headers but stage-specific compilation units. Tested successfully on X11SSM-F. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: Ic62ce4335af605c081ef288e892441585ff2bd3e --- M src/mainboard/supermicro/x11-lga1151-series/Makefile.inc M src/mainboard/supermicro/x11-lga1151-series/bootblock.c A src/mainboard/supermicro/x11-lga1151-series/include/mainboard/gpio.h M src/mainboard/supermicro/x11-lga1151-series/mainboard.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/gpio.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-f/gpio_early.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/gpio.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/gpio_early.c R src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio.c A src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/gpio_early.c 10 files changed, 100 insertions(+), 70 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/48087/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/48087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic62ce4335af605c081ef288e892441585ff2bd3e Gerrit-Change-Number: 48087 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11ssm-f: drop unneeded ITSS override
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48084 to look at the new patch set (#8). Change subject: mb/supermicro/x11ssm-f: drop unneeded ITSS override ...................................................................... mb/supermicro/x11ssm-f: drop unneeded ITSS override The ITSS override is not needed for LPC_CLKOUT* pads. Drop it. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I3dbbc8944751779151dcd4f92fb870d937801d69 --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/48084/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/48084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3dbbc8944751779151dcd4f92fb870d937801d69 Gerrit-Change-Number: 48084 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48083 to look at the new patch set (#11). Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init ...................................................................... mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init GPIO needs to be initialized before the IPMI device gets initialized, so the GPIOs can be read/set by the code in CB:48096 and CB:48094. Thus, use mainboard_ops.init for GPIO configuration instead of using the indirection via a mainboard_enable function. To make it more visible, that we use chip.init, rename `mainboard_init` to `mainboard_chip_init`. Tested successfully on X11SSM-F including the IPMI changes. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae --- M src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h M src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c 3 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48083/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/48083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae Gerrit-Change-Number: 48083 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48083 to look at the new patch set (#10). Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init ...................................................................... mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init Use mainboard_ops.init for GPIO configuration instead of using the indirection via a mainboard_enable function. To make it more visible, that we use chip.init, rename `mainboard_init` to `mainboard_chip_init`. Tested successfully on X11SSM-F. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae --- M src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h M src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c 3 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48083/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/48083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae Gerrit-Change-Number: 48083 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: restructure and clean up devicetree
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48082 to look at the new patch set (#7). Change subject: mb/supermicro/x11-lga1151-series: restructure and clean up devicetree ...................................................................... mb/supermicro/x11-lga1151-series: restructure and clean up devicetree Drop zero-value devicetree options and move PcieRpEnable options down to the corresponding devices. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I9285d786e973621a732e2627c734adc930e54207 --- M src/mainboard/supermicro/x11-lga1151-series/devicetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/overridetree.cb 3 files changed, 9 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/48082/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/48082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9285d786e973621a732e2627c734adc930e54207 Gerrit-Change-Number: 48082 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48083 to look at the new patch set (#9). Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init ...................................................................... mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init GPIO needs to be initialized before the IPMI device gets initialized, so the GPIOs can be read/set by the code in CB:48096 and CB:48094. Thus, use mainboard_ops.init for GPIO configuration instead of using the indirection via a mainboard_enable function. To make it more visible, that we use chip.init, rename `mainboard_init` to `mainboard_chip_init`. Tested successfully on X11SSM-F including the IPMI changes. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae --- M src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h M src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c 3 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48083/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/48083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae Gerrit-Change-Number: 48083 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
by Michael Niewöhner (Code Review) 27 Nov '20

27 Nov '20

Hello Felix Singer, build bot (Jenkins), Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/48083 to look at the new patch set (#8). Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init ...................................................................... mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init GPIO needs to be initialized before the IPMI device gets initialized, so the GPIOs can be read/set by the code in CB:48096 and CB:48094. Thus, use mainboard_ops.init for GPIO configuration instead of using the indirection via a mainboard_enable function. To make it more visible, that we use chip.init, rename `mainboard_init` to `mainboard_chip_init`. Tested successfully on X11SSM-F including the IPMI changes. Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae --- M src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h M src/mainboard/supermicro/x11-lga1151-series/mainboard.c M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c 3 files changed, 6 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/48083/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/48083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae Gerrit-Change-Number: 48083 Gerrit-PatchSet: 8 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init
by Arthur Heymans (Code Review) 27 Nov '20

27 Nov '20

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48083 ) Change subject: mb/supermicro/x11-lga1151-series: switch from dev.init to mb_ops.init ...................................................................... Patch Set 7: Code-Review+2 (1 comment) https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/48083/5//COMMIT_MSG@9 PS5, Line 9: Set mainboard_ops.init directly instead of using the indirection via a : mainboard_enable function. > Forgot this one. GPIOs need to be initialized before the IPMI driver dev gets initialized (dev.init = ipmi_kcs_init) Good enough reason for me, please add that to the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/48083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I192e69a34fa262b38bc40a95fb11c22a4041d0ae Gerrit-Change-Number: 48083 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Nov 2020 20:54:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/supermicro/x11-lga1151-series: restructure and clean up devicetree
by Felix Singer (Code Review) 27 Nov '20

27 Nov '20

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48082 ) Change subject: mb/supermicro/x11-lga1151-series: restructure and clean up devicetree ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/48082 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9285d786e973621a732e2627c734adc930e54207 Gerrit-Change-Number: 48082 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 27 Nov 2020 20:53:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2020