Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35017 )
Change subject: mediatek/mt8183: Set DRAM voltage for each DRAM frequency
......................................................................
Patch Set 11:
(4 comments)
Note that you're not supposed to give yourself Code-Review+2 (and it doesn't work, anyway).
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e…
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e…
PS11, Line 51: enum {
Rather than this and a raw uint array, please define a struct with three members.
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e…
PS11, Line 59: 1125000, 600000
If the latter two values are always constant, do they really need to be in here?
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/e…
PS11, Line 400: #if DUAL_FREQ_K
This seems to be like a very complicated way to write
{
if (DUAL_FREQ_K) {
set_dram_voltabe_by_freq(LP4X_LOW);
...
set_dram_voltage_by_freq(LP4X_MIDDLE);
...
}
set_dram_voltage_by_freq(LP4X_HIGH);
...
}
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/i…
File src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h:
https://review.coreboot.org/c/coreboot/+/35017/11/src/soc/mediatek/mt8183/i…
PS11, Line 41: #define DUAL_FREQ_K 0
What is this? If you want configurable code paths, use Kconfig.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35017
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9539473ff708f9d0d39eb17bd3fdcb916265d33e
Gerrit-Change-Number: 35017
Gerrit-PatchSet: 11
Gerrit-Owner: huayang duan <huayangduan(a)gmail.com>
Gerrit-Reviewer: Huayang Duan <huayang.duan(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: hsin-hsiung wang <hsin-hsiung.wang(a)mediatek.com>
Gerrit-Reviewer: huayang duan <huayangduan(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 30 Sep 2019 21:01:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs
......................................................................
Patch Set 23:
> Patch Set 16:
>
> The motivation as well as documentation is missing. Which code will use it and why?
The CSE FW update logic will use the functionality. The API set helps to get CSE Image layout details, and to notify the CSE to boot from required partition.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa62409c0616d5913d21374a8a6804f82258eb4f
Gerrit-Change-Number: 35402
Gerrit-PatchSet: 23
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andrey Petrov <anpetrov(a)fb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 30 Sep 2019 18:17:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31934 )
Change subject: util/sconfig: Emit array of PNP UART devices
......................................................................
Patch Set 7:
If we expand device aliases to PNP this can be solved differently.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9330bcd5545ec3f94c1c14ed4a639f1ef0548e43
Gerrit-Change-Number: 31934
Gerrit-PatchSet: 7
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:46:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30117 )
Change subject: arch/x86: Support x86_64 exceptions
......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30117/22/src/arch/x86/include/arch…
File src/arch/x86/include/arch/registers.h:
https://review.coreboot.org/c/coreboot/+/30117/22/src/arch/x86/include/arch…
PS22, Line 44: #define QUAD_DOWNTO8(A) \
macros should not use a trailing semicolon
https://review.coreboot.org/c/coreboot/+/30117/22/src/arch/x86/include/arch…
PS22, Line 50: #define QUAD_DOWNTO16(A) \
macros should not use a trailing semicolon
--
To view, visit https://review.coreboot.org/c/coreboot/+/30117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd12c90a95cc2989eb9b2a718740a84222193f48
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 22
Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:43:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment