Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33403
Change subject: nb/intel/nehalem: Die if no memory ranks found
......................................................................
nb/intel/nehalem: Die if no memory ranks found
Die if there are no memory ranks found to prevent a division by zero.
Change-Id: I6146dd8420f3734d1a672a9f29a098f47fcb739c
Signed-off-by: Jacob Garber <jgarber1(a)ualberta.ca>
Found-by: Coverity CID 1229628
---
M src/northbridge/intel/nehalem/raminit.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33403/1
diff --git a/src/northbridge/intel/nehalem/raminit.c b/src/northbridge/intel/nehalem/raminit.c
index 15d6abb..03831e2 100644
--- a/src/northbridge/intel/nehalem/raminit.c
+++ b/src/northbridge/intel/nehalem/raminit.c
@@ -1010,6 +1010,9 @@
}
}
+ if (count == 0)
+ die("No memory ranks found for channel %u\n", channel);
+
info->avg4044[channel] = sum / count;
info->max4048[channel] = max_of_unk;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/33403
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6146dd8420f3734d1a672a9f29a098f47fcb739c
Gerrit-Change-Number: 33403
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33357
Change subject: soc/intel/block/cpu: Make MP init options mutually exclusive
......................................................................
soc/intel/block/cpu: Make MP init options mutually exclusive
It shouldn't be the case that multiple or no MP init paths could be
selected.
Change-Id: I65b80805d3cd7b66f8c9f878d3c741b98f24288d
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/intel/common/block/cpu/Kconfig
1 file changed, 30 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/33357/1
diff --git a/src/soc/intel/common/block/cpu/Kconfig b/src/soc/intel/common/block/cpu/Kconfig
index 9ec5307..e602829 100644
--- a/src/soc/intel/common/block/cpu/Kconfig
+++ b/src/soc/intel/common/block/cpu/Kconfig
@@ -51,29 +51,49 @@
ENHANCED NEM guarantees that modified data is always
kept in cache while clean data is replaced.
-menu "Multiple Processor (MP) Initialization Options"
-config USE_COREBOOT_NATIVE_MP_INIT
+choice
+ prompt "Multiple Processor (MP) Initialization Options"
+ default MP_USE_COREBOOT_NATIVE_MP_INIT if !PLATFORM_USES_FSP2_1
+ default MP_USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI if PLATFORM_USES_FSP2_1
+
+config MP_USE_COREBOOT_NATIVE_MP_INIT
bool "Perform MP Initialization by coreboot"
- default y if !PLATFORM_USES_FSP2_1
- default n
+ select USE_COREBOOT_NATIVE_MP_INIT
help
This option allows user to select native coreboot option to perform
multiprocessor initialization.
-config USE_INTEL_FSP_MP_INIT
+config MP_USE_INTEL_FSP_MP_INIT
bool "Perform MP Initialization by FSP"
- default n
+ select USE_INTEL_FSP_MP_INIT
help
This option allows FSP to perform multiprocessor initialization.
-config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
+config MP_USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
bool "Perform MP Initialization by FSP using coreboot MP PPI service"
depends on FSP_USES_MP_SERVICES_PPI
- default y if PLATFORM_USES_FSP2_1
- default n
+ select USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
select USE_COREBOOT_NATIVE_MP_INIT
help
This option allows FSP to make use of MP services PPI published by
coreboot to perform multiprocessor initialization.
-endmenu # Multiple Processor (MP) Initialization Options
+endchoice
+
+config USE_COREBOOT_NATIVE_MP_INIT
+ bool
+ help
+ This option allows user to select native coreboot option to perform
+ multiprocessor initialization.
+
+config USE_INTEL_FSP_MP_INIT
+ bool
+ help
+ This option allows FSP to perform multiprocessor initialization.
+
+config USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI
+ bool
+ select USE_COREBOOT_NATIVE_MP_INIT
+ help
+ This option allows FSP to make use of MP services PPI published by
+ coreboot to perform multiprocessor initialization.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33357
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65b80805d3cd7b66f8c9f878d3c741b98f24288d
Gerrit-Change-Number: 33357
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newchange
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30831
Change subject: vendorcode/eltan Add hashing library used for measured and verified boot.
......................................................................
vendorcode/eltan Add hashing library used for measured and verified boot.
To avoid having the whole 3rdparty/vboot/firmware included a small hashing library
has been created.
Create library which is a 'wrapper' using only sha1, sha256 and sha512 of
3rdparty/vboot/firmware.
Fucntions cb_sha1(), cb_sha256() and cb_sha512 can be used for hashing.
BUG=N/A
TEST=Created binary and verify logging on Facebok FBG-1701
Change-Id: If828bde54c79e836a5b05ff0447645d7e06e819a
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
A src/vendorcode/eltan/security/include/cb_sha1.h
A src/vendorcode/eltan/security/include/cb_sha256.h
A src/vendorcode/eltan/security/include/cb_sha512.h
A src/vendorcode/eltan/security/include/cryptolib.h
A src/vendorcode/eltan/security/lib/Makefile.inc
A src/vendorcode/eltan/security/lib/cb_sha1.c
A src/vendorcode/eltan/security/lib/cb_sha256.c
A src/vendorcode/eltan/security/lib/cb_sha512.c
8 files changed, 297 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/30831/1
diff --git a/src/vendorcode/eltan/security/include/cb_sha1.h b/src/vendorcode/eltan/security/include/cb_sha1.h
new file mode 100644
index 0000000..3b72355
--- /dev/null
+++ b/src/vendorcode/eltan/security/include/cb_sha1.h
@@ -0,0 +1,21 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018. Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __SECURITY_SHA1_H__
+#define __SECURITY_SHA1_H__
+
+uint8_t *cb_sha1(const uint8_t *data, uint64_t len, uint8_t *digest);
+
+#endif
diff --git a/src/vendorcode/eltan/security/include/cb_sha256.h b/src/vendorcode/eltan/security/include/cb_sha256.h
new file mode 100644
index 0000000..3b45f73
--- /dev/null
+++ b/src/vendorcode/eltan/security/include/cb_sha256.h
@@ -0,0 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018. Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __SECURITY_SHA256_H__
+#define __SECURITY_SHA256_H__
+
+uint8_t *cb_sha256(const uint8_t *data, uint64_t len, uint8_t *digest);
+uint8_t *cb_sha256_ex(const uint8_t *data, uint64_t len, uint8_t *digest,
+ bool endian);
+
+#endif
diff --git a/src/vendorcode/eltan/security/include/cb_sha512.h b/src/vendorcode/eltan/security/include/cb_sha512.h
new file mode 100644
index 0000000..a383cf0
--- /dev/null
+++ b/src/vendorcode/eltan/security/include/cb_sha512.h
@@ -0,0 +1,23 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018. Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __SECURITY_SHA512_H__
+#define __SECURITY_SHA512_H__
+
+uint8_t *cb_sha512(const uint8_t *data, uint64_t len, uint8_t *digest);
+uint8_t *cb_sha512_ex(const uint8_t *data, uint64_t len, uint8_t *digest,
+ bool endian);
+
+#endif
diff --git a/src/vendorcode/eltan/security/include/cryptolib.h b/src/vendorcode/eltan/security/include/cryptolib.h
new file mode 100644
index 0000000..ac1668a
--- /dev/null
+++ b/src/vendorcode/eltan/security/include/cryptolib.h
@@ -0,0 +1,29 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018. Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __SECURITY_CRYPTOLIB_H__
+#define __SECURITY_CRYPTOLIB_H__
+
+#define NEED_VB2_SHA_LIBRARY
+
+#include <2rsa.h>
+#include <vb21_common.h>
+#include <vb2_api.h>
+
+#include "cb_sha1.h"
+#include "cb_sha512.h"
+#include "cb_sha256.h"
+
+#endif
\ No newline at end of file
diff --git a/src/vendorcode/eltan/security/lib/Makefile.inc b/src/vendorcode/eltan/security/lib/Makefile.inc
new file mode 100644
index 0000000..9e2fc39
--- /dev/null
+++ b/src/vendorcode/eltan/security/lib/Makefile.inc
@@ -0,0 +1,52 @@
+#
+# This file is part of the coreboot project.
+#
+# Copyright (C) 2018 Eltan B.V.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+
+SECURITYLIB_INCLUDES = -I3rdparty/vboot/firmware/2lib/include -I3rdparty/vboot/firmware/lib21/include
+
+CPPFLAGS_common+=$(SECURITYLIB_INCLUDES)
+
+ifeq ($(CONFIG_VERIFIED_BOOT),y)
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/2lib/2common.c
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/2lib/2rsa.c
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/2lib/2sha_utility.c
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/lib21/packed_key.c
+ifeq ($(CONFIG_VERIFIED_BOOT_USE_SHA512),y)
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += cb_sha512.c
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/2lib/2sha512.c
+else
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += cb_sha256.c
+bootblock-$(CONFIG_C_ENVIRONMENT_BOOTBLOCK) += $(top)/3rdparty/vboot/firmware/2lib/2sha256.c
+endif
+endif
+
+ifeq ($(CONFIG_MBOOT),y)
+ramstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha1.c
+ramstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha512.c
+ramstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha256.c
+ramstage-y += cb_sha1.c
+ramstage-y += cb_sha512.c
+ramstage-y += cb_sha256.c
+
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2common.c
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2rsa.c
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha1.c
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha256.c
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha512.c
+romstage-y += $(top)/3rdparty/vboot/firmware/2lib/2sha_utility.c
+romstage-y += $(top)/3rdparty/vboot/firmware/lib21/packed_key.c
+romstage-y += cb_sha1.c
+romstage-y += cb_sha512.c
+romstage-y += cb_sha256.c
+endif
\ No newline at end of file
diff --git a/src/vendorcode/eltan/security/lib/cb_sha1.c b/src/vendorcode/eltan/security/lib/cb_sha1.c
new file mode 100644
index 0000000..fd96943
--- /dev/null
+++ b/src/vendorcode/eltan/security/lib/cb_sha1.c
@@ -0,0 +1,27 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018 Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <cryptolib.h>
+
+uint8_t *cb_sha1(const uint8_t *data, uint64_t len, uint8_t *digest)
+{
+ struct vb2_sha1_context ctx;
+
+ vb2_sha1_init(&ctx);
+ vb2_sha1_update(&ctx, data, len);
+ vb2_sha1_finalize(&ctx, digest);
+
+ return digest;
+}
diff --git a/src/vendorcode/eltan/security/lib/cb_sha256.c b/src/vendorcode/eltan/security/lib/cb_sha256.c
new file mode 100644
index 0000000..b02ebb2
--- /dev/null
+++ b/src/vendorcode/eltan/security/lib/cb_sha256.c
@@ -0,0 +1,61 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018 Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <cryptolib.h>
+
+uint8_t *cb_sha256_ex(const uint8_t *data, uint64_t len, uint8_t *digest,
+ bool endian)
+{
+ int i;
+ const uint8_t *input_ptr;
+ uint8_t result[VB2_SHA256_DIGEST_SIZE];
+ uint8_t *result_ptr;
+ uint64_t remaining_len;
+ struct vb2_sha256_context ctx;
+
+ vb2_sha256_init(&ctx);
+
+ input_ptr = data;
+ remaining_len = len;
+
+ /* Process data in at most UINT32_MAX byte chunks at a time. */
+ while (remaining_len) {
+ uint32_t block_size;
+ block_size = (uint32_t) ((remaining_len >= UINT32_MAX) ?
+ UINT32_MAX : remaining_len);
+ vb2_sha256_update(&ctx, input_ptr, block_size);
+ remaining_len -= block_size;
+ input_ptr += block_size;
+ }
+
+ result_ptr = result;
+ vb2_sha256_finalize(&ctx, result_ptr);
+ for (i = 0; i < VB2_SHA256_DIGEST_SIZE; ++i) {
+ if (endian) {
+ /* use big endian here */
+ digest[i] = *result_ptr++;
+ } else {
+ /* use little endian here */
+ digest[VB2_SHA256_DIGEST_SIZE - i - 1] = *result_ptr++;
+ }
+ }
+ return digest;
+}
+
+uint8_t *cb_sha256(const uint8_t *data, uint64_t len, uint8_t *digest)
+{
+ /* Returned the little endian SHA256 digest */
+ return cb_sha256_ex(data, len, digest, 0);
+}
\ No newline at end of file
diff --git a/src/vendorcode/eltan/security/lib/cb_sha512.c b/src/vendorcode/eltan/security/lib/cb_sha512.c
new file mode 100644
index 0000000..9d713e7
--- /dev/null
+++ b/src/vendorcode/eltan/security/lib/cb_sha512.c
@@ -0,0 +1,61 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018 Eltan B.V.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <cryptolib.h>
+
+uint8_t *cb_sha512_ex(const uint8_t *data, uint64_t len, uint8_t *digest,
+ bool endian)
+{
+ int i;
+ const uint8_t *input_ptr;
+ uint8_t result[VB2_SHA512_DIGEST_SIZE];
+ uint8_t *result_ptr;
+ uint64_t remaining_len;
+ struct vb2_sha512_context ctx;
+
+ vb2_sha512_init(&ctx);
+
+ input_ptr = data;
+ remaining_len = len;
+
+ /* Process data in at most UINT32_MAX byte chunks at a time. */
+ while (remaining_len) {
+ uint32_t block_size;
+ block_size = (uint32_t) ((remaining_len >= UINT32_MAX) ?
+ UINT32_MAX : remaining_len);
+ vb2_sha512_update(&ctx, input_ptr, block_size);
+ remaining_len -= block_size;
+ input_ptr += block_size;
+ }
+
+ result_ptr = result;
+ vb2_sha512_finalize(&ctx, result_ptr);
+ for (i = 0; i < VB2_SHA512_DIGEST_SIZE; ++i) {
+ if (endian) {
+ /* use big endian here */
+ digest[i] = *result_ptr++;
+ } else {
+ /* use little endian here */
+ digest[VB2_SHA512_DIGEST_SIZE - i - 1] = *result_ptr++;
+ }
+ }
+ return digest;
+}
+
+uint8_t *cb_sha512(const uint8_t *data, uint64_t len, uint8_t *digest)
+{
+ /* Returned the little endian SHA512 digest */
+ return cb_sha512_ex(data, len, digest, 0);
+}
\ No newline at end of file
--
To view, visit https://review.coreboot.org/c/coreboot/+/30831
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If828bde54c79e836a5b05ff0447645d7e06e819a
Gerrit-Change-Number: 30831
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: newchange
Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31822
Change subject: soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
......................................................................
soc/intel/braswell/acpi/lpc.asl: Allocate used ROM size only
Fixed ROM area is allocated.
Reduce the ROM size using CONFIG_COREBOOT_ROMSIZE.
BUG=N/A
TEST=Facebook FBG-1701 booting Embedded Linux
Change-Id: I7a47bf2600f546271c5a65641d29f868ff2748bf
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M src/soc/intel/braswell/acpi/lpc.asl
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/31822/1
diff --git a/src/soc/intel/braswell/acpi/lpc.asl b/src/soc/intel/braswell/acpi/lpc.asl
index 6b2ecec..a28eb38 100644
--- a/src/soc/intel/braswell/acpi/lpc.asl
+++ b/src/soc/intel/braswell/acpi/lpc.asl
@@ -3,7 +3,7 @@
*
* Copyright (C) 2007-2009 coresystems GmbH
* Copyright (C) 2013 Google Inc.
- * Copyright (C) 2018 Eltan B.V.
+ * Copyright (C) 2018-2019 Eltan B.V.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
@@ -44,7 +44,10 @@
Name (_HID, EISAID("INT0800"))
Name (_CRS, ResourceTemplate()
{
- Memory32Fixed(ReadOnly, 0xff000000, 0x01000000)
+ Memory32Fixed(ReadOnly, 0xffffffff -
+ (CONFIG_COREBOOT_ROMSIZE_KB*1024) + 1,
+ CONFIG_COREBOOT_ROMSIZE_KB*1024)
+
})
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/31822
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a47bf2600f546271c5a65641d29f868ff2748bf
Gerrit-Change-Number: 31822
Gerrit-PatchSet: 1
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-MessageType: newchange
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 17:
(4 comments)
I expect this patch set is now ready for merge
https://review.coreboot.org/c/coreboot/+/29470/16/Documentation/mainboard/p…
File Documentation/mainboard/portwell/pq7-m107.md:
https://review.coreboot.org/c/coreboot/+/29470/16/Documentation/mainboard/p…
PS16, Line 9: make menuconfig
> Mark up as code with ``?
Done
https://review.coreboot.org/c/coreboot/+/29470/16/Documentation/mainboard/p…
PS16, Line 28: to
> on?
Done
https://review.coreboot.org/c/coreboot/+/29470/16/Documentation/mainboard/p…
PS16, Line 37: avaiable
> available
Done
https://review.coreboot.org/c/coreboot/+/29470/16/Documentation/mainboard/p…
PS16, Line 59: - SeaBIOS payload
> What version?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 10 Jul 2019 10:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
Patch Set 17:
(2 comments)
https://review.coreboot.org/c/coreboot/+/29470/17/src/mainboard/portwell/m1…
File src/mainboard/portwell/m107/irqroute.h:
https://review.coreboot.org/c/coreboot/+/29470/17/src/mainboard/portwell/m1…
PS17, Line 40: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/29470/17/src/mainboard/portwell/m1…
PS17, Line 62: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 10 Jul 2019 10:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Patrick Rudolph, Felix Held, Piotr Król, Paul Menzel, David Hendricks, build bot (Jenkins), Michał Żygowski, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/29470
to look at the new patch set (#17).
Change subject: mainboard/portwell/m107: Do initial mainboard commit
......................................................................
mainboard/portwell/m107: Do initial mainboard commit
Initial support for Portwell PQ7-M107 (Q7) module.
Code based on Intel Strago mainboard.
BUG=N/A
TEST=booting SeaBIOS and Linux 4.20 kernel on PQ7-M107
Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/portwell/pq7-m107.md
A src/mainboard/portwell/Kconfig
A src/mainboard/portwell/Kconfig.name
A src/mainboard/portwell/m107/Kconfig
A src/mainboard/portwell/m107/Kconfig.name
A src/mainboard/portwell/m107/Makefile.inc
A src/mainboard/portwell/m107/acpi/ec.asl
A src/mainboard/portwell/m107/acpi/mainboard.asl
A src/mainboard/portwell/m107/acpi/sleepstates.asl
A src/mainboard/portwell/m107/acpi/superio.asl
A src/mainboard/portwell/m107/acpi_tables.c
A src/mainboard/portwell/m107/board_info.txt
A src/mainboard/portwell/m107/cmos.layout
A src/mainboard/portwell/m107/com_init.c
A src/mainboard/portwell/m107/devicetree.cb
A src/mainboard/portwell/m107/dsdt.asl
A src/mainboard/portwell/m107/fadt.c
A src/mainboard/portwell/m107/gpio.c
A src/mainboard/portwell/m107/hda_verb.c
A src/mainboard/portwell/m107/irqroute.c
A src/mainboard/portwell/m107/irqroute.h
A src/mainboard/portwell/m107/mainboard.c
A src/mainboard/portwell/m107/onboard.h
A src/mainboard/portwell/m107/romstage.c
A src/mainboard/portwell/m107/spd/MICRON_MT41K512M16HA-125A.spd.hex
A src/mainboard/portwell/m107/spd/SAMSUNG_K4B8G1646D-MYKO.spd.hex
A src/mainboard/portwell/m107/w25q64.c
28 files changed, 1,830 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/29470/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/29470
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d3173fdcf881f894a75cd9798ba173b425d4e62
Gerrit-Change-Number: 29470
Gerrit-PatchSet: 17
Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34154 )
Change subject: cpu/x86: Remove obsolete smm_init_completion()
......................................................................
cpu/x86: Remove obsolete smm_init_completion()
This is not used together with PARALLEL_MP and SMM_TSEG.
Platforms with SMM_ASEG continue to have their local
implementation doing the same thing.
Change-Id: I13a2f164804330c93240bff7f048e0a162b3ae25
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
M src/cpu/intel/smm/gen1/smmrelocate.c
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/34154/1
diff --git a/src/cpu/intel/smm/gen1/smmrelocate.c b/src/cpu/intel/smm/gen1/smmrelocate.c
index d52043f..986929c 100644
--- a/src/cpu/intel/smm/gen1/smmrelocate.c
+++ b/src/cpu/intel/smm/gen1/smmrelocate.c
@@ -57,7 +57,6 @@
/* This gets filled in and used during relocation. */
static struct smm_relocation_params smm_reloc_params;
-static void *default_smm_area = NULL;
/* On model_6fx, model_1067x and model_106cx SMRR functions slightly
differently. The MSR are at different location from the rest
@@ -168,11 +167,6 @@
memset(ied_base + (1 << 20), 0, (32 << 10));
}
-void smm_init_completion(void)
-{
- restore_default_smm_area(default_smm_area);
-}
-
void smm_lock(void)
{
/* LOCK the SMM memory window and enable normal SMM.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34154
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13a2f164804330c93240bff7f048e0a162b3ae25
Gerrit-Change-Number: 34154
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-MessageType: newchange