coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: cpu/intel/car/core2: Improve a few things
by build bot (Jenkins) (Code Review) 03 Jun '18

03 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26784 ) Change subject: cpu/intel/car/core2: Improve a few things ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74080/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28196/ : SUCCESS -- To view, visit https://review.coreboot.org/26784 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d8672f8b577c2e7cef6e80978c4464a771f430c Gerrit-Change-Number: 26784 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Jun 2018 20:48:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: Rename Pos_Type --> Position_Type
by Nico Huber (Code Review) 03 Jun '18

03 Jun '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/26696 ) Change subject: Rename Pos_Type --> Position_Type ...................................................................... Rename Pos_Type --> Position_Type Yet after few months, it's already too confusing to me. Let's reserve `Pos` for `Positive` and spell out `Position`. Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e Signed-off-by: Nico Huber <nico.h(a)gmx.de> Reviewed-on: https://review.coreboot.org/26696 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M common/hw-gfx.ads M gfxtest/hw-gfx-gma-gfx_test.adb 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Nico Huber: Verified Arthur Heymans: Looks good to me, approved diff --git a/common/hw-gfx.ads b/common/hw-gfx.ads index 1ab2518..7403a86 100644 --- a/common/hw-gfx.ads +++ b/common/hw-gfx.ads @@ -25,9 +25,9 @@ subtype Pos_Pixel_Type is Pixel_Type range 1 .. Pixel_Type'Last; -- Allow same range for width and height (for rotated framebuffers) - subtype Width_Type is Pos32 range 1 .. 8192; - subtype Height_Type is Pos32 range 1 .. 8192; - subtype Pos_Type is Int32 range 0 .. 4095; + subtype Width_Type is Pos32 range 1 .. 8192; + subtype Height_Type is Pos32 range 1 .. 8192; + subtype Position_Type is Int32 range 0 .. 4095; Auto_BPC : constant := 5; subtype BPC_Type is Int64 range Auto_BPC .. 16; @@ -41,8 +41,8 @@ record Width : Width_Type; Height : Height_Type; - Start_X : Pos_Type; - Start_Y : Pos_Type; + Start_X : Position_Type; + Start_Y : Position_Type; BPC : BPC_Type; Stride : Width_Type; V_Stride : Height_Type; diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 94ee312..bf6e917 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -19,9 +19,9 @@ Secondary_Delay_MS : constant := 4_000; Seed : constant := 12345; - package Rand_P is new Ada.Numerics.Discrete_Random (Pos_Type); + package Rand_P is new Ada.Numerics.Discrete_Random (Position_Type); Gen : Rand_P.Generator; - function Rand return Pos_Type is (Rand_P.Random (Gen)); + function Rand return Position_Type is (Rand_P.Random (Gen)); Start_X : constant := 0; Start_Y : constant := 0; @@ -384,7 +384,7 @@ declare New_Pipes : GMA.Pipe_Configs := Pipes; - function Rand_Div (Num : Pos_Type) return Pos_Type is + function Rand_Div (Num : Position_Type) return Position_Type is (case Rand mod 4 is when 3 => Rand mod Num / 3, when 2 => Rand mod Num / 2, @@ -404,9 +404,9 @@ Height : constant Height_Type := Pipes (Pipe).Framebuffer.Height; begin - New_FB.Start_X := Pos_Type'Min + New_FB.Start_X := Position_Type'Min (Width - 320, Rand_Div (Width)); - New_FB.Start_Y := Pos_Type'Min + New_FB.Start_Y := Position_Type'Min (Height - 320, Rand_Div (Height)); New_FB.Width := Width_Type'Max (320, Width - New_FB.Start_X - Rand_Div (Width)); -- To view, visit https://review.coreboot.org/26696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e Gerrit-Change-Number: 26696 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in coreboot[master]: cpu/intel/model_{6xx, f2x, f3x, f4x}: Remove unneeded include
by build bot (Jenkins) (Code Review) 03 Jun '18

03 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26782 ) Change subject: cpu/intel/model_{6xx,f2x,f3x,f4x}: Remove unneeded include ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74078/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28194/ : SUCCESS -- To view, visit https://review.coreboot.org/26782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d5843aada364b557e0618268ad48c650aa54d1e Gerrit-Change-Number: 26782 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Sun, 03 Jun 2018 18:01:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: buildgcc: Update IASL to 20180531
by build bot (Jenkins) (Code Review) 03 Jun '18

03 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21156 ) Change subject: buildgcc: Update IASL to 20180531 ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-toolchain/423/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/74076/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28192/ : SUCCESS -- To view, visit https://review.coreboot.org/21156 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c14f3aad59749896816bb8789788fc513e7176f Gerrit-Change-Number: 21156 Gerrit-PatchSet: 9 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Jun 2018 17:17:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in libgfxinit[master]: Rename Pos_Type --> Position_Type
by Arthur Heymans (Code Review) 03 Jun '18

03 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26696 ) Change subject: Rename Pos_Type --> Position_Type ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/26696 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3445d20665ae6a993cb0e46d08e8f3148abef40e Gerrit-Change-Number: 26696 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 03 Jun 2018 17:11:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/car: Align the stack to 16 bytes before romstage_main
by build bot (Jenkins) (Code Review) 03 Jun '18

03 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26797 ) Change subject: cpu/intel/car: Align the stack to 16 bytes before romstage_main ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74077/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28193/ : SUCCESS -- To view, visit https://review.coreboot.org/26797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Gerrit-Change-Number: 26797 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Jun 2018 16:46:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/car: Align the stack to 16 bytes before romstage_main
by Arthur Heymans (Code Review) 03 Jun '18

03 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26797 to look at the new patch set (#2). Change subject: cpu/intel/car: Align the stack to 16 bytes before romstage_main ...................................................................... cpu/intel/car: Align the stack to 16 bytes before romstage_main Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/car/core2/cache_as_ram.S M src/cpu/intel/car/non-evict/cache_as_ram.S M src/cpu/intel/car/p4-netburst/cache_as_ram.S 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/26797/2 -- To view, visit https://review.coreboot.org/26797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Gerrit-Change-Number: 26797 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: src: Remove unneeded include 'assert.h'
by Elyes HAOUAS (Code Review) 03 Jun '18

03 Jun '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/26796 ) Change subject: src: Remove unneeded include 'assert.h' ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/26796 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ib843eb7144b7dc2932931b9e8f3f1d816bcc1e1a Gerrit-Change-Number: 26796 Gerrit-PatchSet: 6 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: cpu/intel/car: Align the stack to 16 bytes before romstage_main
by build bot (Jenkins) (Code Review) 03 Jun '18

03 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26797 ) Change subject: cpu/intel/car: Align the stack to 16 bytes before romstage_main ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74074/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28190/ : SUCCESS -- To view, visit https://review.coreboot.org/26797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Gerrit-Change-Number: 26797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Jun 2018 15:24:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: cpu/intel/car: Align the stack to 16 bytes before romstage_main
by Arthur Heymans (Code Review) 03 Jun '18

03 Jun '18

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/26797 Change subject: cpu/intel/car: Align the stack to 16 bytes before romstage_main ...................................................................... cpu/intel/car: Align the stack to 16 bytes before romstage_main Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/intel/car/core2/cache_as_ram.S M src/cpu/intel/car/non-evict/cache_as_ram.S M src/cpu/intel/car/p4-netburst/cache_as_ram.S 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/26797/1 diff --git a/src/cpu/intel/car/core2/cache_as_ram.S b/src/cpu/intel/car/core2/cache_as_ram.S index c67c184..ecf97b07 100644 --- a/src/cpu/intel/car/core2/cache_as_ram.S +++ b/src/cpu/intel/car/core2/cache_as_ram.S @@ -168,6 +168,10 @@ /* Setup the stack. */ movl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %eax movl %eax, %esp + /* Align the stack 16 bytes */ + andl $0xfffffff0, %esp + /* Account for pushing the BIST result */ + sub $4, %esp /* Restore the BIST result. */ movl %ebp, %eax diff --git a/src/cpu/intel/car/non-evict/cache_as_ram.S b/src/cpu/intel/car/non-evict/cache_as_ram.S index 76bfe12..3477ef9 100644 --- a/src/cpu/intel/car/non-evict/cache_as_ram.S +++ b/src/cpu/intel/car/non-evict/cache_as_ram.S @@ -173,6 +173,11 @@ movl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %eax movl %eax, %esp + /* Align the stack 16 bytes */ + andl $0xfffffff0, %esp + /* Account for pushing the BIST result */ + sub $4, %esp + /* Restore the BIST result. */ movl %ebp, %eax movl %esp, %ebp diff --git a/src/cpu/intel/car/p4-netburst/cache_as_ram.S b/src/cpu/intel/car/p4-netburst/cache_as_ram.S index 58782b9..02fadf6 100644 --- a/src/cpu/intel/car/p4-netburst/cache_as_ram.S +++ b/src/cpu/intel/car/p4-netburst/cache_as_ram.S @@ -341,6 +341,10 @@ /* Setup the stack. */ movl $(CONFIG_DCACHE_RAM_BASE + CONFIG_DCACHE_RAM_SIZE), %eax movl %eax, %esp + /* Align the stack 16 bytes */ + andl $0xfffffff0, %esp + /* Account for pushing the BIST result */ + sub $4, %esp /* Restore the BIST result. */ movl %ebp, %eax -- To view, visit https://review.coreboot.org/26797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1415c18779bc481fdec5f72f83c06a58ce6d5c39 Gerrit-Change-Number: 26797 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018