coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: util/sconfig: Get rid of latestchild and next_sibling
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26805 ) Change subject: util/sconfig: Get rid of latestchild and next_sibling ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74099/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28215/ : SUCCESS -- To view, visit https://review.coreboot.org/26805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da64f6f10017c9c36f40b0d915f6dbffca9195e Gerrit-Change-Number: 26805 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 01:10:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Change walk_device_tree to breadth-first walk
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26803 ) Change subject: util/sconfig: Change walk_device_tree to breadth-first walk ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74098/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28214/ : SUCCESS -- To view, visit https://review.coreboot.org/26803 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I485b2c51f091d5186f8bc8f3075f28193148e940 Gerrit-Change-Number: 26803 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 01:09:05 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of unused parameter to walk_device_tree
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26801 ) Change subject: util/sconfig: Get rid of unused parameter to walk_device_tree ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74097/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28213/ : SUCCESS -- To view, visit https://review.coreboot.org/26801 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I255ff030562073b16310fc22a0981808bf2c062f Gerrit-Change-Number: 26801 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 01:06:37 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of struct header
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26739 ) Change subject: util/sconfig: Get rid of struct header ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74093/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28209/ : SUCCESS -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 01:02:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Make queue handling more generic within main.c
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26802 ) Change subject: util/sconfig: Make queue handling more generic within main.c ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74096/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28212/ : SUCCESS -- To view, visit https://review.coreboot.org/26802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd2de85b48c5d4e2790bf974ea3bb1bd387f66ee Gerrit-Change-Number: 26802 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 01:02:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of nextdev member in struct device
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26741 ) Change subject: util/sconfig: Get rid of nextdev member in struct device ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74095/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28211/ : SUCCESS -- To view, visit https://review.coreboot.org/26741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie50b3d769a78fe0beddba2e5551441b43cb212a2 Gerrit-Change-Number: 26741 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 00:58:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Add support for multiple device instances
by build bot (Jenkins) (Code Review) 04 Jun '18

04 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 ) Change subject: util/sconfig: Add support for multiple device instances ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74094/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28210/ : SUCCESS -- To view, visit https://review.coreboot.org/26800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1 Gerrit-Change-Number: 26800 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 00:54:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of rescnt in struct device
by Furquan Shaikh (Code Review) 04 Jun '18

04 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26806 Change subject: util/sconfig: Get rid of rescnt in struct device ...................................................................... util/sconfig: Get rid of rescnt in struct device This change gets rid of rescnt member in struct device since it is redundant. "res" member can be used to determine if resource list is present or not. BUG=b:80081934 TEST=Verified that static.c generated with and without this CL is exactly the same for all boards built using abuild. Change-Id: I73a2361686ad1130716a7d29576f2d02b9ed33c1 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h 2 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/26806/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 5c32178..f98cc5f 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -486,7 +486,6 @@ } else { dev->res = r; } - dev->rescnt++; } void add_register(struct chip_instance *chip_instance, char *name, char *val) @@ -567,7 +566,7 @@ } fprintf(fil, "DEVTREE_CONST static struct device %s;\n", ptr->name); - if (ptr->rescnt > 0) + if (ptr->res) fprintf(fil, "DEVTREE_CONST struct resource %s_res[];\n", ptr->name); if (ptr->children || device_has_instance(ptr)) @@ -583,7 +582,7 @@ static void emit_resources(FILE *fil, struct device *ptr) { - if (ptr->rescnt == 0) + if (!ptr->res) return; int i = 1; @@ -692,7 +691,7 @@ fprintf(fil, "\t.subsystem_device = 0x%04x,\n", ptr->subsystem_device); - if (ptr->rescnt > 0) { + if (ptr->res) { fprintf(fil, "\t.resource_list = &%s_res[0],\n", ptr->name); } diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index 2c52d23..10d58ae 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -89,7 +89,6 @@ struct device { int id; int enabled; - int rescnt; int subsystem_vendor; int subsystem_device; int inherit_subsystem; -- To view, visit https://review.coreboot.org/26806 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I73a2361686ad1130716a7d29576f2d02b9ed33c1 Gerrit-Change-Number: 26806 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: util/sconfig: Get rid of next pointer in struct device
by Furquan Shaikh (Code Review) 04 Jun '18

04 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26804 Change subject: util/sconfig: Get rid of next pointer in struct device ...................................................................... util/sconfig: Get rid of next pointer in struct device next pointer in struct device is used for adding ".next" field for a device while generating static.c. Now that we are using breadth-first walk to walk the device tree, bfs_queue can be used to determine what the next node is in the queue and add that to ".next" field. Additionally, if there is no node left in the bfs_queue, then current node is the last device in the list. It can be set to last_dev variable. This change gets rid of "next" pointer in struct device and uses bfs_queue to determine the ".next" field for any given node. It also eliminates the need of having a "lastnode" variable. BUG=b:80081934 TEST=Verified that all boards build successfully using abuild and static.c generated with and without this CL differs only in the order of .next list. The reason for the difference is that the traversal order was different earlier. Change-Id: Ic54a0d5c799baa222bb1ddba01726ee5d29c0cd5 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.y 4 files changed, 30 insertions(+), 22 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/26804/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index d60fb03..7540fc5 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -20,9 +20,8 @@ extern int linenum; -struct device *head, *lastnode; - static struct chip chip_header; +struct device *tree_root; /* * This is intentionally shared between chip and device structure ids because it @@ -152,6 +151,14 @@ return data; } +static void *peek_queue_head(struct queue *queue) +{ + if (!queue) + return NULL; + + return queue->data; +} + static struct queue *chip_queue; void chip_enqueue_tail(void *data) @@ -172,8 +179,6 @@ dev->parent = parent; dev->subsystem_vendor = -1; dev->subsystem_device = -1; - head->next = dev; - head = dev; return dev; } @@ -448,9 +453,6 @@ if (device_has_instance(parent) && !parent->last_instance->children) parent->last_instance->children = new_d; - lastnode->next = new_d; - lastnode = new_d; - switch (bustype) { case PCI: new_d->path = ".type=DEVICE_PATH_PCI,{.pci={ .devfn = PCI_DEVFN(0x%x,%d)}}"; @@ -591,7 +593,7 @@ dev->pci_irq_info[srcpin].ioapic_dst_id = apicid; } -static void pass0(FILE * fil, struct device *ptr) +static void pass0(FILE * fil, struct device *ptr, struct device *next) { if (ptr->id == 0) { fprintf(fil, "DEVTREE_CONST struct bus %s_links[];\n", @@ -606,6 +608,12 @@ if (ptr->children || device_has_instance(ptr)) fprintf(fil, "DEVTREE_CONST struct bus %s_links[];\n", ptr->name); + + if (next) + return; + + fprintf(fil, "DEVTREE_CONST struct device * DEVTREE_CONST last_dev = &%s;\n", + ptr->name); } static void emit_resources(FILE *fil, struct device *ptr) @@ -683,7 +691,7 @@ fprintf(fil, "\t};\n"); } -static void pass1(FILE * fil, struct device *ptr) +static void pass1(FILE * fil, struct device *ptr, struct device *next) { int pin; struct chip_instance *chip_ins = ptr->chip_instance; @@ -738,8 +746,8 @@ if (chip_ins->chip->chiph_exists) fprintf(fil, "\t.chip_info = &%s_info_%d,\n", chip_ins->chip->name_underscore, chip_ins->id); - if (ptr->next) - fprintf(fil, "\t.next=&%s\n", ptr->next->name); + if (next) + fprintf(fil, "\t.next=&%s\n", next->name); fprintf(fil, "};\n"); emit_resources(fil, ptr); @@ -773,15 +781,17 @@ } static void walk_device_tree(FILE * fil, struct device *ptr, - void (*func) (FILE *, struct device *)) + void (*func) (FILE *, struct device *, + struct device *)) { struct queue *bfs_queue = NULL; + struct device *tmp; enqueue_tail(&bfs_queue, ptr); while ((ptr = dequeue_head(&bfs_queue))) { add_children_to_queue(&bfs_queue, ptr); - func(fil, ptr); + func(fil, ptr, peek_queue_head(bfs_queue)); } } @@ -848,7 +858,8 @@ } } -static void inherit_subsystem_ids(FILE * file, struct device *dev) +static void inherit_subsystem_ids(FILE * file, struct device *dev, + struct device *next) { struct device *p; @@ -899,7 +910,7 @@ yyrestart(filec); - lastnode = head = &root; + tree_root = &root; yyparse(); @@ -918,9 +929,7 @@ walk_device_tree(autogen, &root, inherit_subsystem_ids); fprintf(autogen, "\n/* pass 0 */\n"); walk_device_tree(autogen, &root, pass0); - fprintf(autogen, "\n/* pass 1 */\n" - "DEVTREE_CONST struct device * DEVTREE_CONST last_dev = &%s;\n", - lastnode->name); + fprintf(autogen, "\n/* pass 1 */\n"); walk_device_tree(autogen, &root, pass1); fclose(autogen); diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index 76913c5..e4f2270 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -108,7 +108,6 @@ */ int linknum; - struct device *next; struct device *children; struct device *latestchild; struct device *next_sibling; @@ -123,7 +122,7 @@ struct dev_instance *last_instance; }; -extern struct device *head; +extern struct device *tree_root; void fold_in(struct device *parent); diff --git a/util/sconfig/sconfig.tab.c_shipped b/util/sconfig/sconfig.tab.c_shipped index 61f3b50..152e70d 100644 --- a/util/sconfig/sconfig.tab.c_shipped +++ b/util/sconfig/sconfig.tab.c_shipped @@ -1287,7 +1287,7 @@ { case 2: - { cur_parent = head; } + { cur_parent = tree_root; } break; diff --git a/util/sconfig/sconfig.y b/util/sconfig/sconfig.y index 37ac95f..48a727f 100755 --- a/util/sconfig/sconfig.y +++ b/util/sconfig/sconfig.y @@ -33,7 +33,7 @@ %token CHIP DEVICE REGISTER BOOL BUS RESOURCE END EQUALS HEX STRING PCI PNP I2C APIC CPU_CLUSTER CPU DOMAIN IRQ DRQ IO NUMBER SUBSYSTEMID INHERIT IOAPIC_IRQ IOAPIC PCIINT GENERIC SPI USB MMIO %% -devtree: { cur_parent = head; } chip { postprocess_devtree(); } ; +devtree: { cur_parent = tree_root; } chip { postprocess_devtree(); } ; chipchildren: chipchildren device | chipchildren chip | chipchildren registers | /* empty */ ; -- To view, visit https://review.coreboot.org/26804 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic54a0d5c799baa222bb1ddba01726ee5d29c0cd5 Gerrit-Change-Number: 26804 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: util/sconfig: Get rid of latestchild and next_sibling
by Furquan Shaikh (Code Review) 04 Jun '18

04 Jun '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26805 Change subject: util/sconfig: Get rid of latestchild and next_sibling ...................................................................... util/sconfig: Get rid of latestchild and next_sibling latestchild and next_sibling members of struct device were primarily used for walking the device tree. Now that we are using breadth-first walk, there is no need for these members. This CL gets rid of latestchild and next_sibling and the functions required to update these pointers during tree parsing i.e. fold_in and postprocess_devtree. BUG=b:80081934 TEST=Verified that the static.c generated with and without this CL is exactly the same for all boards built using abuild. Change-Id: I0da64f6f10017c9c36f40b0d915f6dbffca9195e Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M util/sconfig/main.c M util/sconfig/sconfig.h M util/sconfig/sconfig.tab.c_shipped M util/sconfig/sconfig.y 4 files changed, 3 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/26805/1 diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 7540fc5..5c32178 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -191,25 +191,6 @@ return !!d->linkcnt; } -void fold_in(struct device *parent) -{ - struct device *child; - struct device *latest = 0; - - child = device_has_instance(parent) ? parent->last_instance->children - : parent->children; - - while (child != latest) { - if (child->children) { - if (!latest) - latest = child->children; - parent->latestchild->next_sibling = child->children; - parent->latestchild = child->latestchild; - } - child = child->next_sibling; - } -} - int yywrap(void) { return 1; @@ -222,17 +203,6 @@ exit(1); } -void postprocess_devtree(void) -{ - root.next_sibling = root.children; - - /* - * Since root is statically created we need to call fold_in explicitly - * here to have the next_sibling and latestchild setup correctly. - */ - fold_in(&root); -} - char *translate_name(const char *str, translate_t mode) { char *b, *c; @@ -427,11 +397,6 @@ if (parent->linkcnt) new_d->linknum = parent->linkcnt - 1; - if (parent->latestchild) - parent->latestchild->next_sibling = new_d; - - parent->latestchild = new_d; - struct device *c; c = device_has_instance(parent) ? parent->last_instance->children : parent->children; diff --git a/util/sconfig/sconfig.h b/util/sconfig/sconfig.h index e4f2270..2c52d23 100644 --- a/util/sconfig/sconfig.h +++ b/util/sconfig/sconfig.h @@ -109,8 +109,6 @@ int linknum; struct device *children; - struct device *latestchild; - struct device *next_sibling; struct device *sibling; struct resource *res; @@ -124,10 +122,6 @@ extern struct device *tree_root; -void fold_in(struct device *parent); - -void postprocess_devtree(void); - struct device *new_device(struct device *parent, struct chip_instance *chip_instance, const int bustype, const char *devnum, diff --git a/util/sconfig/sconfig.tab.c_shipped b/util/sconfig/sconfig.tab.c_shipped index 152e70d..b9300ce 100644 --- a/util/sconfig/sconfig.tab.c_shipped +++ b/util/sconfig/sconfig.tab.c_shipped @@ -487,8 +487,8 @@ static const yytype_uint8 yyrline[] = { 0, 36, 36, 36, 38, 38, 38, 38, 40, 40, - 40, 40, 40, 40, 42, 42, 51, 51, 60, 63, - 66, 69, 72 + 40, 40, 40, 40, 42, 42, 51, 51, 59, 62, + 65, 68, 71 }; #endif @@ -1291,12 +1291,6 @@ break; - case 3: - - { postprocess_devtree(); } - - break; - case 14: { @@ -1328,7 +1322,6 @@ { cur_parent = (yyvsp[-2].device)->parent; - fold_in((yyvsp[-2].device)); } break; diff --git a/util/sconfig/sconfig.y b/util/sconfig/sconfig.y index 48a727f..4c05a47 100755 --- a/util/sconfig/sconfig.y +++ b/util/sconfig/sconfig.y @@ -33,7 +33,7 @@ %token CHIP DEVICE REGISTER BOOL BUS RESOURCE END EQUALS HEX STRING PCI PNP I2C APIC CPU_CLUSTER CPU DOMAIN IRQ DRQ IO NUMBER SUBSYSTEMID INHERIT IOAPIC_IRQ IOAPIC PCIINT GENERIC SPI USB MMIO %% -devtree: { cur_parent = tree_root; } chip { postprocess_devtree(); } ; +devtree: { cur_parent = tree_root; } chip; chipchildren: chipchildren device | chipchildren chip | chipchildren registers | /* empty */ ; @@ -54,7 +54,6 @@ } devicechildren END { cur_parent = $<device>5->parent; - fold_in($<device>5); }; resource: RESOURCE NUMBER /* == resnum */ EQUALS NUMBER /* == resval */ -- To view, visit https://review.coreboot.org/26805 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0da64f6f10017c9c36f40b0d915f6dbffca9195e Gerrit-Change-Number: 26805 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018