build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/24905 )
Change subject: drivers/tpm: Add TPM ramstage driver for devices without vboot.
......................................................................
Patch Set 9:
No Builds Executed
--
To view, visit https://review.coreboot.org/24905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7536c9734732aeaa85ccc7916c12eecb9ca26b2e
Gerrit-Change-Number: 24905
Gerrit-PatchSet: 9
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 21:00:33 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26845
Change subject: gma: Add contract to Enable_Output() to rely less on proof inlining
......................................................................
gma: Add contract to Enable_Output() to rely less on proof inlining
Change-Id: I7bc066b33c969e528c7bcd9328178fac8a37ad21
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma.adb
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/45/26845/1
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index a5e9dbe..ab4e1e2 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -97,6 +97,8 @@
(Pipe : in Pipe_Index;
Pipe_Cfg : in Pipe_Config;
Success : out Boolean)
+ with
+ Pre => Pipe_Cfg.Port in Active_Port_Type
is
Port_Cfg : Port_Config;
Scaler_Available : Boolean;
--
To view, visit https://review.coreboot.org/26845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc066b33c969e528c7bcd9328178fac8a37ad21
Gerrit-Change-Number: 26845
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26844
Change subject: gma display probing: Use expression functions for less proof inlining
......................................................................
gma display probing: Use expression functions for less proof inlining
Change-Id: Ibd10238a3cb5c109dee321ad76ef978465ea7d34
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-display_probing.adb
1 file changed, 20 insertions(+), 39 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/44/26844/1
diff --git a/common/hw-gfx-gma-display_probing.adb b/common/hw-gfx-gma-display_probing.adb
index ab6c05f..9f756f6 100644
--- a/common/hw-gfx-gma-display_probing.adb
+++ b/common/hw-gfx-gma-display_probing.adb
@@ -27,49 +27,30 @@
package body HW.GFX.GMA.Display_Probing
is
- function Port_Configured
- (Configs : Pipe_Configs;
- Port : Port_Type)
- return Boolean
- with
- Global => null
- is
- begin
- return Configs (Primary).Port = Port or
- Configs (Secondary).Port = Port or
- Configs (Tertiary).Port = Port;
- end Port_Configured;
+ function Port_Configured (Configs : Pipe_Configs; Port : Port_Type)
+ return Boolean is
+ (Configs (Primary).Port = Port or
+ Configs (Secondary).Port = Port or
+ Configs (Tertiary).Port = Port);
-- DP and HDMI share physical pins.
- function Sibling_Port (Port : Port_Type) return Port_Type
- is
- begin
- return
- (case Port is
- when HDMI1 => DP1,
- when HDMI2 => DP2,
- when HDMI3 => DP3,
- when DP1 => HDMI1,
- when DP2 => HDMI2,
- when DP3 => HDMI3,
- when others => Disabled);
- end Sibling_Port;
+ function Sibling_Port (Port : Port_Type) return Port_Type is
+ (case Port is
+ when HDMI1 => DP1,
+ when HDMI2 => DP2,
+ when HDMI3 => DP3,
+ when DP1 => HDMI1,
+ when DP2 => HDMI2,
+ when DP3 => HDMI3,
+ when others => Disabled);
- function Has_Sibling_Port (Port : Port_Type) return Boolean
- is
- begin
- return Sibling_Port (Port) /= Disabled;
- end Has_Sibling_Port;
+ function Has_Sibling_Port (Port : Port_Type) return Boolean is
+ (Sibling_Port (Port) /= Disabled);
- function Is_DVI_I (Port : Active_Port_Type) return Boolean
- with
- Global => null
- is
- begin
- return Config.Have_DVI_I and
- (Port = Analog or
- Config_Helpers.To_PCH_Port (Port) = Config.Analog_I2C_Port);
- end Is_DVI_I;
+ function Is_DVI_I (Port : Active_Port_Type) return Boolean is
+ (Config.Have_DVI_I and
+ (Port = Analog or
+ Config_Helpers.To_PCH_Port (Port) = Config.Analog_I2C_Port));
procedure Read_EDID
(Raw_EDID : out EDID.Raw_EDID_Data;
--
To view, visit https://review.coreboot.org/26844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd10238a3cb5c109dee321ad76ef978465ea7d34
Gerrit-Change-Number: 26844
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/26841
Change subject: gfx: Increase range of Frequency_Type
......................................................................
gfx: Increase range of Frequency_Type
New range limits are the minimum and maximum CDClk for Broxton.
Change-Id: I55a77b73ffef90eb08551c49978d020b1cf7eecc
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx.ads
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/41/26841/1
diff --git a/common/hw-gfx.ads b/common/hw-gfx.ads
index a6c883e..86ef51b 100644
--- a/common/hw-gfx.ads
+++ b/common/hw-gfx.ads
@@ -63,7 +63,7 @@
Rotation => No_Rotation,
Offset => 0);
- subtype Frequency_Type is Pos64 range 24_000_000 .. 600_000_000;
+ subtype Frequency_Type is Pos64 range 19_200_000 .. 624_000_000;
type DP_Lane_Count is (DP_Lane_Count_1, DP_Lane_Count_2, DP_Lane_Count_4);
subtype DP_Lane_Count_Type is Pos64 range 1 .. 4;
--
To view, visit https://review.coreboot.org/26841
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I55a77b73ffef90eb08551c49978d020b1cf7eecc
Gerrit-Change-Number: 26841
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>