coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: util/cbmem: Add cbmem TCPA log support
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26244 ) Change subject: util/cbmem: Add cbmem TCPA log support ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74236/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28350/ : SUCCESS -- To view, visit https://review.coreboot.org/26244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2253d86cfc675d45b0a728794cc784215401f4a Gerrit-Change-Number: 26244 Gerrit-PatchSet: 6 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 22:37:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/tpm: Add TCPA logging functionality
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22867 ) Change subject: security/tpm: Add TCPA logging functionality ...................................................................... Patch Set 31: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74234/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28348/ : SUCCESS -- To view, visit https://review.coreboot.org/22867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a52494f647d21e2587231af26ed13d62b3a72f5 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 31 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 22:16:04 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/tpm: Add TPM_PCRRead function to the TSS
by Philipp Deppenwiese (Code Review) 05 Jun '18

05 Jun '18

Philipp Deppenwiese has abandoned this change. ( https://review.coreboot.org/22831 ) Change subject: security/tpm: Add TPM_PCRRead function to the TSS ...................................................................... Abandoned Not needed anymore -- To view, visit https://review.coreboot.org/22831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: Ic85517a8a69f352a02d20a67fbba3d910ef03a1c Gerrit-Change-Number: 22831 Gerrit-PatchSet: 16 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by Philipp Deppenwiese (Code Review) 05 Jun '18

05 Jun '18

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22872 ) Change subject: security/crypto: Add crypto primitives for hashing data ...................................................................... Patch Set 26: (5 comments) https://review.coreboot.org/#/c/22872/21/src/security/Kconfig File src/security/Kconfig: https://review.coreboot.org/#/c/22872/21/src/security/Kconfig@17 PS21, Line 17: > replace all of these with: […] Done https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig File src/security/crypto/Kconfig: https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@15 PS21, Line 15: menu "Cryptographic Primitives" : : config CRYPTO_HASH > Do we need 2 levels of menus? Done https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@24 PS21, Line 24: ds on CRYPTO_HA > Do these need to be user selectable, or would they be set from inside another Kconfig? Done https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@26 PS21, Line 26: Enable this opti > 1) Wouldn't 'depends on CRYPTO_HASH' be better? […] Done https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@49 PS21, Line 49: > 1) How is listing what's supported useful? […] Done -- To view, visit https://review.coreboot.org/22872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 26 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Anonymous Coward #1001824 Gerrit-Reviewer: Anonymous Coward #1001845 Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 22:04:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26725 ) Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74231/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28344/ : SUCCESS -- To view, visit https://review.coreboot.org/26725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Gerrit-Change-Number: 26725 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 21:57:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26724 ) Change subject: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74230/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28343/ : SUCCESS -- To view, visit https://review.coreboot.org/26724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 21:53:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22872 ) Change subject: security/crypto: Add crypto primitives for hashing data ...................................................................... Patch Set 24: (12 comments) https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h File src/security/crypto/hash.h: https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h@186 PS24, Line 186: * if <alg> is invalid. please, no space before tabs https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c File src/security/crypto/hash/sha1.c: https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@184 PS24, Line 184: while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@193 PS24, Line 193: for (i = 0; i < 5; i++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@277 PS24, Line 277: while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c File src/security/crypto/hash/sha256.c: https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@… PS24, Line 106: for (i = 0; i < 8; i++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@… PS24, Line 142: for (j = 0; j < 16; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@… PS24, Line 146: for (j = 16; j < 64; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@… PS24, Line 150: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@… PS24, Line 168: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c File src/security/crypto/hash/sha512.c: https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@… PS24, Line 293: for (j = 0; j < 16; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@… PS24, Line 297: for (j = 16; j < 80; j++) { braces {} are not necessary for single statement blocks https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@… PS24, Line 301: for (j = 0; j < 8; j++) { braces {} are not necessary for single statement blocks -- To view, visit https://review.coreboot.org/22872 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 24 Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: Anonymous Coward #1001824 Gerrit-Reviewer: Anonymous Coward #1001845 Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 04 Jun 2018 21:50:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018