coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: nb/intel/i945: Add default case for CPCTL
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26860 ) Change subject: nb/intel/i945: Add default case for CPCTL ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74289/ : SUCCESS -- To view, visit https://review.coreboot.org/26860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Gerrit-Change-Number: 26860 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 11:39:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26861 ) Change subject: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74288/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28398/ : SUCCESS -- To view, visit https://review.coreboot.org/26861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I438428449ac4bb6d55a9cedfefca271ca95aa965 Gerrit-Change-Number: 26861 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 11:35:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Add default case for CPCTL
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/26860 to look at the new patch set (#2). Change subject: nb/intel/i945: Add default case for CPCTL ...................................................................... nb/intel/i945: Add default case for CPCTL The default MCHBAR8(CPCTL) is 0x80. This value is also used for desktop chip version with FSB800. Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/26860/2 -- To view, visit https://review.coreboot.org/26860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Gerrit-Change-Number: 26860 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: nb/intel/i945: Add default case for CPCTL
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26860 ) Change subject: nb/intel/i945: Add default case for CPCTL ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74285/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28395/ : SUCCESS -- To view, visit https://review.coreboot.org/26860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Gerrit-Change-Number: 26860 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 11:28:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26861 Change subject: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO ...................................................................... nb/intel/i945: Move 'N/A FSB' to BIOS_INFO Let as know if FSB information is not available. Change-Id: I438428449ac4bb6d55a9cedfefca271ca95aa965 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/early_init.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/26861/1 diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index bf486a0..2711a96 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -72,7 +72,7 @@ printk(BIOS_DEBUG, "533 MHz"); break; default: - printk(BIOS_DEBUG, "N/A MHz (%02x)", reg8); + printk(BIOS_INFO, "N/A FSB MHz (%02x)", reg8); } printk(BIOS_DEBUG, "\n"); -- To view, visit https://review.coreboot.org/26861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I438428449ac4bb6d55a9cedfefca271ca95aa965 Gerrit-Change-Number: 26861 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/i945: Add default case for CPCTL
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/26860 Change subject: nb/intel/i945: Add default case for CPCTL ...................................................................... nb/intel/i945: Add default case for CPCTL The default MCHBAR8(CPCTL) is 0x80. This value is also used for on desktop with FSB800. Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/i945/raminit.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/26860/1 diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c index 6719961..8405134 100644 --- a/src/northbridge/intel/i945/raminit.c +++ b/src/northbridge/intel/i945/raminit.c @@ -1622,11 +1622,13 @@ /* Only write the lower byte */ switch (sysinfo->fsb_frequency) { case 400: - MCHBAR8(CPCTL) = 0x90; break; /* FSB400 */ + MCHBAR8(CPCTL) = 0x90; break; /* FSB400 */ case 533: MCHBAR8(CPCTL) = 0x95; break; /* FSB533 */ case 667: MCHBAR8(CPCTL) = 0x8d; break; /* FSB667 */ + default: + MCHBAR8(CPCTL) = 0x80; } MCHBAR16(CPCTL) &= ~(1 << 11); -- To view, visit https://review.coreboot.org/26860 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb343ff45ccb2c10a6d2ac294d80add67dd4a1d6 Gerrit-Change-Number: 26860 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: mb/pcengines: Remove unneeded includes and fix coding style
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26633 ) Change subject: mb/pcengines: Remove unneeded includes and fix coding style ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74284/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28394/ : SUCCESS -- To view, visit https://review.coreboot.org/26633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id13c0ee284293c0c06d46c75c850bc7e81cfc1f6 Gerrit-Change-Number: 26633 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 05 Jun 2018 11:03:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/pcengines: Remove unneeded includes and fix coding style
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26633 ) Change subject: mb/pcengines: Remove unneeded includes and fix coding style ...................................................................... Patch Set 3: (2 comments) https://review.coreboot.org/#/c/26633/3/src/mainboard/pcengines/apu2/mptabl… File src/mainboard/pcengines/apu2/mptable.c: https://review.coreboot.org/#/c/26633/3/src/mainboard/pcengines/apu2/mptabl… PS3, Line 24: 0x03, 0x03, 0x05, 0x07, 0x0B, 0x0A, 0x1F, 0x1F, /* 00 - 07 : INTA - INTF and 2 reserved dont map 4*/ line over 80 characters https://review.coreboot.org/#/c/26633/3/src/mainboard/pcengines/apu2/mptabl… PS3, Line 40: 0x10, 0x10, 0x12, 0x13, 0x14, 0x15, 0x1F, 0x1F, /* 00 - 07 : INTA - INTF and 2 reserved dont map 4*/ line over 80 characters -- To view, visit https://review.coreboot.org/26633 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id13c0ee284293c0c06d46c75c850bc7e81cfc1f6 Gerrit-Change-Number: 26633 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Tue, 05 Jun 2018 10:59:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26859 ) Change subject: [WIP]cpu/intel/haswell: Use C_ENVIRONMENT_BOOTBLOCK ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/74283/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/28393/ : SUCCESS -- To view, visit https://review.coreboot.org/26859 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96499a9d478127f6b9d880883ac41397b58dbea Gerrit-Change-Number: 26859 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 09:36:16 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Disable rear camera/DMIC for vayne sku...
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26855 ) Change subject: mb/google/poppy/variants/nami: Disable rear camera/DMIC for vayne skuid 3A67 ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74282/ : SUCCESS -- To view, visit https://review.coreboot.org/26855 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9131b4c41bf189829be4e7e6bfaf4a96765cfa15 Gerrit-Change-Number: 26855 Gerrit-PatchSet: 4 Gerrit-Owner: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 09:31:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018