coreboot-gerrit June 2018

coreboot-gerrit@coreboot.org

1 participants
2751 discussions

Change in coreboot[master]: util/sconfig: Get rid of nextdev member in struct device
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26741 ) Change subject: util/sconfig: Get rid of nextdev member in struct device ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74295/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28404/ : SUCCESS -- To view, visit https://review.coreboot.org/26741 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie50b3d769a78fe0beddba2e5551441b43cb212a2 Gerrit-Change-Number: 26741 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:20:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Get rid of struct header
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26739 ) Change subject: util/sconfig: Get rid of struct header ...................................................................... Patch Set 7: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74293/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28402/ : SUCCESS -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:16:48 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Add helper function for allocating memory
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26738 ) Change subject: util/sconfig: Add helper function for allocating memory ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74294/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28403/ : SUCCESS -- To view, visit https://review.coreboot.org/26738 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56a70cf4865c50ed238226ace86e867bb1ec53db Gerrit-Change-Number: 26738 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:16:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Re-factor emitting of headers to static.c
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26726 ) Change subject: util/sconfig: Re-factor emitting of headers to static.c ...................................................................... Patch Set 6: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74292/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28401/ : SUCCESS -- To view, visit https://review.coreboot.org/26726 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24d526e81323115d3cc927242a4b9e49414afbe0 Gerrit-Change-Number: 26726 Gerrit-PatchSet: 6 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:12:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Get rid of bus pointer in device structure
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26736 ) Change subject: util/sconfig: Get rid of bus pointer in device structure ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/74290/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/28399/ : SUCCESS -- To view, visit https://review.coreboot.org/26736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f8fe1545a9ed53d66d6d4462df4a5d63023844 Gerrit-Change-Number: 26736 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:10:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Add support for multiple device instances
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 ) Change subject: util/sconfig: Add support for multiple device instances ...................................................................... Patch Set 3: (5 comments) https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c File util/sconfig/main.c: https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@564 PS3, Line 564: if (ptr->children || device_has_instance(ptr)) suspect code indent for conditional statements (8, 24) https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@668 PS3, Line 668: fprintf(fil, "\t.pci_irq_info[%d].ioapic_irq_pin = %d,\n", line over 80 characters https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@672 PS3, Line 672: fprintf(fil, "\t.pci_irq_info[%d].ioapic_dst_id = %d,\n", line over 80 characters https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@692 PS3, Line 692: fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore); line over 80 characters https://review.coreboot.org/#/c/26800/3/util/sconfig/main.c@707 PS3, Line 707: else if(ptr->children) space required before the open parenthesis '(' -- To view, visit https://review.coreboot.org/26800 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1 Gerrit-Change-Number: 26800 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:08:24 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Re-factor sconfig to not assume chip as device
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26720 ) Change subject: util/sconfig: Re-factor sconfig to not assume chip as device ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/28400/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/74291/ : SUCCESS -- To view, visit https://review.coreboot.org/26720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I255092f527c8eecb144385eb681df20e54caf8f5 Gerrit-Change-Number: 26720 Gerrit-PatchSet: 9 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:07:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/sconfig: Get rid of struct header
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26739 ) Change subject: util/sconfig: Get rid of struct header ...................................................................... Patch Set 7: (1 comment) https://review.coreboot.org/#/c/26739/7/util/sconfig/main.c File util/sconfig/main.c: https://review.coreboot.org/#/c/26739/7/util/sconfig/main.c@542 PS7, Line 542: fprintf(fil, "\t.chip_ops = &%s_ops,\n", chip_ins->chip->name_underscore); line over 80 characters -- To view, visit https://review.coreboot.org/26739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6fccdf7c361b4f55a831195adcda9b21932755aa Gerrit-Change-Number: 26739 Gerrit-PatchSet: 7 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:07:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: util/sconfig: Get rid of bus pointer in device structure
by build bot (Jenkins) (Code Review) 05 Jun '18

05 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26736 ) Change subject: util/sconfig: Get rid of bus pointer in device structure ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/#/c/26736/5/util/sconfig/main.c File util/sconfig/main.c: https://review.coreboot.org/#/c/26736/5/util/sconfig/main.c@333 PS5, Line 333: while (cmp && (cmp->parent == d->parent) && (cmp->path_a == d->path_a) line over 80 characters -- To view, visit https://review.coreboot.org/26736 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21f8fe1545a9ed53d66d6d4462df4a5d63023844 Gerrit-Change-Number: 26736 Gerrit-PatchSet: 5 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 05 Jun 2018 12:07:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO
by Elyes HAOUAS (Code Review) 05 Jun '18

05 Jun '18

Elyes HAOUAS has abandoned this change. ( https://review.coreboot.org/26861 ) Change subject: nb/intel/i945: Move 'N/A FSB' to BIOS_INFO ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/26861 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I438428449ac4bb6d55a9cedfefca271ca95aa965 Gerrit-Change-Number: 26861 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2018