coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25970 ) Change subject: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71093/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25267/ : SUCCESS -- To view, visit https://review.coreboot.org/25970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I616a96526ed90bb4ab0c9c6b78787799faa02633 Gerrit-Change-Number: 25970 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 May 2018 21:30:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridge: remove sb_set_readspeed function
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25969 ) Change subject: soc/amd/stoneyridge: remove sb_set_readspeed function ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-checkpatch/25266/ : FAILURE https://qa.coreboot.org/job/coreboot-gerrit/71092/ : SUCCESS -- To view, visit https://review.coreboot.org/25969 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b20cf559ee759ba94d49ff6810a9baa64e86fb Gerrit-Change-Number: 25969 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 May 2018 21:27:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode
by Marc Jones (Code Review) 01 May '18

01 May '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/25970 Change subject: google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode ...................................................................... google/kahlee: Set SPI 100 MHz and SPI Dual Read IO mode Set SPI Fast Read to 100MHz and Dual Read IO mode to speed up the boot process by over a half second. Also, increase the Normal Read speed to 33MHz as supported by the W25Q128FW. BUG=b:70558952 TEST=Run cbmem -t to get boot times. Change-Id: I616a96526ed90bb4ab0c9c6b78787799faa02633 Signed-off-by: Marc Jones <marc.jones(a)scarletltd.com> --- M src/mainboard/google/kahlee/bootblock/bootblock.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/25970/1 diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c index 577c105..aac1d95 100644 --- a/src/mainboard/google/kahlee/bootblock/bootblock.c +++ b/src/mainboard/google/kahlee/bootblock/bootblock.c @@ -34,9 +34,17 @@ void bootblock_mainboard_init(void) { + /* + * W25Q128FW Setup + * Normal Read 40MHz + * Fast Read 104MHz + * Dual Read IO (1-2-2) + */ + sb_read_mode(SPI_READ_MODE_DUAL122); + /* Set SPI speeds before verstage. Needed for TPM */ - sb_set_spi100(SPI_SPEED_22M, /* Normal */ - SPI_SPEED_66M, /* Fast */ + sb_set_spi100(SPI_SPEED_33M, /* Normal */ + SPI_SPEED_100M, /* Fast */ SPI_SPEED_66M, /* AltIO */ SPI_SPEED_66M); /* TPM */ -- To view, visit https://review.coreboot.org/25970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I616a96526ed90bb4ab0c9c6b78787799faa02633 Gerrit-Change-Number: 25970 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: remove sb_set_readspeed function
by Marc Jones (Code Review) 01 May '18

01 May '18

Marc Jones has uploaded this change for review. ( https://review.coreboot.org/25969 Change subject: soc/amd/stoneyridge: remove sb_set_readspeed function ...................................................................... soc/amd/stoneyridge: remove sb_set_readspeed function The sb_set_readspeed() was touching the wrong register and the read speed settings are handled by sb_set_spi100(). Nothing was using the function, so remove it. Change-Id: I23b20cf559ee759ba94d49ff6810a9baa64e86fb Signed-off-by: Marc Jones <marc.jones(a)scarletltd.com> --- M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/southbridge.c 2 files changed, 0 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/25969/1 diff --git a/src/soc/amd/stoneyridge/include/soc/southbridge.h b/src/soc/amd/stoneyridge/include/soc/southbridge.h index 96826e3..0a23fca 100644 --- a/src/soc/amd/stoneyridge/include/soc/southbridge.h +++ b/src/soc/amd/stoneyridge/include/soc/southbridge.h @@ -379,7 +379,6 @@ void sb_pci_port80(void); void sb_read_mode(u32 mode); void sb_set_spi100(u16 norm, u16 fast, u16 alt, u16 tpm); -void sb_set_readspeed(u16 norm, u16 fast); void sb_tpm_decode(void); void sb_tpm_decode_spi(void); void lpc_wideio_512_window(uint16_t base); diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index a767e0c..eb8820f 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -442,15 +442,6 @@ & ~SPI_RD4DW_EN_HOST); } -void sb_set_readspeed(u16 norm, u16 fast) -{ - uintptr_t base = sb_spibase(); - write16((void *)base + SPI_CNTRL1, (read16((void *)base + SPI_CNTRL1) - & ~SPI_CNTRL1_SPEED_MASK) - | (norm << SPI_NORM_SPEED_SH) - | (fast << SPI_FAST_SPEED_SH)); -} - void sb_read_mode(u32 mode) { uintptr_t base = sb_spibase(); -- To view, visit https://review.coreboot.org/25969 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I23b20cf559ee759ba94d49ff6810a9baa64e86fb Gerrit-Change-Number: 25969 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com>

1 0

Change in coreboot[master]: arch/x86: Relocate GDT in verstage, romstage and postcar
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25895 ) Change subject: arch/x86: Relocate GDT in verstage, romstage and postcar ...................................................................... Patch Set 6: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/71089/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/25263/ : SUCCESS -- To view, visit https://review.coreboot.org/25895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ded6e9b358b23e04d92bef5263bfe8c2a5ec5a Gerrit-Change-Number: 25895 Gerrit-PatchSet: 6 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 May 2018 20:58:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: asrock/b75pro3-m: fix the HDMI port
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25820 ) Change subject: asrock/b75pro3-m: fix the HDMI port ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71088/ : SUCCESS -- To view, visit https://review.coreboot.org/25820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb8a4ef55bd97fd2d0baacdbc72863c0985d3d76 Gerrit-Change-Number: 25820 Gerrit-PatchSet: 3 Gerrit-Owner: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 May 2018 19:24:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable Synaptics touchpad
by Martin Roth (Code Review) 01 May '18

01 May '18

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/25913 ) Change subject: mb/google/poppy/variants/nami: Enable Synaptics touchpad ...................................................................... mb/google/poppy/variants/nami: Enable Synaptics touchpad BUG=b:74595037 TEST= 1. emerge-nami coreboot chromeos-bootimage 2. check touchpad function 3. evtest /dev/input/event5: PNP0C50:00 06CB:CD84 Change-Id: I47cb1b13881f0d52860f0afe4bbca7483409de54 Signed-off-by: ivy_jian <ivy_jian(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/25913 Reviewed-by: Furquan Shaikh <furquan(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index b1c278c..c7a4c05 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -271,6 +271,15 @@ register "wake" = "GPE0_DW2_16" device i2c 15 on end end + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_E3_IRQ)" + register "generic.wake" = "GPE0_DW2_16" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end end # I2C #1 device pci 15.2 on chip drivers/i2c/hid -- To view, visit https://review.coreboot.org/25913 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I47cb1b13881f0d52860f0afe4bbca7483409de54 Gerrit-Change-Number: 25913 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: arch/x86: Relocate GDT in verstage, romstage and postcar
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25895 ) Change subject: arch/x86: Relocate GDT in verstage, romstage and postcar ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/71086/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/25261/ : SUCCESS -- To view, visit https://review.coreboot.org/25895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01ded6e9b358b23e04d92bef5263bfe8c2a5ec5a Gerrit-Change-Number: 25895 Gerrit-PatchSet: 5 Gerrit-Owner: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 01 May 2018 18:46:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/kahlee/variants/grunt: Enable BayHub720 driver
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25967 ) Change subject: mb/google/kahlee/variants/grunt: Enable BayHub720 driver ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71085/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25260/ : SUCCESS -- To view, visit https://review.coreboot.org/25967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I850e923f73e01fe629d66ad61b65afa58035845c Gerrit-Change-Number: 25967 Gerrit-PatchSet: 4 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 May 2018 18:33:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/generic/bayhub: Add driver for BayHub BH720
by build bot (Jenkins) (Code Review) 01 May '18

01 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25966 ) Change subject: drivers/generic/bayhub: Add driver for BayHub BH720 ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71084/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25259/ : SUCCESS -- To view, visit https://review.coreboot.org/25966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbfb114f3782c9386ce9b487c3abdb0afbc4a0d9 Gerrit-Change-Number: 25966 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 01 May 2018 18:18:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018