coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: mb/google/poppy/variants/nami: Enable synaptics TouchScreen support
by Ivy Jian (Code Review) 02 May '18

02 May '18

Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25915 to look at the new patch set (#2). Change subject: mb/google/poppy/variants/nami: Enable synaptics TouchScreen support ...................................................................... mb/google/poppy/variants/nami: Enable synaptics TouchScreen support BUG=b:74595040 BRANCH=master TEST= 1. emerge-nami coreboot chromeos-bootimage 2. Booted on Pantheon with S7817 PCBa connected 3. Check TouchScreen device is enabled by evtest /dev/input/event4: SYTS7817:00 06CB:7817 Change-Id: Ic11684d5ed961af5eb704909f7d06eb0898068c2 Signed-off-by: ivy_jian <ivy_jian(a)compal.corp-partner.google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/25915/2 -- To view, visit https://review.coreboot.org/25915 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic11684d5ed961af5eb704909f7d06eb0898068c2 Gerrit-Change-Number: 25915 Gerrit-PatchSet: 2 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: vx900: Move to EARLY_CBMEM_INIT
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25798 ) Change subject: vx900: Move to EARLY_CBMEM_INIT ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71125/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25302/ : SUCCESS -- To view, visit https://review.coreboot.org/25798 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9ae0f97f9f769a20a610f8d76f14165fb924042 Gerrit-Change-Number: 25798 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Wed, 02 May 2018 06:22:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device: Fix discarded-qualifiers compilation issue
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25985 ) Change subject: src/device: Fix discarded-qualifiers compilation issue ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71124/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25301/ : SUCCESS -- To view, visit https://review.coreboot.org/25985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9dfc9b19ce159ce1abcfbb287be4ce273cbaf1 Gerrit-Change-Number: 25985 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 05:19:56 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: src/device: Fix discarded-qualifiers compilation issue
by Subrata Banik (Code Review) 02 May '18

02 May '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/25985 Change subject: src/device: Fix discarded-qualifiers compilation issue ...................................................................... src/device: Fix discarded-qualifiers compilation issue coreboot build is broken due to CL: I6830a65bc9cea2907f4209bb97a53ccebcbf248d This patch ensures to build coreboot successfully. Change-Id: I4c9dfc9b19ce159ce1abcfbb287be4ce273cbaf1 Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/console/post.c M src/device/device_util.c M src/include/console/console.h M src/include/device/device.h 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/25985/1 diff --git a/src/console/post.c b/src/console/post.c index 1caa4b5..969c7c7 100644 --- a/src/console/post.c +++ b/src/console/post.c @@ -108,7 +108,7 @@ spin_unlock(&cmos_post_lock); } -void post_log_path(struct device *dev) +void post_log_path(const struct device *dev) { if (dev) { /* Encode path into lower 3 bytes */ diff --git a/src/device/device_util.c b/src/device/device_util.c index 3d7f5a1..a64b63a 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -209,7 +209,7 @@ * @param dev The device path to encode. * @return Device path encoded into lower 3 bytes of dword. */ -u32 dev_path_encode(struct device *dev) +u32 dev_path_encode(const struct device *dev) { u32 ret; diff --git a/src/include/console/console.h b/src/include/console/console.h index 1ecf89c..535401f 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -31,7 +31,7 @@ #if IS_ENABLED(CONFIG_CMOS_POST_EXTRA) void post_log_extra(u32 value); struct device; -void post_log_path(struct device *dev); +void post_log_path(const struct device *dev); void post_log_clear(void); #else #define post_log_extra(x) do {} while (0) diff --git a/src/include/device/device.h b/src/include/device/device.h index 48a5bcc..744836d 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -185,7 +185,7 @@ void assign_resources(struct bus *bus); const char *dev_name(struct device *dev); const char *dev_path(const struct device *dev); -u32 dev_path_encode(struct device *dev); +u32 dev_path_encode(const struct device *dev); const char *bus_path(struct bus *bus); void dev_set_enabled(struct device *dev, int enable); void disable_children(struct bus *bus); -- To view, visit https://review.coreboot.org/25985 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4c9dfc9b19ce159ce1abcfbb287be4ce273cbaf1 Gerrit-Change-Number: 25985 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: ec/google/chromeec: Update Tablet event call
by Furquan Shaikh (Code Review) 02 May '18

02 May '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25983 ) Change subject: ec/google/chromeec: Update Tablet event call ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/25983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Gerrit-Change-Number: 25983 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 04:11:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/reef: Remove tablet mode switch support
by Furquan Shaikh (Code Review) 02 May '18

02 May '18

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/25982 ) Change subject: mainboard/google/reef: Remove tablet mode switch support ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/25982/1/src/mainboard/google/reef/variants/… File src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h: https://review.coreboot.org/#/c/25982/1/src/mainboard/google/reef/variants/… PS1, Line 37: Why is this removed? -- To view, visit https://review.coreboot.org/25982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Comment-Date: Wed, 02 May 2018 04:11:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in coreboot[master]: ec/google/chromeec: Update Tablet event call
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25983 ) Change subject: ec/google/chromeec: Update Tablet event call ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71117/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25295/ : SUCCESS -- To view, visit https://review.coreboot.org/25983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Gerrit-Change-Number: 25983 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 02:59:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/google/reef: Remove tablet mode switch support
by build bot (Jenkins) (Code Review) 02 May '18

02 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25982 ) Change subject: mainboard/google/reef: Remove tablet mode switch support ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/71116/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/25294/ : SUCCESS -- To view, visit https://review.coreboot.org/25982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 02 May 2018 02:57:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ec/google/chromeec: Update Tablet event call
by Martin Roth (Code Review) 02 May '18

02 May '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25983 Change subject: ec/google/chromeec: Update Tablet event call ...................................................................... ec/google/chromeec: Update Tablet event call The tablet event handler method TPET is defined as an extern, then defined again in skylake, the only platform that supports it. In newer versions of IASL, this generates an error, as the method is defined in two places. Remove the extern and the CondRefOf check. That's not needed if we only set the EC_ENABLE_TABLET_EVENT define on platforms that have a TPET handler. Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/ec/google/chromeec/acpi/ec.asl 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/25983/1 diff --git a/src/ec/google/chromeec/acpi/ec.asl b/src/ec/google/chromeec/acpi/ec.asl index 9ec5f7f..ac4ceb1 100644 --- a/src/ec/google/chromeec/acpi/ec.asl +++ b/src/ec/google/chromeec/acpi/ec.asl @@ -24,7 +24,7 @@ #ifdef DPTF_ENABLE_CHARGER External (\_SB.DPTF.TCHG, DeviceObj) #endif -External (\_SB.DPTF.TPET, MethodObj) + Device (EC0) { @@ -373,9 +373,7 @@ Store ("EC: TABLET mode switch Event", Debug) Notify (CREC, 0x2) #ifdef EC_ENABLE_TABLET_EVENT - If (CondRefOf (\_SB.DPTF.TPET)) { - \_SB.DPTF.TPET() - } + \_SB.DPTF.TPET() #endif #ifdef EC_ENABLE_TBMC_DEVICE Notify (TBMC, 0x80) -- To view, visit https://review.coreboot.org/25983 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8bee069fc95637446593dfaaae1254e931421517 Gerrit-Change-Number: 25983 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboard/google/reef: Remove tablet mode switch support
by Martin Roth (Code Review) 02 May '18

02 May '18

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/25982 Change subject: mainboard/google/reef: Remove tablet mode switch support ...................................................................... mainboard/google/reef: Remove tablet mode switch support The _SB.DPTF.TPET ACPI code attached to EC_ENABLE_TABLET_EVENT doesn't exist in the apollo lake code. Remove it from reef as part of the cleanup to update to the new version of IASL. This was in commit 4f803ac28f4 (mainboards/google/reef: Add support for tablet mode switch.) Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116 Signed-off-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/25982/1 diff --git a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h index ff32ff6..ec18d62 100644 --- a/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/reef/variants/baseboard/include/baseboard/ec.h @@ -33,8 +33,7 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ - EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE)) + EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) #define MAINBOARD_EC_SMI_EVENTS \ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED)) @@ -71,9 +70,6 @@ #define EC_ENABLE_LID_SWITCH #define EC_ENABLE_WAKE_PIN GPE_EC_WAKE -/* Enable Tablet switch */ -#define EC_ENABLE_TABLET_EVENT - #define EC_ENABLE_TBMC_DEVICE #define SIO_EC_MEMMAP_ENABLE /* EC Memory Map Resources */ -- To view, visit https://review.coreboot.org/25982 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic10c418ddc708c1aed87ad4a9861f04d32445116 Gerrit-Change-Number: 25982 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018