coreboot-gerrit May 2018

coreboot-gerrit@coreboot.org

1 participants
3692 discussions

Change in coreboot[master]: cbfstool: add an option for creating a topswap bootblock
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 ) Change subject: cbfstool: add an option for creating a topswap bootblock ...................................................................... Patch Set 9: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73739/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27858/ : SUCCESS -- To view, visit https://review.coreboot.org/22537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e455dc8b7f54e55f2229491695cf4218d9cfef8 Gerrit-Change-Number: 22537 Gerrit-PatchSet: 9 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: dhaval v sharma <dhaval.v.sharma(a)intel.com> Gerrit-CC: Naresh Solanki <naresh.solanki(a)intel.com> Gerrit-Comment-Date: Thu, 31 May 2018 03:40:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26725 ) Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73738/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27857/ : SUCCESS -- To view, visit https://review.coreboot.org/26725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Gerrit-Change-Number: 26725 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Duncan Laurie <dlaurie(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 03:30:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26724 ) Change subject: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73737/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27856/ : SUCCESS -- To view, visit https://review.coreboot.org/26724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 03:28:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan p...
by Shelley Chen (Code Review) 31 May '18

31 May '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/26725 Change subject: mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on ...................................................................... mb/google/poppy/variants/nami: Add delay to enable_gpio during Elan power on During measurement of signals during Elan touchscreen power on, saw that the enable_gpio delay was not sufficient as there is a +1.5 ms delay during power on. Adding more delay to take this into account. BUG=b:78311818 BRANCH=None TEST=probe power on signals to ensure meet timing requirements Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/poppy/variants/nami/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/26725/1 diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb index 5e2575f..9c4b694 100644 --- a/src/mainboard/google/poppy/variants/nami/devicetree.cb +++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb @@ -296,7 +296,7 @@ register "reset_delay_ms" = "20" register "reset_off_delay_ms" = "2" register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B4)" - register "enable_delay_ms" = "1" + register "enable_delay_ms" = "5" register "enable_off_delay_ms" = "100" register "has_power_resource" = "1" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C3)" -- To view, visit https://review.coreboot.org/26725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id661a202188a97aef97514ebecd0be6fc022d21e Gerrit-Change-Number: 26725 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence
by Shelley Chen (Code Review) 31 May '18

31 May '18

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/26724 Change subject: mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence ...................................................................... mb/google/poppy/variants/nami: Fix Elan touchscreen power off sequence Power off does not seem to use the ACPI _OFF function, but rather the smihandler. Creating variant_smi_sleep function for nami to handle the power off sequence during reboot/power off. BUG=b:78311818 BRANCH=None TEST=Run "poweroff" command from AP console with SMI_DEBUG enabled Make sure delays are consistent with spec Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/poppy/variants/nami/Makefile.inc A src/mainboard/google/poppy/variants/nami/smihandler.c 4 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/26724/1 diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index e880581..c8ff749 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -21,6 +21,7 @@ #include <soc/gpio.h> #include <soc/smm.h> +#include <baseboard/variants.h> #include <variant/gpio.h> #include <variant/ec.h> @@ -29,8 +30,11 @@ chromeec_smi_process_events(); } +void __weak variant_smi_sleep(u8 slp_typ) {} + void mainboard_smi_sleep(u8 slp_typ) { + variant_smi_sleep(slp_typ); chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); } diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h index 97cb0fe..7e850b6 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h @@ -54,6 +54,7 @@ int variant_memory_sku(void); void variant_devtree_update(void); uint32_t variant_board_sku(void); +void variant_smi_sleep(u8 slp_typ); struct nhlt; void variant_nhlt_init(struct nhlt *nhlt); diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc index 618011c..8fc0264 100644 --- a/src/mainboard/google/poppy/variants/nami/Makefile.inc +++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc @@ -35,6 +35,8 @@ ramstage-y += nhlt.c ramstage-y += mainboard.c +smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c + # Add OEM ID table cbfs-files-y += oem.bin oem.bin-file := $(call strip_quotes,$(CONFIG_OEM_BIN_FILE)) diff --git a/src/mainboard/google/poppy/variants/nami/smihandler.c b/src/mainboard/google/poppy/variants/nami/smihandler.c new file mode 100644 index 0000000..85a7282 --- /dev/null +++ b/src/mainboard/google/poppy/variants/nami/smihandler.c @@ -0,0 +1,39 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/variants.h> +#include <console/console.h> +#include <delay.h> +#include <device/device.h> +#include "chip.h" +#include "gpio.h" +#include <drivers/i2c/generic/chip.h> + +void variant_smi_sleep(u8 slp_typ) +{ + const struct device *dev_i2c0 = dev_find_slot(0, PCH_DEVFN_I2C0); + const struct drivers_i2c_generic_config *conf = + dev_i2c0->link_list[0].children->chip_info; + + /* TOUCHSCREEN_DIS# */ + gpio_set(GPP_C3, 0); + mdelay(conf->stop_off_delay_ms); + /* TOUCHSCREEN_RST# */ + gpio_set(GPP_B3, 0); + mdelay(conf->reset_off_delay_ms); + /* EN_PP3300_DX_TOUCHSCREEN */ + gpio_set(GPP_B4, 0); + mdelay(conf->enable_off_delay_ms); +} -- To view, visit https://review.coreboot.org/26724 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ifeea545fe268be249793b3e508c51f5e4c1a3460 Gerrit-Change-Number: 26724 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com>

1 0

Change in coreboot[master]: drivers/intel/wifi: Add PCI ID for Intel TP2 Wi-Fi
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26723 ) Change subject: drivers/intel/wifi: Add PCI ID for Intel TP2 Wi-Fi ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73736/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27855/ : SUCCESS -- To view, visit https://review.coreboot.org/26723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51abf615fca6001d564e7cd672cc16f3a0fb8dd6 Gerrit-Change-Number: 26723 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 03:06:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/wifi: Add PCI ID for Intel TP2 Wi-Fi
by Furquan Shaikh (Code Review) 31 May '18

31 May '18

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/26723 Change subject: drivers/intel/wifi: Add PCI ID for Intel TP2 Wi-Fi ...................................................................... drivers/intel/wifi: Add PCI ID for Intel TP2 Wi-Fi This change adds PCI ID for Intel TP2 Wi-Fi and adds that to pci_device_ids in Intel wifi driver. Change-Id: I51abf615fca6001d564e7cd672cc16f3a0fb8dd6 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/drivers/intel/wifi/wifi.c M src/include/device/pci_ids.h 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/26723/1 diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index 1cf89cf..3ef66aa 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -261,6 +261,8 @@ PCI_DEVICE_ID_JP_9000_SERIES_1_WIFI, PCI_DEVICE_ID_JP_9000_SERIES_2_WIFI, PCI_DEVICE_ID_JP_9000_SERIES_3_WIFI, + /* Thunder Peak 2 */ + PCI_DEVICE_ID_TP_9260_SERIES_WIFI, /* Harrison Peak */ PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI, PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI, diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index c5ede36..40f2ea4 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -2986,6 +2986,7 @@ #define PCI_DEVICE_ID_JP_9000_SERIES_1_WIFI 0x9df0 #define PCI_DEVICE_ID_JP_9000_SERIES_2_WIFI 0x31dc #define PCI_DEVICE_ID_JP_9000_SERIES_3_WIFI 0xa370 +#define PCI_DEVICE_ID_TP_9260_SERIES_WIFI 0x2526 #define PCI_DEVICE_ID_HrP_9560_SERIES_1_WIFI 0x34f0 #define PCI_DEVICE_ID_HrP_9560_SERIES_2_WIFI 0xa0f0 -- To view, visit https://review.coreboot.org/26723 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I51abf615fca6001d564e7cd672cc16f3a0fb8dd6 Gerrit-Change-Number: 26723 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com>

1 0

Change in coreboot[master]: soc/amd/stoneyridge: Add ACPI device name lookup
by Marshall Dawson (Code Review) 31 May '18

31 May '18

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/26698 ) Change subject: soc/amd/stoneyridge: Add ACPI device name lookup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/26698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5117e0d39db831364173c9c61ccdab6e34f18c59 Gerrit-Change-Number: 26698 Gerrit-PatchSet: 1 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Kevin Chiu <Kevin.Chiu(a)quantatw.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 02:18:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: google/kukui: Add new board
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26722 ) Change subject: google/kukui: Add new board ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73735/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/27854/ : SUCCESS -- To view, visit https://review.coreboot.org/26722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08644892d34925574f791b000b0035d5afad7022 Gerrit-Change-Number: 26722 Gerrit-PatchSet: 1 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 01:45:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mediatek: refactor to sharing uart and timer code among similar SOCs
by build bot (Jenkins) (Code Review) 31 May '18

31 May '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26658 ) Change subject: mediatek: refactor to sharing uart and timer code among similar SOCs ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/73733/ : SUCCESS -- To view, visit https://review.coreboot.org/26658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5210149b324947ee90f1a481b42f0e2e1f7cfc25 Gerrit-Change-Number: 26658 Gerrit-PatchSet: 2 Gerrit-Owner: Tristan Hsieh <tristan.shieh(a)mediatek.com> Gerrit-Reviewer: Joel Kitching <kitching(a)google.com> Gerrit-Reviewer: Paul Kocialkowski <contact(a)paulk.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 31 May 2018 01:33:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2018