coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: driver/option_table: add option table interface
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25397 ) Change subject: driver/option_table: add option table interface ...................................................................... Patch Set 10: Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/69688/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/23994/ : SUCCESS -- To view, visit https://review.coreboot.org/25397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19b0215170e940c4973e60cbad3d7186a3063cc2 Gerrit-Change-Number: 25397 Gerrit-PatchSet: 10 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: Marcello Sylvester Bauer Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 21:15:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: [WIP] driver/option_table: RO_VPD option table
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25550 ) Change subject: [WIP] driver/option_table: RO_VPD option table ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69687/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/23992/ : ABORTED -- To view, visit https://review.coreboot.org/25550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aeafedf29c80e29c6cf00b821af6b4370e15baf Gerrit-Change-Number: 25550 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 21:05:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: driver/option_table: add option table interface
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25397 ) Change subject: driver/option_table: add option table interface ...................................................................... Patch Set 9: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/69686/ : ABORTED -- To view, visit https://review.coreboot.org/25397 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19b0215170e940c4973e60cbad3d7186a3063cc2 Gerrit-Change-Number: 25397 Gerrit-PatchSet: 9 Gerrit-Owner: Marcello Sylvester Bauer Gerrit-Reviewer: Marcello Sylvester Bauer Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 21:05:13 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: [WIP] driver/option_table: RO_VPD option table
by Marcello Sylvester Bauer (Code Review) 07 Apr '18

07 Apr '18

Marcello Sylvester Bauer has uploaded this change for review. ( https://review.coreboot.org/25550 Change subject: [WIP] driver/option_table: RO_VPD option table ...................................................................... [WIP] driver/option_table: RO_VPD option table Add a read-only VPD section as option table. This will benefit non-x86 boards without nvram. Change-Id: I5aeafedf29c80e29c6cf00b821af6b4370e15baf Signed-off-by: Marcello Sylvester Bauer <info(a)marcellobauer.com> --- M Makefile.inc M src/Kconfig M src/drivers/option_table/Makefile.inc A src/drivers/option_table/option_table_vpd.c M util/cbfstool/default-x86.fmd M util/cbfstool/default.fmd 6 files changed, 72 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/25550/1 diff --git a/Makefile.inc b/Makefile.inc index b11f6e2..d71bf5c 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -820,14 +820,28 @@ endif # ifeq ($(CONFIG_CACHE_MRC_SETTINGS),y) # +# RW VPD region +# +# +ifeq ($(CONFIG_USE_OPTION_TABLE_VPD),y) +FMAP_RO_VPD_BASE := $(call int-add,$(FMAP_FMAP_BASE) $(FMAP_FMAP_SIZE) $(FMAP_CONSOLE_SIZE) \ + $(FMAP_MRC_CACHE_SIZE)) +#FIX ME: use optional size instead of hardcoded value +FMAP_RO_VPD_SIZE := 0x1000 +FMAP_RO_VPD_ENTRY := RO_VPD@$(FMAP_RO_VPD_BASE) $(FMAP_RO_VPD_SIZE) +else # ifeq($(CONFIG_USE_OPTION_TABLE_VPD)) +FMAP_RO_VPD_BASE := 0 +FMAP_RO_VPD_SIZE := 0 +FMAP_RO_VPD_ENTRY := +endif # ifeq($(CONFIG_USE_OPTION_TABLE_VPD)) + +# # X86 COREBOOT default cbfs FMAP region # # position and size of CBFS, relative to BIOS_BASE -ifeq ($(CONFIG_CACHE_MRC_SETTINGS),y) -FMAP_CBFS_BASE := $(call int-add, $(FMAP_MRC_CACHE_BASE) $(FMAP_MRC_CACHE_SIZE)) -else -FMAP_CBFS_BASE := $(call int-add, $(FMAP_CONSOLE_SIZE) $(FMAP_FMAP_SIZE)) -endif +FMAP_CBFS_BASE := $(call int-add, $(FMAP_CONSOLE_SIZE) $(FMAP_FMAP_SIZE) \ + $(FMAP_MRC_CACHE_SIZE) $(FMAP_RO_VPD_SIZE)) + FMAP_CBFS_SIZE := $(call int-subtract, $(FMAP_BIOS_SIZE) $(FMAP_CBFS_BASE)) else # ifeq ($(CONFIG_ARCH_X86),y) DEFAULT_FLASHMAP:=$(top)/util/cbfstool/default.fmd @@ -881,7 +895,7 @@ # # position and size of CBFS, relative to BIOS_BASE FMAP_CBFS_BASE := $(call int-add,$(FMAP_FMAP_BASE) $(FMAP_FMAP_SIZE) $(FMAP_CONSOLE_SIZE) \ - $(FMAP_MRC_CACHE_SIZE)) + $(FMAP_MRC_CACHE_SIZE) $(FMAP_RO_VPD_SIZE)) FMAP_CBFS_SIZE := $(call int-subtract,$(FMAP_BIOS_SIZE) $(FMAP_CBFS_BASE)) endif # ifeq ($(CONFIG_ARCH_X86),y) @@ -894,6 +908,7 @@ -e "s,##FMAP_SIZE##,$(FMAP_FMAP_SIZE)," \ -e "s,##CONSOLE_ENTRY##,$(FMAP_CONSOLE_ENTRY)," \ -e "s,##MRC_CACHE_ENTRY##,$(FMAP_MRC_CACHE_ENTRY)," \ + -e "s,##RO_VPD_ENTRY##,$(FMAP_RO_VPD_ENTRY)," \ -e "s,##CBFS_BASE##,$(FMAP_CBFS_BASE)," \ -e "s,##CBFS_SIZE##,$(FMAP_CBFS_SIZE)," \ $(DEFAULT_FLASHMAP) > $@.tmp diff --git a/src/Kconfig b/src/Kconfig index 60a2977..ecde912 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -130,6 +130,11 @@ help read options from the "CMOS" NVRAM +config USE_OPTION_TABLE_VPD + bool "VPD" + help + read options from the a RV_VPD partition + endchoice config STATIC_OPTION_TABLE_CMOS @@ -495,8 +500,8 @@ config HAVE_OPTION_TABLE bool - default y if HAVE_OPTION_TABLE_CMOS - default n if !HAVE_OPTION_TABLE_CMOS + default y if (HAVE_OPTION_TABLE_CMOS || HAVE_OPTION_TABLE_VPD) + default n if !(HAVE_OPTION_TABLE_CMOS || HAVE_OPTION_TABLE_VPD) config HAVE_OPTION_TABLE_CMOS bool @@ -506,6 +511,10 @@ file containing NVRAM/CMOS bit definitions. It defaults to 'n' but can be selected in mainboard/*/Kconfig. +config HAVE_OPTION_TABLE_VPD + bool + default y + config PIRQ_ROUTE bool default n diff --git a/src/drivers/option_table/Makefile.inc b/src/drivers/option_table/Makefile.inc index b099474..24a359b 100644 --- a/src/drivers/option_table/Makefile.inc +++ b/src/drivers/option_table/Makefile.inc @@ -7,3 +7,12 @@ smm-y += option_table_cmos.c postcar-y += option_table_cmos.c endif + +ifeq ($(CONFIG_USE_OPTION_TABLE_VPD),y) +bootblock-y += option_table_vpd.c +verstage-y += option_table_vpd.c +romstage-y += option_table_vpd.c +ramstage-y += option_table_vpd.c +smm-y += option_table_vpd.c +postcar-y += option_table_vpd.c +endif diff --git a/src/drivers/option_table/option_table_vpd.c b/src/drivers/option_table/option_table_vpd.c new file mode 100644 index 0000000..41d35a2 --- /dev/null +++ b/src/drivers/option_table/option_table_vpd.c @@ -0,0 +1,29 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2018 Google Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <option.h> +#include <types.h> + +//[WIP] dummy function +enum cb_err get_option(void *dest, const char *name) +{ + return CB_CMOS_ACCESS_ERROR; +} + +//[WIP] dummy function +enum cb_err set_option(const char *name, void *value) +{ + return CB_CMOS_ACCESS_ERROR; +} diff --git a/util/cbfstool/default-x86.fmd b/util/cbfstool/default-x86.fmd index 1f1aa43..39706fe 100644 --- a/util/cbfstool/default-x86.fmd +++ b/util/cbfstool/default-x86.fmd @@ -12,6 +12,7 @@ FMAP@##FMAP_BASE## ##FMAP_SIZE## ##CONSOLE_ENTRY## ##MRC_CACHE_ENTRY## + ##RO_VPD_ENTRY## COREBOOT(CBFS)@##CBFS_BASE## ##CBFS_SIZE## } } diff --git a/util/cbfstool/default.fmd b/util/cbfstool/default.fmd index 8f4819e..61de02f 100644 --- a/util/cbfstool/default.fmd +++ b/util/cbfstool/default.fmd @@ -15,6 +15,7 @@ FMAP@##FMAP_BASE## ##FMAP_SIZE## ##CONSOLE_ENTRY## ##MRC_CACHE_ENTRY## + ##RO_VPD_ENTRY## COREBOOT(CBFS)@##CBFS_BASE## ##CBFS_SIZE## } } -- To view, visit https://review.coreboot.org/25550 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5aeafedf29c80e29c6cf00b821af6b4370e15baf Gerrit-Change-Number: 25550 Gerrit-PatchSet: 1 Gerrit-Owner: Marcello Sylvester Bauer

1 0

Change in coreboot[master]: amd/stoneyridge: Add GNB IOAPIC init
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25541 ) Change subject: amd/stoneyridge: Add GNB IOAPIC init ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69685/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/23991/ : SUCCESS -- To view, visit https://review.coreboot.org/25541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4ff8698419890df1459b1107f0861cf8277a99b0 Gerrit-Change-Number: 25541 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 06 Apr 2018 20:42:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: ioapic: extend definition name to avoid collision
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25540 ) Change subject: ioapic: extend definition name to avoid collision ...................................................................... Patch Set 2: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69684/ : SUCCESS -- To view, visit https://review.coreboot.org/25540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef Gerrit-Change-Number: 25540 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 20:42:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: amd/stoneyridge: Add GNB IOAPIC init
by Marc Jones (Code Review) 07 Apr '18

07 Apr '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25541 to look at the new patch set (#2). Change subject: amd/stoneyridge: Add GNB IOAPIC init ...................................................................... amd/stoneyridge: Add GNB IOAPIC init Use standard coreboot function to set virtual wire mode on the GNB IOAPIC. BUG=b:74104946 TEST=Check GNB IOAPIC debug output on serial. Change-Id: I4ff8698419890df1459b1107f0861cf8277a99b0 Signed-off-by: Marc Jones <marc.jones(a)scarletltd.com> --- M src/soc/amd/stoneyridge/northbridge.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/25541/2 -- To view, visit https://review.coreboot.org/25541 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4ff8698419890df1459b1107f0861cf8277a99b0 Gerrit-Change-Number: 25541 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: ioapic: extend definition name to avoid collision
by Marc Jones (Code Review) 07 Apr '18

07 Apr '18

Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/25540 to look at the new patch set (#2). Change subject: ioapic: extend definition name to avoid collision ...................................................................... ioapic: extend definition name to avoid collision Change EN/DISABLED to INT_EN/DISABLED to avoid collision with other EN/DISABLE definition. Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef Signed-off-by: Marc Jones <marc.jones(a)scarletltd.com> --- M src/arch/x86/include/arch/ioapic.h M src/arch/x86/ioapic.c M src/drivers/generic/ioapic/ioapic.c 3 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/25540/2 -- To view, visit https://review.coreboot.org/25540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I85b1c544d0f31340a09e18f4b36c1942ea0fa6ef Gerrit-Change-Number: 25540 Gerrit-PatchSet: 2 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: soc/amd/stoneyridege: Create nb_util.c
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25533 ) Change subject: soc/amd/stoneyridege: Create nb_util.c ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/23990/ : SUCCESS -- To view, visit https://review.coreboot.org/25533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4d1596e0be91db2e5ebd63d33e20f4894528e6 Gerrit-Change-Number: 25533 Gerrit-PatchSet: 3 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 18:04:08 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: soc/amd/stoneyridege: Create nb_util.c
by build bot (Jenkins) (Code Review) 07 Apr '18

07 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25533 ) Change subject: soc/amd/stoneyridege: Create nb_util.c ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/69683/ : SUCCESS -- To view, visit https://review.coreboot.org/25533 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4d1596e0be91db2e5ebd63d33e20f4894528e6 Gerrit-Change-Number: 25533 Gerrit-PatchSet: 4 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Garrett Kirkendall <garrett.kirkendall(a)amd.corp-partner.google.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 06 Apr 2018 18:04:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018