coreboot-gerrit April 2018

coreboot-gerrit@coreboot.org

1 participants
2168 discussions

Change in coreboot[master]: sb/intel/i82801gx: Clean up unneeded smi setup code
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25599 ) Change subject: sb/intel/i82801gx: Clean up unneeded smi setup code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24267/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69998/ : SUCCESS -- To view, visit https://review.coreboot.org/25599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4e6974088a685290ed1dddf5228a99918744124 Gerrit-Change-Number: 25599 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:43:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Use common code for SMM in TSEG
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25597 ) Change subject: nb/intel/x4x: Use common code for SMM in TSEG ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24266/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69997/ : SUCCESS -- To view, visit https://review.coreboot.org/25597 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317c5ca34bd38c3d42bf0d4e929b2a225a8a82dc Gerrit-Change-Number: 25597 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:43:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/gm45: Use common code for SMM in TSEG
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23419 ) Change subject: nb/intel/gm45: Use common code for SMM in TSEG ...................................................................... Patch Set 21: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24261/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69992/ : SUCCESS -- To view, visit https://review.coreboot.org/23419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic80c65ea42fcf554ea5695772e8828d2f3b00b98 Gerrit-Change-Number: 23419 Gerrit-PatchSet: 21 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:43:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801jx: Use common Intel SMM code
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25596 ) Change subject: sb/intel/i82801jx: Use common Intel SMM code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24264/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69995/ : SUCCESS -- To view, visit https://review.coreboot.org/25596 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3b3b3abbb3920d68d77fd7db996a1dc3c6b85a3 Gerrit-Change-Number: 25596 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:39:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: sb/intel/i82801gx: Use common Intel SMM code
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25594 ) Change subject: sb/intel/i82801gx: Use common Intel SMM code ...................................................................... Patch Set 5: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24263/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69994/ : SUCCESS -- To view, visit https://review.coreboot.org/25594 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7016a3b98fc5f14c287ce800325084f9dc602a0 Gerrit-Change-Number: 25594 Gerrit-PatchSet: 5 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:30:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/pineview: Enable and allocate 8M for TSEG
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25593 ) Change subject: nb/intel/pineview: Enable and allocate 8M for TSEG ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24262/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69993/ : SUCCESS -- To view, visit https://review.coreboot.org/25593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3acce57f0c13eee326b7c203a43453c74c3161 Gerrit-Change-Number: 25593 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:20:31 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Enable and allocate 8M for TSEG
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25592 ) Change subject: nb/intel/i945: Enable and allocate 8M for TSEG ...................................................................... Patch Set 4: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24258/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69989/ : SUCCESS -- To view, visit https://review.coreboot.org/25592 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0da5a00c98c4c4fb309b2691dc1d4645eb35b4fd Gerrit-Change-Number: 25592 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:11:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/x4x: Change memory layout to improve MTRR
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21634 ) Change subject: nb/intel/x4x: Change memory layout to improve MTRR ...................................................................... Patch Set 22: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24260/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69991/ : SUCCESS -- To view, visit https://review.coreboot.org/21634 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b5ea04d9b7d5494a30aa7156d8c17170e77b8ad Gerrit-Change-Number: 21634 Gerrit-PatchSet: 22 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:11:01 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: nb/intel/i945: Add a common function to compute TSEG size
by build bot (Jenkins) (Code Review) 11 Apr '18

11 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23448 ) Change subject: nb/intel/i945: Add a common function to compute TSEG size ...................................................................... Patch Set 11: Build Successful https://qa.coreboot.org/job/coreboot-checkpatch/24259/ : SUCCESS https://qa.coreboot.org/job/coreboot-gerrit/69990/ : SUCCESS -- To view, visit https://review.coreboot.org/23448 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e163598752fb6cd036aec229fce439ebad74def Gerrit-Change-Number: 23448 Gerrit-PatchSet: 11 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 11 Apr 2018 12:06:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in coreboot[master]: drivers/asmedia: Add ASPM blacklist
by Nico Huber (Code Review) 11 Apr '18

11 Apr '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/25619 Change subject: drivers/asmedia: Add ASPM blacklist ...................................................................... drivers/asmedia: Add ASPM blacklist To be selected by mainboard Kconfig. Change-Id: I05f9789bc14db56d2ac085f4f14047d80c3aefb5 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- A src/drivers/asmedia/Kconfig A src/drivers/asmedia/Makefile.inc A src/drivers/asmedia/aspm_blacklist.c 3 files changed, 61 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/25619/1 diff --git a/src/drivers/asmedia/Kconfig b/src/drivers/asmedia/Kconfig new file mode 100644 index 0000000..e0a0ca3 --- /dev/null +++ b/src/drivers/asmedia/Kconfig @@ -0,0 +1,2 @@ +config DRIVERS_ASMEDIA_ASPM_BLACKLIST + bool diff --git a/src/drivers/asmedia/Makefile.inc b/src/drivers/asmedia/Makefile.inc new file mode 100644 index 0000000..daa4e89 --- /dev/null +++ b/src/drivers/asmedia/Makefile.inc @@ -0,0 +1,16 @@ +## +## This file is part of the coreboot project. +## +## Copyright (C) 2018 secunet Security Networks AG +## +## This program is free software; you can redistribute it and/or modify +## it under the terms of the GNU General Public License as published by +## the Free Software Foundation; version 2 of the License. +## +## This program is distributed in the hope that it will be useful, +## but WITHOUT ANY WARRANTY; without even the implied warranty of +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +## GNU General Public License for more details. +## + +ramstage-$(CONFIG_DRIVERS_ASMEDIA_ASPM_BLACKLIST) += aspm_blacklist.c diff --git a/src/drivers/asmedia/aspm_blacklist.c b/src/drivers/asmedia/aspm_blacklist.c new file mode 100644 index 0000000..eb3a60a --- /dev/null +++ b/src/drivers/asmedia/aspm_blacklist.c @@ -0,0 +1,43 @@ +/* + * This file is part of the coreboot project. + * + * Copyright (C) 2018 secunet Security Networks AG + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <console/console.h> +#include <device/device.h> +#include <device/pci.h> + +static void disable_aspm(struct device *const dev) +{ + printk(BIOS_DEBUG, "Disabling ASPM for %s [%04x/%04x]\n", + dev_path(dev), dev->vendor, dev->device); + dev->disable_pcie_aspm = 1; +} + +static struct device_operations asmedia_noaspm_ops = { + .read_resources = pci_dev_read_resources, + .set_resources = pci_dev_set_resources, + .enable_resources = pci_dev_enable_resources, + .enable = disable_aspm, +}; + +static const unsigned short pci_device_ids[] = { + 0x0611, + 0 +}; + +static const struct pci_driver asmedia_noaspm __pci_driver = { + .ops = &asmedia_noaspm_ops, + .vendor = 0x1b21, + .devices = pci_device_ids, +}; -- To view, visit https://review.coreboot.org/25619 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I05f9789bc14db56d2ac085f4f14047d80c3aefb5 Gerrit-Change-Number: 25619 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2018