coreboot-gerrit February 2018

coreboot-gerrit@coreboot.org

1 participants
1573 discussions

Change in coreboot[master]: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected
by Subrata Banik (Code Review) 26 Feb '18

26 Feb '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/23871 to look at the new patch set (#2). Change subject: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected ...................................................................... drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected This patch fixes brokenness issues in coreboot with CONFIG_DISPLAY_HOBs config selection due to recent UDK2017 package changes. TEST=Build and boot UDK2017 platforms with DISPLAY_HOBS select. Change-Id: I5c779c86870c62253d64c6af456bf017553e269c Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/fsp2_0/hob_display.c M src/drivers/intel/fsp2_0/include/fsp/util.h 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/23871/2 -- To view, visit https://review.coreboot.org/23871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5c779c86870c62253d64c6af456bf017553e269c Gerrit-Change-Number: 23871 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23871 ) Change subject: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected ...................................................................... Patch Set 1: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67917/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22401/ : SUCCESS -- To view, visit https://review.coreboot.org/23871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c779c86870c62253d64c6af456bf017553e269c Gerrit-Change-Number: 23871 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 12:07:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected
by Subrata Banik (Code Review) 26 Feb '18

26 Feb '18

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/23871 Change subject: drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected ...................................................................... drivers/intel/fsp2_0: Fix build error while DISPLAY_HOBS is selected This patch fixes brokenness issues in coreboot with CONFIG_DISPLAY_HOBs config selection due to recent UDK2017 package changes. TEST=Build and boot UDK2017 platforms with DISPLAY_HOBS select. Change-Id: I5c779c86870c62253d64c6af456bf017553e269c Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/drivers/intel/fsp2_0/hob_display.c M src/drivers/intel/fsp2_0/include/fsp/util.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/23871/1 diff --git a/src/drivers/intel/fsp2_0/hob_display.c b/src/drivers/intel/fsp2_0/hob_display.c index 67e79b4..d9838e9 100644 --- a/src/drivers/intel/fsp2_0/hob_display.c +++ b/src/drivers/intel/fsp2_0/hob_display.c @@ -89,7 +89,7 @@ { tseg_guid, "TSEG" }, }; -static const char *resource_name(enum resource_type type) +static const char *resource_name(uint32_t type) { if (type >= ARRAY_SIZE(resource_names)) return "UNKNOWN"; diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h index e7778ec..6d09875 100644 --- a/src/drivers/intel/fsp2_0/include/fsp/util.h +++ b/src/drivers/intel/fsp2_0/include/fsp/util.h @@ -20,6 +20,7 @@ #include <fsp/api.h> #include <fsp/info_header.h> #include <memrange.h> +#include <Pi/PiHob.h> struct hob_header { uint16_t type; -- To view, visit https://review.coreboot.org/23871 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5c779c86870c62253d64c6af456bf017553e269c Gerrit-Change-Number: 23871 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>

1 0

Change in coreboot[master]: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19820 ) Change subject: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot ...................................................................... Patch Set 5: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67916/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22400/ : SUCCESS -- To view, visit https://review.coreboot.org/19820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac5 Gerrit-Change-Number: 19820 Gerrit-PatchSet: 5 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: James Hebden <james(a)hebden.net.au> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:43:30 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Add bzImage header detection
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23868 ) Change subject: util/cbfstool: Add bzImage header detection ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67913/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22397/ : SUCCESS -- To view, visit https://review.coreboot.org/23868 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fc96caedb872b14f3238e4a7a96f0d32d17f7ee Gerrit-Change-Number: 23868 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:41:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Support self-relocatable images.
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13762 ) Change subject: Support self-relocatable images. ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67912/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22396/ : SUCCESS -- To view, visit https://review.coreboot.org/13762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27d5825e5b748a2220506005f96eceaef6d94cc2 Gerrit-Change-Number: 13762 Gerrit-PatchSet: 4 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:38:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19820 ) Change subject: mb/asus/kgpe-d16: Set ASpeed GPIO SPD mux lines during boot ...................................................................... Patch Set 4: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/67915/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/22399/ : SUCCESS -- To view, visit https://review.coreboot.org/19820 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia251334ae44668c2260d8d2e816f85f1f62faac5 Gerrit-Change-Number: 19820 Gerrit-PatchSet: 4 Gerrit-Owner: Timothy Pearson <tpearson(a)raptorengineering.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: James Hebden <james(a)hebden.net.au> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:28:14 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Add ARM64 Image support
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23869 ) Change subject: util/cbfstool: Add ARM64 Image support ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67914/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22398/ : SUCCESS -- To view, visit https://review.coreboot.org/23869 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a8183a87de4dc3a4c4f038fe5b4912ada5d75f9 Gerrit-Change-Number: 23869 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:26:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: Make coreboot supply DTB
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/13760 ) Change subject: Make coreboot supply DTB ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/67910/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/22394/ : SUCCESS -- To view, visit https://review.coreboot.org/13760 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I352ee291ac64dada0759c89438195bd207b860ae Gerrit-Change-Number: 13760 Gerrit-PatchSet: 4 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:24:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: util/cbfstool: Move x86 Linux trampoline
by build bot (Jenkins) (Code Review) 26 Feb '18

26 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23867 ) Change subject: util/cbfstool: Move x86 Linux trampoline ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/67911/ : FAILURE https://qa.coreboot.org/job/coreboot-checkpatch/22395/ : SUCCESS -- To view, visit https://review.coreboot.org/23867 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d8630554e9fd845840de88142e5115c0bf92842 Gerrit-Change-Number: 23867 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 26 Feb 2018 11:22:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2018