coreboot-gerrit December 2018

coreboot-gerrit@coreboot.org

1 participants
1832 discussions

Change in ...coreboot[master]: util/qualcomm: Add T32 debug scripts
by Patrick Georgi (Code Review) 06 Dec '18

06 Dec '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29951 ) Change subject: util/qualcomm: Add T32 debug scripts ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_… File util/qualcomm/scripts/cmm/pbl32_to_bootblock64_jump.cmm: https://review.coreboot.org/#/c/29951/2/util/qualcomm/scripts/cmm/pbl32_to_… PS2, Line 16: are the multiple newlines near the end required? our style guide prefers us not to use such things (and that's where the Verified-1 comes from). -- To view, visit https://review.coreboot.org/c/coreboot/+/29951 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e792a2806e5ebd3b4075c7bb69c43587920deae Gerrit-Change-Number: 29951 Gerrit-PatchSet: 2 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Comment-Date: Thu, 06 Dec 2018 21:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: qcs405: Add Timer support
by Patrick Georgi (Code Review) 06 Dec '18

06 Dec '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29952 ) Change subject: qcs405: Add Timer support ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/29952/2/src/soc/qualcomm/qcs405/Makefile.inc File src/soc/qualcomm/qcs405/Makefile.inc: https://review.coreboot.org/#/c/29952/2/src/soc/qualcomm/qcs405/Makefile.in… PS2, Line 8: bootblock-y += timer.c is there any reason for this reordering? -- To view, visit https://review.coreboot.org/c/coreboot/+/29952 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I566c7ff2b7085c9dd89ea74a08f3ba862feab2ab Gerrit-Change-Number: 29952 Gerrit-PatchSet: 2 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-Comment-Date: Thu, 06 Dec 2018 21:42:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: soc/qualcomm/qcs405: Add MMU support
by Patrick Georgi (Code Review) 06 Dec '18

06 Dec '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29950 ) Change subject: soc/qualcomm/qcs405: Add MMU support ...................................................................... Patch Set 2: Code-Review+1 This looks simple enough, but please take care of the coding style checks. -- To view, visit https://review.coreboot.org/c/coreboot/+/29950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8c6353be2c0379ec94f91223805762a2286de06d Gerrit-Change-Number: 29950 Gerrit-PatchSet: 2 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-Comment-Date: Thu, 06 Dec 2018 21:38:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mainboard/google/mistral: Add support for Mistral
by Patrick Georgi (Code Review) 06 Dec '18

06 Dec '18

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29949 ) Change subject: mainboard/google/mistral: Add support for Mistral ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/29949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ecfad68bb50f42acf36f51bc3433add56597c3d Gerrit-Change-Number: 29949 Gerrit-PatchSet: 2 Gerrit-Owner: nsekar(a)codeaurora.org Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: nsekar(a)codeaurora.org Gerrit-Comment-Date: Thu, 06 Dec 2018 21:32:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: mb/google/kahlee: Use new VBIOS if liara
by Richard Spiegel (Code Review) 06 Dec '18

06 Dec '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30090 Change subject: mb/google/kahlee: Use new VBIOS if liara ...................................................................... mb/google/kahlee: Use new VBIOS if liara A new liara specific VBIOS updating eDP power sequence is available now, Change Kconfig to use it if board is google liara. BUG=b:120534087 TEST=Build liara, booted, tested eDP test compliance. Change-Id: I444cfa0bd755480e006f11c0d692b25b96129c29 Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M src/mainboard/google/kahlee/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/30090/1 diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index dde4835..97d15f5 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -55,6 +55,7 @@ config VGA_BIOS_FILE string default "3rdparty/blobs/mainboard/google/kahlee/aleena/VBIOS_015_049_000_018.bin" if BOARD_GOOGLE_ALEENA + default "3rdparty/blobs/mainboard/google/kahlee/liara/VBIOS_BRT39865.001.bin" if BOARD_GOOGLE_LIARA default "3rdparty/blobs/mainboard/google/kahlee/VBIOS_015_049_000_017.bin" config VARIANT_DIR -- To view, visit https://review.coreboot.org/c/coreboot/+/30090 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I444cfa0bd755480e006f11c0d692b25b96129c29 Gerrit-Change-Number: 30090 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: 3rdparty/blobs: Update video BIOS to customize release binary
by Richard Spiegel (Code Review) 06 Dec '18

06 Dec '18

Richard Spiegel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30089 Change subject: 3rdparty/blobs: Update video BIOS to customize release binary ...................................................................... 3rdparty/blobs: Update video BIOS to customize release binary A liara specific VBIOS was released and merged to blobs. Now coreboot need to point to the updated blob, so it can use liara specific VBIOS. Liara Chromebook Stoney VBIOS BRT39865 BRT39865.001 12/05/18,01:13:54 CL#1716128 @ 15.49.0.18 ATOMBuild#436504 Major Changes included: 1. First Stoney VBIOS released to Liara update eDP power up sequence. BUG=b:120534087 TEST=none Change-Id: I3b060b1ccfb311584afd0fb66258eb7cc942408d Signed-off-by: Richard Spiegel <richard.spiegel(a)silverbackltd.com> --- M 3rdparty/blobs 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/30089/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index be390ff..5b9c768 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit be390ffb5b2cce76a563f4516c58a49f1af90229 +Subproject commit 5b9c768f37991591409f5db6ecfb02fdd0c6319a -- To view, visit https://review.coreboot.org/c/coreboot/+/30089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b060b1ccfb311584afd0fb66258eb7cc942408d Gerrit-Change-Number: 30089 Gerrit-PatchSet: 1 Gerrit-Owner: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-MessageType: newchange

1 0

Change in ...coreboot[master]: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Modul...
by Martin Roth (Code Review) 06 Dec '18

06 Dec '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30049 ) Change subject: google/grunt: Update micron-MT40A1G16KNR-075-E.spd.hex SPD file Module Part Number ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30049/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A1G16KNR-075-E.spd.hex: https://review.coreboot.org/#/c/30049/1/src/mainboard/google/kahlee/variant… PS1, Line 23: : Same issue here. 0x15D Module Revision code 0x15E Manufacturer's ID, LSB 0x15F Manufacturer's ID, MSB 0x160 DRAM stepping I'm fine with updating these bytes if appropriate, but there should be a comment in the commit message as to why. -- To view, visit https://review.coreboot.org/c/coreboot/+/30049 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9d582b3753de9a48865eb6eca7e4fbdb31b799ff Gerrit-Change-Number: 30049 Gerrit-PatchSet: 1 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 16:50:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: google/grunt: Update hynix-H5AN8G6NAFR-UH.spd.hex SPD file Module Par...
by Martin Roth (Code Review) 06 Dec '18

06 Dec '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30048 ) Change subject: google/grunt: Update hynix-H5AN8G6NAFR-UH.spd.hex SPD file Module Part Number ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30048/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/spd/hynix-H5AN8G6NAFR-UH.spd.hex: https://review.coreboot.org/#/c/30048/1/src/mainboard/google/kahlee/variant… PS1, Line 23: : Same comment as the other patch - these bytes are different fields. -- To view, visit https://review.coreboot.org/c/coreboot/+/30048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f6e885638589a35334a9a8f905af4877c5d1f91 Gerrit-Change-Number: 30048 Gerrit-PatchSet: 1 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 16:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: google/grunt: Update micron-MT40A512M16JY-083E-B.spd.hex SPD file Mod...
by Martin Roth (Code Review) 06 Dec '18

06 Dec '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30050 ) Change subject: google/grunt: Update micron-MT40A512M16JY-083E-B.spd.hex SPD file Module Part Number ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30050/1/src/mainboard/google/kahlee/variant… File src/mainboard/google/kahlee/variants/baseboard/spd/micron-MT40A512M16JY-083E-B.spd.hex: https://review.coreboot.org/#/c/30050/1/src/mainboard/google/kahlee/variant… PS1, Line 23: : These aren't part of the part number: 0x15D Module Revision code 0x15E Manufacturer's ID, LSB 0x15F Manufacturer's ID, MSB 0x160 DRAM stepping If these need to be updated as well, please comment in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/30050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6847a55968260cdbc1588ddeb8d23c515ad87920 Gerrit-Change-Number: 30050 Gerrit-PatchSet: 1 Gerrit-Owner: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lucas Chen <lucas.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Tim Chen <tim-chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 16:44:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in ...coreboot[master]: sb/amd/pi/hudson: Fix UART address math
by Martin Roth (Code Review) 06 Dec '18

06 Dec '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30072 ) Change subject: sb/amd/pi/hudson: Fix UART address math ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/30072 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc0ff9d80c3f5cab9ab837cf1cd0cd8eb0753284 Gerrit-Change-Number: 30072 Gerrit-PatchSet: 1 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Dec 2018 16:22:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2018