coreboot-gerrit January 2018

coreboot-gerrit@coreboot.org

1 participants
2315 discussions

Change in coreboot[master]: mainboard/broadcom/blast: Remove not necessary braces {}
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23523 ) Change subject: mainboard/broadcom/blast: Remove not necessary braces {} ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66883/ : SUCCESS -- To view, visit https://review.coreboot.org/23523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Gerrit-Change-Number: 23523 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:25:42 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/winent: Remove not necessary braces {}
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23524 ) Change subject: mainboard/winent: Remove not necessary braces {} ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66884/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21473/ : SUCCESS -- To view, visit https://review.coreboot.org/23524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a7bd4bd98d1a9d7b0ce4c12e09284fa4be6c7a Gerrit-Change-Number: 23524 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:24:22 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/winent: Remove not necessary braces {}
by Elyes HAOUAS (Code Review) 01 Feb '18

01 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23524 Change subject: mainboard/winent: Remove not necessary braces {} ...................................................................... mainboard/winent: Remove not necessary braces {} also add required space before opening parenthesis '(' Change-Id: I48a7bd4bd98d1a9d7b0ce4c12e09284fa4be6c7a Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/winent/mb6047/mptable.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/23524/1 diff --git a/src/mainboard/winent/mb6047/mptable.c b/src/mainboard/winent/mb6047/mptable.c index 3d9ffb5..53eded0 100644 --- a/src/mainboard/winent/mb6047/mptable.c +++ b/src/mainboard/winent/mb6047/mptable.c @@ -77,14 +77,12 @@ smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_ck804_0, ((sbdn +8)<<2)|0, apicid_ck804, 0x16); // 22 //Slot PCIE x16 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_ck804_5, (0x00 << 2)|i, apicid_ck804, 0x10 + (2+i+4-sbdn%4)%4); - } //Slot PCIE x4 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_ck804_4, (0x00 << 2)|i, apicid_ck804, 0x10 + (1+i+4-sbdn%4)%4); - } //Onboard SM720 VGA smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_ck804_1, (6 << 2)|0, apicid_ck804, 0x13); // 19 -- To view, visit https://review.coreboot.org/23524 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48a7bd4bd98d1a9d7b0ce4c12e09284fa4be6c7a Gerrit-Change-Number: 23524 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/sandybridge: Add required space before opening parenthesis '('
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23522 ) Change subject: nb/intel/sandybridge: Add required space before opening parenthesis '(' ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66881/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/21471/ : SUCCESS -- To view, visit https://review.coreboot.org/23522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6dfef118dc2fecf2a8f2f3401c779a3becfb71a9 Gerrit-Change-Number: 23522 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:18:41 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/broadcom/blast: Remove not necessary braces {}
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23523 ) Change subject: mainboard/broadcom/blast: Remove not necessary braces {} ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/66882/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/21472/ : SUCCESS -- To view, visit https://review.coreboot.org/23523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Gerrit-Change-Number: 23523 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:18:40 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/broadcom/blast: Remove not necessary braces {}
by Elyes HAOUAS (Code Review) 01 Feb '18

01 Feb '18

Hello Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23523 to look at the new patch set (#2). Change subject: mainboard/broadcom/blast: Remove not necessary braces {} ...................................................................... mainboard/broadcom/blast: Remove not necessary braces {} Also, add required space before opening parenthesis '(' Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/broadcom/blast/mptable.c 1 file changed, 10 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/23523/2 -- To view, visit https://review.coreboot.org/23523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Gerrit-Change-Number: 23523 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>

1 0

Change in coreboot[master]: mainboard/broadcom/blast: Rmove not necessary braces {}
by Martin Roth (Code Review) 01 Feb '18

01 Feb '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/23523 ) Change subject: mainboard/broadcom/blast: Rmove not necessary braces {} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/23523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Gerrit-Change-Number: 23523 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:14:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in coreboot[master]: mainboard/broadcom/blast: Rmove not necessary braces {}
by Elyes HAOUAS (Code Review) 01 Feb '18

01 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23523 Change subject: mainboard/broadcom/blast: Rmove not necessary braces {} ...................................................................... mainboard/broadcom/blast: Rmove not necessary braces {} Also, add required space before opening parenthesis '(' Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/broadcom/blast/mptable.c 1 file changed, 10 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/23523/1 diff --git a/src/mainboard/broadcom/blast/mptable.c b/src/mainboard/broadcom/blast/mptable.c index 2417c96..854e255 100644 --- a/src/mainboard/broadcom/blast/mptable.c +++ b/src/mainboard/broadcom/blast/mptable.c @@ -36,7 +36,7 @@ { device_t dev = 0; struct resource *res; - for(i = 0; i < 3; i++) { + for (i = 0; i < 3; i++) { dev = dev_find_device(0x1166, 0x0235, dev); if (dev) { res = find_resource(dev, PCI_BASE_ADDRESS_0); @@ -63,9 +63,8 @@ //USB outb(0x01, 0xc00); outb(0x0a, 0xc01); - for(i = 0; i < 3; i++) { + for (i = 0; i < 3; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, ((2+sysconf.sbdn)<<2)|i, apicid_bcm5785[0], 0xa); // - } @@ -85,51 +84,43 @@ } //First pci-x slot (on bcm5785) under bus_bcm5785_1:d.0 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_1_1, (4 << 2)|i, apicid_bcm5785[1], 2 + (0+i)%4); // - } //pci slot (on bcm5785) - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, (4 << 2)|i, apicid_bcm5785[1], i%2); // - } //onboard ati smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5785_0, (5 << 2)|0, apicid_bcm5785[1], 0x1); //PCI-X on bcm5780 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[1], (4 << 2)|i, apicid_bcm5785[1], 6 + (0+i)%4); // - } - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[1], (5 << 2)|i, apicid_bcm5785[1], 6 + (1+i)%4); // - } //onboard Broadcom - for(i = 0; i < 2; i++) { + for (i = 0; i < 2; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[2], (4 << 2)|i, apicid_bcm5785[1], 0xa + (0+i)%4); // - } // First PCI-E x8 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[5], (0 << 2)|i, apicid_bcm5785[1], 0xe); // - } // Second PCI-E x8 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[3], (0 << 2)|i, apicid_bcm5785[1], 0xc); // - } // Third PCI-E x1 - for(i = 0; i < 4; i++) { + for (i = 0; i < 4; i++) smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_LEVEL|MP_IRQ_POLARITY_LOW, bus_bcm5780[4], (0 << 2)|i, apicid_bcm5785[1], 0xd); // - } /*Local Ints: Type Polarity Trigger Bus ID IRQ APIC ID PIN#*/ mptable_lintsrc(mc, bus_isa); -- To view, visit https://review.coreboot.org/23523 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1b6913f9fe97e42836a6698645d0d380ceecec0d Gerrit-Change-Number: 23523 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: nb/intel/sandybridge: Add required space before opening parenthesis '('
by Elyes HAOUAS (Code Review) 01 Feb '18

01 Feb '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/23522 Change subject: nb/intel/sandybridge: Add required space before opening parenthesis '(' ...................................................................... nb/intel/sandybridge: Add required space before opening parenthesis '(' Change-Id: I6dfef118dc2fecf2a8f2f3401c779a3becfb71a9 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/23522/1 diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index eaef5f7..0a44220 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -2357,7 +2357,7 @@ */ cmdrate = ((ctrl->rankmap[channel] & 0x5) == 0x5); - for(; cmdrate < 2; cmdrate++) { + for (; cmdrate < 2; cmdrate++) { err = try_cmd_stretch(ctrl, channel, cmdrate << 1); if (!err) -- To view, visit https://review.coreboot.org/23522 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6dfef118dc2fecf2a8f2f3401c779a3becfb71a9 Gerrit-Change-Number: 23522 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in coreboot[master]: soc/amd/common: Add S3 supporting functions
by build bot (Jenkins) (Code Review) 01 Feb '18

01 Feb '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22727 ) Change subject: soc/amd/common: Add S3 supporting functions ...................................................................... Patch Set 11: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/66880/ : SUCCESS -- To view, visit https://review.coreboot.org/22727 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie60162ea10f053393bc84e927dbd80c9279e6b63 Gerrit-Change-Number: 22727 Gerrit-PatchSet: 11 Gerrit-Owner: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 31 Jan 2018 22:01:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2018