coreboot-gerrit September 2017

coreboot-gerrit@coreboot.org

1 participants
1960 discussions

Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21727 ) Change subject: google/gru: Fix pmu1833_volsel handling ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61227/ : SUCCESS -- To view, visit https://review.coreboot.org/21727 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Gerrit-Change-Number: 21727 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:50:06 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21727 ) Change subject: google/gru: Fix pmu1833_volsel handling ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/61226/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/16377/ : SUCCESS -- To view, visit https://review.coreboot.org/21727 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Gerrit-Change-Number: 21727 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:44:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling
by Julius Werner (Code Review) 27 Sep '17

27 Sep '17

Hello Lin Huang, David Schneider, Philip Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21727 to look at the new patch set (#2). Change subject: google/gru: Fix pmu1833_volsel handling ...................................................................... google/gru: Fix pmu1833_volsel handling RK3399 has a pin that can decide whether GPIO port 1 is driven with 1.8V or 3.0V. We thought this mechanism was disabled by default, but it turns out it wasn't. We want to use that pin as an output GPIO on Scarlet so we need to reconfigure the respective SoC controls before we do that. It seems that we also need to explicitly pinmux the pin away from that special function (to normal GPIO) or weird things happen on some boards. BUG=b:66534913 TEST=Sprinkled several long udelays, poked test points with a multi-meter on Scarlet. Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/bootblock.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21727/2 -- To view, visit https://review.coreboot.org/21727 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Gerrit-Change-Number: 21727 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>

1 0

Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling
by Julius Werner (Code Review) 27 Sep '17

27 Sep '17

Julius Werner has posted comments on this change. ( https://review.coreboot.org/21727 ) Change subject: google/gru: Fix pmu1833_volsel handling ...................................................................... Patch Set 1: Code-Review+2 +2ing myself since I'm the only one who knows this code and has commit rights. If anyone has objections please speak up, otherwise I'll merge in a few days. -- To view, visit https://review.coreboot.org/21727 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Gerrit-Change-Number: 21727 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:42:07 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Fix pmu1833_volsel handling
by Julius Werner (Code Review) 27 Sep '17

27 Sep '17

Hello Lin Huang, David Schneider, Philip Chen, I'd like you to do a code review. Please visit https://review.coreboot.org/21727 to review the following change. Change subject: google/gru: Fix pmu1833_volsel handling ...................................................................... google/gru: Fix pmu1833_volsel handling RK3399 has a pin that can decide whether GPIO port 1 is driven with 1.8V or 3.0V. We thought this mechanism was disabled by default, but it turns out it wasn't. We want to use that pin as an output GPIO on Scarlet so we need to reconfigure the respective SoC controls before we do that. It seems that we also need to explicitly pinmux the pin away from that special function (to normal GPIO) or weird things happen on some boards. Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/mainboard/google/gru/bootblock.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/21727/1 diff --git a/src/mainboard/google/gru/bootblock.c b/src/mainboard/google/gru/bootblock.c index a3d3121..162a7e5 100644 --- a/src/mainboard/google/gru/bootblock.c +++ b/src/mainboard/google/gru/bootblock.c @@ -48,6 +48,12 @@ if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) write32(&rk3399_grf->io_vsel, RK_SETBITS(1 << 3)); + /* Reconfigure GPIO1 from dynamic voltage selection through GPIO0_B1 to + hardcoded 1.8V, and change that pin to a normal GPIO. The TRM says + this is already the power-on reset, but we all know that TRMs lie. */ + write32(&rk3399_pmugrf->soc_con0, RK_SETBITS(1 << 9 | 1 << 8)); + write32(&rk3399_pmugrf->gpio0b_iomux, RK_CLRBITS(3 << 2)); + /* Enable rails powering GPIO blocks, among other things. */ gpio_output(GPIO_P30V_EN, 1); if (!IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) -- To view, visit https://review.coreboot.org/21727 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia02cbb4f3b2f14b0d958b84adcddb0c5f4259efa Gerrit-Change-Number: 21727 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: David Schneider <dnschneid(a)chromium.org> Gerrit-Reviewer: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org>

1 0

Change in coreboot[master]: intel/fsp: Update cannonlake FSP header
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21705 ) Change subject: intel/fsp: Update cannonlake FSP header ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61225/ : SUCCESS -- To view, visit https://review.coreboot.org/21705 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac8db8403b0f909f32049329f867c28c68e3b830 Gerrit-Change-Number: 21705 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: AndreX Andraos <andrex.andraos(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:21:31 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/cannonlake: Disable CPU ratio override
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21709 ) Change subject: soc/intel/cannonlake: Disable CPU ratio override ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61224/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16376/ : SUCCESS -- To view, visit https://review.coreboot.org/21709 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a1df15c619038f17c1bef5b7f53d322e352c56b Gerrit-Change-Number: 21709 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:13:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: mainboard/intel/cannonlake_rvp: Disable CPu Ratio override
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21712 ) Change subject: mainboard/intel/cannonlake_rvp: Disable CPu Ratio override ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61223/ : SUCCESS -- To view, visit https://review.coreboot.org/21712 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57631f00750cc793da70b8cce85aaad0df136ebe Gerrit-Change-Number: 21712 Gerrit-PatchSet: 3 Gerrit-Owner: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:05:35 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Update LPC lib
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21605 ) Change subject: soc/intel/common/block: Update LPC lib ...................................................................... Patch Set 15: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/61222/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/16375/ : SUCCESS -- To view, visit https://review.coreboot.org/21605 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a Gerrit-Change-Number: 21605 Gerrit-PatchSet: 15 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 23:05:34 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: soc/intel/common/block: Update LPC lib
by build bot (Jenkins) (Code Review) 27 Sep '17

27 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21605 ) Change subject: soc/intel/common/block: Update LPC lib ...................................................................... Patch Set 14: Verified-1 Build Unstable https://qa.coreboot.org/job/coreboot-gerrit/61221/ : UNSTABLE https://qa.coreboot.org/job/coreboot-checkpatch/16374/ : SUCCESS -- To view, visit https://review.coreboot.org/21605 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a Gerrit-Change-Number: 21605 Gerrit-PatchSet: 14 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 27 Sep 2017 22:45:48 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2017