coreboot-gerrit July 2017

coreboot-gerrit@coreboot.org

1 participants
1657 discussions

Change in coreboot[master]: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST
by Rizwan Qureshi (Code Review) 28 Jul '17

28 Jul '17

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/20804 Change subject: mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST ...................................................................... mb/google/soraka: configure GPP_B8 to control WLAN_PE_RST WLAN_PE_RST control was moved from EC to SoC, it connected to GPP_B8. Configure GPP_B8 to drive low. Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Signed-off-by: Rizwan Qureshi <rizwan.qureshi(a)intel.com> --- M src/mainboard/google/poppy/variants/soraka/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/20804/1 diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c index c576155..f0fb34a 100644 --- a/src/mainboard/google/poppy/variants/soraka/gpio.c +++ b/src/mainboard/google/poppy/variants/soraka/gpio.c @@ -78,8 +78,8 @@ PAD_CFG_NF(GPP_B6, NONE, DEEP, NF1), /* B7 : SRCCLKREQ2# ==> NC */ PAD_CFG_NC(GPP_B7), - /* B8 : SRCCLKREQ3# ==> NC */ - PAD_CFG_NC(GPP_B8), + /* B8 : SRCCLKREQ3# ==> WLAN_PE_RST */ + PAD_CFG_GPO(GPP_B8, 0, DEEP), /* B9 : SRCCLKREQ4# ==> NC */ PAD_CFG_NC(GPP_B9), /* B10 : SRCCLKREQ5# ==> NC */ -- To view, visit https://review.coreboot.org/20804 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I6a6ea0ddefe8402284fe37665864c7a1961cbc15 Gerrit-Change-Number: 20804 Gerrit-PatchSet: 1 Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi(a)intel.com>

1 0

Change in coreboot[master]: google/gru: Correct the Sdcard control gpio setting for Scarlet
by build bot (Jenkins) (Code Review) 28 Jul '17

28 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20803 ) Change subject: google/gru: Correct the Sdcard control gpio setting for Scarlet ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57954/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13398/ : SUCCESS -- To view, visit https://review.coreboot.org/20803 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Gerrit-Change-Number: 20803 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 02:51:00 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Scarlet gpio4cd use 1.8V powerdomain
by build bot (Jenkins) (Code Review) 28 Jul '17

28 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20802 ) Change subject: google/gru: Scarlet gpio4cd use 1.8V powerdomain ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57953/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13397/ : SUCCESS -- To view, visit https://review.coreboot.org/20802 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Gerrit-Change-Number: 20802 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 02:50:52 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Scarlet gpio4cd use 1.8V powerdomain
by build bot (Jenkins) (Code Review) 28 Jul '17

28 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20802 ) Change subject: google/gru: Scarlet gpio4cd use 1.8V powerdomain ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57951/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13396/ : SUCCESS -- To view, visit https://review.coreboot.org/20802 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Gerrit-Change-Number: 20802 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 02:45:48 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Correct the Sdcard control gpio setting for Scarlet
by build bot (Jenkins) (Code Review) 28 Jul '17

28 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/20803 ) Change subject: google/gru: Correct the Sdcard control gpio setting for Scarlet ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/coreboot-gerrit/57952/ : ABORTED https://qa.coreboot.org/job/coreboot-checkpatch/13395/ : SUCCESS -- To view, visit https://review.coreboot.org/20803 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Gerrit-Change-Number: 20803 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 02:45:45 +0000 Gerrit-HasComments: No

1 0

Change in coreboot[master]: google/gru: Correct the Sdcard control gpio setting for Scarlet
by Lin Huang (Code Review) 28 Jul '17

28 Jul '17

Hello Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20803 to look at the new patch set (#2). Change subject: google/gru: Correct the Sdcard control gpio setting for Scarlet ...................................................................... google/gru: Correct the Sdcard control gpio setting for Scarlet in Scarlet Sdcard control gpio different with other project, let's correct it. Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/mainboard.c 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/20803/2 -- To view, visit https://review.coreboot.org/20803 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Gerrit-Change-Number: 20803 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: google/gru: Scarlet gpio4cd use 1.8V powerdomain
by Lin Huang (Code Review) 28 Jul '17

28 Jul '17

Hello Julius Werner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/20802 to look at the new patch set (#2). Change subject: google/gru: Scarlet gpio4cd use 1.8V powerdomain ...................................................................... google/gru: Scarlet gpio4cd use 1.8V powerdomain Scarlet gpio4cd use 1.8V powerdomain, let's make a correct register setting, otherwise even the uart can not work. Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/bootblock.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/20802/2 -- To view, visit https://review.coreboot.org/20802 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Gerrit-Change-Number: 20802 Gerrit-PatchSet: 2 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>

1 0

Change in coreboot[master]: google/gru: Correct the Sdcard control gpio setting for Scarlet
by Lin Huang (Code Review) 28 Jul '17

28 Jul '17

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/20803 Change subject: google/gru: Correct the Sdcard control gpio setting for Scarlet ...................................................................... google/gru: Correct the Sdcard control gpio setting for Scarlet in Scarlet Sdcard control gpio different with other project, let's correct it. Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/bootblock.c M src/mainboard/google/gru/mainboard.c 2 files changed, 13 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/20803/1 diff --git a/src/mainboard/google/gru/bootblock.c b/src/mainboard/google/gru/bootblock.c index d0a5182..c5ab28a 100644 --- a/src/mainboard/google/gru/bootblock.c +++ b/src/mainboard/google/gru/bootblock.c @@ -44,7 +44,7 @@ */ write32(&rk3399_grf->io_vsel, RK_SETBITS(1 << 0)); - /* Scarlet gpio2ab iodomain is 1.8V */ + /* Scarlet gpio4cd iodomain is 1.8V */ if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) write32(&rk3399_grf->io_vsel, RK_SETBITS(1 << 3)); diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c index 2542d74..d39a7fc 100644 --- a/src/mainboard/google/gru/mainboard.c +++ b/src/mainboard/google/gru/mainboard.c @@ -167,13 +167,21 @@ { gpio_output(GPIO(2, A, 2), 1); /* SDMMC_SDIO_PWR_EN */ - /* SDMMC_DET_L is different on Kevin board revision 0. */ - if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN) && (board_id() == 0)) - gpio_input(GPIO(4, D, 2)); + /* set SDMMC_DET_L pin */ + if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) + gpio_input(GPIO(1, B, 3)); else gpio_input(GPIO(4, D, 0)); - gpio_output(GPIO(2, D, 4), 0); /* Keep the max voltage */ + /* + * Keep sd card io domain 3v + * in Scarlet this gpio set to high will get 3v + * other project set this gpio to low will get 3v + */ + if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) + gpio_output(GPIO(2, D, 4), 1); + else + gpio_output(GPIO(2, D, 4), 0); gpio_input(GPIO(4, B, 0)); /* SDMMC0_D0 remove pull-up */ gpio_input(GPIO(4, B, 1)); /* SDMMC0_D1 remove pull-up */ -- To view, visit https://review.coreboot.org/20803 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5fa19b212a716213462eea58b6242392d32a2c5c Gerrit-Change-Number: 20803 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: google/gru: Scarlet gpio4cd use 1.8V powerdomain
by Lin Huang (Code Review) 28 Jul '17

28 Jul '17

Lin Huang has uploaded this change for review. ( https://review.coreboot.org/20802 Change subject: google/gru: Scarlet gpio4cd use 1.8V powerdomain ...................................................................... google/gru: Scarlet gpio4cd use 1.8V powerdomain Scarlet gpio4cd use 1.8V powerdomain, let's make a correct register setting, otherwise even the uart can not work. Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Signed-off-by: Lin Huang <hl(a)rock-chips.com> --- M src/mainboard/google/gru/bootblock.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/20802/1 diff --git a/src/mainboard/google/gru/bootblock.c b/src/mainboard/google/gru/bootblock.c index 7359f2a..d0a5182 100644 --- a/src/mainboard/google/gru/bootblock.c +++ b/src/mainboard/google/gru/bootblock.c @@ -44,6 +44,10 @@ */ write32(&rk3399_grf->io_vsel, RK_SETBITS(1 << 0)); + /* Scarlet gpio2ab iodomain is 1.8V */ + if (IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) + write32(&rk3399_grf->io_vsel, RK_SETBITS(1 << 3)); + if (!IS_ENABLED(CONFIG_BOARD_GOOGLE_SCARLET)) { /* Enable rails powering GPIO blocks, among other things. These are EC-controlled on Scarlet and already on. */ -- To view, visit https://review.coreboot.org/20802 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5a8b2a4d92502fb829688d0a3e1b645d53cd7fc Gerrit-Change-Number: 20802 Gerrit-PatchSet: 1 Gerrit-Owner: Lin Huang <hl(a)rock-chips.com>

1 0

Change in coreboot[master]: google/kahlee: Add ChromeOS SMBIOS Board ID
by build bot (Jenkins) (Code Review) 28 Jul '17

28 Jul '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19837 ) Change subject: google/kahlee: Add ChromeOS SMBIOS Board ID ...................................................................... Patch Set 24: Build Successful https://qa.coreboot.org/job/coreboot-gerrit/57950/ : SUCCESS https://qa.coreboot.org/job/coreboot-checkpatch/13394/ : SUCCESS -- To view, visit https://review.coreboot.org/19837 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9693db6d6506af7ff40db0b3ce4cc6c1469f6ef Gerrit-Change-Number: 19837 Gerrit-PatchSet: 24 Gerrit-Owner: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 28 Jul 2017 01:11:12 +0000 Gerrit-HasComments: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2017